René's URL Explorer Experiment


Title: inspector: do not change async call stack depth if the worker is done by eugeneo · Pull Request #28613 · nodejs/node · GitHub

Open Graph Title: inspector: do not change async call stack depth if the worker is done by eugeneo · Pull Request #28613 · nodejs/node

X Title: inspector: do not change async call stack depth if the worker is done by eugeneo · Pull Request #28613 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes: #28528 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines

X Description: Fixes: #28528 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines

Opengraph URL: https://github.com/nodejs/node/pull/28613

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b4184a0e-cca4-0e74-bbf7-c25b109198af
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEAD8:3F60C6:4998B9C:689209E:6A4FD1EC
html-safe-nonce14d8a3562bddc3b0e9f12f1fe2f05beda9a7e99568b4df75e4171c3fb9aaa9f1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQUQ4OjNGNjBDNjo0OTk4QjlDOjY4OTIwOUU6NkE0RkQxRUMiLCJ2aXNpdG9yX2lkIjoiNDE5MDYxODgwNzA0NzE3MjkyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmace7f0729289dd0769be37b190de6b14ce06eb5b56025e3f475a99f5cbe6cd5b2b
hovercard-subject-tagpull_request:295892954
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28613/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/db9c92ff592763a2b2f4a1348423628c3b3de898c8ea5e14dec9ca922db5a23c/nodejs/node/pull/28613
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/db9c92ff592763a2b2f4a1348423628c3b3de898c8ea5e14dec9ca922db5a23c/nodejs/node/pull/28613
og:image:altFixes: #28528 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameeugeneo
hostnamegithub.com
expected-hostnamegithub.com
None19b98c3d9767bb8a56238a89ff8401d1cbdf3bc5c353799aacf49fe6c76b4b7c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release142593e66413bbae27fd485859993597d5a3b104
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/28613#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28613
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28613
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/28613
Reloadhttps://github.com/nodejs/node/pull/28613
Reloadhttps://github.com/nodejs/node/pull/28613
Please reload this pagehttps://github.com/nodejs/node/pull/28613
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/28613
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 973 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
eugeneohttps://github.com/eugeneo
nodejs:masterhttps://github.com/nodejs/node/tree/master
Conversationhttps://github.com/nodejs/node/pull/28613
Commits0 (0)https://github.com/nodejs/node/pull/28613/commits
Checkshttps://github.com/nodejs/node/pull/28613/checks
Files changedhttps://github.com/nodejs/node/pull/28613/files
inspector: do not change async call stack depth if the worker is donehttps://github.com/nodejs/node/pull/28613#top
eugeneohttps://github.com/eugeneo
nodejs:masterhttps://github.com/nodejs/node/tree/master
https://github.com/eugeneo
eugeneohttps://github.com/eugeneo
Jul 9, 2019https://github.com/nodejs/node/pull/28613#issue-465952590
#28528https://github.com/nodejs/node/issues/28528
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/28613
https://github.com/eugeneo
eugeneohttps://github.com/eugeneo
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
inspector https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ainspector
Jul 9, 2019https://github.com/nodejs/node/pull/28613#event-2470466175
https://github.com/alexkozy
alexkozyhttps://github.com/alexkozy
Jul 9, 2019 https://github.com/nodejs/node/pull/28613#pullrequestreview-259735937
View reviewed changes https://github.com/nodejs/node/pull/28613/files
test/parallel/test-inspector-async-hook-after-done.jshttps://github.com/nodejs/node/pull/28613/files#diff-e74df714bd28e6e2c5fdc722ec9f9d9c5735b42c93778bddbe579850dbe14f9e
alexkozyhttps://github.com/alexkozy
Jul 9, 2019https://github.com/nodejs/node/pull/28613#discussion_r301774797
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28613
eugeneohttps://github.com/eugeneo
Jul 9, 2019https://github.com/nodejs/node/pull/28613#discussion_r301778279
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28613
https://github.com/alexkozy
alexkozyhttps://github.com/alexkozy
Jul 9, 2019 https://github.com/nodejs/node/pull/28613#pullrequestreview-259736265
View reviewed changes https://github.com/nodejs/node/pull/28613/files
test/parallel/test-inspector-async-hook-after-done.jshttps://github.com/nodejs/node/pull/28613/files#diff-e74df714bd28e6e2c5fdc722ec9f9d9c5735b42c93778bddbe579850dbe14f9e
alexkozyhttps://github.com/alexkozy
Jul 9, 2019https://github.com/nodejs/node/pull/28613#discussion_r301775056
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28613
eugeneohttps://github.com/eugeneo
Jul 9, 2019https://github.com/nodejs/node/pull/28613#discussion_r301784831
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28613
https://github.com/alexkozy
alexkozyhttps://github.com/alexkozy
Jul 9, 2019 https://github.com/nodejs/node/pull/28613#pullrequestreview-259736360
View reviewed changes https://github.com/nodejs/node/pull/28613/files
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jul 11, 2019 https://github.com/nodejs/node/pull/28613#pullrequestreview-260722439
View reviewed changes https://github.com/nodejs/node/pull/28613/files
src/inspector_agent.cchttps://github.com/nodejs/node/pull/28613/files#diff-70a38bba4bd6538b0bdf462db5268047b43a0260fe71c3f469d5ad52cbf8f2dd
BridgeARhttps://github.com/BridgeAR
Jul 11, 2019https://github.com/nodejs/node/pull/28613#discussion_r302562494
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28613
eugeneohttps://github.com/eugeneo
Jul 12, 2019https://github.com/nodejs/node/pull/28613#discussion_r303075434
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28613
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 14, 2019 https://github.com/nodejs/node/pull/28613#pullrequestreview-261603329
View reviewed changes https://github.com/nodejs/node/pull/28613/files
test/parallel/test-inspector-async-hook-after-done.jshttps://github.com/nodejs/node/pull/28613/files#diff-e74df714bd28e6e2c5fdc722ec9f9d9c5735b42c93778bddbe579850dbe14f9e
Please reload this pagehttps://github.com/nodejs/node/pull/28613
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jul 15, 2019 https://github.com/nodejs/node/pull/28613#pullrequestreview-261879368
View reviewed changes https://github.com/nodejs/node/pull/28613/files
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 15, 2019https://github.com/nodejs/node/pull/28613#issuecomment-511487478
https://ci.nodejs.org/job/node-test-pull-request/24473/https://ci.nodejs.org/job/node-test-pull-request/24473/
Please reload this pagehttps://github.com/nodejs/node/pull/28613
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 15, 2019https://github.com/nodejs/node/pull/28613#issuecomment-511509580
https://ci.nodejs.org/job/node-test-pull-request/24474/https://ci.nodejs.org/job/node-test-pull-request/24474/
Please reload this pagehttps://github.com/nodejs/node/pull/28613
https://github.com/eugeneo
eugeneohttps://github.com/eugeneo
Jul 15, 2019https://github.com/nodejs/node/pull/28613#event-2483999770
https://github.com/eugeneo
eugeneohttps://github.com/eugeneo
July 15, 2019 19:33https://github.com/nodejs/node/pull/28613#event-2484000586
https://github.com/eugeneo
eugeneohttps://github.com/eugeneo
Jul 15, 2019https://github.com/nodejs/node/pull/28613#issuecomment-511538914
7e543bbhttps://github.com/nodejs/node/commit/7e543bb2e4711ab2c5a14d49e4465ff1fd75f232
Please reload this pagehttps://github.com/nodejs/node/pull/28613
https://github.com/eugeneo
eugeneohttps://github.com/eugeneo
7e543bbhttps://github.com/nodejs/node/commit/7e543bb2e4711ab2c5a14d49e4465ff1fd75f232
Jul 15, 2019https://github.com/nodejs/node/pull/28613#event-2484001963
targoshttps://github.com/targos
Jul 20, 2019 https://github.com/nodejs/node/pull/28613#ref-commit-aba0cf3
https://github.com/targos
inspector: do not change async call stack depth if the worker is donehttps://github.com/nodejs/node/commit/aba0cf33ecf97fe690f0b5de5c3c103076e23b3a
aba0cf3https://github.com/nodejs/node/commit/aba0cf33ecf97fe690f0b5de5c3c103076e23b3a
#28528https://github.com/nodejs/node/issues/28528
#28613https://github.com/nodejs/node/pull/28613
v12.7.0 release proposal #28816 https://github.com/nodejs/node/pull/28816
v12.7.0 release proposal #28817 https://github.com/nodejs/node/pull/28817
vikashk1https://github.com/vikashk1
Aug 13, 2019 https://github.com/nodejs/node/pull/28613#ref-commit-9af17ad
https://github.com/vikashk1
Please ignore this msg (https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc
#1https://github.com/vikashk1/node/pull/1
)https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc
9af17adhttps://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28613
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/28613/files/7d27343de6595b8a4a66adf01be91627c0305fd8
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/28613/files/602e22c509c4a851e1a68e5beba88ab6abae1eb9
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/28613/files/7d27343de6595b8a4a66adf01be91627c0305fd8
https://github.com/alexkozy
alexkozy https://github.com/alexkozy
https://github.com/nodejs/node/pull/28613/files/6f5b2b6365604bf318e116b941a18f529bdc515a
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
inspector https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ainspector
inspector: Debugger.setAsyncCallStackDepth after waitingForDisconnect event crashes worker https://github.com/nodejs/node/issues/28528
Please reload this pagehttps://github.com/nodejs/node/pull/28613
https://github.com/eugeneo
https://github.com/nodejs-github-bot
https://github.com/alexkozy
https://github.com/jasnell
https://github.com/addaleax
https://github.com/BridgeAR
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.