| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:f17b7242-5c1e-b694-3f9c-256f50a59973 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B7D6:1D90CC:63E494B:8C5FFED:6A502C1F |
| html-safe-nonce | f9b3139f2f723ceb3c2678bdd9bffb200d455c6043ff716e96791636a4af7b03 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCN0Q2OjFEOTBDQzo2M0U0OTRCOjhDNUZGRUQ6NkE1MDJDMUYiLCJ2aXNpdG9yX2lkIjoiNjgzMjQyMzAxNTUwMzg5OTY4MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | f845d961dfd7b16ae3359cf0115f32cb24449df5502fd0fec9da5c39be3da47f |
| hovercard-subject-tag | pull_request:295690019 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28607/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/daa5beb0801a923f7271c0763966c1a6f6b18dcb8274716f245cf1be88111f7d/nodejs/node/pull/28607 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/daa5beb0801a923f7271c0763966c1a6f6b18dcb8274716f245cf1be88111f7d/nodejs/node/pull/28607 |
| og:image:alt | On IBM i (OS400), some libraries do not exist.
Only tested on IBM i, may need some help for AIX test due to the code changes.
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
co... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | dmabupt |
| hostname | github.com |
| expected-hostname | github.com |
| None | d6dc8294eb500fa36bbc57472d61fe87c522f9c3c1d64f70f4926f66a66a7efb |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d90666eaf032b7eb8975a378efe38e37f4ebb96c |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/28607#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28607 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28607 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/28607 |
| Reload | https://github.com/nodejs/node/pull/28607 |
| Reload | https://github.com/nodejs/node/pull/28607 |
| Please reload this page | https://github.com/nodejs/node/pull/28607 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/28607 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
977
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| dmabupt | https://github.com/dmabupt |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Conversation | https://github.com/nodejs/node/pull/28607 |
| Commits1 (1) | https://github.com/nodejs/node/pull/28607/commits |
| Checks | https://github.com/nodejs/node/pull/28607/checks |
| Files changed | https://github.com/nodejs/node/pull/28607/files |
| build,v8: support IBM i | https://github.com/nodejs/node/pull/28607#top |
| dmabupt | https://github.com/dmabupt |
| nodejs:master | https://github.com/nodejs/node/tree/master |
|
| https://github.com/dmabupt |
| dmabupt | https://github.com/dmabupt |
| Jul 9, 2019 | https://github.com/nodejs/node/pull/28607#issue-465702199 |
| Please reload this page | https://github.com/nodejs/node/pull/28607 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/28607 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Jul 9, 2019 | https://github.com/nodejs/node/pull/28607#event-2468898891 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Jul 9, 2019 | https://github.com/nodejs/node/pull/28607#issuecomment-509592201 |
| Please reload this page | https://github.com/nodejs/node/pull/28607 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 9, 2019 | https://github.com/nodejs/node/pull/28607#issuecomment-509592294 |
| https://ci.nodejs.org/job/node-test-pull-request/24345/ | https://ci.nodejs.org/job/node-test-pull-request/24345/ |
| Please reload this page | https://github.com/nodejs/node/pull/28607 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
Jul 9, 2019
| https://github.com/nodejs/node/pull/28607#pullrequestreview-259428201 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28607/files |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
| Jul 9, 2019 | https://github.com/nodejs/node/pull/28607#issuecomment-509598749 |
| Please reload this page | https://github.com/nodejs/node/pull/28607 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Jul 9, 2019
| https://github.com/nodejs/node/pull/28607#pullrequestreview-259459995 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28607/files |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Jul 9, 2019 | https://github.com/nodejs/node/pull/28607#event-2469416866 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Jul 9, 2019
| https://github.com/nodejs/node/pull/28607#pullrequestreview-259550749 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28607/files |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Jul 9, 2019
| https://github.com/nodejs/node/pull/28607#pullrequestreview-259750305 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28607/files |
| bnoordhuis | https://github.com/bnoordhuis |
| https://github.com/nodejs/node/pull/28607#pullrequestreview-259750305 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/28607 |
| tools/v8_gypfiles/v8.gyp | https://github.com/nodejs/node/pull/28607/files#diff-f350b1b5e53caf9ecde4240ba8f544b3be4f278e4f8efa86b54c30ea625b8b1d |
| Please reload this page | https://github.com/nodejs/node/pull/28607 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Jul 9, 2019
| https://github.com/nodejs/node/pull/28607#pullrequestreview-259789883 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28607/files |
| mhdawson | https://github.com/mhdawson |
| https://github.com/nodejs/node/pull/28607#pullrequestreview-259789883 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/28607 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 10, 2019 | https://github.com/nodejs/node/pull/28607#issuecomment-509882778 |
| https://ci.nodejs.org/job/node-test-pull-request/24356/ | https://ci.nodejs.org/job/node-test-pull-request/24356/ |
| Please reload this page | https://github.com/nodejs/node/pull/28607 |
|
| https://github.com/dmabupt |
| build,v8: support IBM i | https://github.com/nodejs/node/pull/28607/commits/810c8e34b45f73f78208812d494e66c42a06ab3a |
| 810c8e3 | https://github.com/nodejs/node/pull/28607/commits/810c8e34b45f73f78208812d494e66c42a06ab3a |
| 417c18e | https://github.com/nodejs/node/commit/417c18e83472373ea1829f451b0bc87b17565d14 |
| #28607 | https://github.com/nodejs/node/pull/28607 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 12, 2019 | https://github.com/nodejs/node/pull/28607#issuecomment-510756287 |
| https://ci.nodejs.org/job/node-test-pull-request/24388/ | https://ci.nodejs.org/job/node-test-pull-request/24388/ |
| Please reload this page | https://github.com/nodejs/node/pull/28607 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 12, 2019 | https://github.com/nodejs/node/pull/28607#issuecomment-510842869 |
| https://ci.nodejs.org/job/node-test-pull-request/24403/ | https://ci.nodejs.org/job/node-test-pull-request/24403/ |
| Please reload this page | https://github.com/nodejs/node/pull/28607 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Jul 14, 2019 | https://github.com/nodejs/node/pull/28607#issuecomment-511239589 |
| d0b0230 | https://github.com/nodejs/node/commit/d0b0230e7dc536a311e0047c127875c17b998468 |
| Please reload this page | https://github.com/nodejs/node/pull/28607 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Jul 14, 2019 | https://github.com/nodejs/node/pull/28607#event-2481520184 |
| addaleax | https://github.com/addaleax |
|
Jul 14, 2019
| https://github.com/nodejs/node/pull/28607#ref-commit-d0b0230 |
|
| https://github.com/dmabupt |
|
| https://github.com/addaleax |
| build,v8: support IBM i | https://github.com/nodejs/node/commit/d0b0230e7dc536a311e0047c127875c17b998468 |
| d0b0230 | https://github.com/nodejs/node/commit/d0b0230e7dc536a311e0047c127875c17b998468 |
| 417c18e | https://github.com/nodejs/node/commit/417c18e83472373ea1829f451b0bc87b17565d14 |
| #28607 | https://github.com/nodejs/node/pull/28607 |
| https://github.com/dmabupt |
| dmabupt | https://github.com/dmabupt |
| July 15, 2019 00:13 | https://github.com/nodejs/node/pull/28607#event-2481572881 |
| targos | https://github.com/targos |
|
Jul 20, 2019
| https://github.com/nodejs/node/pull/28607#ref-commit-209b353 |
|
| https://github.com/dmabupt |
|
| https://github.com/targos |
| build,v8: support IBM i | https://github.com/nodejs/node/commit/209b353ff4999dcbc1067dac5e2028f534dcacad |
| 209b353 | https://github.com/nodejs/node/commit/209b353ff4999dcbc1067dac5e2028f534dcacad |
| 417c18e | https://github.com/nodejs/node/commit/417c18e83472373ea1829f451b0bc87b17565d14 |
| #28607 | https://github.com/nodejs/node/pull/28607 |
|
v12.7.0 release proposal
#28816
| https://github.com/nodejs/node/pull/28816 |
|
v12.7.0 release proposal
#28817
| https://github.com/nodejs/node/pull/28817 |
| vikashk1 | https://github.com/vikashk1 |
|
Aug 13, 2019
| https://github.com/nodejs/node/pull/28607#ref-commit-9af17ad |
|
| https://github.com/vikashk1 |
| Please ignore this msg ( | https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc |
| #1 | https://github.com/vikashk1/node/pull/1 |
| ) | https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc |
| 9af17ad | https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28607 |
|
| https://github.com/bnoordhuis |
|
bnoordhuis
| https://github.com/bnoordhuis |
|
| https://github.com/nodejs/node/pull/28607/files/bd669520e2e5706faf33a047a60ef83f53719963 |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/28607/files/bd669520e2e5706faf33a047a60ef83f53719963 |
|
| https://github.com/gireeshpunathil |
|
gireeshpunathil
| https://github.com/gireeshpunathil |
|
| https://github.com/nodejs/node/pull/28607/files/bd669520e2e5706faf33a047a60ef83f53719963 |
|
| https://github.com/BethGriggs |
|
BethGriggs
| https://github.com/BethGriggs |
|
| https://github.com/nodejs/node/pull/28607/files/bd669520e2e5706faf33a047a60ef83f53719963 |
|
| https://github.com/mhdawson |
|
mhdawson
| https://github.com/mhdawson |
|
| https://github.com/nodejs/node/pull/28607/files/bd669520e2e5706faf33a047a60ef83f53719963 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Please reload this page | https://github.com/nodejs/node/pull/28607 |
|
| https://github.com/dmabupt |
|
| https://github.com/targos |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/gireeshpunathil |
|
| https://github.com/addaleax |
|
| https://github.com/bnoordhuis |
|
| https://github.com/richardlau |
|
| https://github.com/BethGriggs |
|
| https://github.com/mhdawson |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |