René's URL Explorer Experiment


Title: n-api: make thread-safe-function calls properly by gabrielschulhof · Pull Request #28606 · nodejs/node · GitHub

Open Graph Title: n-api: make thread-safe-function calls properly by gabrielschulhof · Pull Request #28606 · nodejs/node

X Title: n-api: make thread-safe-function calls properly by gabrielschulhof · Pull Request #28606 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Use NapiCallIntoModuleThrow() to execute the call into JavaScript and the finalizer for consistency with the rest of the calls into the N-API addon. Checklist make -j4 test (UNIX), or vcbuild t...

X Description: Use NapiCallIntoModuleThrow() to execute the call into JavaScript and the finalizer for consistency with the rest of the calls into the N-API addon. Checklist make -j4 test (UNIX), or vcbuild t...

Opengraph URL: https://github.com/nodejs/node/pull/28606

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a5ebbf38-0968-bb65-aeec-b93bed6fb8a7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9BA8:165D8F:D787D1:12D6552:6A4FE407
html-safe-nonce5e801d48378b34f3e32f35f1b4b11184d172543fd75376c26666a1f5ef430a38
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QkE4OjE2NUQ4RjpENzg3RDE6MTJENjU1Mjo2QTRGRTQwNyIsInZpc2l0b3JfaWQiOiIyNTMyNDA2MjUxMDA4MDI1NjA3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac27ee27aae47ce2b90e5bfd7deabdfb83ef49b00ccee4449a3c7e0a704bfb9d36
hovercard-subject-tagpull_request:295612353
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28606/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/659b331b49eda4b8427efdac339595e0c10f63c69ece9867a6109a0f8a17c944/nodejs/node/pull/28606
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/659b331b49eda4b8427efdac339595e0c10f63c69ece9867a6109a0f8a17c944/nodejs/node/pull/28606
og:image:altUse NapiCallIntoModuleThrow() to execute the call into JavaScript and the finalizer for consistency with the rest of the calls into the N-API addon. Checklist make -j4 test (UNIX), or vcbuild t...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegabrielschulhof
hostnamegithub.com
expected-hostnamegithub.com
None19b98c3d9767bb8a56238a89ff8401d1cbdf3bc5c353799aacf49fe6c76b4b7c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release142593e66413bbae27fd485859993597d5a3b104
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/28606#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28606
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28606
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/28606
Reloadhttps://github.com/nodejs/node/pull/28606
Reloadhttps://github.com/nodejs/node/pull/28606
Please reload this pagehttps://github.com/nodejs/node/pull/28606
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/28606
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 975 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
gabrielschulhofhttps://github.com/gabrielschulhof
nodejs:masterhttps://github.com/nodejs/node/tree/master
gabrielschulhof:n-api-tsfn-call-properlyhttps://github.com/gabrielschulhof/node/tree/n-api-tsfn-call-properly
Conversationhttps://github.com/nodejs/node/pull/28606
Commits1 (1)https://github.com/nodejs/node/pull/28606/commits
Checkshttps://github.com/nodejs/node/pull/28606/checks
Files changedhttps://github.com/nodejs/node/pull/28606/files
n-api: make thread-safe-function calls properlyhttps://github.com/nodejs/node/pull/28606#top
gabrielschulhofhttps://github.com/gabrielschulhof
nodejs:masterhttps://github.com/nodejs/node/tree/master
gabrielschulhof:n-api-tsfn-call-properlyhttps://github.com/gabrielschulhof/node/tree/n-api-tsfn-call-properly
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Jul 9, 2019https://github.com/nodejs/node/pull/28606#issue-465605322
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/28606
n-api: make thread-safe-function calls properlyhttps://github.com/nodejs/node/pull/28606/commits/24a96bc6e6d576caba1f1c8603338038099b03b9
24a96bchttps://github.com/nodejs/node/pull/28606/commits/24a96bc6e6d576caba1f1c8603338038099b03b9
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
Jul 9, 2019https://github.com/nodejs/node/pull/28606#event-2468306031
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jul 9, 2019 https://github.com/nodejs/node/pull/28606#pullrequestreview-259380266
View reviewed changes https://github.com/nodejs/node/pull/28606/files/24a96bc6e6d576caba1f1c8603338038099b03b9
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jul 9, 2019 https://github.com/nodejs/node/pull/28606#pullrequestreview-259511659
View reviewed changes https://github.com/nodejs/node/pull/28606/files/24a96bc6e6d576caba1f1c8603338038099b03b9
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 9, 2019 https://github.com/nodejs/node/pull/28606#pullrequestreview-259514558
View reviewed changes https://github.com/nodejs/node/pull/28606/files/24a96bc6e6d576caba1f1c8603338038099b03b9
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/28606#pullrequestreview-259514558
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28606
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Jul 9, 2019https://github.com/nodejs/node/pull/28606#issuecomment-509724489
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/28606
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jul 9, 2019 https://github.com/nodejs/node/pull/28606#pullrequestreview-259666211
View reviewed changes https://github.com/nodejs/node/pull/28606/files/24a96bc6e6d576caba1f1c8603338038099b03b9
mhdawsonhttps://github.com/mhdawson
https://github.com/nodejs/node/pull/28606#pullrequestreview-259666211
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28606
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jul 9, 2019 https://github.com/nodejs/node/pull/28606#pullrequestreview-259667616
View reviewed changes https://github.com/nodejs/node/pull/28606/files/24a96bc6e6d576caba1f1c8603338038099b03b9
mhdawsonhttps://github.com/mhdawson
https://github.com/nodejs/node/pull/28606#pullrequestreview-259667616
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28606
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 10, 2019https://github.com/nodejs/node/pull/28606#issuecomment-510161447
Please reload this pagehttps://github.com/nodejs/node/pull/28606
https://ci.nodejs.org/job/node-test-pull-request/24365/https://ci.nodejs.org/job/node-test-pull-request/24365/
Please reload this pagehttps://github.com/nodejs/node/pull/28606
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Jul 11, 2019https://github.com/nodejs/node/pull/28606#issuecomment-510366732
f5b40b2https://github.com/nodejs/node/commit/f5b40b2ffaac2932f941bda1e456b62ec61eabd1
Please reload this pagehttps://github.com/nodejs/node/pull/28606
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Jul 11, 2019https://github.com/nodejs/node/pull/28606#event-2474913109
gabrielschulhofhttps://github.com/gabrielschulhof
Jul 11, 2019 https://github.com/nodejs/node/pull/28606#ref-commit-f5b40b2
n-api: make thread-safe-function calls properlyhttps://github.com/gabrielschulhof/node/commit/f5b40b2ffaac2932f941bda1e456b62ec61eabd1
f5b40b2https://github.com/gabrielschulhof/node/commit/f5b40b2ffaac2932f941bda1e456b62ec61eabd1
nodejs#28606https://github.com/nodejs/node/pull/28606
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
July 11, 2019 07:33https://github.com/nodejs/node/pull/28606#event-2474914283
targoshttps://github.com/targos
Jul 20, 2019 https://github.com/nodejs/node/pull/28606#ref-commit-44de431
https://github.com/targos
n-api: make thread-safe-function calls properlyhttps://github.com/nodejs/node/commit/44de4317cfb0dc2de0f0f7a6e0b46ce4c2fc2321
44de431https://github.com/nodejs/node/commit/44de4317cfb0dc2de0f0f7a6e0b46ce4c2fc2321
#28606https://github.com/nodejs/node/pull/28606
v12.7.0 release proposal #28816 https://github.com/nodejs/node/pull/28816
v12.7.0 release proposal #28817 https://github.com/nodejs/node/pull/28817
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28606
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/28606/files/24a96bc6e6d576caba1f1c8603338038099b03b9
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/28606/files/24a96bc6e6d576caba1f1c8603338038099b03b9
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/28606/files/24a96bc6e6d576caba1f1c8603338038099b03b9
https://github.com/mhdawson
mhdawson https://github.com/mhdawson
https://github.com/nodejs/node/pull/28606/files/24a96bc6e6d576caba1f1c8603338038099b03b9
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
Please reload this pagehttps://github.com/nodejs/node/pull/28606
https://github.com/gabrielschulhof
https://github.com/nodejs-github-bot
https://github.com/bnoordhuis
https://github.com/addaleax
https://github.com/cjihrig
https://github.com/mhdawson
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.