| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:3e18d7dc-0e85-aa9b-7926-005767e43063 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C594:D9FFD:2F12497:43783E1:6A4FB9E5 |
| html-safe-nonce | 945ab14a9831d0433d3852c4283966c332bcb51113288ed8ee709bddd1255067 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNTk0OkQ5RkZEOjJGMTI0OTc6NDM3ODNFMTo2QTRGQjlFNSIsInZpc2l0b3JfaWQiOiI2MDE3ODk3OTY0MDU5NDc0NDA1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 017c1a420750d7be26537e7145048a72d4524b8f53306d0c20c92c19e214bb09 |
| hovercard-subject-tag | pull_request:295547222 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28604/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/36e56cfc5e0c30e58e7a27538a2409c791790ee9f58ee40913db9058986fde0c/nodejs/node/pull/28604 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/36e56cfc5e0c30e58e7a27538a2409c791790ee9f58ee40913db9058986fde0c/nodejs/node/pull/28604 |
| og:image:alt | It is very important to me (and to my employer) that the Electron v6 release at the end of this month (July 2019) supports ARM64 Windows without manual patching of anything. Right now, developers h... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jkunkee |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4b249b445842943ed31549e027f57a8ade9881ed |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/28604#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28604 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28604 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/28604 |
| Reload | https://github.com/nodejs/node/pull/28604 |
| Reload | https://github.com/nodejs/node/pull/28604 |
| Please reload this page | https://github.com/nodejs/node/pull/28604 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/28604 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
973
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| jkunkee | https://github.com/jkunkee |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| jkunkee:node-gyp-arm64-patch | https://github.com/jkunkee/node/tree/node-gyp-arm64-patch |
| Conversation | https://github.com/nodejs/node/pull/28604 |
| Commits2 (2) | https://github.com/nodejs/node/pull/28604/commits |
| Checks | https://github.com/nodejs/node/pull/28604/checks |
| Files changed | https://github.com/nodejs/node/pull/28604/files |
| deps: cherry-pick ARM64 Windows changes to node-gyp | https://github.com/nodejs/node/pull/28604#top |
| jkunkee | https://github.com/jkunkee |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| jkunkee:node-gyp-arm64-patch | https://github.com/jkunkee/node/tree/node-gyp-arm64-patch |
|
| https://github.com/jkunkee |
| jkunkee | https://github.com/jkunkee |
| Jul 9, 2019 | https://github.com/nodejs/node/pull/28604#issue-465522138 |
| nodejs/node-gyp#1739 | https://github.com/nodejs/node-gyp/pull/1739 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/28604 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
npm
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anpm |
| Jul 9, 2019 | https://github.com/nodejs/node/pull/28604#event-2467826470 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jul 9, 2019 | https://github.com/nodejs/node/pull/28604#issuecomment-509478026 |
| Please reload this page | https://github.com/nodejs/node/pull/28604 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
|
Jul 9, 2019
| https://github.com/nodejs/node/pull/28604#pullrequestreview-259278092 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28604/files |
| https://github.com/jkunkee |
| jkunkee | https://github.com/jkunkee |
| force-pushed | https://github.com/nodejs/node/compare/acffc9db6313f835dbf507a76e7398dc2054601c..efa9b80b4af437ae569fbb24c0f4b905d590e1e6 |
| acffc9d | https://github.com/nodejs/node/commit/acffc9db6313f835dbf507a76e7398dc2054601c |
| efa9b80 | https://github.com/nodejs/node/commit/efa9b80b4af437ae569fbb24c0f4b905d590e1e6 |
|
Compare
| https://github.com/nodejs/node/compare/acffc9db6313f835dbf507a76e7398dc2054601c..efa9b80b4af437ae569fbb24c0f4b905d590e1e6 |
| July 9, 2019 18:15 | https://github.com/nodejs/node/pull/28604#event-2470249475 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 9, 2019 | https://github.com/nodejs/node/pull/28604#issuecomment-509770152 |
| Please reload this page | https://github.com/nodejs/node/pull/28604 |
| https://ci.nodejs.org/job/node-test-pull-request/24350/ | https://ci.nodejs.org/job/node-test-pull-request/24350/ |
| Please reload this page | https://github.com/nodejs/node/pull/28604 |
| https://github.com/joaocgreis |
| joaocgreis | https://github.com/joaocgreis |
|
Jul 9, 2019
| https://github.com/nodejs/node/pull/28604#pullrequestreview-259756739 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28604/files |
| https://github.com/joaocgreis |
| joaocgreis | https://github.com/joaocgreis |
|
Jul 9, 2019
| https://github.com/nodejs/node/pull/28604#ref-pullrequest-465500983 |
|
deps, v8: strip out overly broad DLL Export annotations
#28602
| https://github.com/nodejs/node/pull/28602 |
| https://github.com/joaocgreis |
| joaocgreis | https://github.com/joaocgreis |
| Jul 9, 2019 | https://github.com/nodejs/node/pull/28604#issuecomment-509809590 |
| Please reload this page | https://github.com/nodejs/node/pull/28604 |
| #28602 | https://github.com/nodejs/node/pull/28602 |
| https://ci.nodejs.org/view/All/job/node-test-commit-windows-arm64/18/ | https://ci.nodejs.org/view/All/job/node-test-commit-windows-arm64/18/ |
| https://ci.nodejs.org/view/All/job/node-test-commit-windows-arm64/19/ | https://ci.nodejs.org/view/All/job/node-test-commit-windows-arm64/19/ |
| Please reload this page | https://github.com/nodejs/node/pull/28604 |
| https://github.com/joaocgreis |
| joaocgreis | https://github.com/joaocgreis |
| Jul 9, 2019 | https://github.com/nodejs/node/pull/28604#issuecomment-509841174 |
| @jkunkee | https://github.com/jkunkee |
| nodejs/node-gyp@721dc7d | https://github.com/nodejs/node-gyp/commit/721dc7d3148ab71ee283d9cb15df84d9b87b7efc |
| Please reload this page | https://github.com/nodejs/node/pull/28604 |
| https://github.com/joaocgreis |
| joaocgreis | https://github.com/joaocgreis |
| stale review | https://github.com/nodejs/node/pull/28604#pullrequestreview-259756739 |
| July 9, 2019 23:03 | https://github.com/nodejs/node/pull/28604#event-2470893257 |
| jkunkee | https://github.com/jkunkee |
| July 11, 2019 03:46 | https://github.com/nodejs/node/pull/28604#commits-pushed-dfd204c |
|
| https://github.com/jkunkee |
|
| https://github.com/joaocgreis |
| deps: cherry-pick | https://github.com/nodejs/node/pull/28604/commits/dfd204cdb47b57ee8b305b92d79aa50ef403f318 |
| 721dc7d | https://github.com/jkunkee/node/commit/721dc7deb9ddf290abc7ae0d6bbe536cb6d4f4a3 |
| from node-gyp upstream | https://github.com/nodejs/node/pull/28604/commits/dfd204cdb47b57ee8b305b92d79aa50ef403f318 |
| dfd204c | https://github.com/nodejs/node/pull/28604/commits/dfd204cdb47b57ee8b305b92d79aa50ef403f318 |
| nodejs/node-gyp#1655 | https://github.com/nodejs/node-gyp/pull/1655 |
| nodejs/node-gyp@721dc7d | https://github.com/nodejs/node-gyp/commit/721dc7d3148ab71ee283d9cb15df84d9b87b7efc |
| nodejs#28604 | https://github.com/nodejs/node/pull/28604 |
|
| https://github.com/jkunkee |
|
| https://github.com/joaocgreis |
| deps: cherry-pick 91744bf from node-gyp upstream | https://github.com/nodejs/node/pull/28604/commits/c51ec2b04c52dfea8c8a36b41f06b78c6cf732b6 |
| c51ec2b | https://github.com/nodejs/node/pull/28604/commits/c51ec2b04c52dfea8c8a36b41f06b78c6cf732b6 |
| refack/GYP3#33 | https://github.com/refack/GYP3/pull/33 |
| nodejs/node-gyp#1678 | https://github.com/nodejs/node-gyp/pull/1678 |
| nodejs/node-gyp#1739 | https://github.com/nodejs/node-gyp/pull/1739 |
| nodejs/node-gyp@91744bf | https://github.com/nodejs/node-gyp/commit/91744bfecc67fda7db58e2a1c7aa72f196d6da4f |
| nodejs#28604 | https://github.com/nodejs/node/pull/28604 |
| https://github.com/joaocgreis |
| joaocgreis | https://github.com/joaocgreis |
| force-pushed | https://github.com/nodejs/node/compare/bcf05dc1fe3bff7f42fb851cab093259cf67354f..c51ec2b04c52dfea8c8a36b41f06b78c6cf732b6 |
| bcf05dc | https://github.com/nodejs/node/commit/bcf05dc1fe3bff7f42fb851cab093259cf67354f |
| c51ec2b | https://github.com/nodejs/node/commit/c51ec2b04c52dfea8c8a36b41f06b78c6cf732b6 |
|
Compare
| https://github.com/nodejs/node/compare/bcf05dc1fe3bff7f42fb851cab093259cf67354f..c51ec2b04c52dfea8c8a36b41f06b78c6cf732b6 |
| July 11, 2019 03:04 | https://github.com/nodejs/node/pull/28604#event-2474483634 |
| https://github.com/joaocgreis |
| joaocgreis | https://github.com/joaocgreis |
| Jul 11, 2019 | https://github.com/nodejs/node/pull/28604#issuecomment-510310652 |
| https://github.com/nodejs/node/blob/master/doc/guides/maintaining-V8.md | https://github.com/nodejs/node/blob/master/doc/guides/maintaining-V8.md |
| @jkunkee | https://github.com/jkunkee |
| Please reload this page | https://github.com/nodejs/node/pull/28604 |
| joaocgreis | https://github.com/joaocgreis |
|
Jul 11, 2019
| https://github.com/nodejs/node/pull/28604#ref-commit-de5f83f |
|
| https://github.com/jkunkee |
|
| https://github.com/joaocgreis |
| deps: cherry-pick | https://github.com/JaneaSystems/node/commit/de5f83f7fc22cd2cb57e2cf0b9a9b065e8178b4e |
| 721dc7d | https://github.com/JaneaSystems/node/commit/721dc7deb9ddf290abc7ae0d6bbe536cb6d4f4a3 |
| from node-gyp upstream | https://github.com/JaneaSystems/node/commit/de5f83f7fc22cd2cb57e2cf0b9a9b065e8178b4e |
| de5f83f | https://github.com/JaneaSystems/node/commit/de5f83f7fc22cd2cb57e2cf0b9a9b065e8178b4e |
| nodejs/node-gyp#1655 | https://github.com/nodejs/node-gyp/pull/1655 |
| nodejs/node-gyp@721dc7d | https://github.com/nodejs/node-gyp/commit/721dc7d3148ab71ee283d9cb15df84d9b87b7efc |
| nodejs#28604 | https://github.com/nodejs/node/pull/28604 |
| joaocgreis | https://github.com/joaocgreis |
|
Jul 11, 2019
| https://github.com/nodejs/node/pull/28604#ref-commit-d806255 |
|
| https://github.com/jkunkee |
|
| https://github.com/joaocgreis |
| deps: cherry-pick 91744bf from node-gyp upstream | https://github.com/JaneaSystems/node/commit/d806255a209e761aadc842f6dcab2d8c0c802ea3 |
| d806255 | https://github.com/JaneaSystems/node/commit/d806255a209e761aadc842f6dcab2d8c0c802ea3 |
| refack/GYP3#33 | https://github.com/refack/GYP3/pull/33 |
| nodejs/node-gyp#1678 | https://github.com/nodejs/node-gyp/pull/1678 |
| nodejs/node-gyp#1739 | https://github.com/nodejs/node-gyp/pull/1739 |
| nodejs/node-gyp@91744bf | https://github.com/nodejs/node-gyp/commit/91744bfecc67fda7db58e2a1c7aa72f196d6da4f |
| nodejs#28604 | https://github.com/nodejs/node/pull/28604 |
| https://github.com/joaocgreis |
| joaocgreis | https://github.com/joaocgreis |
| Jul 11, 2019 | https://github.com/nodejs/node/pull/28604#issuecomment-510326300 |
| #28602 | https://github.com/nodejs/node/pull/28602 |
| https://ci.nodejs.org/view/All/job/node-test-commit-windows-arm64/22/ | https://ci.nodejs.org/view/All/job/node-test-commit-windows-arm64/22/ |
| Please reload this page | https://github.com/nodejs/node/pull/28604 |
| https://github.com/jkunkee |
| jkunkee | https://github.com/jkunkee |
| Jul 11, 2019 | https://github.com/nodejs/node/pull/28604#issuecomment-510327779 |
| #28604 | https://github.com/nodejs/node/pull/28604 |
| https://github.com/nodejs/node/blob/master/doc/guides/maintaining-V8.md | https://github.com/nodejs/node/blob/master/doc/guides/maintaining-V8.md |
| @jkunkee | https://github.com/jkunkee |
| Please reload this page | https://github.com/nodejs/node/pull/28604 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| Jul 11, 2019 | https://github.com/nodejs/node/pull/28604#issuecomment-510330045 |
| Please reload this page | https://github.com/nodejs/node/pull/28604 |
| Please reload this page | https://github.com/nodejs/node/pull/28604 |
| https://github.com/jkunkee |
| jkunkee | https://github.com/jkunkee |
| Jul 11, 2019 | https://github.com/nodejs/node/pull/28604#issuecomment-510332125 |
| Please reload this page | https://github.com/nodejs/node/pull/28604 |
| https://github.com/joaocgreis |
| joaocgreis | https://github.com/joaocgreis |
|
Jul 11, 2019
| https://github.com/nodejs/node/pull/28604#pullrequestreview-260807731 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28604/files/c51ec2b04c52dfea8c8a36b41f06b78c6cf732b6 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Jul 11, 2019 | https://github.com/nodejs/node/pull/28604#issuecomment-510554208 |
| https://github.com/nodejs/node/blob/master/doc/guides/maintaining-npm.md#step-3-remove-old-npm | https://github.com/nodejs/node/blob/master/doc/guides/maintaining-npm.md#step-3-remove-old-npm |
| Please reload this page | https://github.com/nodejs/node/pull/28604 |
| https://github.com/jkunkee |
| jkunkee | https://github.com/jkunkee |
| Jul 12, 2019 | https://github.com/nodejs/node/pull/28604#issuecomment-510702202 |
| Please reload this page | https://github.com/nodejs/node/pull/28604 |
| @richardlau | https://github.com/richardlau |
| Please reload this page | https://github.com/nodejs/node/pull/28604 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Jul 12, 2019 | https://github.com/nodejs/node/pull/28604#issuecomment-510737624 |
| https://npm.community/t/release-npm-6-10-1/8790 | https://npm.community/t/release-npm-6-10-1/8790 |
| #28647 | https://github.com/nodejs/node/pull/28647 |
| Maintaining npm in Node.js policy | https://github.com/nodejs/node/blob/master/doc/guides/maintaining-npm.md#maintaining-npm-in-nodejs |
| Please reload this page | https://github.com/nodejs/node/pull/28604 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 12, 2019 | https://github.com/nodejs/node/pull/28604#issuecomment-510756585 |
| Please reload this page | https://github.com/nodejs/node/pull/28604 |
| https://ci.nodejs.org/job/node-test-pull-request/24389/ | https://ci.nodejs.org/job/node-test-pull-request/24389/ |
| Please reload this page | https://github.com/nodejs/node/pull/28604 |
| https://github.com/jkunkee |
| jkunkee | https://github.com/jkunkee |
| Jul 12, 2019 | https://github.com/nodejs/node/pull/28604#issuecomment-510995339 |
| @richardlau | https://github.com/richardlau |
| Please reload this page | https://github.com/nodejs/node/pull/28604 |
| pull | https://github.com/apps/pull |
|
Jul 15, 2019
| https://github.com/nodejs/node/pull/28604#ref-commit-d53144e |
|
| https://github.com/jkunkee |
|
| https://github.com/joaocgreis |
| deps: cherry-pick | https://github.com/Mattlk13/node/commit/d53144e549598ae1ce36ba643e2fc70edacfd2e1 |
| 721dc7d | https://github.com/Mattlk13/node/commit/721dc7deb9ddf290abc7ae0d6bbe536cb6d4f4a3 |
| from node-gyp upstream | https://github.com/Mattlk13/node/commit/d53144e549598ae1ce36ba643e2fc70edacfd2e1 |
| d53144e | https://github.com/Mattlk13/node/commit/d53144e549598ae1ce36ba643e2fc70edacfd2e1 |
| nodejs/node-gyp#1655 | https://github.com/nodejs/node-gyp/pull/1655 |
| nodejs/node-gyp@721dc7d | https://github.com/nodejs/node-gyp/commit/721dc7d3148ab71ee283d9cb15df84d9b87b7efc |
| nodejs#28604 | https://github.com/nodejs/node/pull/28604 |
| pull | https://github.com/apps/pull |
|
Jul 15, 2019
| https://github.com/nodejs/node/pull/28604#ref-commit-c3caf21 |
|
| https://github.com/jkunkee |
|
| https://github.com/joaocgreis |
| deps: cherry-pick 91744bf from node-gyp upstream | https://github.com/Mattlk13/node/commit/c3caf21bd35359fe8b0470a65775ade5979890f7 |
| c3caf21 | https://github.com/Mattlk13/node/commit/c3caf21bd35359fe8b0470a65775ade5979890f7 |
| refack/GYP3#33 | https://github.com/refack/GYP3/pull/33 |
| nodejs/node-gyp#1678 | https://github.com/nodejs/node-gyp/pull/1678 |
| nodejs/node-gyp#1739 | https://github.com/nodejs/node-gyp/pull/1739 |
| nodejs/node-gyp@91744bf | https://github.com/nodejs/node-gyp/commit/91744bfecc67fda7db58e2a1c7aa72f196d6da4f |
| nodejs#28604 | https://github.com/nodejs/node/pull/28604 |
| https://github.com/joaocgreis |
| joaocgreis | https://github.com/joaocgreis |
| Jul 15, 2019 | https://github.com/nodejs/node/pull/28604#issuecomment-511443148 |
| e984917...c3caf21 | https://github.com/nodejs/node/compare/e984917aaf161d810ff1acaf2f4b5e4e0b345315...c3caf21bd35359fe8b0470a65775ade5979890f7 |
| Please reload this page | https://github.com/nodejs/node/pull/28604 |
| https://github.com/joaocgreis |
| joaocgreis | https://github.com/joaocgreis |
| Jul 15, 2019 | https://github.com/nodejs/node/pull/28604#event-2483254666 |
| https://github.com/joaocgreis |
| joaocgreis | https://github.com/joaocgreis |
|
Jul 15, 2019
| https://github.com/nodejs/node/pull/28604#ref-pullrequest-467173743 |
|
deps: upgrade npm to 6.10.1
#28647
| https://github.com/nodejs/node/pull/28647 |
| https://github.com/jkunkee |
| jkunkee | https://github.com/jkunkee |
|
Jul 15, 2019
| https://github.com/nodejs/node/pull/28604#ref-issue-407948197 |
|
Support ARM64 Windows desktop
#25998
| https://github.com/nodejs/node/issues/25998 |
| targos | https://github.com/targos |
|
Jul 20, 2019
| https://github.com/nodejs/node/pull/28604#ref-commit-7fa982e |
|
| https://github.com/jkunkee |
|
| https://github.com/targos |
| deps: cherry-pick | https://github.com/nodejs/node/commit/7fa982ee89ad82f30ad302423c8c1b9dbaeb7ca6 |
| 721dc7d | https://github.com/nodejs/node/commit/721dc7deb9ddf290abc7ae0d6bbe536cb6d4f4a3 |
| from node-gyp upstream | https://github.com/nodejs/node/commit/7fa982ee89ad82f30ad302423c8c1b9dbaeb7ca6 |
| 7fa982e | https://github.com/nodejs/node/commit/7fa982ee89ad82f30ad302423c8c1b9dbaeb7ca6 |
| nodejs/node-gyp#1655 | https://github.com/nodejs/node-gyp/pull/1655 |
| nodejs/node-gyp@721dc7d | https://github.com/nodejs/node-gyp/commit/721dc7d3148ab71ee283d9cb15df84d9b87b7efc |
| #28604 | https://github.com/nodejs/node/pull/28604 |
| targos | https://github.com/targos |
|
Jul 20, 2019
| https://github.com/nodejs/node/pull/28604#ref-commit-df0f42a |
|
| https://github.com/jkunkee |
|
| https://github.com/targos |
| deps: cherry-pick 91744bf from node-gyp upstream | https://github.com/nodejs/node/commit/df0f42ab7fe10d9cbbf5a9b916a45932aa4ddfbf |
| df0f42a | https://github.com/nodejs/node/commit/df0f42ab7fe10d9cbbf5a9b916a45932aa4ddfbf |
| refack/GYP3#33 | https://github.com/refack/GYP3/pull/33 |
| nodejs/node-gyp#1678 | https://github.com/nodejs/node-gyp/pull/1678 |
| nodejs/node-gyp#1739 | https://github.com/nodejs/node-gyp/pull/1739 |
| nodejs/node-gyp@91744bf | https://github.com/nodejs/node-gyp/commit/91744bfecc67fda7db58e2a1c7aa72f196d6da4f |
| #28604 | https://github.com/nodejs/node/pull/28604 |
|
v12.7.0 release proposal
#28816
| https://github.com/nodejs/node/pull/28816 |
|
v12.7.0 release proposal
#28817
| https://github.com/nodejs/node/pull/28817 |
| vikashk1 | https://github.com/vikashk1 |
|
Aug 13, 2019
| https://github.com/nodejs/node/pull/28604#ref-commit-9af17ad |
|
| https://github.com/vikashk1 |
| Please ignore this msg ( | https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc |
| #1 | https://github.com/vikashk1/node/pull/1 |
| ) | https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc |
| 9af17ad | https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc |
| https://github.com/StefanStojanovic |
| StefanStojanovic | https://github.com/StefanStojanovic |
|
Mar 8, 2023
| https://github.com/nodejs/node/pull/28604#ref-pullrequest-1613511176 |
|
deps: cherry-pick ARM64 Windows changes to node-gyp
#46995
| https://github.com/nodejs/node/pull/46995 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28604 |
|
| https://github.com/cclauss |
|
cclauss
| https://github.com/cclauss |
|
| https://github.com/nodejs/node/pull/28604/files/acffc9db6313f835dbf507a76e7398dc2054601c |
|
| https://github.com/joaocgreis |
|
joaocgreis
| https://github.com/joaocgreis |
|
| https://github.com/nodejs/node/pull/28604/files/c51ec2b04c52dfea8c8a36b41f06b78c6cf732b6 |
|
npm
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anpm |
| Please reload this page | https://github.com/nodejs/node/pull/28604 |
|
| https://github.com/jkunkee |
|
| https://github.com/Trott |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/joaocgreis |
|
| https://github.com/cclauss |
|
| https://github.com/richardlau |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |