| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:8ec932a4-5c5b-0580-e2e3-bb0cf93be91d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 86D8:B2444:D70E29:12E1606:6A4FE3FB |
| html-safe-nonce | 1205d3fef02808d456be7975618691777f72fccea5adb21adb5143ebf998bc48 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NkQ4OkIyNDQ0OkQ3MEUyOToxMkUxNjA2OjZBNEZFM0ZCIiwidmlzaXRvcl9pZCI6IjI0MTA4ODgzOTM0MDk5NDY2MTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 6b650b764fccc4eb94f716ea4efa87166017c4140694616dda40a184aaa73a29 |
| hovercard-subject-tag | pull_request:295083356 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28585/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/265e5451ce7a48a6f785f26bdb81f9925181dcc0421e3f94a7bcab8d9e598344/nodejs/node/pull/28585 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/265e5451ce7a48a6f785f26bdb81f9925181dcc0421e3f94a7bcab8d9e598344/nodejs/node/pull/28585 |
| og:image:alt | To fix #28523
Checklist
documentation is changed or added
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | joe9111 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 19b98c3d9767bb8a56238a89ff8401d1cbdf3bc5c353799aacf49fe6c76b4b7c |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 142593e66413bbae27fd485859993597d5a3b104 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/28585#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28585 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28585 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/28585 |
| Reload | https://github.com/nodejs/node/pull/28585 |
| Reload | https://github.com/nodejs/node/pull/28585 |
| Please reload this page | https://github.com/nodejs/node/pull/28585 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/28585 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
975
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| joe9111 | https://github.com/joe9111 |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| joe9111:patch-1 | https://github.com/joe9111/node/tree/patch-1 |
| Conversation | https://github.com/nodejs/node/pull/28585 |
| Commits8 (8) | https://github.com/nodejs/node/pull/28585/commits |
| Checks | https://github.com/nodejs/node/pull/28585/checks |
| Files changed | https://github.com/nodejs/node/pull/28585/files |
| Update crypto.md | https://github.com/nodejs/node/pull/28585#top |
| joe9111 | https://github.com/joe9111 |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| joe9111:patch-1 | https://github.com/joe9111/node/tree/patch-1 |
|
| https://github.com/joe9111 |
| joe9111 | https://github.com/joe9111 |
| Jul 7, 2019 | https://github.com/nodejs/node/pull/28585#issue-464921845 |
| Please reload this page | https://github.com/nodejs/node/pull/28585 |
| #28523 | https://github.com/nodejs/node/issues/28523 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/28585 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
crypto
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
| Jul 7, 2019 | https://github.com/nodejs/node/pull/28585#event-2464242290 |
| doc: add documentation for createDiffieHellmanGroup | https://github.com/nodejs/node/pull/28585/commits/2b12b37fc8bf9eca5128536e0b50c7a89d7ceb20 |
| 2b12b37 | https://github.com/nodejs/node/pull/28585/commits/2b12b37fc8bf9eca5128536e0b50c7a89d7ceb20 |
| https://github.com/joe9111 |
| joe9111 | https://github.com/joe9111 |
| force-pushed | https://github.com/nodejs/node/compare/c5296a39553c0535b4031de3811f37cf06cba12e..2b12b37fc8bf9eca5128536e0b50c7a89d7ceb20 |
| c5296a3 | https://github.com/nodejs/node/commit/c5296a39553c0535b4031de3811f37cf06cba12e |
| 2b12b37 | https://github.com/nodejs/node/commit/2b12b37fc8bf9eca5128536e0b50c7a89d7ceb20 |
|
Compare
| https://github.com/nodejs/node/compare/c5296a39553c0535b4031de3811f37cf06cba12e..2b12b37fc8bf9eca5128536e0b50c7a89d7ceb20 |
| July 7, 2019 09:15 | https://github.com/nodejs/node/pull/28585#event-2464290661 |
| doc: add documentation for class DiffieHellmanGroup | https://github.com/nodejs/node/pull/28585/commits/69af1e1ae70739871c0e7bba46023b8cb4d26334 |
| 69af1e1 | https://github.com/nodejs/node/pull/28585/commits/69af1e1ae70739871c0e7bba46023b8cb4d26334 |
| https://github.com/fhinkel |
| fhinkel | https://github.com/fhinkel |
|
Jul 8, 2019
| https://github.com/nodejs/node/pull/28585#pullrequestreview-259013743 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28585/files/69af1e1ae70739871c0e7bba46023b8cb4d26334 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Jul 8, 2019
| https://github.com/nodejs/node/pull/28585#pullrequestreview-259104681 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28585/files/69af1e1ae70739871c0e7bba46023b8cb4d26334 |
| Trott | https://github.com/Trott |
| https://github.com/nodejs/node/pull/28585#pullrequestreview-259104681 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/28585 |
| https://github.com/joe9111 |
| joe9111 | https://github.com/joe9111 |
| Jul 9, 2019 | https://github.com/nodejs/node/pull/28585#issuecomment-509453242 |
| Please reload this page | https://github.com/nodejs/node/pull/28585 |
| @Trott | https://github.com/Trott |
| Please reload this page | https://github.com/nodejs/node/pull/28585 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jul 9, 2019 | https://github.com/nodejs/node/pull/28585#issuecomment-509478667 |
| @Trott | https://github.com/Trott |
| @vsemozhetbyt | https://github.com/vsemozhetbyt |
| Please reload this page | https://github.com/nodejs/node/pull/28585 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Jul 9, 2019 | https://github.com/nodejs/node/pull/28585#issuecomment-509491118 |
| Please reload this page | https://github.com/nodejs/node/pull/28585 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Jul 9, 2019
| https://github.com/nodejs/node/pull/28585#pullrequestreview-259272470 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28585/files/69af1e1ae70739871c0e7bba46023b8cb4d26334 |
| doc/api/crypto.md | https://github.com/nodejs/node/pull/28585/files/69af1e1ae70739871c0e7bba46023b8cb4d26334#diff-52a58775d8a5519e232893c0d176d1a7461037007ac2c8f25a2aa803b8304454 |
| Please reload this page | https://github.com/nodejs/node/pull/28585 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Jul 9, 2019
| https://github.com/nodejs/node/pull/28585#pullrequestreview-259272703 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28585/files/69af1e1ae70739871c0e7bba46023b8cb4d26334 |
| doc/api/crypto.md | https://github.com/nodejs/node/pull/28585/files/69af1e1ae70739871c0e7bba46023b8cb4d26334#diff-52a58775d8a5519e232893c0d176d1a7461037007ac2c8f25a2aa803b8304454 |
| Please reload this page | https://github.com/nodejs/node/pull/28585 |
| joe9111 | https://github.com/joe9111 |
| July 9, 2019 14:24 | https://github.com/nodejs/node/pull/28585#commits-pushed-f9b1600 |
|
| https://github.com/joe9111 |
|
| https://github.com/vsemozhetbyt |
| Apply suggestions from code review | https://github.com/nodejs/node/pull/28585/commits/f9b1600cda30df9d8aae17aa713d61258ddf50cc |
| f9b1600 | https://github.com/nodejs/node/pull/28585/commits/f9b1600cda30df9d8aae17aa713d61258ddf50cc |
| move section to correct place | https://github.com/nodejs/node/pull/28585/commits/23ee1b893228c0da48d617350cb5e760b18725ae |
| 23ee1b8 | https://github.com/nodejs/node/pull/28585/commits/23ee1b893228c0da48d617350cb5e760b18725ae |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Jul 10, 2019
| https://github.com/nodejs/node/pull/28585#pullrequestreview-259873379 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28585/files/23ee1b893228c0da48d617350cb5e760b18725ae |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jul 10, 2019 | https://github.com/nodejs/node/pull/28585#issuecomment-509911309 |
| https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3759/ | https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3759/ |
| Please reload this page | https://github.com/nodejs/node/pull/28585 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Jul 10, 2019 | https://github.com/nodejs/node/pull/28585#event-2471359407 |
| https://github.com/joe9111 |
| joe9111 | https://github.com/joe9111 |
| Jul 10, 2019 | https://github.com/nodejs/node/pull/28585#issuecomment-509917040 |
| https://ci.nodejs.org/job/node-test-commit-linuxone/nodes=rhel72-s390x/14495/consoleFull | https://ci.nodejs.org/job/node-test-commit-linuxone/nodes=rhel72-s390x/14495/consoleFull |
| Please reload this page | https://github.com/nodejs/node/pull/28585 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jul 10, 2019 | https://github.com/nodejs/node/pull/28585#issuecomment-509919456 |
| Please reload this page | https://github.com/nodejs/node/pull/28585 |
| https://ci.nodejs.org/job/node-test-commit-linuxone/nodes=rhel72-s390x/14495/consoleFull | https://ci.nodejs.org/job/node-test-commit-linuxone/nodes=rhel72-s390x/14495/consoleFull |
| Please reload this page | https://github.com/nodejs/node/pull/28585 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| stale review | https://github.com/nodejs/node/pull/28585#pullrequestreview-259873379 |
| July 10, 2019 05:55 | https://github.com/nodejs/node/pull/28585#event-2471417807 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Jul 10, 2019 | https://github.com/nodejs/node/pull/28585#event-2471418046 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Jul 10, 2019 | https://github.com/nodejs/node/pull/28585#issuecomment-509920487 |
| @Trott | https://github.com/Trott |
| Please reload this page | https://github.com/nodejs/node/pull/28585 |
| add type for argument | https://github.com/nodejs/node/pull/28585/commits/f2e0defc5081feddead0acf24981955c5c0eed19 |
| f2e0def | https://github.com/nodejs/node/pull/28585/commits/f2e0defc5081feddead0acf24981955c5c0eed19 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Jul 10, 2019
| https://github.com/nodejs/node/pull/28585#pullrequestreview-260100906 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28585/files/f2e0defc5081feddead0acf24981955c5c0eed19 |
| doc/api/crypto.md | https://github.com/nodejs/node/pull/28585/files/f2e0defc5081feddead0acf24981955c5c0eed19#diff-52a58775d8a5519e232893c0d176d1a7461037007ac2c8f25a2aa803b8304454 |
| Please reload this page | https://github.com/nodejs/node/pull/28585 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Jul 10, 2019
| https://github.com/nodejs/node/pull/28585#pullrequestreview-260101905 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28585/files/f2e0defc5081feddead0acf24981955c5c0eed19 |
| doc/api/crypto.md | https://github.com/nodejs/node/pull/28585/files/f2e0defc5081feddead0acf24981955c5c0eed19#diff-52a58775d8a5519e232893c0d176d1a7461037007ac2c8f25a2aa803b8304454 |
| Please reload this page | https://github.com/nodejs/node/pull/28585 |
|
| https://github.com/joe9111 |
|
| https://github.com/vsemozhetbyt |
| Apply suggestions from code review | https://github.com/nodejs/node/pull/28585/commits/a04b890557281bace752dd02227e7df37c41912c |
| a04b890 | https://github.com/nodejs/node/pull/28585/commits/a04b890557281bace752dd02227e7df37c41912c |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| sam-github | https://github.com/sam-github |
| tniessen | https://github.com/tniessen |
| July 11, 2019 14:18 | https://github.com/nodejs/node/pull/28585#event-2476106747 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Jul 12, 2019
| https://github.com/nodejs/node/pull/28585#pullrequestreview-261073030 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28585/files/a04b890557281bace752dd02227e7df37c41912c |
| doc/api/crypto.md | https://github.com/nodejs/node/pull/28585/files/a04b890557281bace752dd02227e7df37c41912c#diff-52a58775d8a5519e232893c0d176d1a7461037007ac2c8f25a2aa803b8304454 |
| Trott | https://github.com/Trott |
| Jul 12, 2019 | https://github.com/nodejs/node/pull/28585#discussion_r302838768 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/28585 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
|
Jul 12, 2019
| https://github.com/nodejs/node/pull/28585#pullrequestreview-261258585 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28585/files |
| doc/api/crypto.md | https://github.com/nodejs/node/pull/28585/files#diff-52a58775d8a5519e232893c0d176d1a7461037007ac2c8f25a2aa803b8304454 |
| tniessen | https://github.com/tniessen |
| Jul 12, 2019 | https://github.com/nodejs/node/pull/28585#discussion_r302982775 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/28585 |
| move text above code | https://github.com/nodejs/node/pull/28585/commits/d2a0636b44f75ceacd05663dea284406e3d1e772 |
| d2a0636 | https://github.com/nodejs/node/pull/28585/commits/d2a0636b44f75ceacd05663dea284406e3d1e772 |
| https://github.com/joe9111 |
| joe9111 | https://github.com/joe9111 |
| force-pushed | https://github.com/nodejs/node/compare/c78356350d0e1fd3c0ceb50b828a84ffeb40e913..d2a0636b44f75ceacd05663dea284406e3d1e772 |
| c783563 | https://github.com/nodejs/node/commit/c78356350d0e1fd3c0ceb50b828a84ffeb40e913 |
| d2a0636 | https://github.com/nodejs/node/commit/d2a0636b44f75ceacd05663dea284406e3d1e772 |
|
Compare
| https://github.com/nodejs/node/compare/c78356350d0e1fd3c0ceb50b828a84ffeb40e913..d2a0636b44f75ceacd05663dea284406e3d1e772 |
| July 12, 2019 14:39 | https://github.com/nodejs/node/pull/28585#event-2479265958 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jul 15, 2019 | https://github.com/nodejs/node/pull/28585#issuecomment-511281957 |
| https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3775/ | https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3775/ |
| Please reload this page | https://github.com/nodejs/node/pull/28585 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Jul 15, 2019
| https://github.com/nodejs/node/pull/28585#pullrequestreview-261639415 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28585/files/d2a0636b44f75ceacd05663dea284406e3d1e772 |
| doc/api/crypto.md | https://github.com/nodejs/node/pull/28585/files/d2a0636b44f75ceacd05663dea284406e3d1e772#diff-52a58775d8a5519e232893c0d176d1a7461037007ac2c8f25a2aa803b8304454 |
| Please reload this page | https://github.com/nodejs/node/pull/28585 |
|
| https://github.com/joe9111 |
|
| https://github.com/Trott |
| Update doc/api/crypto.md | https://github.com/nodejs/node/pull/28585/commits/e9fb832d407736144811124a2945ac9569938256 |
| e9fb832 | https://github.com/nodejs/node/pull/28585/commits/e9fb832d407736144811124a2945ac9569938256 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jul 15, 2019 | https://github.com/nodejs/node/pull/28585#issuecomment-511283393 |
| https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3777/ | https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3777/ |
| Please reload this page | https://github.com/nodejs/node/pull/28585 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jul 15, 2019 | https://github.com/nodejs/node/pull/28585#issuecomment-511283458 |
| @bnoordhuis | https://github.com/bnoordhuis |
| Please reload this page | https://github.com/nodejs/node/pull/28585 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Jul 15, 2019
| https://github.com/nodejs/node/pull/28585#pullrequestreview-261641023 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28585/files/e9fb832d407736144811124a2945ac9569938256 |
| Trott | https://github.com/Trott |
|
Jul 15, 2019
| https://github.com/nodejs/node/pull/28585#ref-commit-11c52d9 |
|
| https://github.com/Trott |
| doc: add documentation for createDiffieHellmanGroup | https://github.com/Trott/io.js/commit/11c52d9e9f4afa6659fd93021a8401c360e8870d |
| 11c52d9 | https://github.com/Trott/io.js/commit/11c52d9e9f4afa6659fd93021a8401c360e8870d |
| nodejs#28585 | https://github.com/nodejs/node/pull/28585 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jul 15, 2019 | https://github.com/nodejs/node/pull/28585#issuecomment-511285166 |
| 11c52d9 | https://github.com/nodejs/node/commit/11c52d9e9f4afa6659fd93021a8401c360e8870d |
| Please reload this page | https://github.com/nodejs/node/pull/28585 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jul 15, 2019 | https://github.com/nodejs/node/pull/28585#event-2481867439 |
| https://github.com/joe9111 |
| joe9111 | https://github.com/joe9111 |
| Jul 15, 2019 | https://github.com/nodejs/node/pull/28585#issuecomment-511291835 |
| @Trott | https://github.com/Trott |
| Please reload this page | https://github.com/nodejs/node/pull/28585 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Jul 15, 2019
| https://github.com/nodejs/node/pull/28585#pullrequestreview-261691826 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28585/files/e9fb832d407736144811124a2945ac9569938256 |
| bnoordhuis | https://github.com/bnoordhuis |
| https://github.com/nodejs/node/pull/28585#pullrequestreview-261691826 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/28585 |
| doc/api/crypto.md | https://github.com/nodejs/node/pull/28585/files/e9fb832d407736144811124a2945ac9569938256#diff-52a58775d8a5519e232893c0d176d1a7461037007ac2c8f25a2aa803b8304454 |
| bnoordhuis | https://github.com/bnoordhuis |
| Jul 15, 2019 | https://github.com/nodejs/node/pull/28585#discussion_r303335719 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/28585 |
| targos | https://github.com/targos |
|
Jul 20, 2019
| https://github.com/nodejs/node/pull/28585#ref-commit-5614e08 |
|
| https://github.com/targos |
| doc: add documentation for createDiffieHellmanGroup | https://github.com/nodejs/node/commit/5614e08f348f4db07cf2c66235ee99c7a515c8d4 |
| 5614e08 | https://github.com/nodejs/node/commit/5614e08f348f4db07cf2c66235ee99c7a515c8d4 |
| #28585 | https://github.com/nodejs/node/pull/28585 |
|
v12.7.0 release proposal
#28816
| https://github.com/nodejs/node/pull/28816 |
|
v12.7.0 release proposal
#28817
| https://github.com/nodejs/node/pull/28817 |
| https://github.com/olingern |
| olingern | https://github.com/olingern |
|
Jul 24, 2019
| https://github.com/nodejs/node/pull/28585#ref-issue-463835383 |
|
doc: crypto.createDiffieHellmanGroup() not documented
#28523
| https://github.com/nodejs/node/issues/28523 |
| vikashk1 | https://github.com/vikashk1 |
|
Aug 13, 2019
| https://github.com/nodejs/node/pull/28585#ref-commit-9af17ad |
|
| https://github.com/vikashk1 |
| Please ignore this msg ( | https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc |
| #1 | https://github.com/vikashk1/node/pull/1 |
| ) | https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc |
| 9af17ad | https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28585 |
|
| https://github.com/bnoordhuis |
|
bnoordhuis
| https://github.com/bnoordhuis |
|
| https://github.com/nodejs/node/pull/28585/files/e9fb832d407736144811124a2945ac9569938256 |
|
| https://github.com/tniessen |
|
tniessen
| https://github.com/tniessen |
|
| https://github.com/nodejs/node/pull/28585/files/c78356350d0e1fd3c0ceb50b828a84ffeb40e913 |
|
| https://github.com/fhinkel |
|
fhinkel
| https://github.com/fhinkel |
|
| https://github.com/nodejs/node/pull/28585/files/69af1e1ae70739871c0e7bba46023b8cb4d26334 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/28585/files/e9fb832d407736144811124a2945ac9569938256 |
|
| https://github.com/sam-github |
|
sam-github
| https://github.com/sam-github |
|
| https://github.com/vsemozhetbyt |
|
vsemozhetbyt
| https://github.com/vsemozhetbyt |
|
| https://github.com/nodejs/node/pull/28585/files/f2e0defc5081feddead0acf24981955c5c0eed19 |
|
crypto
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
doc: crypto.createDiffieHellmanGroup() not documented
| https://github.com/nodejs/node/issues/28523 |
| Please reload this page | https://github.com/nodejs/node/pull/28585 |
|
| https://github.com/joe9111 |
|
| https://github.com/Trott |
|
| https://github.com/vsemozhetbyt |
|
| https://github.com/fhinkel |
|
| https://github.com/bnoordhuis |
|
| https://github.com/tniessen |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |