René's URL Explorer Experiment


Title: http2: override authority with options by lpinca · Pull Request #28584 · nodejs/node · GitHub

Open Graph Title: http2: override authority with options by lpinca · Pull Request #28584 · nodejs/node

X Title: http2: override authority with options by lpinca · Pull Request #28584 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Make options.host and options.port take precedence over authority.host and authority.port respectively. Fixes: #28182 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and...

X Description: Make options.host and options.port take precedence over authority.host and authority.port respectively. Fixes: #28182 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and...

Opengraph URL: https://github.com/nodejs/node/pull/28584

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a1964aef-8707-7a16-30aa-ae2ef8a947ab
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA32E:B97C3:4958A40:667BB06:6A4F7C19
html-safe-nonce2d4ac2e0b4b7d07d4080d1ded9cad1b0cd1a8bca8c22772a341a5262ee99325d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMzJFOkI5N0MzOjQ5NThBNDA6NjY3QkIwNjo2QTRGN0MxOSIsInZpc2l0b3JfaWQiOiI2MDE2NzIyNjcyMDI4NzExOTYxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac94ee6ae2416eda33ceeef634366254cf5b52749771b1e9ca032dd2de7b1515e8
hovercard-subject-tagpull_request:295081316
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28584/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/866fe29340c169b3b029382b666950efceba6493f026df15cbb24166d3486d48/nodejs/node/pull/28584
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/866fe29340c169b3b029382b666950efceba6493f026df15cbb24166d3486d48/nodejs/node/pull/28584
og:image:altMake options.host and options.port take precedence over authority.host and authority.port respectively. Fixes: #28182 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamelpinca
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/28584#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28584
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28584
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/28584
Reloadhttps://github.com/nodejs/node/pull/28584
Reloadhttps://github.com/nodejs/node/pull/28584
Please reload this pagehttps://github.com/nodejs/node/pull/28584
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/28584
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 973 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
lpincahttps://github.com/lpinca
nodejs:masterhttps://github.com/nodejs/node/tree/master
lpinca:gh-28182https://github.com/lpinca/node/tree/gh-28182
Conversationhttps://github.com/nodejs/node/pull/28584
Commits1 (1)https://github.com/nodejs/node/pull/28584/commits
Checkshttps://github.com/nodejs/node/pull/28584/checks
Files changedhttps://github.com/nodejs/node/pull/28584/files
http2: override authority with optionshttps://github.com/nodejs/node/pull/28584#top
lpincahttps://github.com/lpinca
nodejs:masterhttps://github.com/nodejs/node/tree/master
lpinca:gh-28182https://github.com/lpinca/node/tree/gh-28182
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jul 7, 2019https://github.com/nodejs/node/pull/28584#issue-464918714
#28182https://github.com/nodejs/node/issues/28182
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/28584
https://github.com/lpinca
http2: override authority with optionshttps://github.com/nodejs/node/pull/28584/commits/9d4ccdceb245b7f66356fa5bca7227c1b8302a0c
9d4ccdchttps://github.com/nodejs/node/pull/28584/commits/9d4ccdceb245b7f66356fa5bca7227c1b8302a0c
nodejs#28182https://github.com/nodejs/node/issues/28182
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
Jul 7, 2019https://github.com/nodejs/node/pull/28584#event-2464227400
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 7, 2019 https://github.com/nodejs/node/pull/28584#pullrequestreview-258613691
View reviewed changes https://github.com/nodejs/node/pull/28584/files/9d4ccdceb245b7f66356fa5bca7227c1b8302a0c
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 8, 2019 https://github.com/nodejs/node/pull/28584#pullrequestreview-258668951
View reviewed changes https://github.com/nodejs/node/pull/28584/files/9d4ccdceb245b7f66356fa5bca7227c1b8302a0c
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 8, 2019https://github.com/nodejs/node/pull/28584#issuecomment-509061153
Please reload this pagehttps://github.com/nodejs/node/pull/28584
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Jul 8, 2019 https://github.com/nodejs/node/pull/28584#pullrequestreview-259013662
View reviewed changes https://github.com/nodejs/node/pull/28584/files/9d4ccdceb245b7f66356fa5bca7227c1b8302a0c
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Jul 9, 2019 https://github.com/nodejs/node/pull/28584#pullrequestreview-259763279
View reviewed changes https://github.com/nodejs/node/pull/28584/files/9d4ccdceb245b7f66356fa5bca7227c1b8302a0c
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 10, 2019https://github.com/nodejs/node/pull/28584#issuecomment-510058586
https://ci.nodejs.org/job/node-test-pull-request/24359/https://ci.nodejs.org/job/node-test-pull-request/24359/
Please reload this pagehttps://github.com/nodejs/node/pull/28584
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jul 10, 2019https://github.com/nodejs/node/pull/28584#issuecomment-510083018
e800f9dhttps://github.com/nodejs/node/commit/e800f9d68a3d949cd2bcea741638cfa8e42f3461
Please reload this pagehttps://github.com/nodejs/node/pull/28584
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jul 10, 2019https://github.com/nodejs/node/pull/28584#event-2472756435
https://github.com/lpinca
lpincahttps://github.com/lpinca
July 10, 2019 14:24https://github.com/nodejs/node/pull/28584#event-2472758810
lpincahttps://github.com/lpinca
Jul 10, 2019 https://github.com/nodejs/node/pull/28584#ref-commit-e800f9d
https://github.com/lpinca
http2: override authority with optionshttps://github.com/nodejs/node/commit/e800f9d68a3d949cd2bcea741638cfa8e42f3461
e800f9dhttps://github.com/nodejs/node/commit/e800f9d68a3d949cd2bcea741638cfa8e42f3461
#28584https://github.com/nodejs/node/pull/28584
#28182https://github.com/nodejs/node/issues/28182
targoshttps://github.com/targos
Jul 20, 2019 https://github.com/nodejs/node/pull/28584#ref-commit-5b9c227
https://github.com/lpinca
https://github.com/targos
http2: override authority with optionshttps://github.com/nodejs/node/commit/5b9c22710aa7278fc2182e021aa1b5cdd4900298
5b9c227https://github.com/nodejs/node/commit/5b9c22710aa7278fc2182e021aa1b5cdd4900298
#28584https://github.com/nodejs/node/pull/28584
#28182https://github.com/nodejs/node/issues/28182
v12.7.0 release proposal #28816 https://github.com/nodejs/node/pull/28816
v12.7.0 release proposal #28817 https://github.com/nodejs/node/pull/28817
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
Oct 5, 2019 https://github.com/nodejs/node/pull/28584#ref-pullrequest-501628420
http2: support passing options of http2.connect to net.connect #29816 https://github.com/nodejs/node/pull/29816
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28584
https://github.com/fhinkel
fhinkel https://github.com/fhinkel
https://github.com/nodejs/node/pull/28584/files/9d4ccdceb245b7f66356fa5bca7227c1b8302a0c
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/28584/files/9d4ccdceb245b7f66356fa5bca7227c1b8302a0c
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/28584/files/9d4ccdceb245b7f66356fa5bca7227c1b8302a0c
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/28584/files/9d4ccdceb245b7f66356fa5bca7227c1b8302a0c
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
http2.connect(...) - overriding authority with options https://github.com/nodejs/node/issues/28182
Please reload this pagehttps://github.com/nodejs/node/pull/28584
https://github.com/lpinca
https://github.com/Trott
https://github.com/nodejs-github-bot
https://github.com/fhinkel
https://github.com/addaleax
https://github.com/trivikr
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.