René's URL Explorer Experiment


Title: doc: clarify http2 server.close() behavior by cjihrig · Pull Request #28581 · nodejs/node · GitHub

Open Graph Title: doc: clarify http2 server.close() behavior by cjihrig · Pull Request #28581 · nodejs/node

X Title: doc: clarify http2 server.close() behavior by cjihrig · Pull Request #28581 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This commit is an attempt to clarify the behavior of HTTP2's server.close() method. Specifically, this makes it more clear that the server stops allowing new sessions although the callback may ...

X Description: This commit is an attempt to clarify the behavior of HTTP2's server.close() method. Specifically, this makes it more clear that the server stops allowing new sessions although the callback ...

Opengraph URL: https://github.com/nodejs/node/pull/28581

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ccdeadd6-349c-ba83-16f8-d7b074af848b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idECB6:1B445F:46D3596:64CBAAC:6A4FD19F
html-safe-nonce1d31e06ceb982bfb9f499537d1f51ffcbc33a7707bf93dd82d67b9980b5f87b3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQ0I2OjFCNDQ1Rjo0NkQzNTk2OjY0Q0JBQUM6NkE0RkQxOUYiLCJ2aXNpdG9yX2lkIjoiMzUwMTA3NTc2NjMxODA4NDE2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac0020a3c2945b357f1b6438634beb0ac8418a7f34d8517cc3a5904896886cf128
hovercard-subject-tagpull_request:295044997
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28581/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f10e2ff199e0ea12ea3d0c804fca54a079f1cab343d3061f8f06f4ca99e7319b/nodejs/node/pull/28581
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f10e2ff199e0ea12ea3d0c804fca54a079f1cab343d3061f8f06f4ca99e7319b/nodejs/node/pull/28581
og:image:altThis commit is an attempt to clarify the behavior of HTTP2's server.close() method. Specifically, this makes it more clear that the server stops allowing new sessions although the callback may ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecjihrig
hostnamegithub.com
expected-hostnamegithub.com
None19b98c3d9767bb8a56238a89ff8401d1cbdf3bc5c353799aacf49fe6c76b4b7c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release142593e66413bbae27fd485859993597d5a3b104
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/28581#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28581
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28581
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/28581
Reloadhttps://github.com/nodejs/node/pull/28581
Reloadhttps://github.com/nodejs/node/pull/28581
Please reload this pagehttps://github.com/nodejs/node/pull/28581
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/28581
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 973 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:h2-server-closehttps://github.com/cjihrig/node/tree/h2-server-close
Conversationhttps://github.com/nodejs/node/pull/28581
Commits1 (1)https://github.com/nodejs/node/pull/28581/commits
Checkshttps://github.com/nodejs/node/pull/28581/checks
Files changedhttps://github.com/nodejs/node/pull/28581/files
doc: clarify http2 server.close() behaviorhttps://github.com/nodejs/node/pull/28581#top
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:h2-server-closehttps://github.com/cjihrig/node/tree/h2-server-close
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jul 6, 2019https://github.com/nodejs/node/pull/28581#issue-464863196
#28214https://github.com/nodejs/node/issues/28214
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/28581
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
doc https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
Jul 6, 2019https://github.com/nodejs/node/pull/28581#event-2463982598
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Jul 6, 2019https://github.com/nodejs/node/pull/28581#issuecomment-508934684
the same method of the Http2SecureServerhttps://nodejs.org/api/http2.html#http2_server_close_callback_1
Please reload this pagehttps://github.com/nodejs/node/pull/28581
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jul 6, 2019 https://github.com/nodejs/node/pull/28581#pullrequestreview-258600787
View reviewed changes https://github.com/nodejs/node/pull/28581/files
https://github.com/gengjiawen
gengjiawenhttps://github.com/gengjiawen
Jul 7, 2019 https://github.com/nodejs/node/pull/28581#pullrequestreview-258626661
View reviewed changes https://github.com/nodejs/node/pull/28581/files
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/de0c9d178f685b1aac242a19e3da9048f3721421..aeecc3bbb65b4b0fdc205ab26380a14b9f4de397
de0c9d1https://github.com/nodejs/node/commit/de0c9d178f685b1aac242a19e3da9048f3721421
aeecc3bhttps://github.com/nodejs/node/commit/aeecc3bbb65b4b0fdc205ab26380a14b9f4de397
Compare https://github.com/nodejs/node/compare/de0c9d178f685b1aac242a19e3da9048f3721421..aeecc3bbb65b4b0fdc205ab26380a14b9f4de397
July 7, 2019 16:07https://github.com/nodejs/node/pull/28581#event-2464455746
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jul 7, 2019https://github.com/nodejs/node/pull/28581#issuecomment-509012339
https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3750/https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3750/
Please reload this pagehttps://github.com/nodejs/node/pull/28581
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jul 7, 2019https://github.com/nodejs/node/pull/28581#event-2464460152
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 8, 2019 https://github.com/nodejs/node/pull/28581#pullrequestreview-258674298
View reviewed changes https://github.com/nodejs/node/pull/28581/files
https://github.com/cjihrig
doc: clarify http2 server.close() behaviorhttps://github.com/nodejs/node/pull/28581/commits/30911157f6b186628ffc527b89b84eb10becda84
3091115https://github.com/nodejs/node/pull/28581/commits/30911157f6b186628ffc527b89b84eb10becda84
nodejs#28581https://github.com/nodejs/node/pull/28581
nodejs#28214https://github.com/nodejs/node/issues/28214
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/aeecc3bbb65b4b0fdc205ab26380a14b9f4de397..30911157f6b186628ffc527b89b84eb10becda84
aeecc3bhttps://github.com/nodejs/node/commit/aeecc3bbb65b4b0fdc205ab26380a14b9f4de397
3091115https://github.com/nodejs/node/commit/30911157f6b186628ffc527b89b84eb10becda84
Compare https://github.com/nodejs/node/compare/aeecc3bbb65b4b0fdc205ab26380a14b9f4de397..30911157f6b186628ffc527b89b84eb10becda84
July 8, 2019 17:38https://github.com/nodejs/node/pull/28581#event-2466930039
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
3091115https://github.com/nodejs/node/commit/30911157f6b186628ffc527b89b84eb10becda84
Jul 8, 2019https://github.com/nodejs/node/pull/28581#event-2466934997
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
July 8, 2019 17:40https://github.com/nodejs/node/pull/28581#event-2466935595
targoshttps://github.com/targos
Jul 20, 2019 https://github.com/nodejs/node/pull/28581#ref-commit-6f3ebb8
https://github.com/cjihrig
https://github.com/targos
doc: clarify http2 server.close() behaviorhttps://github.com/nodejs/node/commit/6f3ebb8787d2def925ac28a4a6b8c836e42e364d
6f3ebb8https://github.com/nodejs/node/commit/6f3ebb8787d2def925ac28a4a6b8c836e42e364d
#28581https://github.com/nodejs/node/pull/28581
#28214https://github.com/nodejs/node/issues/28214
v12.7.0 release proposal #28816 https://github.com/nodejs/node/pull/28816
v12.7.0 release proposal #28817 https://github.com/nodejs/node/pull/28817
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28581
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/28581/files/aeecc3bbb65b4b0fdc205ab26380a14b9f4de397
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/28581/files/de0c9d178f685b1aac242a19e3da9048f3721421
https://github.com/gengjiawen
gengjiawen https://github.com/gengjiawen
https://github.com/nodejs/node/pull/28581/files/de0c9d178f685b1aac242a19e3da9048f3721421
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
doc https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
Http2Server.prototype.close Does Not Work as Expected https://github.com/nodejs/node/issues/28214
Please reload this pagehttps://github.com/nodejs/node/pull/28581
https://github.com/cjihrig
https://github.com/vsemozhetbyt
https://github.com/Trott
https://github.com/lpinca
https://github.com/gengjiawen
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.