| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:3bfc6770-dd37-7276-535b-2254723f0bd4 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9EAA:25572C:3AB483C:503C202:6A4F255C |
| html-safe-nonce | 33bbb5180aeb12d8666af5ef1f4a45cc63f54db6d675b0265637ec656a2681dd |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RUFBOjI1NTcyQzozQUI0ODNDOjUwM0MyMDI6NkE0RjI1NUMiLCJ2aXNpdG9yX2lkIjoiMTQyNDI1MTgwNDcwNzY2MTE0OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | c46bf9320a66edc616fadaa59ece41ba5a0277ba9eb5d30cf58e77eb1095108c |
| hovercard-subject-tag | pull_request:294938807 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28563/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/d447387e38065b8989515927a5c2480418ca2f4e02101f12f27eec4b2a4b439b/nodejs/node/pull/28563 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d447387e38065b8989515927a5c2480418ca2f4e02101f12f27eec4b2a4b439b/nodejs/node/pull/28563 |
| og:image:alt | EDIT: Title and commit message changed to reflect that this PR is now only about Python 3 compatibility and is no longer a complete upgrade to gyp v5.0.2.
As discussed in #28555 there are a lot of... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | cclauss |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b8f23afb982271f1b22258a94aede67a6b77760 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/28563#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28563 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28563 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/28563 |
| Reload | https://github.com/nodejs/node/pull/28563 |
| Reload | https://github.com/nodejs/node/pull/28563 |
| Please reload this page | https://github.com/nodejs/node/pull/28563 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/28563 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
969
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| cclauss | https://github.com/cclauss |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| cclauss:Update-gyp-to-49c7f99-v5.0.2 | https://github.com/cclauss/node/tree/Update-gyp-to-49c7f99-v5.0.2 |
| Conversation | https://github.com/nodejs/node/pull/28563 |
| Commits2 (2) | https://github.com/nodejs/node/pull/28563/commits |
| Checks | https://github.com/nodejs/node/pull/28563/checks |
| Files changed | https://github.com/nodejs/node/pull/28563/files |
| gyp: cherrypick more Python3 changes from node-gyp | https://github.com/nodejs/node/pull/28563#top |
| cclauss | https://github.com/cclauss |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| cclauss:Update-gyp-to-49c7f99-v5.0.2 | https://github.com/cclauss/node/tree/Update-gyp-to-49c7f99-v5.0.2 |
|
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| Jul 5, 2019 | https://github.com/nodejs/node/pull/28563#issue-464718095 |
| Please reload this page | https://github.com/nodejs/node/pull/28563 |
| #28555 | https://github.com/nodejs/node/issues/28555 |
| 317b712 | https://github.com/nodejs/node/commit/317b712a52e0bb855bd18670ea8efa6c32bae032 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/28563 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| bzoz | https://github.com/bzoz |
| refack | https://github.com/refack |
| richardlau | https://github.com/richardlau |
| rvagg | https://github.com/rvagg |
| sam-github | https://github.com/sam-github |
| July 5, 2019 17:07 | https://github.com/nodejs/node/pull/28563#event-2463219456 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Jul 5, 2019 | https://github.com/nodejs/node/pull/28563#event-2463219548 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Jul 5, 2019
| https://github.com/nodejs/node/pull/28563#pullrequestreview-258492029 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28563/files |
| tools/gyp/AUTHORS | https://github.com/nodejs/node/pull/28563/files#diff-9067366ae35ede12693c11f7d2f7c45d406ecc01409fdcd144506b5b60fbcfee |
| Please reload this page | https://github.com/nodejs/node/pull/28563 |
| tools/gyp/pylib/gyp/MSVSVersion.py | https://github.com/nodejs/node/pull/28563/files#diff-b8a1b7c640de99a9d3266a1a22e6a68191a7c473169650b62260f5c9df2aa1cc |
| Please reload this page | https://github.com/nodejs/node/pull/28563 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Jul 5, 2019 | https://github.com/nodejs/node/pull/28563#issuecomment-508825115 |
| @cclauss | https://github.com/cclauss |
| https://ci.nodejs.org/job/node-test-pull-request/build?delay=0sec | https://ci.nodejs.org/job/node-test-pull-request/build?delay=0sec |
| Please reload this page | https://github.com/nodejs/node/pull/28563 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Jul 5, 2019 | https://github.com/nodejs/node/pull/28563#issuecomment-508825741 |
| Please reload this page | https://github.com/nodejs/node/pull/28563 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
python
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Apython |
| Jul 5, 2019 | https://github.com/nodejs/node/pull/28563#event-2463307429 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jul 5, 2019 | https://github.com/nodejs/node/pull/28563#issuecomment-508829803 |
| Please reload this page | https://github.com/nodejs/node/pull/28563 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| Jul 5, 2019 | https://github.com/nodejs/node/pull/28563#issuecomment-508837082 |
| Please reload this page | https://github.com/nodejs/node/pull/28563 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| Jul 5, 2019 | https://github.com/nodejs/node/pull/28563#issuecomment-508868092 |
| Please reload this page | https://github.com/nodejs/node/pull/28563 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 5, 2019 | https://github.com/nodejs/node/pull/28563#issuecomment-508868674 |
| https://ci.nodejs.org/job/node-test-pull-request/24294/ | https://ci.nodejs.org/job/node-test-pull-request/24294/ |
| Please reload this page | https://github.com/nodejs/node/pull/28563 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 6, 2019 | https://github.com/nodejs/node/pull/28563#issuecomment-508895889 |
| https://ci.nodejs.org/job/node-test-pull-request/24308/ | https://ci.nodejs.org/job/node-test-pull-request/24308/ |
| Please reload this page | https://github.com/nodejs/node/pull/28563 |
| https://github.com/rvagg |
| rvagg | https://github.com/rvagg |
| Jul 6, 2019 | https://github.com/nodejs/node/pull/28563#issuecomment-508896724 |
| https://ci.nodejs.org/job/node-test-commit-linux-containered/13762/nodes=ubuntu1604_sharedlibs_shared_x64/ | https://ci.nodejs.org/job/node-test-commit-linux-containered/13762/nodes=ubuntu1604_sharedlibs_shared_x64/ |
| Please reload this page | https://github.com/nodejs/node/pull/28563 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| Jul 6, 2019 | https://github.com/nodejs/node/pull/28563#issuecomment-508900844 |
| Please reload this page | https://github.com/nodejs/node/pull/28563 |
| https://github.com/rvagg |
| rvagg | https://github.com/rvagg |
| Jul 6, 2019 | https://github.com/nodejs/node/pull/28563#issuecomment-508901011 |
| Please reload this page | https://github.com/nodejs/node/pull/28563 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| Jul 6, 2019 | https://github.com/nodejs/node/pull/28563#issuecomment-508901332 |
| Please reload this page | https://github.com/nodejs/node/pull/28563 |
| Please reload this page | https://github.com/nodejs/node/pull/28563 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
|
Jul 6, 2019
| https://github.com/nodejs/node/pull/28563#ref-pullrequest-464849824 |
|
gyp: pull Python 3 changes from node/node-gyp
#28573
| https://github.com/nodejs/node/pull/28573 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
|
gyp
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Agyp |
| Jul 6, 2019 | https://github.com/nodejs/node/pull/28563#event-2463933594 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Jul 8, 2019 | https://github.com/nodejs/node/pull/28563#issuecomment-509343021 |
| Please reload this page | https://github.com/nodejs/node/pull/28563 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| force-pushed | https://github.com/nodejs/node/compare/be09992271658d7b7e824ddd74aa58fdf87bcbd4..ea06c83313e3ba89026bca4f759e6ebd003874bd |
| be09992 | https://github.com/nodejs/node/commit/be09992271658d7b7e824ddd74aa58fdf87bcbd4 |
| ea06c83 | https://github.com/nodejs/node/commit/ea06c83313e3ba89026bca4f759e6ebd003874bd |
|
Compare
| https://github.com/nodejs/node/compare/be09992271658d7b7e824ddd74aa58fdf87bcbd4..ea06c83313e3ba89026bca4f759e6ebd003874bd |
| July 8, 2019 18:47 | https://github.com/nodejs/node/pull/28563#event-2467104969 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 8, 2019 | https://github.com/nodejs/node/pull/28563#issuecomment-509347752 |
| https://ci.nodejs.org/job/node-test-pull-request/24331/ | https://ci.nodejs.org/job/node-test-pull-request/24331/ |
| Please reload this page | https://github.com/nodejs/node/pull/28563 |
| https://github.com/MattIPv4 |
| MattIPv4 | https://github.com/MattIPv4 |
| Jul 11, 2019 | https://github.com/nodejs/node/pull/28563#issuecomment-510562208 |
| #28573 | https://github.com/nodejs/node/pull/28573 |
| Please reload this page | https://github.com/nodejs/node/pull/28563 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| force-pushed | https://github.com/nodejs/node/compare/ea06c83313e3ba89026bca4f759e6ebd003874bd..be49b93dec5e93bf728d1c756473e606c0b5f92f |
| ea06c83 | https://github.com/nodejs/node/commit/ea06c83313e3ba89026bca4f759e6ebd003874bd |
| be49b93 | https://github.com/nodejs/node/commit/be49b93dec5e93bf728d1c756473e606c0b5f92f |
|
Compare
| https://github.com/nodejs/node/compare/ea06c83313e3ba89026bca4f759e6ebd003874bd..be49b93dec5e93bf728d1c756473e606c0b5f92f |
| July 11, 2019 16:45 | https://github.com/nodejs/node/pull/28563#event-2476592310 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Jul 11, 2019 | https://github.com/nodejs/node/pull/28563#issuecomment-510595448 |
| Please reload this page | https://github.com/nodejs/node/pull/28563 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 11, 2019 | https://github.com/nodejs/node/pull/28563#issuecomment-510595670 |
| https://ci.nodejs.org/job/node-test-pull-request/24377/ | https://ci.nodejs.org/job/node-test-pull-request/24377/ |
| Please reload this page | https://github.com/nodejs/node/pull/28563 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| force-pushed | https://github.com/nodejs/node/compare/d8284d23407b8858948588a74d6c3724af20d7bc..31f69ea6e40e4f77a2a8f00a158fb1fbd63c33da |
| d8284d2 | https://github.com/nodejs/node/commit/d8284d23407b8858948588a74d6c3724af20d7bc |
| 31f69ea | https://github.com/nodejs/node/commit/31f69ea6e40e4f77a2a8f00a158fb1fbd63c33da |
|
Compare
| https://github.com/nodejs/node/compare/d8284d23407b8858948588a74d6c3724af20d7bc..31f69ea6e40e4f77a2a8f00a158fb1fbd63c33da |
| July 11, 2019 20:45 | https://github.com/nodejs/node/pull/28563#event-2477209758 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Jul 11, 2019 | https://github.com/nodejs/node/pull/28563#issuecomment-510668381 |
| Please reload this page | https://github.com/nodejs/node/pull/28563 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 11, 2019 | https://github.com/nodejs/node/pull/28563#issuecomment-510668665 |
| https://ci.nodejs.org/job/node-test-pull-request/24383/ | https://ci.nodejs.org/job/node-test-pull-request/24383/ |
| Please reload this page | https://github.com/nodejs/node/pull/28563 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Jul 12, 2019
| https://github.com/nodejs/node/pull/28563#pullrequestreview-261008068 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28563/files |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Jul 12, 2019 | https://github.com/nodejs/node/pull/28563#issuecomment-510695782 |
| Please reload this page | https://github.com/nodejs/node/pull/28563 |
|
| https://github.com/cclauss |
| gyp: cherrypick more Python3 changes from node-gyp | https://github.com/nodejs/node/pull/28563/commits/f1019de44d6c24dfbf2c3e17ed46a1f0b15d70ac |
| f1019de | https://github.com/nodejs/node/pull/28563/commits/f1019de44d6c24dfbf2c3e17ed46a1f0b15d70ac |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| force-pushed | https://github.com/nodejs/node/compare/c8e2e7519036a943edd1a49567f11021794f3b5d..f1019de44d6c24dfbf2c3e17ed46a1f0b15d70ac |
| c8e2e75 | https://github.com/nodejs/node/commit/c8e2e7519036a943edd1a49567f11021794f3b5d |
| f1019de | https://github.com/nodejs/node/commit/f1019de44d6c24dfbf2c3e17ed46a1f0b15d70ac |
|
Compare
| https://github.com/nodejs/node/compare/c8e2e7519036a943edd1a49567f11021794f3b5d..f1019de44d6c24dfbf2c3e17ed46a1f0b15d70ac |
| July 12, 2019 06:58 | https://github.com/nodejs/node/pull/28563#event-2478095501 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| Jul 12, 2019 | https://github.com/nodejs/node/pull/28563#event-2478098508 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| Jul 12, 2019 | https://github.com/nodejs/node/pull/28563#issuecomment-510772540 |
| Please reload this page | https://github.com/nodejs/node/pull/28563 |
| Please reload this page | https://github.com/nodejs/node/pull/28563 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 12, 2019 | https://github.com/nodejs/node/pull/28563#issuecomment-510825182 |
| https://ci.nodejs.org/job/node-test-pull-request/24402/ | https://ci.nodejs.org/job/node-test-pull-request/24402/ |
| Please reload this page | https://github.com/nodejs/node/pull/28563 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| bnoordhuis | https://github.com/bnoordhuis |
| July 13, 2019 17:17 | https://github.com/nodejs/node/pull/28563#event-2480880764 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| Jul 15, 2019 | https://github.com/nodejs/node/pull/28563#issuecomment-511334715 |
| Please reload this page | https://github.com/nodejs/node/pull/28563 |
| @MattIPv4 | https://github.com/MattIPv4 |
| #28573 | https://github.com/nodejs/node/pull/28573 |
| #28563 | https://github.com/nodejs/node/pull/28563 |
| #28537 | https://github.com/nodejs/node/pull/28537 |
| #25878 | https://github.com/nodejs/node/pull/25878 |
| Please reload this page | https://github.com/nodejs/node/pull/28563 |
| https://github.com/MattIPv4 |
| MattIPv4 | https://github.com/MattIPv4 |
| Jul 15, 2019 | https://github.com/nodejs/node/pull/28563#issuecomment-511340670 |
| @cclauss | https://github.com/cclauss |
| Please reload this page | https://github.com/nodejs/node/pull/28563 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| Jul 15, 2019 | https://github.com/nodejs/node/pull/28563#issuecomment-511344367 |
| Please reload this page | https://github.com/nodejs/node/pull/28563 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Jul 15, 2019
| https://github.com/nodejs/node/pull/28563#pullrequestreview-261768983 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28563/files/f1019de44d6c24dfbf2c3e17ed46a1f0b15d70ac |
| bnoordhuis | https://github.com/bnoordhuis |
| https://github.com/nodejs/node/pull/28563#pullrequestreview-261768983 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @cclauss | https://github.com/cclauss |
| Please reload this page | https://github.com/nodejs/node/pull/28563 |
| tools/gyp/pylib/gyp/MSVSSettings.py | https://github.com/nodejs/node/pull/28563/files/f1019de44d6c24dfbf2c3e17ed46a1f0b15d70ac#diff-b87f5b5c9ff40e1285d22a4268c18f5e7142447345c309a06db4ddce782af24d |
| Please reload this page | https://github.com/nodejs/node/pull/28563 |
| tools/gyp/pylib/gyp/MSVSSettings.py | https://github.com/nodejs/node/pull/28563/files/f1019de44d6c24dfbf2c3e17ed46a1f0b15d70ac#diff-b87f5b5c9ff40e1285d22a4268c18f5e7142447345c309a06db4ddce782af24d |
| Please reload this page | https://github.com/nodejs/node/pull/28563 |
| tools/gyp/pylib/gyp/xcodeproj_file.py | https://github.com/nodejs/node/pull/28563/files/f1019de44d6c24dfbf2c3e17ed46a1f0b15d70ac#diff-b10e4f64fd3927710c2904d184cb90ef4a0471580d5997018fb9a96e8669cb40 |
| Please reload this page | https://github.com/nodejs/node/pull/28563 |
|
| https://github.com/cclauss |
| Fix indentation | https://github.com/nodejs/node/pull/28563/commits/a7817928e3e5cd962528bbb28d3be8b0382ed4a2 |
| a781792 | https://github.com/nodejs/node/pull/28563/commits/a7817928e3e5cd962528bbb28d3be8b0382ed4a2 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| joaocgreis | https://github.com/joaocgreis |
| July 15, 2019 15:34 | https://github.com/nodejs/node/pull/28563#event-2483334808 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Jul 15, 2019
| https://github.com/nodejs/node/pull/28563#pullrequestreview-262049613 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28563/files/a7817928e3e5cd962528bbb28d3be8b0382ed4a2 |
| https://github.com/MattIPv4 |
| MattIPv4 | https://github.com/MattIPv4 |
|
Jul 15, 2019
| https://github.com/nodejs/node/pull/28563#pullrequestreview-262079780 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28563/files/a7817928e3e5cd962528bbb28d3be8b0382ed4a2 |
| MattIPv4 | https://github.com/MattIPv4 |
| https://github.com/nodejs/node/pull/28563#pullrequestreview-262079780 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/28563 |
| tools/gyp/pylib/gyp/generator/make.py | https://github.com/nodejs/node/pull/28563/files/a7817928e3e5cd962528bbb28d3be8b0382ed4a2#diff-fdcd8e99fcabbabf780f5388bc9bd6d3f1e52502dad7008019acb21365e99d17 |
| MattIPv4 | https://github.com/MattIPv4 |
| Jul 15, 2019 | https://github.com/nodejs/node/pull/28563#discussion_r303640296 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/28563 |
| cclauss | https://github.com/cclauss |
| Jul 15, 2019 | https://github.com/nodejs/node/pull/28563#discussion_r303652409 |
| Please reload this page | https://github.com/nodejs/node/pull/28563 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| nodejs/node-gyp#1334 (comment) | https://github.com/nodejs/node-gyp/pull/1334#issuecomment-429650411 |
| Please reload this page | https://github.com/nodejs/node/pull/28563 |
| MattIPv4 | https://github.com/MattIPv4 |
| Jul 15, 2019 | https://github.com/nodejs/node/pull/28563#discussion_r303653914 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/28563 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 16, 2019 | https://github.com/nodejs/node/pull/28563#issuecomment-511656927 |
| https://ci.nodejs.org/job/node-test-pull-request/24491/ | https://ci.nodejs.org/job/node-test-pull-request/24491/ |
| Please reload this page | https://github.com/nodejs/node/pull/28563 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Jul 16, 2019
| https://github.com/nodejs/node/pull/28563#pullrequestreview-262576831 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28563/files/a7817928e3e5cd962528bbb28d3be8b0382ed4a2 |
| Trott | https://github.com/Trott |
| https://github.com/nodejs/node/pull/28563#pullrequestreview-262576831 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/28563 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Jul 16, 2019
| https://github.com/nodejs/node/pull/28563#pullrequestreview-262577038 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28563/files/a7817928e3e5cd962528bbb28d3be8b0382ed4a2 |
| Trott | https://github.com/Trott |
| https://github.com/nodejs/node/pull/28563#pullrequestreview-262577038 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/28563 |
| Trott | https://github.com/Trott |
|
Jul 16, 2019
| https://github.com/nodejs/node/pull/28563#ref-commit-54fcb14 |
|
| https://github.com/cclauss |
|
| https://github.com/Trott |
| gyp: cherrypick more Python3 changes from node-gyp | https://github.com/Trott/io.js/commit/54fcb14467b59e82d6e24bf44803462226a5de4d |
| 54fcb14 | https://github.com/Trott/io.js/commit/54fcb14467b59e82d6e24bf44803462226a5de4d |
| nodejs#28563 | https://github.com/nodejs/node/pull/28563 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jul 16, 2019 | https://github.com/nodejs/node/pull/28563#issuecomment-511915792 |
| Please reload this page | https://github.com/nodejs/node/pull/28563 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jul 16, 2019 | https://github.com/nodejs/node/pull/28563#event-2486961536 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| July 16, 2019 18:11 | https://github.com/nodejs/node/pull/28563#event-2487042412 |
| targos | https://github.com/targos |
|
Jul 20, 2019
| https://github.com/nodejs/node/pull/28563#ref-commit-d630cc0 |
|
| https://github.com/cclauss |
|
| https://github.com/targos |
| gyp: cherrypick more Python3 changes from node-gyp | https://github.com/nodejs/node/commit/d630cc0ec5cac7d31d1fd9fa9f4661a53e51a590 |
| d630cc0 | https://github.com/nodejs/node/commit/d630cc0ec5cac7d31d1fd9fa9f4661a53e51a590 |
| #28563 | https://github.com/nodejs/node/pull/28563 |
|
v12.7.0 release proposal
#28816
| https://github.com/nodejs/node/pull/28816 |
|
v12.7.0 release proposal
#28817
| https://github.com/nodejs/node/pull/28817 |
| vikashk1 | https://github.com/vikashk1 |
|
Aug 13, 2019
| https://github.com/nodejs/node/pull/28563#ref-commit-9af17ad |
|
| https://github.com/vikashk1 |
| Please ignore this msg ( | https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc |
| #1 | https://github.com/vikashk1/node/pull/1 |
| ) | https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc |
| 9af17ad | https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc |
| BaochengSu | https://github.com/BaochengSu |
|
Oct 20, 2020
| https://github.com/nodejs/node/pull/28563#ref-commit-6eb5e27 |
|
| https://github.com/cclauss |
|
| https://github.com/BaochengSu |
| gyp: cherrypick more Python3 changes from node-gyp | https://github.com/BaochengSu/node/commit/6eb5e27ed1bcf0216a20ec842671e650c36c39d0 |
| 6eb5e27 | https://github.com/BaochengSu/node/commit/6eb5e27ed1bcf0216a20ec842671e650c36c39d0 |
| nodejs#28563 | https://github.com/nodejs/node/pull/28563 |
| 54fcb14 | https://github.com/BaochengSu/node/commit/54fcb14467b59e82d6e24bf44803462226a5de4d |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28563 |
|
| https://github.com/bnoordhuis |
|
bnoordhuis
| https://github.com/bnoordhuis |
|
| https://github.com/nodejs/node/pull/28563/files/a7817928e3e5cd962528bbb28d3be8b0382ed4a2 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/28563/files/a7817928e3e5cd962528bbb28d3be8b0382ed4a2 |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/28563/files/c8e2e7519036a943edd1a49567f11021794f3b5d |
|
| https://github.com/sam-github |
|
sam-github
| https://github.com/sam-github |
|
| https://github.com/refack |
|
refack
| https://github.com/refack |
|
| https://github.com/rvagg |
|
rvagg
| https://github.com/rvagg |
|
| https://github.com/bzoz |
|
bzoz
| https://github.com/bzoz |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/joaocgreis |
|
joaocgreis
| https://github.com/joaocgreis |
|
| https://github.com/MattIPv4 |
|
MattIPv4
| https://github.com/MattIPv4 |
|
| https://github.com/nodejs/node/pull/28563/files/a7817928e3e5cd962528bbb28d3be8b0382ed4a2 |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
gyp
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Agyp |
|
python
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Apython |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Please reload this page | https://github.com/nodejs/node/pull/28563 |
|
| https://github.com/cclauss |
|
| https://github.com/sam-github |
|
| https://github.com/Trott |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/rvagg |
|
| https://github.com/MattIPv4 |
|
| https://github.com/richardlau |
|
| https://github.com/bnoordhuis |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |