| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:2fe7e931-54d9-d510-a9bf-399bb70e82c2 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | ECF4:11B239:23A23C7:30F49C9:6A503E83 |
| html-safe-nonce | 6f25b876a13501113ad9dba5a043f28d250bc1cf00f1444cd69a2b0144e0263b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQ0Y0OjExQjIzOToyM0EyM0M3OjMwRjQ5Qzk6NkE1MDNFODMiLCJ2aXNpdG9yX2lkIjoiMjAwNzc1ODIwMTc1MjE0MTQ0MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 3ff281f00a831f1ff2a089510239a3bc10c904bcf74ea3e7b50b908cb24a3deb |
| hovercard-subject-tag | pull_request:294923508 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28562/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/a8d6e694a9bb4d36ef3dc9959045d71fd5dc9e57465c15de9dbc9b722b91c03b/nodejs/node/pull/28562 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a8d6e694a9bb4d36ef3dc9959045d71fd5dc9e57465c15de9dbc9b722b91c03b/nodejs/node/pull/28562 |
| og:image:alt | This commit allows fatal exceptions to be enhanced so that exceptions thrown from an 'unhandledException' handler have the stack attached properly.
I still need to add a test, but first I w... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | cjihrig |
| hostname | github.com |
| expected-hostname | github.com |
| None | d6dc8294eb500fa36bbc57472d61fe87c522f9c3c1d64f70f4926f66a66a7efb |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d90666eaf032b7eb8975a378efe38e37f4ebb96c |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/28562#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28562 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28562 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/28562 |
| Reload | https://github.com/nodejs/node/pull/28562 |
| Reload | https://github.com/nodejs/node/pull/28562 |
| Please reload this page | https://github.com/nodejs/node/pull/28562 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/28562 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
978
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| cjihrig | https://github.com/cjihrig |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| cjihrig:err-stack | https://github.com/cjihrig/node/tree/err-stack |
| Conversation | https://github.com/nodejs/node/pull/28562 |
| Commits1 (1) | https://github.com/nodejs/node/pull/28562/commits |
| Checks | https://github.com/nodejs/node/pull/28562/checks |
| Files changed | https://github.com/nodejs/node/pull/28562/files |
| src: allow fatal exceptions to be enhanced | https://github.com/nodejs/node/pull/28562#top |
| cjihrig | https://github.com/cjihrig |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| cjihrig:err-stack | https://github.com/cjihrig/node/tree/err-stack |
|
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Jul 5, 2019 | https://github.com/nodejs/node/pull/28562#issue-464698723 |
| Please reload this page | https://github.com/nodejs/node/pull/28562 |
| #28550 | https://github.com/nodejs/node/issues/28550 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/28562 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
| Jul 5, 2019 | https://github.com/nodejs/node/pull/28562#event-2463101162 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Jul 5, 2019
| https://github.com/nodejs/node/pull/28562#pullrequestreview-258477188 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28562/files |
| src/node_errors.cc | https://github.com/nodejs/node/pull/28562/files#diff-090d65062da5652b79f8a641489e4bd33b37faf28b8e91cc2ac31ab43084a3d2 |
| Please reload this page | https://github.com/nodejs/node/pull/28562 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Jul 5, 2019 | https://github.com/nodejs/node/pull/28562#issuecomment-508812910 |
| Please reload this page | https://github.com/nodejs/node/pull/28562 |
| https://github.com/devsnek |
| devsnek | https://github.com/devsnek |
| Jul 5, 2019 | https://github.com/nodejs/node/pull/28562#issuecomment-508822123 |
| Please reload this page | https://github.com/nodejs/node/pull/28562 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| force-pushed | https://github.com/nodejs/node/compare/5aa189da140d5ca8fe7b89b488f71e67dcaac37c..1f21d4f72b72f78236c54d310d41bd954f5b1564 |
| 5aa189d | https://github.com/nodejs/node/commit/5aa189da140d5ca8fe7b89b488f71e67dcaac37c |
| 1f21d4f | https://github.com/nodejs/node/commit/1f21d4f72b72f78236c54d310d41bd954f5b1564 |
|
Compare
| https://github.com/nodejs/node/compare/5aa189da140d5ca8fe7b89b488f71e67dcaac37c..1f21d4f72b72f78236c54d310d41bd954f5b1564 |
| July 5, 2019 18:09 | https://github.com/nodejs/node/pull/28562#event-2463314095 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Jul 5, 2019 | https://github.com/nodejs/node/pull/28562#issuecomment-508830658 |
| Please reload this page | https://github.com/nodejs/node/pull/28562 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Jul 5, 2019
| https://github.com/nodejs/node/pull/28562#pullrequestreview-258520754 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28562/files |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 6, 2019 | https://github.com/nodejs/node/pull/28562#issuecomment-508926872 |
| https://ci.nodejs.org/job/node-test-pull-request/24317/ | https://ci.nodejs.org/job/node-test-pull-request/24317/ |
| Please reload this page | https://github.com/nodejs/node/pull/28562 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 6, 2019 | https://github.com/nodejs/node/pull/28562#issuecomment-508933541 |
| Please reload this page | https://github.com/nodejs/node/pull/28562 |
| https://ci.nodejs.org/job/node-test-pull-request/24318/ | https://ci.nodejs.org/job/node-test-pull-request/24318/ |
| Please reload this page | https://github.com/nodejs/node/pull/28562 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Jul 6, 2019
| https://github.com/nodejs/node/pull/28562#pullrequestreview-258596398 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28562/files |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Jul 6, 2019
| https://github.com/nodejs/node/pull/28562#pullrequestreview-258597865 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28562/files |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Jul 6, 2019 | https://github.com/nodejs/node/pull/28562#event-2464050379 |
|
| https://github.com/cjihrig |
| src: allow fatal exceptions to be enhanced | https://github.com/nodejs/node/pull/28562/commits/36fdf1aa6c87ccfaebabb8f9c8004baab0549b0b |
| 36fdf1a | https://github.com/nodejs/node/pull/28562/commits/36fdf1aa6c87ccfaebabb8f9c8004baab0549b0b |
| nodejs#28562 | https://github.com/nodejs/node/pull/28562 |
| nodejs#28550 | https://github.com/nodejs/node/issues/28550 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| force-pushed | https://github.com/nodejs/node/compare/1f21d4f72b72f78236c54d310d41bd954f5b1564..36fdf1aa6c87ccfaebabb8f9c8004baab0549b0b |
| 1f21d4f | https://github.com/nodejs/node/commit/1f21d4f72b72f78236c54d310d41bd954f5b1564 |
| 36fdf1a | https://github.com/nodejs/node/commit/36fdf1aa6c87ccfaebabb8f9c8004baab0549b0b |
|
Compare
| https://github.com/nodejs/node/compare/1f21d4f72b72f78236c54d310d41bd954f5b1564..36fdf1aa6c87ccfaebabb8f9c8004baab0549b0b |
| July 7, 2019 15:56 | https://github.com/nodejs/node/pull/28562#event-2464451391 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| 36fdf1a | https://github.com/nodejs/node/commit/36fdf1aa6c87ccfaebabb8f9c8004baab0549b0b |
| Jul 7, 2019 | https://github.com/nodejs/node/pull/28562#event-2464452203 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| July 7, 2019 15:58 | https://github.com/nodejs/node/pull/28562#event-2464452295 |
| basti1302 | https://github.com/basti1302 |
|
Jul 7, 2019
| https://github.com/nodejs/node/pull/28562#ref-commit-0857b54 |
|
| https://github.com/basti1302 |
| test: exclude tests only Node 12.6.0, not for >= 12.6.0 | https://github.com/instana/nodejs/commit/0857b541c2e5fc9ed08c9bd5116162e1a29bf8db |
| 0857b54 | https://github.com/instana/nodejs/commit/0857b541c2e5fc9ed08c9bd5116162e1a29bf8db |
| nodejs/node#28562 | https://github.com/nodejs/node/pull/28562 |
| targos | https://github.com/targos |
|
Jul 20, 2019
| https://github.com/nodejs/node/pull/28562#ref-commit-a24ab56 |
|
| https://github.com/cjihrig |
|
| https://github.com/targos |
| src: allow fatal exceptions to be enhanced | https://github.com/nodejs/node/commit/a24ab56dc5119d456f7fe354a6ad558f304b64e2 |
| a24ab56 | https://github.com/nodejs/node/commit/a24ab56dc5119d456f7fe354a6ad558f304b64e2 |
| #28562 | https://github.com/nodejs/node/pull/28562 |
| #28550 | https://github.com/nodejs/node/issues/28550 |
|
v12.7.0 release proposal
#28816
| https://github.com/nodejs/node/pull/28816 |
|
v12.7.0 release proposal
#28817
| https://github.com/nodejs/node/pull/28817 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28562 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/28562/files/1f21d4f72b72f78236c54d310d41bd954f5b1564 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/28562/files/1f21d4f72b72f78236c54d310d41bd954f5b1564 |
|
| https://github.com/joyeecheung |
|
joyeecheung
| https://github.com/joyeecheung |
|
| https://github.com/nodejs/node/pull/28562/files/1f21d4f72b72f78236c54d310d41bd954f5b1564 |
|
| https://github.com/hashseed |
|
hashseed
| https://github.com/hashseed |
|
| https://github.com/nodejs/node/pull/28562/files/3538ca7ccae7f6565146d58b6a28a562f8f97662 |
|
| https://github.com/devsnek |
|
devsnek
| https://github.com/devsnek |
|
| https://github.com/nodejs/node/pull/28562/files/3538ca7ccae7f6565146d58b6a28a562f8f97662 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
Stack trace gets lost in Node.js 12.6.0 when rethrowing from uncaught exception handler
| https://github.com/nodejs/node/issues/28550 |
| Please reload this page | https://github.com/nodejs/node/pull/28562 |
|
| https://github.com/cjihrig |
|
| https://github.com/joyeecheung |
|
| https://github.com/devsnek |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/Trott |
|
| https://github.com/addaleax |
|
| https://github.com/hashseed |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |