René's URL Explorer Experiment


Title: stream: use readableEncoding public api for child_process by ZYSzys · Pull Request #28548 · nodejs/node · GitHub

Open Graph Title: stream: use readableEncoding public api for child_process by ZYSzys · Pull Request #28548 · nodejs/node

X Title: stream: use readableEncoding public api for child_process by ZYSzys · Pull Request #28548 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Adding encoding getter readableEncoding to stream.Readable to reduce usage of internal _readableState.encoding. Refs: #445 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests...

X Description: Adding encoding getter readableEncoding to stream.Readable to reduce usage of internal _readableState.encoding. Refs: #445 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests...

Opengraph URL: https://github.com/nodejs/node/pull/28548

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:59da66b6-cde3-a58e-15db-03b78b9d1522
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8638:16C3D3:45B1B67:62C4628:6A4FBE7F
html-safe-nonce3d99ded813ef0eb22e59a5006b35f79a5be36ddd9b38d73b3325db6dcf4f690f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NjM4OjE2QzNEMzo0NUIxQjY3OjYyQzQ2Mjg6NkE0RkJFN0YiLCJ2aXNpdG9yX2lkIjoiNDEyNDkxNjcyNjM1MjU1OTc0MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8672f84852b2f015b4633430792a8ddd29dd1532753b1ed2980822e2e88f85da
hovercard-subject-tagpull_request:294724913
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28548/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4a3a4f39959ada0c96d6c23ac7d1fa3aa193eb4b51abafea22d595e30fe6a05c/nodejs/node/pull/28548
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4a3a4f39959ada0c96d6c23ac7d1fa3aa193eb4b51abafea22d595e30fe6a05c/nodejs/node/pull/28548
og:image:altAdding encoding getter readableEncoding to stream.Readable to reduce usage of internal _readableState.encoding. Refs: #445 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameZYSzys
hostnamegithub.com
expected-hostnamegithub.com
None7d8f8209b188a80e19a6957836ab9229715797be5db1a04163963c674ccc33f6
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseea848e83cf3bf3613dd7b13d52965a684fd23ec5
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/28548#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28548
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28548
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/28548
Reloadhttps://github.com/nodejs/node/pull/28548
Reloadhttps://github.com/nodejs/node/pull/28548
Please reload this pagehttps://github.com/nodejs/node/pull/28548
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/28548
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 973 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
ZYSzyshttps://github.com/ZYSzys
nodejs:masterhttps://github.com/nodejs/node/tree/master
Conversationhttps://github.com/nodejs/node/pull/28548
Commits2 (2)https://github.com/nodejs/node/pull/28548/commits
Checkshttps://github.com/nodejs/node/pull/28548/checks
Files changedhttps://github.com/nodejs/node/pull/28548/files
stream: use readableEncoding public api for child_processhttps://github.com/nodejs/node/pull/28548#top
ZYSzyshttps://github.com/ZYSzys
nodejs:masterhttps://github.com/nodejs/node/tree/master
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
Jul 5, 2019https://github.com/nodejs/node/pull/28548#issue-464449408
#445https://github.com/nodejs/node/issues/445
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/28548
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
child_process https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Achild_process
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Jul 5, 2019https://github.com/nodejs/node/pull/28548#event-2461632623
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 5, 2019https://github.com/nodejs/node/pull/28548#issuecomment-508630599
Please reload this pagehttps://github.com/nodejs/node/pull/28548
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jul 5, 2019 https://github.com/nodejs/node/pull/28548#pullrequestreview-258249769
View reviewed changes https://github.com/nodejs/node/pull/28548/files
doc/api/stream.mdhttps://github.com/nodejs/node/pull/28548/files#diff-00d8d040a3fe90e3052af39cb55dc9bcac70539d5d17791449cbfe7e3b55fb90
Please reload this pagehttps://github.com/nodejs/node/pull/28548
https://github.com/ZYSzys
stream: use readableEncoding public api for child_processhttps://github.com/nodejs/node/pull/28548/commits/50027515d4991957c5ba8c3c28c005abead515a2
5002751https://github.com/nodejs/node/pull/28548/commits/50027515d4991957c5ba8c3c28c005abead515a2
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Jul 5, 2019 https://github.com/nodejs/node/pull/28548#pullrequestreview-258409402
View reviewed changes https://github.com/nodejs/node/pull/28548/files/50027515d4991957c5ba8c3c28c005abead515a2
doc/api/stream.mdhttps://github.com/nodejs/node/pull/28548/files/50027515d4991957c5ba8c3c28c005abead515a2#diff-00d8d040a3fe90e3052af39cb55dc9bcac70539d5d17791449cbfe7e3b55fb90
Please reload this pagehttps://github.com/nodejs/node/pull/28548
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Jul 5, 2019 https://github.com/nodejs/node/pull/28548#pullrequestreview-258410354
View reviewed changes https://github.com/nodejs/node/pull/28548/files/50027515d4991957c5ba8c3c28c005abead515a2
doc/api/stream.mdhttps://github.com/nodejs/node/pull/28548/files/50027515d4991957c5ba8c3c28c005abead515a2#diff-00d8d040a3fe90e3052af39cb55dc9bcac70539d5d17791449cbfe7e3b55fb90
Please reload this pagehttps://github.com/nodejs/node/pull/28548
https://github.com/ZYSzys
fixup! stream: use readableEncoding public api for child_processhttps://github.com/nodejs/node/pull/28548/commits/852797d85d876bd0061baf476be54eff266e777e
852797dhttps://github.com/nodejs/node/pull/28548/commits/852797d85d876bd0061baf476be54eff266e777e
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jul 11, 2019 https://github.com/nodejs/node/pull/28548#pullrequestreview-260771393
View reviewed changes https://github.com/nodejs/node/pull/28548/files/852797d85d876bd0061baf476be54eff266e777e
doc/api/stream.mdhttps://github.com/nodejs/node/pull/28548/files/852797d85d876bd0061baf476be54eff266e777e#diff-00d8d040a3fe90e3052af39cb55dc9bcac70539d5d17791449cbfe7e3b55fb90
BridgeARhttps://github.com/BridgeAR
Jul 11, 2019https://github.com/nodejs/node/pull/28548#discussion_r302599668
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28548
ZYSzyshttps://github.com/ZYSzys
Jul 13, 2019https://github.com/nodejs/node/pull/28548#discussion_r303206075
Please reload this pagehttps://github.com/nodejs/node/pull/28548
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#445 (comment)https://github.com/nodejs/node/issues/445#issuecomment-475176635
Please reload this pagehttps://github.com/nodejs/node/pull/28548
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jul 14, 2019 https://github.com/nodejs/node/pull/28548#pullrequestreview-261577176
View reviewed changes https://github.com/nodejs/node/pull/28548/files/852797d85d876bd0061baf476be54eff266e777e
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/28548#pullrequestreview-261577176
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28548
https://github.com/mcollina
mcollinahttps://github.com/mcollina
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
Jul 14, 2019https://github.com/nodejs/node/pull/28548#event-2481226713
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 15, 2019https://github.com/nodejs/node/pull/28548#issuecomment-511251712
https://ci.nodejs.org/job/node-test-pull-request/24445/https://ci.nodejs.org/job/node-test-pull-request/24445/
Please reload this pagehttps://github.com/nodejs/node/pull/28548
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 15, 2019 https://github.com/nodejs/node/pull/28548#pullrequestreview-261634937
View reviewed changes https://github.com/nodejs/node/pull/28548/files/852797d85d876bd0061baf476be54eff266e777e
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 15, 2019https://github.com/nodejs/node/pull/28548#issuecomment-511277952
6c430b4https://github.com/nodejs/node/commit/6c430b48b9dff238995aeffe3626bd8b156f563d
Please reload this pagehttps://github.com/nodejs/node/pull/28548
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 15, 2019https://github.com/nodejs/node/pull/28548#event-2481807427
Trotthttps://github.com/Trott
Jul 15, 2019 https://github.com/nodejs/node/pull/28548#ref-commit-6c430b4
https://github.com/ZYSzys
https://github.com/Trott
stream: use readableEncoding public api for child_processhttps://github.com/Trott/io.js/commit/6c430b48b9dff238995aeffe3626bd8b156f563d
6c430b4https://github.com/Trott/io.js/commit/6c430b48b9dff238995aeffe3626bd8b156f563d
nodejs#28548https://github.com/nodejs/node/pull/28548
nodejs#445https://github.com/nodejs/node/issues/445
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
July 15, 2019 05:30https://github.com/nodejs/node/pull/28548#event-2481810671
targoshttps://github.com/targos
Jul 20, 2019 https://github.com/nodejs/node/pull/28548#ref-commit-00b2200
https://github.com/ZYSzys
https://github.com/targos
stream: use readableEncoding public api for child_processhttps://github.com/nodejs/node/commit/00b2200e035ace6c034b8b646024ca37733a7ac4
00b2200https://github.com/nodejs/node/commit/00b2200e035ace6c034b8b646024ca37733a7ac4
#28548https://github.com/nodejs/node/pull/28548
#445https://github.com/nodejs/node/issues/445
v12.7.0 release proposal #28816 https://github.com/nodejs/node/pull/28816
v12.7.0 release proposal #28817 https://github.com/nodejs/node/pull/28817
vikashk1https://github.com/vikashk1
Aug 13, 2019 https://github.com/nodejs/node/pull/28548#ref-commit-9af17ad
https://github.com/vikashk1
Please ignore this msg (https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc
#1https://github.com/vikashk1/node/pull/1
)https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc
9af17adhttps://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28548
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/28548/files/852797d85d876bd0061baf476be54eff266e777e
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/28548/files/852797d85d876bd0061baf476be54eff266e777e
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/28548/files/852797d85d876bd0061baf476be54eff266e777e
https://github.com/vsemozhetbyt
vsemozhetbyt https://github.com/vsemozhetbyt
https://github.com/nodejs/node/pull/28548/files/50027515d4991957c5ba8c3c28c005abead515a2
child_process https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Achild_process
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Please reload this pagehttps://github.com/nodejs/node/pull/28548
https://github.com/ZYSzys
https://github.com/Trott
https://github.com/nodejs-github-bot
https://github.com/mcollina
https://github.com/BridgeAR
https://github.com/vsemozhetbyt
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.