| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:23605f8d-d115-d9d8-4a79-06f1c7c19d44 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E0CC:322E35:2FDD927:4318195:6A4F7287 |
| html-safe-nonce | 335d25418e1b2be498fc8bb502d476479a3da599550d036b91dc8075925cfaf2 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMENDOjMyMkUzNToyRkREOTI3OjQzMTgxOTU6NkE0RjcyODciLCJ2aXNpdG9yX2lkIjoiMzIwNDk5MTI3OTA4ODc1OTQzMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 9ccaa1642279d0d3f3f7e48328abd4696e352a0d4ef57598a24683d6123163d2 |
| hovercard-subject-tag | pull_request:294683358 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28541/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/e8ab0701b8261322201861c32d32cf5b63561fc6e9da998fa5c7a75ed02ad51a/nodejs/node/pull/28541 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e8ab0701b8261322201861c32d32cf5b63561fc6e9da998fa5c7a75ed02ad51a/nodejs/node/pull/28541 |
| og:image:alt | See: nodejs/build#1820
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | sam-github |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4b249b445842943ed31549e027f57a8ade9881ed |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/28541#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28541 |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28541 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/28541 |
| Reload | https://github.com/nodejs/node/pull/28541 |
| Reload | https://github.com/nodejs/node/pull/28541 |
| Please reload this page | https://github.com/nodejs/node/pull/28541 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/28541 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
973
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| sam-github | https://github.com/sam-github |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| sam-github:skip-console-tests-on-aix | https://github.com/sam-github/node/tree/skip-console-tests-on-aix |
| Conversation | https://github.com/nodejs/node/pull/28541 |
| Commits2 (2) | https://github.com/nodejs/node/pull/28541/commits |
| Checks | https://github.com/nodejs/node/pull/28541/checks |
| Files changed | https://github.com/nodejs/node/pull/28541/files |
| test: skip pseudo-tty tests on AIX | https://github.com/nodejs/node/pull/28541#top |
| sam-github | https://github.com/sam-github |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| sam-github:skip-console-tests-on-aix | https://github.com/sam-github/node/tree/skip-console-tests-on-aix |
|
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Jul 4, 2019 | https://github.com/nodejs/node/pull/28541#issue-464394160 |
| Please reload this page | https://github.com/nodejs/node/pull/28541 |
| nodejs/build#1820 | https://github.com/nodejs/build/issues/1820 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/28541 |
|
| https://github.com/sam-github |
| test: skip pseudo-tty tests on AIX | https://github.com/nodejs/node/pull/28541/commits/1f7cdf16c2e1a9c75bf16ec40c56c171852c0b3a |
| 1f7cdf1 | https://github.com/nodejs/node/pull/28541/commits/1f7cdf16c2e1a9c75bf16ec40c56c171852c0b3a |
| nodejs/build#1820 | https://github.com/nodejs/build/issues/1820 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
tty
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atty |
| Jul 4, 2019 | https://github.com/nodejs/node/pull/28541#event-2461333656 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 4, 2019 | https://github.com/nodejs/node/pull/28541#issuecomment-508576574 |
| https://ci.nodejs.org/job/node-test-pull-request/24271/ | https://ci.nodejs.org/job/node-test-pull-request/24271/ |
| Please reload this page | https://github.com/nodejs/node/pull/28541 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Jul 4, 2019
| https://github.com/nodejs/node/pull/28541#pullrequestreview-258169955 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28541/files/1f7cdf16c2e1a9c75bf16ec40c56c171852c0b3a |
| mhdawson | https://github.com/mhdawson |
| https://github.com/nodejs/node/pull/28541#pullrequestreview-258169955 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/28541 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Jul 4, 2019 | https://github.com/nodejs/node/pull/28541#issuecomment-508576712 |
| Please reload this page | https://github.com/nodejs/node/pull/28541 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
fast-track
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track |
| Jul 4, 2019 | https://github.com/nodejs/node/pull/28541#event-2461335114 |
|
| https://github.com/sam-github |
| fixup! test: skip pseudo-tty tests on AIX | https://github.com/nodejs/node/pull/28541/commits/5294516b3df8bea85846f0c9c985376c9dd5c307 |
| 5294516 | https://github.com/nodejs/node/pull/28541/commits/5294516b3df8bea85846f0c9c985376c9dd5c307 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Jul 4, 2019
| https://github.com/nodejs/node/pull/28541#pullrequestreview-258174073 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28541/files/5294516b3df8bea85846f0c9c985376c9dd5c307 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Jul 4, 2019 | https://github.com/nodejs/node/pull/28541#issuecomment-508581645 |
| 8619b19 | https://github.com/nodejs/node/commit/8619b19a8099b22cbc985503c7d2082df0009fa0 |
| Please reload this page | https://github.com/nodejs/node/pull/28541 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Jul 4, 2019 | https://github.com/nodejs/node/pull/28541#event-2461369323 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| July 4, 2019 21:49 | https://github.com/nodejs/node/pull/28541#event-2461369454 |
| sam-github | https://github.com/sam-github |
|
Jul 4, 2019
| https://github.com/nodejs/node/pull/28541#ref-commit-8619b19 |
|
| https://github.com/sam-github |
| test: skip pseudo-tty tests on AIX | https://github.com/nodejs/node/commit/8619b19a8099b22cbc985503c7d2082df0009fa0 |
| 8619b19 | https://github.com/nodejs/node/commit/8619b19a8099b22cbc985503c7d2082df0009fa0 |
| nodejs/build#1820 | https://github.com/nodejs/build/issues/1820 |
| #28541 | https://github.com/nodejs/node/pull/28541 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Jul 9, 2019
| https://github.com/nodejs/node/pull/28541#ref-pullrequest-465410643 |
|
test: fix pty test hangs on aix
#28600
| https://github.com/nodejs/node/pull/28600 |
| targos | https://github.com/targos |
|
Jul 20, 2019
| https://github.com/nodejs/node/pull/28541#ref-commit-b7731eb |
|
| https://github.com/sam-github |
|
| https://github.com/targos |
| test: skip pseudo-tty tests on AIX | https://github.com/nodejs/node/commit/b7731eb0e497f69fd2a0d32bf9e20e84f02c3c93 |
| b7731eb | https://github.com/nodejs/node/commit/b7731eb0e497f69fd2a0d32bf9e20e84f02c3c93 |
| nodejs/build#1820 | https://github.com/nodejs/build/issues/1820 |
| #28541 | https://github.com/nodejs/node/pull/28541 |
|
v12.7.0 release proposal
#28816
| https://github.com/nodejs/node/pull/28816 |
|
v12.7.0 release proposal
#28817
| https://github.com/nodejs/node/pull/28817 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28541 |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/28541/files/5294516b3df8bea85846f0c9c985376c9dd5c307 |
|
| https://github.com/mhdawson |
|
mhdawson
| https://github.com/mhdawson |
|
| https://github.com/nodejs/node/pull/28541/files/1f7cdf16c2e1a9c75bf16ec40c56c171852c0b3a |
|
fast-track
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
tty
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atty |
| Please reload this page | https://github.com/nodejs/node/pull/28541 |
|
| https://github.com/sam-github |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/mhdawson |
|
| https://github.com/richardlau |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |