René's URL Explorer Experiment


Title: process: refactor unhandledRejection logic by cjihrig · Pull Request #28540 · nodejs/node · GitHub

Open Graph Title: process: refactor unhandledRejection logic by cjihrig · Pull Request #28540 · nodejs/node

X Title: process: refactor unhandledRejection logic by cjihrig · Pull Request #28540 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This commit prevents a deprecation warning from being emitted if the 'unhandledRejection' event was actually handled. Fixes: #28539 Checklist make -j4 test (UNIX), or vcbuild test (Window...

X Description: This commit prevents a deprecation warning from being emitted if the 'unhandledRejection' event was actually handled. Fixes: #28539 Checklist make -j4 test (UNIX), or vcbuild test...

Opengraph URL: https://github.com/nodejs/node/pull/28540

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8d05fa57-7768-3feb-186e-35546d3570f6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE4CC:48B83:211A066:2D5D451:6A502C2A
html-safe-noncee1878d2b95366a250434997ac1519e004e6476461d7e5bd1fa8657e1733e9d68
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNENDOjQ4QjgzOjIxMUEwNjY6MkQ1RDQ1MTo2QTUwMkMyQSIsInZpc2l0b3JfaWQiOiI1MjcxMDIzMzc2Mjg2MTAwNTIyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac89b492d91c18a9852cff087168296ab6046ee38349b51ba5a0f46385b2f1a7be
hovercard-subject-tagpull_request:294677503
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28540/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/022f75305bede29ef8b58dd8ea67d52ea9102bc10424b9707b02c8de5690e49e/nodejs/node/pull/28540
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/022f75305bede29ef8b58dd8ea67d52ea9102bc10424b9707b02c8de5690e49e/nodejs/node/pull/28540
og:image:altThis commit prevents a deprecation warning from being emitted if the 'unhandledRejection' event was actually handled. Fixes: #28539 Checklist make -j4 test (UNIX), or vcbuild test (Window...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecjihrig
hostnamegithub.com
expected-hostnamegithub.com
Noned6dc8294eb500fa36bbc57472d61fe87c522f9c3c1d64f70f4926f66a66a7efb
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released90666eaf032b7eb8975a378efe38e37f4ebb96c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/28540#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28540
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28540
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/28540
Reloadhttps://github.com/nodejs/node/pull/28540
Reloadhttps://github.com/nodejs/node/pull/28540
Please reload this pagehttps://github.com/nodejs/node/pull/28540
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/28540
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 977 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:promisehttps://github.com/cjihrig/node/tree/promise
Conversationhttps://github.com/nodejs/node/pull/28540
Commits1 (1)https://github.com/nodejs/node/pull/28540/commits
Checkshttps://github.com/nodejs/node/pull/28540/checks
Files changedhttps://github.com/nodejs/node/pull/28540/files
process: refactor unhandledRejection logichttps://github.com/nodejs/node/pull/28540#top
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:promisehttps://github.com/cjihrig/node/tree/promise
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jul 4, 2019https://github.com/nodejs/node/pull/28540#issue-464386601
#28539https://github.com/nodejs/node/issues/28539
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/28540
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
process https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aprocess
Jul 4, 2019https://github.com/nodejs/node/pull/28540#event-2461293680
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/c7b987277aae919b4e0b82b4b6dbd2c778cee4e7..40917215abe6823113c0a516b84b299f8b09e0c0
c7b9872https://github.com/nodejs/node/commit/c7b987277aae919b4e0b82b4b6dbd2c778cee4e7
4091721https://github.com/nodejs/node/commit/40917215abe6823113c0a516b84b299f8b09e0c0
Compare https://github.com/nodejs/node/compare/c7b987277aae919b4e0b82b4b6dbd2c778cee4e7..40917215abe6823113c0a516b84b299f8b09e0c0
July 4, 2019 20:49https://github.com/nodejs/node/pull/28540#event-2461320717
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Jul 5, 2019 https://github.com/nodejs/node/pull/28540#pullrequestreview-258186305
View reviewed changes https://github.com/nodejs/node/pull/28540/files
https://github.com/shisama
shisamahttps://github.com/shisama
Jul 5, 2019 https://github.com/nodejs/node/pull/28540#pullrequestreview-258187820
View reviewed changes https://github.com/nodejs/node/pull/28540/files
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jul 5, 2019 https://github.com/nodejs/node/pull/28540#pullrequestreview-258188886
View reviewed changes https://github.com/nodejs/node/pull/28540/files
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 5, 2019 https://github.com/nodejs/node/pull/28540#pullrequestreview-258220825
View reviewed changes https://github.com/nodejs/node/pull/28540/files
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 6, 2019https://github.com/nodejs/node/pull/28540#issuecomment-508926808
Please reload this pagehttps://github.com/nodejs/node/pull/28540
https://ci.nodejs.org/job/node-test-pull-request/24316/https://ci.nodejs.org/job/node-test-pull-request/24316/
Please reload this pagehttps://github.com/nodejs/node/pull/28540
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jul 6, 2019https://github.com/nodejs/node/pull/28540#event-2463983795
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 6, 2019 https://github.com/nodejs/node/pull/28540#pullrequestreview-258597803
View reviewed changes https://github.com/nodejs/node/pull/28540/files
https://github.com/cjihrig
process: refactor unhandledRejection logichttps://github.com/nodejs/node/pull/28540/commits/7cf6f9e964aa00772965391c23acda6d71972a9a
7cf6f9ehttps://github.com/nodejs/node/pull/28540/commits/7cf6f9e964aa00772965391c23acda6d71972a9a
nodejs#28540https://github.com/nodejs/node/pull/28540
nodejs#28539https://github.com/nodejs/node/issues/28539
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/40917215abe6823113c0a516b84b299f8b09e0c0..7cf6f9e964aa00772965391c23acda6d71972a9a
4091721https://github.com/nodejs/node/commit/40917215abe6823113c0a516b84b299f8b09e0c0
7cf6f9ehttps://github.com/nodejs/node/commit/7cf6f9e964aa00772965391c23acda6d71972a9a
Compare https://github.com/nodejs/node/compare/40917215abe6823113c0a516b84b299f8b09e0c0..7cf6f9e964aa00772965391c23acda6d71972a9a
July 7, 2019 15:29https://github.com/nodejs/node/pull/28540#event-2464440293
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
7cf6f9ehttps://github.com/nodejs/node/commit/7cf6f9e964aa00772965391c23acda6d71972a9a
Jul 7, 2019https://github.com/nodejs/node/pull/28540#event-2464441017
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
July 7, 2019 15:31https://github.com/nodejs/node/pull/28540#event-2464441173
targoshttps://github.com/targos
Jul 20, 2019 https://github.com/nodejs/node/pull/28540#ref-commit-4cb0fc3
https://github.com/cjihrig
https://github.com/targos
process: refactor unhandledRejection logichttps://github.com/nodejs/node/commit/4cb0fc3ab150f3f60e6d100ee7dd83b60c1885db
4cb0fc3https://github.com/nodejs/node/commit/4cb0fc3ab150f3f60e6d100ee7dd83b60c1885db
#28540https://github.com/nodejs/node/pull/28540
#28539https://github.com/nodejs/node/issues/28539
v12.7.0 release proposal #28816 https://github.com/nodejs/node/pull/28816
v12.7.0 release proposal #28817 https://github.com/nodejs/node/pull/28817
ehmickyhttps://github.com/ehmicky
Jul 31, 2019 https://github.com/nodejs/node/pull/28540#ref-commit-57415f9
https://github.com/ehmicky
Remove rejectionWarning logichttps://github.com/ehmicky/log-process-errors/commit/57415f967edf43a2ec93bd3bbdaff0114cc4410f
57415f9https://github.com/ehmicky/log-process-errors/commit/57415f967edf43a2ec93bd3bbdaff0114cc4410f
nodejs/node#28540https://github.com/nodejs/node/pull/28540
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28540
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/28540/files/40917215abe6823113c0a516b84b299f8b09e0c0
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/28540/files/40917215abe6823113c0a516b84b299f8b09e0c0
https://github.com/joyeecheung
joyeecheung https://github.com/joyeecheung
https://github.com/nodejs/node/pull/28540/files/40917215abe6823113c0a516b84b299f8b09e0c0
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/28540/files/40917215abe6823113c0a516b84b299f8b09e0c0
https://github.com/shisama
shisama https://github.com/shisama
https://github.com/nodejs/node/pull/28540/files/40917215abe6823113c0a516b84b299f8b09e0c0
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
process https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aprocess
Unhandled promise rejection deprecation message is printed even when there's an unhandledRejection listener https://github.com/nodejs/node/issues/28539
Please reload this pagehttps://github.com/nodejs/node/pull/28540
https://github.com/cjihrig
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/addaleax
https://github.com/joyeecheung
https://github.com/BridgeAR
https://github.com/shisama
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.