René's URL Explorer Experiment


Title: build: block SIGTTOU before calling tcsetattr() by bnoordhuis · Pull Request #28535 · nodejs/node · GitHub

Open Graph Title: build: block SIGTTOU before calling tcsetattr() by bnoordhuis · Pull Request #28535 · nodejs/node

X Title: build: block SIGTTOU before calling tcsetattr() by bnoordhuis · Pull Request #28535 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: We might be a background job that doesn't own the TTY so block SIGTTOU before making the tcsetattr() call, otherwise that signal suspends us. This is a better fix than PR #28490 for issue #2847...

X Description: We might be a background job that doesn't own the TTY so block SIGTTOU before making the tcsetattr() call, otherwise that signal suspends us. This is a better fix than PR #28490 for issue #...

Opengraph URL: https://github.com/nodejs/node/pull/28535

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b8d7fe1c-443d-6d75-69a6-8f7fdb515ea9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA7B6:47423:35A89FF:4B61C09:6A4F8D44
html-safe-nonce0506a77c56b67080554fc772b5ac37d86516ab59e65e90bc81fc5676bac961d6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBN0I2OjQ3NDIzOjM1QTg5RkY6NEI2MUMwOTo2QTRGOEQ0NCIsInZpc2l0b3JfaWQiOiIyMjI5ODM0Njc0MTEyMjY5NjM2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmace8bf7c940a91bb4e238f4ef94cdd7c7285e1f5209498dc56731a9b584861fe2d
hovercard-subject-tagpull_request:294584729
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28535/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/549cd3006eb01213b51d8dc1f86ec8bf974694de178f7543604003b689fcb5d4/nodejs/node/pull/28535
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/549cd3006eb01213b51d8dc1f86ec8bf974694de178f7543604003b689fcb5d4/nodejs/node/pull/28535
og:image:altWe might be a background job that doesn't own the TTY so block SIGTTOU before making the tcsetattr() call, otherwise that signal suspends us. This is a better fix than PR #28490 for issue #2847...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebnoordhuis
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/28535#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28535
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28535
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/28535
Reloadhttps://github.com/nodejs/node/pull/28535
Reloadhttps://github.com/nodejs/node/pull/28535
Please reload this pagehttps://github.com/nodejs/node/pull/28535
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/28535
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 971 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
bnoordhuishttps://github.com/bnoordhuis
nodejs:masterhttps://github.com/nodejs/node/tree/master
bnoordhuis:fix28530https://github.com/bnoordhuis/io.js/tree/fix28530
Conversationhttps://github.com/nodejs/node/pull/28535
Commits1 (1)https://github.com/nodejs/node/pull/28535/commits
Checkshttps://github.com/nodejs/node/pull/28535/checks
Files changedhttps://github.com/nodejs/node/pull/28535/files
build: block SIGTTOU before calling tcsetattr()https://github.com/nodejs/node/pull/28535#top
bnoordhuishttps://github.com/bnoordhuis
nodejs:masterhttps://github.com/nodejs/node/tree/master
bnoordhuis:fix28530https://github.com/bnoordhuis/io.js/tree/fix28530
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jul 4, 2019https://github.com/nodejs/node/pull/28535#issue-464270030
#28490https://github.com/nodejs/node/pull/28490
#28479https://github.com/nodejs/node/issues/28479
#28530https://github.com/nodejs/node/issues/28530
#28479https://github.com/nodejs/node/issues/28479
#28490https://github.com/nodejs/node/pull/28490
Please reload this pagehttps://github.com/nodejs/node/pull/28535
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Jul 4, 2019https://github.com/nodejs/node/pull/28535#event-2460622730
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Jul 4, 2019 https://github.com/nodejs/node/pull/28535#pullrequestreview-258070862
View reviewed changes https://github.com/nodejs/node/pull/28535/files
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jul 4, 2019 https://github.com/nodejs/node/pull/28535#pullrequestreview-258072001
View reviewed changes https://github.com/nodejs/node/pull/28535/files
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jul 4, 2019https://github.com/nodejs/node/pull/28535#issuecomment-508504362
Please reload this pagehttps://github.com/nodejs/node/pull/28535
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 4, 2019 https://github.com/nodejs/node/pull/28535#pullrequestreview-258089479
View reviewed changes https://github.com/nodejs/node/pull/28535/files
Trotthttps://github.com/Trott
https://github.com/nodejs/node/pull/28535#pullrequestreview-258089479
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28535
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jul 4, 2019 https://github.com/nodejs/node/pull/28535#pullrequestreview-258094704
View reviewed changes https://github.com/nodejs/node/pull/28535/files
cjihrighttps://github.com/cjihrig
https://github.com/nodejs/node/pull/28535#pullrequestreview-258094704
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28535
https://github.com/bnoordhuis
src: block SIGTTOU before calling tcsetattr()https://github.com/nodejs/node/pull/28535/commits/49acd1ee4f4bef8544d34e7c03c9d7eda938595f
49acd1ehttps://github.com/nodejs/node/pull/28535/commits/49acd1ee4f4bef8544d34e7c03c9d7eda938595f
nodejs#28490https://github.com/nodejs/node/pull/28490
nodejs#28479https://github.com/nodejs/node/issues/28479
nodejs#28530https://github.com/nodejs/node/issues/28530
nodejs#28479https://github.com/nodejs/node/issues/28479
nodejs#28490https://github.com/nodejs/node/pull/28490
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
force-pushedhttps://github.com/nodejs/node/compare/2812496661ba8a57b62bef43233c50ed3d6fbd3a..49acd1ee4f4bef8544d34e7c03c9d7eda938595f
2812496https://github.com/nodejs/node/commit/2812496661ba8a57b62bef43233c50ed3d6fbd3a
49acd1ehttps://github.com/nodejs/node/commit/49acd1ee4f4bef8544d34e7c03c9d7eda938595f
Compare https://github.com/nodejs/node/compare/2812496661ba8a57b62bef43233c50ed3d6fbd3a..49acd1ee4f4bef8544d34e7c03c9d7eda938595f
July 4, 2019 19:12https://github.com/nodejs/node/pull/28535#event-2461223916
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jul 4, 2019https://github.com/nodejs/node/pull/28535#issuecomment-508560022
Please reload this pagehttps://github.com/nodejs/node/pull/28535
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Jul 4, 2019 https://github.com/nodejs/node/pull/28535#pullrequestreview-258176331
View reviewed changes https://github.com/nodejs/node/pull/28535/files/49acd1ee4f4bef8544d34e7c03c9d7eda938595f
sam-githubhttps://github.com/sam-github
https://github.com/nodejs/node/pull/28535#pullrequestreview-258176331
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28535
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 5, 2019https://github.com/nodejs/node/pull/28535#issuecomment-508613048
Please reload this pagehttps://github.com/nodejs/node/pull/28535
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jul 5, 2019https://github.com/nodejs/node/pull/28535#issuecomment-508844815
Please reload this pagehttps://github.com/nodejs/node/pull/28535
https://github.com/Trott
Trotthttps://github.com/Trott
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jul 5, 2019https://github.com/nodejs/node/pull/28535#event-2463472267
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28535
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 6, 2019https://github.com/nodejs/node/pull/28535#issuecomment-508895117
https://ci.nodejs.org/job/node-test-pull-request/24306/https://ci.nodejs.org/job/node-test-pull-request/24306/
Please reload this pagehttps://github.com/nodejs/node/pull/28535
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 6, 2019https://github.com/nodejs/node/pull/28535#issuecomment-508946885
b06ce0bhttps://github.com/nodejs/node/commit/b06ce0bf8d6f50dd2666a3a0d117ccd58c76c694
Please reload this pagehttps://github.com/nodejs/node/pull/28535
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 6, 2019https://github.com/nodejs/node/pull/28535#event-2464063505
pullhttps://github.com/apps/pull
Jul 6, 2019 https://github.com/nodejs/node/pull/28535#ref-commit-b06ce0b
https://github.com/bnoordhuis
https://github.com/addaleax
src: block SIGTTOU before calling tcsetattr()https://github.com/Mattlk13/node/commit/b06ce0bf8d6f50dd2666a3a0d117ccd58c76c694
b06ce0bhttps://github.com/Mattlk13/node/commit/b06ce0bf8d6f50dd2666a3a0d117ccd58c76c694
nodejs#28490https://github.com/nodejs/node/pull/28490
nodejs#28479https://github.com/nodejs/node/issues/28479
nodejs#28530https://github.com/nodejs/node/issues/28530
nodejs#28479https://github.com/nodejs/node/issues/28479
nodejs#28490https://github.com/nodejs/node/pull/28490
nodejs#28535https://github.com/nodejs/node/pull/28535
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jul 9, 2019 https://github.com/nodejs/node/pull/28535#ref-issue-465944620
"suspended (tty output)" on exit, when node is run in the background #28612 https://github.com/nodejs/node/issues/28612
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
July 10, 2019 06:28https://github.com/nodejs/node/pull/28535#event-2471475254
targoshttps://github.com/targos
Jul 20, 2019 https://github.com/nodejs/node/pull/28535#ref-commit-d4113f9
https://github.com/bnoordhuis
https://github.com/targos
src: block SIGTTOU before calling tcsetattr()https://github.com/nodejs/node/commit/d4113f96f59f4acea41a67c128ea0ea6e612a766
d4113f9https://github.com/nodejs/node/commit/d4113f96f59f4acea41a67c128ea0ea6e612a766
#28490https://github.com/nodejs/node/pull/28490
#28479https://github.com/nodejs/node/issues/28479
#28530https://github.com/nodejs/node/issues/28530
#28479https://github.com/nodejs/node/issues/28479
#28490https://github.com/nodejs/node/pull/28490
#28535https://github.com/nodejs/node/pull/28535
v12.7.0 release proposal #28816 https://github.com/nodejs/node/pull/28816
v12.7.0 release proposal #28817 https://github.com/nodejs/node/pull/28817
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jul 24, 2019 https://github.com/nodejs/node/pull/28535#ref-issue-469817763
Node >= 12.5 issues in OSX when using GNU parallel #28752 https://github.com/nodejs/node/issues/28752
https://github.com/andersk
anderskhttps://github.com/andersk
Oct 7, 2020 https://github.com/nodejs/node/pull/28535#ref-issue-716208307
Background node process corrupts terminal state with tcsetattr() on exit #35536 https://github.com/nodejs/node/issues/35536
https://github.com/andersk
anderskhttps://github.com/andersk
Oct 7, 2020https://github.com/nodejs/node/pull/28535#issuecomment-704705128
#35536https://github.com/nodejs/node/issues/35536
Please reload this pagehttps://github.com/nodejs/node/pull/28535
https://github.com/kangweichan
kangweichanhttps://github.com/kangweichan
Jan 21, 2021 https://github.com/nodejs/node/pull/28535#ref-issue-335215516
Automatic install makes zsh to hang forever f/omelette#25 https://github.com/f/omelette/issues/25
sunshowershttps://github.com/sunshowers
Jan 3, 2026 https://github.com/nodejs/node/pull/28535#ref-commit-33d6817
https://github.com/sunshowers
[nextest-runner] block SIGTTOU during tcsetattr in InputHandlerhttps://github.com/nextest-rs/nextest/commit/33d6817364a9f44ae0abf229d9c730be07537045
33d6817https://github.com/nextest-rs/nextest/commit/33d6817364a9f44ae0abf229d9c730be07537045
https://github.com/gwsw/less/blob/e77e117/signal.c#L213-L221https://github.com/gwsw/less/blob/e77e117/signal.c#L213-L221
nodejs/node#28535https://github.com/nodejs/node/pull/28535
#2878https://github.com/nextest-rs/nextest/issues/2878
https://github.com/sunshowers
sunshowershttps://github.com/sunshowers
Jan 3, 2026 https://github.com/nodejs/node/pull/28535#ref-pullrequest-3778549597
[nextest-runner] ignore SIGTTIN/SIGTTOU while input handling is active nextest-rs/nextest#2884 https://github.com/nextest-rs/nextest/pull/2884
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28535
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/28535/files/2812496661ba8a57b62bef43233c50ed3d6fbd3a
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/28535/files/2812496661ba8a57b62bef43233c50ed3d6fbd3a
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/28535/files/2812496661ba8a57b62bef43233c50ed3d6fbd3a
https://github.com/gireeshpunathil
gireeshpunathil https://github.com/gireeshpunathil
https://github.com/nodejs/node/pull/28535/files/2812496661ba8a57b62bef43233c50ed3d6fbd3a
https://github.com/sam-github
sam-github https://github.com/sam-github
https://github.com/nodejs/node/pull/28535/files/49acd1ee4f4bef8544d34e7c03c9d7eda938595f
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
cat <(node -v) never exits after >= 12.5.0 https://github.com/nodejs/node/issues/28530
CHECK failure in ResetStdio on >=12.5.0 https://github.com/nodejs/node/issues/28479
Please reload this pagehttps://github.com/nodejs/node/pull/28535
https://github.com/bnoordhuis
https://github.com/BridgeAR
https://github.com/Trott
https://github.com/nodejs-github-bot
https://github.com/addaleax
https://github.com/andersk
https://github.com/sam-github
https://github.com/cjihrig
https://github.com/richardlau
https://github.com/gireeshpunathil
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.