René's URL Explorer Experiment


Title: test: propagate napi_status to JS by octaviansoldea · Pull Request #28505 · nodejs/node · GitHub

Open Graph Title: test: propagate napi_status to JS by octaviansoldea · Pull Request #28505 · nodejs/node

X Title: test: propagate napi_status to JS by octaviansoldea · Pull Request #28505 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Re: #27945 (comment) This commit regards reporting to the JS level an actual event that happens when using suspected improper null arguments. It is better to report the exact reason from N-API to t...

X Description: Re: #27945 (comment) This commit regards reporting to the JS level an actual event that happens when using suspected improper null arguments. It is better to report the exact reason from N-API to t...

Opengraph URL: https://github.com/nodejs/node/pull/28505

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:055cfceb-456c-8328-82dd-5f4e100d142e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAD44:C3948:479C0E1:645F044:6A4F7C1F
html-safe-noncec352c75b8347d77f6de2d93a5943fc3188358570a05db2b6159b8872d7cef347
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRDQ0OkMzOTQ4OjQ3OUMwRTE6NjQ1RjA0NDo2QTRGN0MxRiIsInZpc2l0b3JfaWQiOiIyODg1Nzk2MjgwMzgxOTYzMjk1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac9a06f9001ec810cd0b870c8af54035d1befbdf4638a0cd77dfa9a89e5db97bbe
hovercard-subject-tagpull_request:293553600
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28505/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/dbdb252fba3ea8f9b555f6fbe8cd6272e2ad8be90caa896d1de3e89120c76e55/nodejs/node/pull/28505
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/dbdb252fba3ea8f9b555f6fbe8cd6272e2ad8be90caa896d1de3e89120c76e55/nodejs/node/pull/28505
og:image:altRe: #27945 (comment) This commit regards reporting to the JS level an actual event that happens when using suspected improper null arguments. It is better to report the exact reason from N-API to t...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameoctaviansoldea
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/28505#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28505
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28505
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/28505
Reloadhttps://github.com/nodejs/node/pull/28505
Reloadhttps://github.com/nodejs/node/pull/28505
Please reload this pagehttps://github.com/nodejs/node/pull/28505
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/28505
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 973 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
octaviansoldeahttps://github.com/octaviansoldea
nodejs:masterhttps://github.com/nodejs/node/tree/master
octaviansoldea:convenience_napi_null_testinghttps://github.com/octaviansoldea/node/tree/convenience_napi_null_testing
Conversationhttps://github.com/nodejs/node/pull/28505
Commits7 (7)https://github.com/nodejs/node/pull/28505/commits
Checkshttps://github.com/nodejs/node/pull/28505/checks
Files changedhttps://github.com/nodejs/node/pull/28505/files
test: propagate napi_status to JShttps://github.com/nodejs/node/pull/28505#top
octaviansoldeahttps://github.com/octaviansoldea
nodejs:masterhttps://github.com/nodejs/node/tree/master
octaviansoldea:convenience_napi_null_testinghttps://github.com/octaviansoldea/node/tree/convenience_napi_null_testing
https://github.com/octaviansoldea
octaviansoldeahttps://github.com/octaviansoldea
Jul 2, 2019https://github.com/nodejs/node/pull/28505#issue-462982091
#27945 (comment)https://github.com/nodejs/node/pull/27945#discussion_r288833979
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/28505
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Jul 2, 2019https://github.com/nodejs/node/pull/28505#event-2452876235
https://github.com/octaviansoldea
octaviansoldeahttps://github.com/octaviansoldea
Jul 2, 2019https://github.com/nodejs/node/pull/28505#issuecomment-507487777
@legendecashttps://github.com/legendecas
@gabrielschulhofhttps://github.com/gabrielschulhof
#27945 (comment)https://github.com/nodejs/node/pull/27945#discussion_r288833979
@octaviansoldeahttps://github.com/octaviansoldea
Please reload this pagehttps://github.com/nodejs/node/pull/28505
https://github.com/danbev
danbevhttps://github.com/danbev
Jul 3, 2019 https://github.com/nodejs/node/pull/28505#pullrequestreview-257276076
View reviewed changes https://github.com/nodejs/node/pull/28505/files
test/js-native-api/common.hhttps://github.com/nodejs/node/pull/28505/files#diff-ac48d74fba3af83ce63c08fc5cf7f521db393cae257bfee88a0e1857417848a6
danbevhttps://github.com/danbev
Jul 3, 2019https://github.com/nodejs/node/pull/28505#discussion_r299789581
Please reload this pagehttps://github.com/nodejs/node/pull/28505
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28505
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jul 3, 2019 https://github.com/nodejs/node/pull/28505#pullrequestreview-257672818
View reviewed changes https://github.com/nodejs/node/pull/28505/files
test/js-native-api/common.hhttps://github.com/nodejs/node/pull/28505/files#diff-ac48d74fba3af83ce63c08fc5cf7f521db393cae257bfee88a0e1857417848a6
mhdawsonhttps://github.com/mhdawson
Jul 3, 2019https://github.com/nodejs/node/pull/28505#discussion_r300104276
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28505
https://github.com/octaviansoldea
octaviansoldeahttps://github.com/octaviansoldea
Jul 4, 2019https://github.com/nodejs/node/pull/28505#issuecomment-508347263
@octaviansoldeahttps://github.com/octaviansoldea
Please reload this pagehttps://github.com/nodejs/node/pull/28505
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Jul 6, 2019 https://github.com/nodejs/node/pull/28505#pullrequestreview-258578801
View reviewed changes https://github.com/nodejs/node/pull/28505/files
gabrielschulhofhttps://github.com/gabrielschulhof
https://github.com/nodejs/node/pull/28505#pullrequestreview-258578801
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28505
test/js-native-api/test_constructor/test_constructor.chttps://github.com/nodejs/node/pull/28505/files#diff-41d56102df7063c15cd7a5b3c9b1e8a64ed8fd8accdc01d0d1b56b79f48223e9
gabrielschulhofhttps://github.com/gabrielschulhof
Jul 6, 2019https://github.com/nodejs/node/pull/28505#discussion_r300821601
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28505
test/js-native-api/test_constructor/test_constructor.chttps://github.com/nodejs/node/pull/28505/files#diff-41d56102df7063c15cd7a5b3c9b1e8a64ed8fd8accdc01d0d1b56b79f48223e9
gabrielschulhofhttps://github.com/gabrielschulhof
Jul 6, 2019https://github.com/nodejs/node/pull/28505#discussion_r300821608
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28505
test/js-native-api/test_constructor/test_constructor.chttps://github.com/nodejs/node/pull/28505/files#diff-41d56102df7063c15cd7a5b3c9b1e8a64ed8fd8accdc01d0d1b56b79f48223e9
gabrielschulhofhttps://github.com/gabrielschulhof
Jul 6, 2019https://github.com/nodejs/node/pull/28505#discussion_r300821672
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28505
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
stale reviewhttps://github.com/nodejs/node/pull/28505#pullrequestreview-258578801
July 9, 2019 20:53https://github.com/nodejs/node/pull/28505#event-2470642246
https://github.com/octaviansoldea
octaviansoldeahttps://github.com/octaviansoldea
force-pushedhttps://github.com/nodejs/node/compare/b07fa0407cda72b9b906c226a82504974dc424ab..73d6146d842a83a4b12fbb1ac654fbe5e5c05559
b07fa04https://github.com/nodejs/node/commit/b07fa0407cda72b9b906c226a82504974dc424ab
73d6146https://github.com/nodejs/node/commit/73d6146d842a83a4b12fbb1ac654fbe5e5c05559
Compare https://github.com/nodejs/node/compare/b07fa0407cda72b9b906c226a82504974dc424ab..73d6146d842a83a4b12fbb1ac654fbe5e5c05559
July 10, 2019 02:58https://github.com/nodejs/node/pull/28505#event-2471193334
https://github.com/octaviansoldea
octaviansoldeahttps://github.com/octaviansoldea
Jul 10, 2019https://github.com/nodejs/node/pull/28505#issuecomment-509888421
@gabrielschulhofhttps://github.com/gabrielschulhof
@octaviansoldeahttps://github.com/octaviansoldea
Please reload this pagehttps://github.com/nodejs/node/pull/28505
https://github.com/octaviansoldea
octaviansoldeahttps://github.com/octaviansoldea
Jul 10, 2019https://github.com/nodejs/node/pull/28505#issuecomment-510239490
@mhdawsonhttps://github.com/mhdawson
@danbevhttps://github.com/danbev
@gabrielschulhofhttps://github.com/gabrielschulhof
@octaviansoldeahttps://github.com/octaviansoldea
Please reload this pagehttps://github.com/nodejs/node/pull/28505
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Jul 15, 2019 https://github.com/nodejs/node/pull/28505#pullrequestreview-262111627
View reviewed changes https://github.com/nodejs/node/pull/28505/files
test/js-native-api/test_constructor/test_constructor.chttps://github.com/nodejs/node/pull/28505/files#diff-41d56102df7063c15cd7a5b3c9b1e8a64ed8fd8accdc01d0d1b56b79f48223e9
gabrielschulhofhttps://github.com/gabrielschulhof
Jul 15, 2019https://github.com/nodejs/node/pull/28505#discussion_r303666499
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28505
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Jul 16, 2019 https://github.com/nodejs/node/pull/28505#pullrequestreview-262721260
View reviewed changes https://github.com/nodejs/node/pull/28505/files
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 16, 2019https://github.com/nodejs/node/pull/28505#issuecomment-512025744
https://ci.nodejs.org/job/node-test-pull-request/24505/https://ci.nodejs.org/job/node-test-pull-request/24505/
Please reload this pagehttps://github.com/nodejs/node/pull/28505
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 17, 2019https://github.com/nodejs/node/pull/28505#issuecomment-512529359
https://ci.nodejs.org/job/node-test-pull-request/24520/https://ci.nodejs.org/job/node-test-pull-request/24520/
Please reload this pagehttps://github.com/nodejs/node/pull/28505
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Jul 18, 2019https://github.com/nodejs/node/pull/28505#issuecomment-512659303
@octaviansoldeahttps://github.com/octaviansoldea
Please reload this pagehttps://github.com/nodejs/node/pull/28505
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 18, 2019https://github.com/nodejs/node/pull/28505#issuecomment-512661870
https://ci.nodejs.org/job/node-test-pull-request/24535/https://ci.nodejs.org/job/node-test-pull-request/24535/
Please reload this pagehttps://github.com/nodejs/node/pull/28505
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 18, 2019https://github.com/nodejs/node/pull/28505#issuecomment-512662571
https://ci.nodejs.org/job/node-test-pull-request/24536/https://ci.nodejs.org/job/node-test-pull-request/24536/
Please reload this pagehttps://github.com/nodejs/node/pull/28505
July 18, 2019 08:48https://github.com/nodejs/node/pull/28505#commits-pushed-ce7e75a
test: propagate napi_status to JShttps://github.com/nodejs/node/pull/28505/commits/ce7e75a16063d1c8be400e8384777362aa6ad80b
ce7e75ahttps://github.com/nodejs/node/pull/28505/commits/ce7e75a16063d1c8be400e8384777362aa6ad80b
nodejs#27945 (comment)https://github.com/nodejs/node/pull/27945#discussion_r288833979
test: propagate napi_status to JShttps://github.com/nodejs/node/pull/28505/commits/5c2f2a37d0fcd4665d5ef15b88c23e116b897f08
5c2f2a3https://github.com/nodejs/node/pull/28505/commits/5c2f2a37d0fcd4665d5ef15b88c23e116b897f08
nodejs#27945 (comment)https://github.com/nodejs/node/pull/27945#discussion_r288833979
test: propagate napi_status to JS - second answer to reviewershttps://github.com/nodejs/node/pull/28505/commits/76e92465474fe114d968f27dfefc7834a65d2bb4
76e9246https://github.com/nodejs/node/pull/28505/commits/76e92465474fe114d968f27dfefc7834a65d2bb4
test: propagate napi_status to JS - third answerhttps://github.com/nodejs/node/pull/28505/commits/e067b82f48b94018801597a27474e589e4048bee
e067b82https://github.com/nodejs/node/pull/28505/commits/e067b82f48b94018801597a27474e589e4048bee
test: propagate napi_status to JS - fourth answerhttps://github.com/nodejs/node/pull/28505/commits/930aca8116ec3ecd2dee23789d67f20c79518229
930aca8https://github.com/nodejs/node/pull/28505/commits/930aca8116ec3ecd2dee23789d67f20c79518229
test: propagate napi_status to JS - fifth answerhttps://github.com/nodejs/node/pull/28505/commits/a697a98238eb602e068a5215be85e8d658b69a0f
a697a98https://github.com/nodejs/node/pull/28505/commits/a697a98238eb602e068a5215be85e8d658b69a0f
test: propagate napi_status to JS - sixth answerhttps://github.com/nodejs/node/pull/28505/commits/c0ad9df2b30385754ccfb37ebf457c9803b4149f
c0ad9dfhttps://github.com/nodejs/node/pull/28505/commits/c0ad9df2b30385754ccfb37ebf457c9803b4149f
https://github.com/octaviansoldea
octaviansoldeahttps://github.com/octaviansoldea
force-pushedhttps://github.com/nodejs/node/compare/1ea7d7d2d1182455021d4df0795a81241748aa41..c0ad9df2b30385754ccfb37ebf457c9803b4149f
1ea7d7dhttps://github.com/nodejs/node/commit/1ea7d7d2d1182455021d4df0795a81241748aa41
c0ad9dfhttps://github.com/nodejs/node/commit/c0ad9df2b30385754ccfb37ebf457c9803b4149f
Compare https://github.com/nodejs/node/compare/1ea7d7d2d1182455021d4df0795a81241748aa41..c0ad9df2b30385754ccfb37ebf457c9803b4149f
July 18, 2019 17:01https://github.com/nodejs/node/pull/28505#event-2493399893
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Jul 18, 2019 https://github.com/nodejs/node/pull/28505#pullrequestreview-263790309
View reviewed changes https://github.com/nodejs/node/pull/28505/files/c0ad9df2b30385754ccfb37ebf457c9803b4149f
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 18, 2019https://github.com/nodejs/node/pull/28505#issuecomment-512903435
https://ci.nodejs.org/job/node-test-pull-request/24542/https://ci.nodejs.org/job/node-test-pull-request/24542/
Please reload this pagehttps://github.com/nodejs/node/pull/28505
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jul 18, 2019 https://github.com/nodejs/node/pull/28505#pullrequestreview-263877104
View reviewed changes https://github.com/nodejs/node/pull/28505/files/c0ad9df2b30385754ccfb37ebf457c9803b4149f
mhdawsonhttps://github.com/mhdawson
https://github.com/nodejs/node/pull/28505#pullrequestreview-263877104
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28505
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 18, 2019 https://github.com/nodejs/node/pull/28505#pullrequestreview-263886816
View reviewed changes https://github.com/nodejs/node/pull/28505/files/c0ad9df2b30385754ccfb37ebf457c9803b4149f
https://github.com/Trott
Trotthttps://github.com/Trott
stale reviewhttps://github.com/nodejs/node/pull/28505#pullrequestreview-263886816
July 18, 2019 20:24https://github.com/nodejs/node/pull/28505#event-2493923675
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 18, 2019 https://github.com/nodejs/node/pull/28505#pullrequestreview-263888381
View reviewed changes https://github.com/nodejs/node/pull/28505/files/c0ad9df2b30385754ccfb37ebf457c9803b4149f
Trotthttps://github.com/Trott
https://github.com/nodejs/node/pull/28505#pullrequestreview-263888381
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28505
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 18, 2019https://github.com/nodejs/node/pull/28505#issuecomment-512974368
Please reload this pagehttps://github.com/nodejs/node/pull/28505
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 18, 2019https://github.com/nodejs/node/pull/28505#event-2493930300
Trotthttps://github.com/Trott
Jul 18, 2019 https://github.com/nodejs/node/pull/28505#ref-commit-3da44b0
https://github.com/Trott
test: propagate napi_status to JShttps://github.com/Trott/io.js/commit/3da44b0b52617556a1c3816a0ae9167a1848655f
3da44b0https://github.com/Trott/io.js/commit/3da44b0b52617556a1c3816a0ae9167a1848655f
nodejs#27945 (comment)https://github.com/nodejs/node/pull/27945#discussion_r288833979
nodejs#28505https://github.com/nodejs/node/pull/28505
targoshttps://github.com/targos
Jul 20, 2019 https://github.com/nodejs/node/pull/28505#ref-commit-88809a4
https://github.com/targos
test: propagate napi_status to JShttps://github.com/nodejs/node/commit/88809a49f66e4e494d4e2c6565284d1e4a247bf2
88809a4https://github.com/nodejs/node/commit/88809a49f66e4e494d4e2c6565284d1e4a247bf2
#27945 (comment)https://github.com/nodejs/node/pull/27945#discussion_r288833979
#28505https://github.com/nodejs/node/pull/28505
v12.7.0 release proposal #28816 https://github.com/nodejs/node/pull/28816
v12.7.0 release proposal #28817 https://github.com/nodejs/node/pull/28817
octaviansoldeahttps://github.com/octaviansoldea
Jul 24, 2019 https://github.com/nodejs/node/pull/28505#ref-commit-7723333
n-api: refactoring a previous commithttps://github.com/octaviansoldea/node/commit/77233338017f39ba0fab94d7047144912acca12f
7723333https://github.com/octaviansoldea/node/commit/77233338017f39ba0fab94d7047144912acca12f
nodejs#27628https://github.com/nodejs/node/pull/27628
nodejs#28505https://github.com/nodejs/node/pull/28505
https://github.com/octaviansoldea
octaviansoldeahttps://github.com/octaviansoldea
Jul 24, 2019 https://github.com/nodejs/node/pull/28505#ref-pullrequest-472562175
n-api: refactoring a previous commit #28848 https://github.com/nodejs/node/pull/28848
gabrielschulhofhttps://github.com/gabrielschulhof
Jul 26, 2019 https://github.com/nodejs/node/pull/28505#ref-commit-db1c4a7
n-api: refactor a previous commithttps://github.com/nodejs/node/commit/db1c4a7592a896053a8f791d7cc38a6de5c4a059
db1c4a7https://github.com/nodejs/node/commit/db1c4a7592a896053a8f791d7cc38a6de5c4a059
#27628https://github.com/nodejs/node/pull/27628
#28505https://github.com/nodejs/node/pull/28505
#28848https://github.com/nodejs/node/pull/28848
gntemhttps://github.com/gntem
Jul 27, 2019 https://github.com/nodejs/node/pull/28505#ref-commit-3d65e58
https://github.com/gntem
n-api: refactor a previous commithttps://github.com/gntem/node/commit/3d65e5809aca2efc63744ffc6f80db89ecdc83ce
3d65e58https://github.com/gntem/node/commit/3d65e5809aca2efc63744ffc6f80db89ecdc83ce
nodejs#27628https://github.com/nodejs/node/pull/27628
nodejs#28505https://github.com/nodejs/node/pull/28505
nodejs#28848https://github.com/nodejs/node/pull/28848
octaviansoldeahttps://github.com/octaviansoldea
Jul 28, 2019 https://github.com/nodejs/node/pull/28505#ref-commit-7da1633
n-api: refactoring napi_create_function testinghttps://github.com/octaviansoldea/node/commit/7da1633037b0857414311ad33959f7cbcacc4530
7da1633https://github.com/octaviansoldea/node/commit/7da1633037b0857414311ad33959f7cbcacc4530
nodejs#26998https://github.com/nodejs/node/pull/26998
nodejs#26998https://github.com/nodejs/node/pull/26998
nodejs#28505https://github.com/nodejs/node/pull/28505
nodejs#28848https://github.com/nodejs/node/pull/28848
nodejs#26998https://github.com/nodejs/node/pull/26998
nodejs#28505https://github.com/nodejs/node/pull/28505
nodejs#28848https://github.com/nodejs/node/pull/28848
https://github.com/octaviansoldea
octaviansoldeahttps://github.com/octaviansoldea
Jul 29, 2019 https://github.com/nodejs/node/pull/28505#ref-pullrequest-474194120
n-api: refactoring napi_create_function testing #28894 https://github.com/nodejs/node/pull/28894
Trotthttps://github.com/Trott
Aug 1, 2019 https://github.com/nodejs/node/pull/28505#ref-commit-1ee47d5
https://github.com/Trott
n-api: refactoring napi_create_function testinghttps://github.com/Trott/io.js/commit/1ee47d550c6de132f06110aa13eceb7551d643b3
1ee47d5https://github.com/Trott/io.js/commit/1ee47d550c6de132f06110aa13eceb7551d643b3
nodejs#26998https://github.com/nodejs/node/pull/26998
nodejs#28505https://github.com/nodejs/node/pull/28505
nodejs#28848https://github.com/nodejs/node/pull/28848
nodejs#28894https://github.com/nodejs/node/pull/28894
targoshttps://github.com/targos
Aug 2, 2019 https://github.com/nodejs/node/pull/28505#ref-commit-e6b3bfe
https://github.com/targos
n-api: refactor a previous commithttps://github.com/nodejs/node/commit/e6b3bfe1118cf6830388422b764c99fa67ed9fce
e6b3bfehttps://github.com/nodejs/node/commit/e6b3bfe1118cf6830388422b764c99fa67ed9fce
#27628https://github.com/nodejs/node/pull/27628
#28505https://github.com/nodejs/node/pull/28505
#28848https://github.com/nodejs/node/pull/28848
targoshttps://github.com/targos
Aug 2, 2019 https://github.com/nodejs/node/pull/28505#ref-commit-c93df0c
https://github.com/targos
n-api: refactoring napi_create_function testinghttps://github.com/nodejs/node/commit/c93df0cfc397c9430e22d21059f16424880bb140
c93df0chttps://github.com/nodejs/node/commit/c93df0cfc397c9430e22d21059f16424880bb140
#26998https://github.com/nodejs/node/pull/26998
#28505https://github.com/nodejs/node/pull/28505
#28848https://github.com/nodejs/node/pull/28848
#28894https://github.com/nodejs/node/pull/28894
vikashk1https://github.com/vikashk1
Aug 13, 2019 https://github.com/nodejs/node/pull/28505#ref-commit-9af17ad
https://github.com/vikashk1
Please ignore this msg (https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc
#1https://github.com/vikashk1/node/pull/1
)https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc
9af17adhttps://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28505
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/28505/files/c0ad9df2b30385754ccfb37ebf457c9803b4149f
https://github.com/gabrielschulhof
gabrielschulhof https://github.com/gabrielschulhof
https://github.com/nodejs/node/pull/28505/files/c0ad9df2b30385754ccfb37ebf457c9803b4149f
https://github.com/danbev
danbev https://github.com/danbev
https://github.com/nodejs/node/pull/28505/files/ce56853033e179ab8fcbf700de535c5a741bb209
https://github.com/mhdawson
mhdawson https://github.com/mhdawson
https://github.com/nodejs/node/pull/28505/files/c0ad9df2b30385754ccfb37ebf457c9803b4149f
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/28505
https://github.com/octaviansoldea
https://github.com/nodejs-github-bot
https://github.com/gabrielschulhof
https://github.com/Trott
https://github.com/danbev
https://github.com/mhdawson
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.