René's URL Explorer Experiment


Title: src: don't abort on EIO when restoring tty by bnoordhuis · Pull Request #28490 · nodejs/node · GitHub

Open Graph Title: src: don't abort on EIO when restoring tty by bnoordhuis · Pull Request #28490 · nodejs/node

X Title: src: don't abort on EIO when restoring tty by bnoordhuis · Pull Request #28490 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: EIO has been observed to be returned by the Linux kernel under some circumstances. Reading through drivers/tty/tty_io*.c, it seems to indicate the tty went away. Of course none of this is documente...

X Description: EIO has been observed to be returned by the Linux kernel under some circumstances. Reading through drivers/tty/tty_io*.c, it seems to indicate the tty went away. Of course none of this is documente...

Opengraph URL: https://github.com/nodejs/node/pull/28490

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:52b3e87c-0fd8-4a3a-9f52-4f6db0d6f496
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB6DC:1F29:1D359F5:2795403:6A503E64
html-safe-nonce96053f0c65ce594a640cd9a967c48fe2829a9b1d17348e5c2ec83c01482c0dd6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNkRDOjFGMjk6MUQzNTlGNToyNzk1NDAzOjZBNTAzRTY0IiwidmlzaXRvcl9pZCI6IjIyODE5NDMzNjA1MzYwNjc2ODQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac70faf50fb232ec5243f5a3bc14c140b3ba25c583066f9af4191e1679b0cc6e46
hovercard-subject-tagpull_request:293199010
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28490/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f3b0aa2d5e55f26703dec4c7cf2a493e47b394b2acf603881246c60f0f872ad3/nodejs/node/pull/28490
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f3b0aa2d5e55f26703dec4c7cf2a493e47b394b2acf603881246c60f0f872ad3/nodejs/node/pull/28490
og:image:altEIO has been observed to be returned by the Linux kernel under some circumstances. Reading through drivers/tty/tty_io*.c, it seems to indicate the tty went away. Of course none of this is documente...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebnoordhuis
hostnamegithub.com
expected-hostnamegithub.com
Noned6dc8294eb500fa36bbc57472d61fe87c522f9c3c1d64f70f4926f66a66a7efb
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released90666eaf032b7eb8975a378efe38e37f4ebb96c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/28490#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28490
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28490
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/28490
Reloadhttps://github.com/nodejs/node/pull/28490
Reloadhttps://github.com/nodejs/node/pull/28490
Please reload this pagehttps://github.com/nodejs/node/pull/28490
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/28490
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 978 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
bnoordhuishttps://github.com/bnoordhuis
nodejs:masterhttps://github.com/nodejs/node/tree/master
bnoordhuis:fix28479https://github.com/bnoordhuis/io.js/tree/fix28479
Conversationhttps://github.com/nodejs/node/pull/28490
Commits1 (1)https://github.com/nodejs/node/pull/28490/commits
Checkshttps://github.com/nodejs/node/pull/28490/checks
Files changedhttps://github.com/nodejs/node/pull/28490/files
src: don't abort on EIO when restoring ttyhttps://github.com/nodejs/node/pull/28490#top
bnoordhuishttps://github.com/bnoordhuis
nodejs:masterhttps://github.com/nodejs/node/tree/master
bnoordhuis:fix28479https://github.com/bnoordhuis/io.js/tree/fix28479
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jul 1, 2019https://github.com/nodejs/node/pull/28490#issue-462537380
#28479https://github.com/nodejs/node/issues/28479
Please reload this pagehttps://github.com/nodejs/node/pull/28490
https://github.com/bnoordhuis
src: don't abort on EIO when restoring ttyhttps://github.com/nodejs/node/pull/28490/commits/1ba286cccc75daf9ba82e01a845210a3125284c4
1ba286chttps://github.com/nodejs/node/pull/28490/commits/1ba286cccc75daf9ba82e01a845210a3125284c4
nodejs#28479https://github.com/nodejs/node/issues/28479
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Jul 1, 2019https://github.com/nodejs/node/pull/28490#event-2450116186
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jul 1, 2019 https://github.com/nodejs/node/pull/28490#ref-issue-462411609
CHECK failure in ResetStdio on >=12.5.0 #28479 https://github.com/nodejs/node/issues/28479
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 1, 2019https://github.com/nodejs/node/pull/28490#issuecomment-507135808
https://ci.nodejs.org/job/node-test-pull-request/24182/https://ci.nodejs.org/job/node-test-pull-request/24182/
Please reload this pagehttps://github.com/nodejs/node/pull/28490
https://github.com/targos
targoshttps://github.com/targos
Jul 1, 2019 https://github.com/nodejs/node/pull/28490#pullrequestreview-256152662
View reviewed changes https://github.com/nodejs/node/pull/28490/files/1ba286cccc75daf9ba82e01a845210a3125284c4
https://github.com/targos
targoshttps://github.com/targos
Jul 1, 2019https://github.com/nodejs/node/pull/28490#issuecomment-507136482
Please reload this pagehttps://github.com/nodejs/node/pull/28490
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Jul 1, 2019 https://github.com/nodejs/node/pull/28490#pullrequestreview-256156461
View reviewed changes https://github.com/nodejs/node/pull/28490/files/1ba286cccc75daf9ba82e01a845210a3125284c4
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jul 1, 2019 https://github.com/nodejs/node/pull/28490#pullrequestreview-256322978
View reviewed changes https://github.com/nodejs/node/pull/28490/files/1ba286cccc75daf9ba82e01a845210a3125284c4
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Jul 1, 2019https://github.com/nodejs/node/pull/28490#event-2451147809
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 1, 2019 https://github.com/nodejs/node/pull/28490#pullrequestreview-256323420
View reviewed changes https://github.com/nodejs/node/pull/28490/files/1ba286cccc75daf9ba82e01a845210a3125284c4
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
tty https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atty
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jul 1, 2019https://github.com/nodejs/node/pull/28490#event-2451149071
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 1, 2019https://github.com/nodejs/node/pull/28490#issuecomment-507256698
https://ci.nodejs.org/job/node-test-pull-request/24184/https://ci.nodejs.org/job/node-test-pull-request/24184/
Please reload this pagehttps://github.com/nodejs/node/pull/28490
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Jul 1, 2019 https://github.com/nodejs/node/pull/28490#pullrequestreview-256597896
View reviewed changes https://github.com/nodejs/node/pull/28490/files/1ba286cccc75daf9ba82e01a845210a3125284c4
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Jul 2, 2019https://github.com/nodejs/node/pull/28490#issuecomment-507475542
1095635https://github.com/nodejs/node/commit/1095635a8aaf8658670a0610fea5dd775bac36d1
Please reload this pagehttps://github.com/nodejs/node/pull/28490
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Jul 2, 2019https://github.com/nodejs/node/pull/28490#event-2452800102
devsnekhttps://github.com/devsnek
Jul 2, 2019 https://github.com/nodejs/node/pull/28490#ref-commit-1095635
https://github.com/bnoordhuis
https://github.com/devsnek
src: don't abort on EIO when restoring ttyhttps://github.com/nodejs/node/commit/1095635a8aaf8658670a0610fea5dd775bac36d1
1095635https://github.com/nodejs/node/commit/1095635a8aaf8658670a0610fea5dd775bac36d1
#28479https://github.com/nodejs/node/issues/28479
#28490https://github.com/nodejs/node/pull/28490
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Jul 2, 2019 https://github.com/nodejs/node/pull/28490#ref-pullrequest-378911719
src: restore stdio on program exit #24260 https://github.com/nodejs/node/pull/24260
targoshttps://github.com/targos
Jul 2, 2019 https://github.com/nodejs/node/pull/28490#ref-commit-a0638b0
https://github.com/bnoordhuis
https://github.com/targos
src: don't abort on EIO when restoring ttyhttps://github.com/nodejs/node/commit/a0638b008c60571d97c41f128cff535d89a32afd
a0638b0https://github.com/nodejs/node/commit/a0638b008c60571d97c41f128cff535d89a32afd
#28479https://github.com/nodejs/node/issues/28479
#28490https://github.com/nodejs/node/pull/28490
targoshttps://github.com/targos
Jul 2, 2019 https://github.com/nodejs/node/pull/28490#ref-commit-035b613
https://github.com/bnoordhuis
https://github.com/targos
src: don't abort on EIO when restoring ttyhttps://github.com/nodejs/node/commit/035b613f80000a71069440ec13b0dabae8eaba33
035b613https://github.com/nodejs/node/commit/035b613f80000a71069440ec13b0dabae8eaba33
#28479https://github.com/nodejs/node/issues/28479
#28490https://github.com/nodejs/node/pull/28490
targoshttps://github.com/targos
Jul 2, 2019 https://github.com/nodejs/node/pull/28490#ref-commit-d711542
https://github.com/targos
2019-07-03, Version 12.6.0 (Current)https://github.com/nodejs/node/commit/d711542f65df9a087d21f868305011ff8118c586
d711542https://github.com/nodejs/node/commit/d711542f65df9a087d21f868305011ff8118c586
#27992https://github.com/nodejs/node/pull/27992
#28325https://github.com/nodejs/node/pull/28325
#28449https://github.com/nodejs/node/pull/28449
#28018https://github.com/nodejs/node/pull/28018
#28490https://github.com/nodejs/node/pull/28490
#28007https://github.com/nodejs/node/pull/28007
#28153https://github.com/nodejs/node/pull/28153
#28508https://github.com/nodejs/node/pull/28508
https://github.com/targos
targoshttps://github.com/targos
Jul 2, 2019 https://github.com/nodejs/node/pull/28490#ref-pullrequest-463146264
Release v12.6.0 proposal #28508 https://github.com/nodejs/node/pull/28508
targoshttps://github.com/targos
Jul 2, 2019 https://github.com/nodejs/node/pull/28490#ref-commit-e6a8ac1
https://github.com/targos
2019-07-03, Version 12.6.0 (Current)https://github.com/nodejs/node/commit/e6a8ac12407b92557984cd1bbce7af97fa656f40
e6a8ac1https://github.com/nodejs/node/commit/e6a8ac12407b92557984cd1bbce7af97fa656f40
#27992https://github.com/nodejs/node/pull/27992
#28325https://github.com/nodejs/node/pull/28325
#28449https://github.com/nodejs/node/pull/28449
#28018https://github.com/nodejs/node/pull/28018
#28490https://github.com/nodejs/node/pull/28490
#28007https://github.com/nodejs/node/pull/28007
#28153https://github.com/nodejs/node/pull/28153
https://github.com/gengjiawenhttps://github.com/gengjiawen
#28322https://github.com/nodejs/node/pull/28322
#28508https://github.com/nodejs/node/pull/28508
targoshttps://github.com/targos
Jul 2, 2019 https://github.com/nodejs/node/pull/28490#ref-commit-e71a0f4
https://github.com/targos
2019-07-03, Version 12.6.0 (Current)https://github.com/nodejs/node/commit/e71a0f4d5faa4ad77887fbb3fff0ddb7bca6942e
e71a0f4https://github.com/nodejs/node/commit/e71a0f4d5faa4ad77887fbb3fff0ddb7bca6942e
#27992https://github.com/nodejs/node/pull/27992
#28325https://github.com/nodejs/node/pull/28325
#28449https://github.com/nodejs/node/pull/28449
#28511https://github.com/nodejs/node/pull/28511
#28018https://github.com/nodejs/node/pull/28018
#28490https://github.com/nodejs/node/pull/28490
#28007https://github.com/nodejs/node/pull/28007
#28153https://github.com/nodejs/node/pull/28153
https://github.com/gengjiawenhttps://github.com/gengjiawen
#28322https://github.com/nodejs/node/pull/28322
#28508https://github.com/nodejs/node/pull/28508
targoshttps://github.com/targos
Jul 3, 2019 https://github.com/nodejs/node/pull/28490#ref-commit-fcf8fe9
https://github.com/targos
2019-07-03, Version 12.6.0 (Current)https://github.com/nodejs/node/commit/fcf8fe9f1a556758eb9faf86bf74de2ddda805c8
fcf8fe9https://github.com/nodejs/node/commit/fcf8fe9f1a556758eb9faf86bf74de2ddda805c8
#27992https://github.com/nodejs/node/pull/27992
#28325https://github.com/nodejs/node/pull/28325
#28449https://github.com/nodejs/node/pull/28449
#28511https://github.com/nodejs/node/pull/28511
#28018https://github.com/nodejs/node/pull/28018
#28490https://github.com/nodejs/node/pull/28490
#28007https://github.com/nodejs/node/pull/28007
#28153https://github.com/nodejs/node/pull/28153
https://github.com/gengjiawenhttps://github.com/gengjiawen
#28322https://github.com/nodejs/node/pull/28322
#28508https://github.com/nodejs/node/pull/28508
https://github.com/marsam
marsamhttps://github.com/marsam
Jul 3, 2019 https://github.com/nodejs/node/pull/28490#ref-pullrequest-461880250
nodejs-12_x: 12.4.0 -> 12.5.0 NixOS/nixpkgs#63883 https://github.com/NixOS/nixpkgs/pull/63883
2019-07-03 Version 12.6.0 (Current) @targos beevelop/docker-nodejs#288 https://github.com/beevelop/docker-nodejs/issues/288
2019-07-03 Version 12.6.0 (Current) @targos beevelop/docker-nodejs#289 https://github.com/beevelop/docker-nodejs/issues/289
2019-07-03 Version 12.6.0 (Current) @targos beevelop/docker-nodejs#290 https://github.com/beevelop/docker-nodejs/issues/290
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jul 4, 2019 https://github.com/nodejs/node/pull/28490#ref-pullrequest-464270030
build: block SIGTTOU before calling tcsetattr() #28535 https://github.com/nodejs/node/pull/28535
bnoordhuishttps://github.com/bnoordhuis
Jul 4, 2019 https://github.com/nodejs/node/pull/28490#ref-commit-49acd1e
https://github.com/bnoordhuis
src: block SIGTTOU before calling tcsetattr()https://github.com/bnoordhuis/io.js/commit/49acd1ee4f4bef8544d34e7c03c9d7eda938595f
49acd1ehttps://github.com/bnoordhuis/io.js/commit/49acd1ee4f4bef8544d34e7c03c9d7eda938595f
nodejs#28490https://github.com/nodejs/node/pull/28490
nodejs#28479https://github.com/nodejs/node/issues/28479
nodejs#28530https://github.com/nodejs/node/issues/28530
nodejs#28479https://github.com/nodejs/node/issues/28479
nodejs#28490https://github.com/nodejs/node/pull/28490
pullhttps://github.com/apps/pull
Jul 6, 2019 https://github.com/nodejs/node/pull/28490#ref-commit-b06ce0b
https://github.com/bnoordhuis
https://github.com/addaleax
src: block SIGTTOU before calling tcsetattr()https://github.com/Mattlk13/node/commit/b06ce0bf8d6f50dd2666a3a0d117ccd58c76c694
b06ce0bhttps://github.com/Mattlk13/node/commit/b06ce0bf8d6f50dd2666a3a0d117ccd58c76c694
nodejs#28490https://github.com/nodejs/node/pull/28490
nodejs#28479https://github.com/nodejs/node/issues/28479
nodejs#28530https://github.com/nodejs/node/issues/28530
nodejs#28479https://github.com/nodejs/node/issues/28479
nodejs#28490https://github.com/nodejs/node/pull/28490
nodejs#28535https://github.com/nodejs/node/pull/28535
targoshttps://github.com/targos
Jul 20, 2019 https://github.com/nodejs/node/pull/28490#ref-commit-d4113f9
https://github.com/bnoordhuis
https://github.com/targos
src: block SIGTTOU before calling tcsetattr()https://github.com/nodejs/node/commit/d4113f96f59f4acea41a67c128ea0ea6e612a766
d4113f9https://github.com/nodejs/node/commit/d4113f96f59f4acea41a67c128ea0ea6e612a766
#28490https://github.com/nodejs/node/pull/28490
#28479https://github.com/nodejs/node/issues/28479
#28530https://github.com/nodejs/node/issues/28530
#28479https://github.com/nodejs/node/issues/28479
#28490https://github.com/nodejs/node/pull/28490
#28535https://github.com/nodejs/node/pull/28535
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28490
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/28490/files/1ba286cccc75daf9ba82e01a845210a3125284c4
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/28490/files/1ba286cccc75daf9ba82e01a845210a3125284c4
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/28490/files/1ba286cccc75daf9ba82e01a845210a3125284c4
https://github.com/gireeshpunathil
gireeshpunathil https://github.com/gireeshpunathil
https://github.com/nodejs/node/pull/28490/files/1ba286cccc75daf9ba82e01a845210a3125284c4
https://github.com/devsnek
devsnek https://github.com/devsnek
https://github.com/nodejs/node/pull/28490/files/1ba286cccc75daf9ba82e01a845210a3125284c4
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
tty https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atty
CHECK failure in ResetStdio on >=12.5.0 https://github.com/nodejs/node/issues/28479
Please reload this pagehttps://github.com/nodejs/node/pull/28490
https://github.com/bnoordhuis
https://github.com/nodejs-github-bot
https://github.com/targos
https://github.com/devsnek
https://github.com/addaleax
https://github.com/cjihrig
https://github.com/gireeshpunathil
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.