René's URL Explorer Experiment


Title: http: improve parser error messages by addaleax · Pull Request #28487 · nodejs/node · GitHub

Open Graph Title: http: improve parser error messages by addaleax · Pull Request #28487 · nodejs/node

X Title: http: improve parser error messages by addaleax · Pull Request #28487 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Include the library-provided reason in the Error’s message. Fixes: #28468 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message ...

X Description: Include the library-provided reason in the Error’s message. Fixes: #28468 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message ...

Opengraph URL: https://github.com/nodejs/node/pull/28487

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/*id(.:format)
route-controllerpull_requests
route-actionshow
fetch-noncev2:810997bb-4fc8-1935-ae6e-9fb1525aac73
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCA1C:512E3:659054A:8FD375D:6A4FF326
html-safe-nonce64d79f4c083792ec2c520402f14ad55790275e7e56c61dc5d34801a2c89eda65
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQTFDOjUxMkUzOjY1OTA1NEE6OEZEMzc1RDo2QTRGRjMyNiIsInZpc2l0b3JfaWQiOiI3NzI3ODA3NDg3Nzg5NzU3MjIyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac766d6cbcf3d186971e377c62584f3b7992b1a40a7ff1dcaeedfa998d4b9deb14
hovercard-subject-tagpull_request:293137649
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/28487
twitter:imagehttps://opengraph.githubassets.com/46f288cf7865ef255da67f973717d246dd20294af2a38263694d78a8800df3b8/nodejs/node/pull/28487
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/46f288cf7865ef255da67f973717d246dd20294af2a38263694d78a8800df3b8/nodejs/node/pull/28487
og:image:altInclude the library-provided reason in the Error’s message. Fixes: #28468 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None19b98c3d9767bb8a56238a89ff8401d1cbdf3bc5c353799aacf49fe6c76b4b7c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef7e270be010aa4de2871991025fbb97f3afe2bcb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/28487#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28487
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28487
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/28487
Reloadhttps://github.com/nodejs/node/pull/28487
Reloadhttps://github.com/nodejs/node/pull/28487
Please reload this pagehttps://github.com/nodejs/node/pull/28487
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/28487
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 976 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:http-errorshttps://github.com/addaleax/node/tree/http-errors
Conversationhttps://github.com/nodejs/node/pull/28487
Commits1 (1)https://github.com/nodejs/node/pull/28487/commits
Checkshttps://github.com/nodejs/node/pull/28487/checks
Files changedhttps://github.com/nodejs/node/pull/28487/files
http: improve parser error messageshttps://github.com/nodejs/node/pull/28487#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:http-errorshttps://github.com/addaleax/node/tree/http-errors
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 30, 2019https://github.com/nodejs/node/pull/28487#issue-462454242
#28468https://github.com/nodejs/node/issues/28468
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/28487
https://github.com/addaleax
http: improve parser error messageshttps://github.com/nodejs/node/pull/28487/commits/965b02f3f6b330c237982004f7bbe8f2607adda5
965b02fhttps://github.com/nodejs/node/pull/28487/commits/965b02f3f6b330c237982004f7bbe8f2607adda5
nodejs#28468https://github.com/nodejs/node/issues/28468
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
Jun 30, 2019https://github.com/nodejs/node/pull/28487#event-2449642545
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 30, 2019 https://github.com/nodejs/node/pull/28487#ref-issue-462087099
Better communication / errors around node 12 breaking HTTP parser changes #28468 https://github.com/nodejs/node/issues/28468
https://github.com/indutny
indutnyhttps://github.com/indutny
Jun 30, 2019https://github.com/nodejs/node/pull/28487#issuecomment-507073306
Please reload this pagehttps://github.com/nodejs/node/pull/28487
https://github.com/antsmartian
antsmartianhttps://github.com/antsmartian
Jul 1, 2019 https://github.com/nodejs/node/pull/28487#pullrequestreview-256126888
View reviewed changes https://github.com/nodejs/node/pull/28487/files/965b02f3f6b330c237982004f7bbe8f2607adda5
https://github.com/danbev
danbevhttps://github.com/danbev
Jul 1, 2019 https://github.com/nodejs/node/pull/28487#pullrequestreview-256127579
View reviewed changes https://github.com/nodejs/node/pull/28487/files/965b02f3f6b330c237982004f7bbe8f2607adda5
https://github.com/indutny
indutnyhttps://github.com/indutny
Jul 1, 2019 https://github.com/nodejs/node/pull/28487#pullrequestreview-256128082
View reviewed changes https://github.com/nodejs/node/pull/28487/files/965b02f3f6b330c237982004f7bbe8f2607adda5
indutnyhttps://github.com/indutny
https://github.com/nodejs/node/pull/28487#pullrequestreview-256128082
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28487
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 1, 2019 https://github.com/nodejs/node/pull/28487#pullrequestreview-256130049
View reviewed changes https://github.com/nodejs/node/pull/28487/files/965b02f3f6b330c237982004f7bbe8f2607adda5
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jul 1, 2019 https://github.com/nodejs/node/pull/28487#pullrequestreview-256259668
View reviewed changes https://github.com/nodejs/node/pull/28487/files/965b02f3f6b330c237982004f7bbe8f2607adda5
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 1, 2019https://github.com/nodejs/node/pull/28487#issuecomment-507237865
https://ci.nodejs.org/job/node-test-pull-request/24183/https://ci.nodejs.org/job/node-test-pull-request/24183/
Please reload this pagehttps://github.com/nodejs/node/pull/28487
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jul 1, 2019 https://github.com/nodejs/node/pull/28487#pullrequestreview-256320919
View reviewed changes https://github.com/nodejs/node/pull/28487/files/965b02f3f6b330c237982004f7bbe8f2607adda5
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jul 1, 2019https://github.com/nodejs/node/pull/28487#event-2451156560
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 1, 2019https://github.com/nodejs/node/pull/28487#issuecomment-507257064
https://ci.nodejs.org/job/node-test-pull-request/24185/https://ci.nodejs.org/job/node-test-pull-request/24185/
Please reload this pagehttps://github.com/nodejs/node/pull/28487
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Jul 1, 2019 https://github.com/nodejs/node/pull/28487#pullrequestreview-256402567
View reviewed changes https://github.com/nodejs/node/pull/28487/files/965b02f3f6b330c237982004f7bbe8f2607adda5
trivikrhttps://github.com/trivikr
https://github.com/nodejs/node/pull/28487#pullrequestreview-256402567
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28487
test/parallel/test-http-client-error-rawbytes.jshttps://github.com/nodejs/node/pull/28487/files/965b02f3f6b330c237982004f7bbe8f2607adda5#diff-04e9c9ff7af3bd8d276b5873555bc2633663c6d620fbbfb069835e8e8d79a8a0
trivikrhttps://github.com/trivikr
Jul 1, 2019https://github.com/nodejs/node/pull/28487#discussion_r299093332
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28487
BridgeARhttps://github.com/BridgeAR
Jul 4, 2019https://github.com/nodejs/node/pull/28487#discussion_r300456575
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28487
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 4, 2019https://github.com/nodejs/node/pull/28487#issuecomment-508539882
https://ci.nodejs.org/job/node-test-pull-request/24266/https://ci.nodejs.org/job/node-test-pull-request/24266/
Please reload this pagehttps://github.com/nodejs/node/pull/28487
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 6, 2019https://github.com/nodejs/node/pull/28487#issuecomment-508899139
Please reload this pagehttps://github.com/nodejs/node/pull/28487
Trotthttps://github.com/Trott
Jul 6, 2019 https://github.com/nodejs/node/pull/28487#ref-commit-ba565a3
https://github.com/addaleax
https://github.com/Trott
http: improve parser error messageshttps://github.com/Trott/io.js/commit/ba565a37349e81c9d2402b0c8ef05ab39dca8968
ba565a3https://github.com/Trott/io.js/commit/ba565a37349e81c9d2402b0c8ef05ab39dca8968
nodejs#28468https://github.com/nodejs/node/issues/28468
nodejs#28487https://github.com/nodejs/node/pull/28487
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 6, 2019https://github.com/nodejs/node/pull/28487#event-2463787930
targoshttps://github.com/targos
Jul 20, 2019 https://github.com/nodejs/node/pull/28487#ref-commit-38f8cd5
https://github.com/addaleax
https://github.com/targos
http: improve parser error messageshttps://github.com/nodejs/node/commit/38f8cd5ba100a3922d84ae5bc6c3828559bbc693
38f8cd5https://github.com/nodejs/node/commit/38f8cd5ba100a3922d84ae5bc6c3828559bbc693
#28468https://github.com/nodejs/node/issues/28468
#28487https://github.com/nodejs/node/pull/28487
v12.7.0 release proposal #28816 https://github.com/nodejs/node/pull/28816
v12.7.0 release proposal #28817 https://github.com/nodejs/node/pull/28817
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28487
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/28487/files/965b02f3f6b330c237982004f7bbe8f2607adda5
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/28487/files/965b02f3f6b330c237982004f7bbe8f2607adda5
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/28487/files/965b02f3f6b330c237982004f7bbe8f2607adda5
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/28487/files/965b02f3f6b330c237982004f7bbe8f2607adda5
https://github.com/indutny
indutny https://github.com/indutny
https://github.com/nodejs/node/pull/28487/files/965b02f3f6b330c237982004f7bbe8f2607adda5
https://github.com/danbev
danbev https://github.com/danbev
https://github.com/nodejs/node/pull/28487/files/965b02f3f6b330c237982004f7bbe8f2607adda5
https://github.com/antsmartian
antsmartian https://github.com/antsmartian
https://github.com/nodejs/node/pull/28487/files/965b02f3f6b330c237982004f7bbe8f2607adda5
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
Better communication / errors around node 12 breaking HTTP parser changes https://github.com/nodejs/node/issues/28468
Please reload this pagehttps://github.com/nodejs/node/pull/28487
https://github.com/addaleax
https://github.com/indutny
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/danbev
https://github.com/antsmartian
https://github.com/cjihrig
https://github.com/BridgeAR
https://github.com/trivikr
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.