| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:189f4299-9993-bdb7-88d8-b5d363f70146 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 969C:1F19:49BED73:69449CA:6A50093C |
| html-safe-nonce | 6dc3387f70e5d6af57a0e743681d70cbb6caf8e5bb5f57c49575f0715a64f642 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NjlDOjFGMTk6NDlCRUQ3Mzo2OTQ0OUNBOjZBNTAwOTNDIiwidmlzaXRvcl9pZCI6IjIzOTIzNDU5NjczMjYxMzY2MzYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | d4a0f9aab833892feae548fe96bb7c6dc62bc2429f2b54285f8b9835a59786b1 |
| hovercard-subject-tag | pull_request:292422804 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28446/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/ac342c414e607ce9c888f3cc7a530aa880e0ec8eca767c4bab84437c13126f3f/nodejs/node/pull/28446 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ac342c414e607ce9c888f3cc7a530aa880e0ec8eca767c4bab84437c13126f3f/nodejs/node/pull/28446 |
| og:image:alt | This commit removes the now obsolete option.
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | danbev |
| hostname | github.com |
| expected-hostname | github.com |
| None | 56eec25a3430492dd6ec2a480eb33256a0da5192d5714b0db4f5ab5f33203d94 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 93a615b89b7dcbdb6b678f4772931ecc28ada82a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/28446#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28446 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28446 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/28446 |
| Reload | https://github.com/nodejs/node/pull/28446 |
| Reload | https://github.com/nodejs/node/pull/28446 |
| Please reload this page | https://github.com/nodejs/node/pull/28446 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/28446 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
977
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| danbev | https://github.com/danbev |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| danbev:build_configure_code_cache_path_help | https://github.com/danbev/node/tree/build_configure_code_cache_path_help |
| Conversation | https://github.com/nodejs/node/pull/28446 |
| Commits3 (3) | https://github.com/nodejs/node/pull/28446/commits |
| Checks | https://github.com/nodejs/node/pull/28446/checks |
| Files changed | https://github.com/nodejs/node/pull/28446/files |
| build: remove --code-cache-path help option | https://github.com/nodejs/node/pull/28446#top |
| danbev | https://github.com/danbev |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| danbev:build_configure_code_cache_path_help | https://github.com/danbev/node/tree/build_configure_code_cache_path_help |
|
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Jun 27, 2019 | https://github.com/nodejs/node/pull/28446#issue-461514490 |
| Please reload this page | https://github.com/nodejs/node/pull/28446 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/28446 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
| Jun 27, 2019 | https://github.com/nodejs/node/pull/28446#event-2444177715 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Jun 27, 2019 | https://github.com/nodejs/node/pull/28446#issuecomment-506335501 |
| https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3723/ | https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3723/ |
| Please reload this page | https://github.com/nodejs/node/pull/28446 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Jun 27, 2019
| https://github.com/nodejs/node/pull/28446#pullrequestreview-255229113 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28446/files |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Jun 27, 2019
| https://github.com/nodejs/node/pull/28446#pullrequestreview-255316846 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28446/files |
| joyeecheung | https://github.com/joyeecheung |
| https://github.com/nodejs/node/pull/28446#pullrequestreview-255316846 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/28446 |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
|
Jun 27, 2019
| https://github.com/nodejs/node/pull/28446#pullrequestreview-255378838 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28446/files |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Jun 27, 2019
| https://github.com/nodejs/node/pull/28446#pullrequestreview-255429239 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28446/files |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Jun 28, 2019 | https://github.com/nodejs/node/pull/28446#issuecomment-506584574 |
| Please reload this page | https://github.com/nodejs/node/pull/28446 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Jun 28, 2019
| https://github.com/nodejs/node/pull/28446#pullrequestreview-255605310 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28446/files |
| Trott | https://github.com/Trott |
| https://github.com/nodejs/node/pull/28446#pullrequestreview-255605310 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @joyeecheung | https://github.com/joyeecheung |
| @danbev | https://github.com/danbev |
| Please reload this page | https://github.com/nodejs/node/pull/28446 |
| danbev | https://github.com/danbev |
| July 2, 2019 07:49 | https://github.com/nodejs/node/pull/28446#commits-pushed-9db4857 |
|
| https://github.com/danbev |
| build: remove --code-cache-path help option | https://github.com/nodejs/node/pull/28446/commits/9db48578b6d22f4b83cf022ce4d63602f1a19cde |
| 9db4857 | https://github.com/nodejs/node/pull/28446/commits/9db48578b6d22f4b83cf022ce4d63602f1a19cde |
|
| https://github.com/danbev |
| build: rename node_code_cache_path to node_code_cache | https://github.com/nodejs/node/pull/28446/commits/5dfb434c897b6e090cb8e1ead6849aa11d474e39 |
| 5dfb434 | https://github.com/nodejs/node/pull/28446/commits/5dfb434c897b6e090cb8e1ead6849aa11d474e39 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| force-pushed | https://github.com/nodejs/node/compare/f3aac033ccc1e27c068dd15ff489f135b0e61be9..5dfb434c897b6e090cb8e1ead6849aa11d474e39 |
| f3aac03 | https://github.com/nodejs/node/commit/f3aac033ccc1e27c068dd15ff489f135b0e61be9 |
| 5dfb434 | https://github.com/nodejs/node/commit/5dfb434c897b6e090cb8e1ead6849aa11d474e39 |
|
Compare
| https://github.com/nodejs/node/compare/f3aac033ccc1e27c068dd15ff489f135b0e61be9..5dfb434c897b6e090cb8e1ead6849aa11d474e39 |
| July 2, 2019 05:58 | https://github.com/nodejs/node/pull/28446#event-2453183354 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Jul 2, 2019 | https://github.com/nodejs/node/pull/28446#event-2453184118 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 2, 2019 | https://github.com/nodejs/node/pull/28446#issuecomment-507531055 |
| https://ci.nodejs.org/job/node-test-pull-request/24205/ | https://ci.nodejs.org/job/node-test-pull-request/24205/ |
| Please reload this page | https://github.com/nodejs/node/pull/28446 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| joyeecheung | https://github.com/joyeecheung |
| July 3, 2019 04:00 | https://github.com/nodejs/node/pull/28446#event-2456251451 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Jul 4, 2019
| https://github.com/nodejs/node/pull/28446#pullrequestreview-257808029 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28446/files/5dfb434c897b6e090cb8e1ead6849aa11d474e39 |
| joyeecheung | https://github.com/joyeecheung |
| https://github.com/nodejs/node/pull/28446#pullrequestreview-257808029 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/28446 |
| configure.py | https://github.com/nodejs/node/pull/28446/files/5dfb434c897b6e090cb8e1ead6849aa11d474e39#diff-4d5f3192809ec1b9add6b33007e0c50031ad9a0a2f3f55a481b506468824db2c |
| Please reload this page | https://github.com/nodejs/node/pull/28446 |
|
| https://github.com/danbev |
| squash:! add comment | https://github.com/nodejs/node/pull/28446/commits/f57b8a6b0438d1f5aaff62e9e04ca6a5135edd24 |
| f57b8a6 | https://github.com/nodejs/node/pull/28446/commits/f57b8a6b0438d1f5aaff62e9e04ca6a5135edd24 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Jul 4, 2019 | https://github.com/nodejs/node/pull/28446#issuecomment-508340237 |
| 39a9358 | https://github.com/nodejs/node/commit/39a935883df8cc87e1bd6364df38a61131e1e4ba |
| Please reload this page | https://github.com/nodejs/node/pull/28446 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Jul 4, 2019 | https://github.com/nodejs/node/pull/28446#event-2459427742 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| July 4, 2019 05:10 | https://github.com/nodejs/node/pull/28446#event-2459428103 |
| danbev | https://github.com/danbev |
|
Jul 4, 2019
| https://github.com/nodejs/node/pull/28446#ref-commit-39a9358 |
|
| https://github.com/danbev |
| build: remove --code-cache-path help option | https://github.com/nodejs/node/commit/39a935883df8cc87e1bd6364df38a61131e1e4ba |
| 39a9358 | https://github.com/nodejs/node/commit/39a935883df8cc87e1bd6364df38a61131e1e4ba |
| #28446 | https://github.com/nodejs/node/pull/28446 |
| targos | https://github.com/targos |
|
Jul 20, 2019
| https://github.com/nodejs/node/pull/28446#ref-commit-7d3ddfe |
|
| https://github.com/danbev |
|
| https://github.com/targos |
| build: remove --code-cache-path help option | https://github.com/nodejs/node/commit/7d3ddfe6b899be17291ce1b9365da5e86b8e0a10 |
| 7d3ddfe | https://github.com/nodejs/node/commit/7d3ddfe6b899be17291ce1b9365da5e86b8e0a10 |
| #28446 | https://github.com/nodejs/node/pull/28446 |
|
v12.7.0 release proposal
#28816
| https://github.com/nodejs/node/pull/28816 |
|
v12.7.0 release proposal
#28817
| https://github.com/nodejs/node/pull/28817 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28446 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/28446/files/f3aac033ccc1e27c068dd15ff489f135b0e61be9 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/28446/files/f3aac033ccc1e27c068dd15ff489f135b0e61be9 |
|
| https://github.com/joyeecheung |
|
joyeecheung
| https://github.com/joyeecheung |
|
| https://github.com/nodejs/node/pull/28446/files/5dfb434c897b6e090cb8e1ead6849aa11d474e39 |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/28446/files/f3aac033ccc1e27c068dd15ff489f135b0e61be9 |
|
| https://github.com/trivikr |
|
trivikr
| https://github.com/trivikr |
|
| https://github.com/nodejs/node/pull/28446/files/f3aac033ccc1e27c068dd15ff489f135b0e61be9 |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
| Please reload this page | https://github.com/nodejs/node/pull/28446 |
|
| https://github.com/danbev |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/Trott |
|
| https://github.com/lpinca |
|
| https://github.com/joyeecheung |
|
| https://github.com/richardlau |
|
| https://github.com/trivikr |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |