René's URL Explorer Experiment


Title: n-api: render finalizers as env cleanup hooks by gabrielschulhof · Pull Request #28428 · nodejs/node · GitHub

Open Graph Title: n-api: render finalizers as env cleanup hooks by gabrielschulhof · Pull Request #28428 · nodejs/node

X Title: n-api: render finalizers as env cleanup hooks by gabrielschulhof · Pull Request #28428 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines

X Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines

Opengraph URL: https://github.com/nodejs/node/pull/28428

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:07b8dddf-c30d-1077-57e9-bb0093ead4ce
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCD3C:397AD8:E69791:13737D5:6A4F01C1
html-safe-nonce1109a8af9a4b8451f0a458d07a090f0ff747b4b3d91733b863a1af2bc30fa208
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRDNDOjM5N0FEODpFNjk3OTE6MTM3MzdENTo2QTRGMDFDMSIsInZpc2l0b3JfaWQiOiI2MzAxNTk1NjQ2NDc1MzA1NDA5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac2740c8a4fd913ad7586b3b470b71e2bbb830f0ca834ebb49a0e62350fb37b5e0
hovercard-subject-tagpull_request:291707783
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28428/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6df396ea53ef90b713caee9b7c0ae926fe8b6ca92327d65413e37586646f415c/nodejs/node/pull/28428
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6df396ea53ef90b713caee9b7c0ae926fe8b6ca92327d65413e37586646f415c/nodejs/node/pull/28428
og:image:altChecklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegabrielschulhof
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b8f23afb982271f1b22258a94aede67a6b77760
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/28428#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28428
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28428
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/28428
Reloadhttps://github.com/nodejs/node/pull/28428
Reloadhttps://github.com/nodejs/node/pull/28428
Please reload this pagehttps://github.com/nodejs/node/pull/28428
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/28428
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 965 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
gabrielschulhofhttps://github.com/gabrielschulhof
nodejs:masterhttps://github.com/nodejs/node/tree/master
gabrielschulhof:track-all-finalizershttps://github.com/gabrielschulhof/node/tree/track-all-finalizers
Conversationhttps://github.com/nodejs/node/pull/28428
Commits1 (1)https://github.com/nodejs/node/pull/28428/commits
Checkshttps://github.com/nodejs/node/pull/28428/checks
Files changedhttps://github.com/nodejs/node/pull/28428/files
n-api: render finalizers as env cleanup hookshttps://github.com/nodejs/node/pull/28428#top
gabrielschulhofhttps://github.com/gabrielschulhof
nodejs:masterhttps://github.com/nodejs/node/tree/master
gabrielschulhof:track-all-finalizershttps://github.com/gabrielschulhof/node/tree/track-all-finalizers
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Jun 25, 2019https://github.com/nodejs/node/pull/28428#issue-460610273
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/28428
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
addaleaxhttps://github.com/addaleax
mhdawsonhttps://github.com/mhdawson
June 25, 2019 19:54https://github.com/nodejs/node/pull/28428#event-2438748103
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
Jun 25, 2019https://github.com/nodejs/node/pull/28428#event-2438748273
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
force-pushedhttps://github.com/nodejs/node/compare/42afad0afa666dfd5813403c19d42efa75e91fd3..a3955d6994e7a9ddc852023e6b53985171cbbd2f
42afad0https://github.com/nodejs/node/commit/42afad0afa666dfd5813403c19d42efa75e91fd3
a3955d6https://github.com/nodejs/node/commit/a3955d6994e7a9ddc852023e6b53985171cbbd2f
Compare https://github.com/nodejs/node/compare/42afad0afa666dfd5813403c19d42efa75e91fd3..a3955d6994e7a9ddc852023e6b53985171cbbd2f
June 25, 2019 20:33https://github.com/nodejs/node/pull/28428#event-2438853037
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 25, 2019 https://github.com/nodejs/node/pull/28428#pullrequestreview-254270405
View reviewed changes https://github.com/nodejs/node/pull/28428/files
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/28428#pullrequestreview-254270405
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28428
src/js_native_api_v8.cchttps://github.com/nodejs/node/pull/28428/files#diff-4b35cbf831be523a4f3e5aac3729c95490ed220892695d0e4245c15c1f63cfc1
Please reload this pagehttps://github.com/nodejs/node/pull/28428
src/js_native_api_v8.cchttps://github.com/nodejs/node/pull/28428/files#diff-4b35cbf831be523a4f3e5aac3729c95490ed220892695d0e4245c15c1f63cfc1
addaleaxhttps://github.com/addaleax
Jun 25, 2019https://github.com/nodejs/node/pull/28428#discussion_r297393865
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28428
gabrielschulhofhttps://github.com/gabrielschulhof
Jun 25, 2019https://github.com/nodejs/node/pull/28428#discussion_r297414926
Please reload this pagehttps://github.com/nodejs/node/pull/28428
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28428
src/js_native_api_v8.hhttps://github.com/nodejs/node/pull/28428/files#diff-5ce201326b61f008b7515e8db2290224fd5fe8e3e7133e3f00ee489e7809b8c5
addaleaxhttps://github.com/addaleax
Jun 25, 2019https://github.com/nodejs/node/pull/28428#discussion_r297395305
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28428
gabrielschulhofhttps://github.com/gabrielschulhof
Jun 25, 2019https://github.com/nodejs/node/pull/28428#discussion_r297416964
Please reload this pagehttps://github.com/nodejs/node/pull/28428
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28428
addaleaxhttps://github.com/addaleax
Jun 25, 2019https://github.com/nodejs/node/pull/28428#discussion_r297421151
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28428
gabrielschulhofhttps://github.com/gabrielschulhof
Jun 25, 2019https://github.com/nodejs/node/pull/28428#discussion_r297422185
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/28428
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Jun 25, 2019https://github.com/nodejs/node/pull/28428#issuecomment-505644541
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/28428
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 25, 2019https://github.com/nodejs/node/pull/28428#issuecomment-505648037
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/28428
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
force-pushedhttps://github.com/nodejs/node/compare/af2c2e637617cddb91cb18d8357561a9ab01a96a..aafa352badb08a7d7ca5c7b97bdfd2972517e616
af2c2e6https://github.com/nodejs/node/commit/af2c2e637617cddb91cb18d8357561a9ab01a96a
aafa352https://github.com/nodejs/node/commit/aafa352badb08a7d7ca5c7b97bdfd2972517e616
Compare https://github.com/nodejs/node/compare/af2c2e637617cddb91cb18d8357561a9ab01a96a..aafa352badb08a7d7ca5c7b97bdfd2972517e616
June 26, 2019 01:12https://github.com/nodejs/node/pull/28428#event-2439343740
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Jun 26, 2019https://github.com/nodejs/node/pull/28428#issuecomment-505678867
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/28428
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jun 26, 2019https://github.com/nodejs/node/pull/28428#issuecomment-505912495
@gabrielfhttps://github.com/gabrielf
Please reload this pagehttps://github.com/nodejs/node/pull/28428
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jun 26, 2019 https://github.com/nodejs/node/pull/28428#pullrequestreview-254687945
View reviewed changes https://github.com/nodejs/node/pull/28428/files
src/js_native_api_v8.cchttps://github.com/nodejs/node/pull/28428/files#diff-4b35cbf831be523a4f3e5aac3729c95490ed220892695d0e4245c15c1f63cfc1
Please reload this pagehttps://github.com/nodejs/node/pull/28428
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Jun 26, 2019https://github.com/nodejs/node/pull/28428#issuecomment-506030271
@mhdawsonhttps://github.com/mhdawson
Please reload this pagehttps://github.com/nodejs/node/pull/28428
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Jul 1, 2019 https://github.com/nodejs/node/pull/28428#ref-pullrequest-461893242
n-api: add napi_get_module() #28464 https://github.com/nodejs/node/pull/28464
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
force-pushedhttps://github.com/nodejs/node/compare/874bbec76b3e841abcb26049f0fd2c723335f0af..0b9b0f30c6c63f7c7f1792a71b52bc2ecea72e7a
874bbechttps://github.com/nodejs/node/commit/874bbec76b3e841abcb26049f0fd2c723335f0af
0b9b0f3https://github.com/nodejs/node/commit/0b9b0f30c6c63f7c7f1792a71b52bc2ecea72e7a
Compare https://github.com/nodejs/node/compare/874bbec76b3e841abcb26049f0fd2c723335f0af..0b9b0f30c6c63f7c7f1792a71b52bc2ecea72e7a
July 4, 2019 05:36https://github.com/nodejs/node/pull/28428#event-2459461856
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Jul 4, 2019https://github.com/nodejs/node/pull/28428#issuecomment-508352030
@mhdawsonhttps://github.com/mhdawson
https://github.com/Level/benchhttps://github.com/Level/bench
Please reload this pagehttps://github.com/nodejs/node/pull/28428
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Jul 4, 2019https://github.com/nodejs/node/pull/28428#issuecomment-508359444
@NickNasohttps://github.com/NickNaso
Please reload this pagehttps://github.com/nodejs/node/pull/28428
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jul 4, 2019https://github.com/nodejs/node/pull/28428#issuecomment-508486323
@gabrielschulhofhttps://github.com/gabrielschulhof
Please reload this pagehttps://github.com/nodejs/node/pull/28428
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Jul 5, 2019https://github.com/nodejs/node/pull/28428#issuecomment-508646581
@mhdawsonhttps://github.com/mhdawson
async PI estimatehttps://github.com/nodejs/node-addon-examples/tree/master/async_pi_estimate/node-addon-api
@NickNasohttps://github.com/NickNaso
Please reload this pagehttps://github.com/nodejs/node/pull/28428
https://github.com/NickNaso
NickNasohttps://github.com/NickNaso
Jul 5, 2019https://github.com/nodejs/node/pull/28428#issuecomment-508654051
Please reload this pagehttps://github.com/nodejs/node/pull/28428
@gabrielschulhofhttps://github.com/gabrielschulhof
Please reload this pagehttps://github.com/nodejs/node/pull/28428
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Jul 6, 2019 https://github.com/nodejs/node/pull/28428#ref-issue-464823661
New API to store per-addon-instance data nodejs/abi-stable-node#378 https://github.com/nodejs/abi-stable-node/issues/378
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jul 8, 2019https://github.com/nodejs/node/pull/28428#issuecomment-509268853
Please reload this pagehttps://github.com/nodejs/node/pull/28428
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Jul 8, 2019https://github.com/nodejs/node/pull/28428#issuecomment-509303389
@mhdawsonhttps://github.com/mhdawson
Please reload this pagehttps://github.com/nodejs/node/pull/28428
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Jul 8, 2019https://github.com/nodejs/node/pull/28428#issuecomment-509304043
@mhdawsonhttps://github.com/mhdawson
Please reload this pagehttps://github.com/nodejs/node/pull/28428
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Jul 8, 2019 https://github.com/nodejs/node/pull/28428#ref-issue-450701947
Should finalizers run on exit in Node.js? tc39/proposal-weakrefs#125 https://github.com/tc39/proposal-weakrefs/issues/125
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jul 9, 2019https://github.com/nodejs/node/pull/28428#issuecomment-509834192
Please reload this pagehttps://github.com/nodejs/node/pull/28428
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 9, 2019https://github.com/nodejs/node/pull/28428#issuecomment-509836120
Please reload this pagehttps://github.com/nodejs/node/pull/28428
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jul 10, 2019https://github.com/nodejs/node/pull/28428#issuecomment-510205859
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/28428
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Oct 9, 2019 https://github.com/nodejs/node/pull/28428#pullrequestreview-299716386
View reviewed changes https://github.com/nodejs/node/pull/28428/files
mhdawsonhttps://github.com/mhdawson
https://github.com/nodejs/node/pull/28428#pullrequestreview-299716386
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28428
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Oct 10, 2019 https://github.com/nodejs/node/pull/28428#ref-pullrequest-499664802
implement Object::AddFinalizer nodejs/node-addon-api#551 https://github.com/nodejs/node-addon-api/pull/551
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
force-pushedhttps://github.com/nodejs/node/compare/bccf6b35b4fa0403174e2264e8be9ac16fc76355..908cc59b28cc3c043f70304628b3b2771a60c01a
bccf6b3https://github.com/nodejs/node/commit/bccf6b35b4fa0403174e2264e8be9ac16fc76355
908cc59https://github.com/nodejs/node/commit/908cc59b28cc3c043f70304628b3b2771a60c01a
Compare https://github.com/nodejs/node/compare/bccf6b35b4fa0403174e2264e8be9ac16fc76355..908cc59b28cc3c043f70304628b3b2771a60c01a
October 10, 2019 16:47https://github.com/nodejs/node/pull/28428#event-2703445791
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Oct 10, 2019https://github.com/nodejs/node/pull/28428#issuecomment-540676108
@mhdawsonhttps://github.com/mhdawson
Please reload this pagehttps://github.com/nodejs/node/pull/28428
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 10, 2019https://github.com/nodejs/node/pull/28428#issuecomment-540676917
https://ci.nodejs.org/job/node-test-pull-request/25945/https://ci.nodejs.org/job/node-test-pull-request/25945/
Please reload this pagehttps://github.com/nodejs/node/pull/28428
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Oct 11, 2019https://github.com/nodejs/node/pull/28428#issuecomment-541240553
@gabrielschulhofhttps://github.com/gabrielschulhof
Please reload this pagehttps://github.com/nodejs/node/pull/28428
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 11, 2019 https://github.com/nodejs/node/pull/28428#pullrequestreview-300948848
View reviewed changes https://github.com/nodejs/node/pull/28428/files
src/js_native_api_v8.cchttps://github.com/nodejs/node/pull/28428/files#diff-4b35cbf831be523a4f3e5aac3729c95490ed220892695d0e4245c15c1f63cfc1
Please reload this pagehttps://github.com/nodejs/node/pull/28428
src/js_native_api_v8_internals.hhttps://github.com/nodejs/node/pull/28428/files#diff-7f7cbfc322f6a471abfa8e030f29b28ad779397ee1fb78998d6da7c0208e804e
Please reload this pagehttps://github.com/nodejs/node/pull/28428
src: render N-API weak callbacks as cleanup hookshttps://github.com/nodejs/node/pull/28428/commits/4f39a8482eb955e78bddb66bc3d164db887e6b3b
4f39a84https://github.com/nodejs/node/pull/28428/commits/4f39a8482eb955e78bddb66bc3d164db887e6b3b
tc39/proposal-weakrefs#125 (comment)https://github.com/tc39/proposal-weakrefs/issues/125#issuecomment-535832130
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
force-pushedhttps://github.com/nodejs/node/compare/908cc59b28cc3c043f70304628b3b2771a60c01a..4f39a8482eb955e78bddb66bc3d164db887e6b3b
908cc59https://github.com/nodejs/node/commit/908cc59b28cc3c043f70304628b3b2771a60c01a
4f39a84https://github.com/nodejs/node/commit/4f39a8482eb955e78bddb66bc3d164db887e6b3b
Compare https://github.com/nodejs/node/compare/908cc59b28cc3c043f70304628b3b2771a60c01a..4f39a8482eb955e78bddb66bc3d164db887e6b3b
October 13, 2019 05:39https://github.com/nodejs/node/pull/28428#event-2708473403
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 13, 2019https://github.com/nodejs/node/pull/28428#issuecomment-541388745
https://ci.nodejs.org/job/node-test-pull-request/25995/https://ci.nodejs.org/job/node-test-pull-request/25995/
Please reload this pagehttps://github.com/nodejs/node/pull/28428
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 13, 2019https://github.com/nodejs/node/pull/28428#issuecomment-541391575
https://ci.nodejs.org/job/node-test-pull-request/25996/https://ci.nodejs.org/job/node-test-pull-request/25996/
Please reload this pagehttps://github.com/nodejs/node/pull/28428
gabrielschulhofhttps://github.com/gabrielschulhof
Oct 13, 2019 https://github.com/nodejs/node/pull/28428#ref-commit-53ca0b9
src: render N-API weak callbacks as cleanup hookshttps://github.com/nodejs/node/commit/53ca0b9ae145c430842bf78e553e3b6cbd2823aa
https://github.com/nodejs/node/commit/53ca0b9ae145c430842bf78e553e3b6cbd2823aa#comments
53ca0b9https://github.com/nodejs/node/commit/53ca0b9ae145c430842bf78e553e3b6cbd2823aa
tc39/proposal-weakrefs#125 (comment)https://github.com/tc39/proposal-weakrefs/issues/125#issuecomment-535832130
#28428https://github.com/nodejs/node/pull/28428
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Oct 13, 2019https://github.com/nodejs/node/pull/28428#issuecomment-541393220
53ca0b9https://github.com/nodejs/node/commit/53ca0b9ae145c430842bf78e553e3b6cbd2823aa
Please reload this pagehttps://github.com/nodejs/node/pull/28428
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Oct 13, 2019https://github.com/nodejs/node/pull/28428#event-2708501600
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
October 13, 2019 07:16https://github.com/nodejs/node/pull/28428#event-2708504204
Memory management questions nodejs/node-addon-api#550 https://github.com/nodejs/node-addon-api/issues/550
Garbage collection doesn't free values released during garbage collection (via native pointers) jerryscript-project/jerryscript#2253 https://github.com/jerryscript-project/jerryscript/issues/2253
Context-aware add-ons? nodejs/node-addon-api#567 https://github.com/nodejs/node-addon-api/issues/567
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Oct 21, 2019 https://github.com/nodejs/node/pull/28428#ref-pullrequest-491100896
2019-10-22, Version 13.0.0 (Current) #29504 https://github.com/nodejs/node/pull/29504
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Oct 22, 2019 https://github.com/nodejs/node/pull/28428#ref-pullrequest-510938668
[v12.x] src: render N-API weak callbacks as cleanup hooks #30070 https://github.com/nodejs/node/pull/30070
gabrielschulhofhttps://github.com/gabrielschulhof
Oct 22, 2019 https://github.com/nodejs/node/pull/28428#ref-commit-063c2ff
src: render N-API weak callbacks as cleanup hookshttps://github.com/gabrielschulhof/node/commit/063c2ff7a7ae380c98ac3d9b275947af091539c8
063c2ffhttps://github.com/gabrielschulhof/node/commit/063c2ff7a7ae380c98ac3d9b275947af091539c8
tc39/proposal-weakrefs#125 (comment)https://github.com/tc39/proposal-weakrefs/issues/125#issuecomment-535832130
nodejs#28428https://github.com/nodejs/node/pull/28428
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Oct 26, 2019 https://github.com/nodejs/node/pull/28428#ref-pullrequest-512810484
src: create HandleScope for env retrieval #30130 https://github.com/nodejs/node/pull/30130
targoshttps://github.com/targos
Nov 8, 2019 https://github.com/nodejs/node/pull/28428#ref-commit-1f4779e
https://github.com/targos
src: render N-API weak callbacks as cleanup hookshttps://github.com/nodejs/node/commit/1f4779ece9f10e6490e5eb6d2e0aada8d778d56a
1f4779ehttps://github.com/nodejs/node/commit/1f4779ece9f10e6490e5eb6d2e0aada8d778d56a
tc39/proposal-weakrefs#125 (comment)https://github.com/tc39/proposal-weakrefs/issues/125#issuecomment-535832130
#28428https://github.com/nodejs/node/pull/28428
targoshttps://github.com/targos
Nov 10, 2019 https://github.com/nodejs/node/pull/28428#ref-commit-aac2476
https://github.com/targos
src: render N-API weak callbacks as cleanup hookshttps://github.com/nodejs/node/commit/aac2476346f5bbab7e961c8441c88aa9964ac8a3
aac2476https://github.com/nodejs/node/commit/aac2476346f5bbab7e961c8441c88aa9964ac8a3
tc39/proposal-weakrefs#125 (comment)https://github.com/tc39/proposal-weakrefs/issues/125#issuecomment-535832130
#28428https://github.com/nodejs/node/pull/28428
https://github.com/targos
targoshttps://github.com/targos
Nov 10, 2019 https://github.com/nodejs/node/pull/28428#ref-pullrequest-520604598
v12.13.1 release proposal #30352 https://github.com/nodejs/node/pull/30352
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 7, 2019 https://github.com/nodejs/node/pull/28428#ref-pullrequest-532307441
src: migrated to new V8 ArrayBuffer API #30782 https://github.com/nodejs/node/pull/30782
https://github.com/vweevers
vweevershttps://github.com/vweevers
Jan 4, 2020 https://github.com/nodejs/node/pull/28428#ref-pullrequest-545190136
fix: leveldb iterator memory leak ipfs/js-datastore-level#26 https://github.com/ipfs/js-datastore-level/pull/26
https://github.com/FauxFaux
FauxFauxhttps://github.com/FauxFaux
Dec 24, 2020 https://github.com/nodejs/node/pull/28428#ref-issue-773153414
Segfault on process shutdown with vm.createContext node-ffi-napi/weak-napi#31 https://github.com/node-ffi-napi/weak-napi/issues/31
https://github.com/vweevers
vweevershttps://github.com/vweevers
Jan 31, 2021 https://github.com/nodejs/node/pull/28428#ref-issue-797675011
Multiple Assertion Failed !! Level/leveldown#755 https://github.com/Level/leveldown/issues/755
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28428
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/28428/files/908cc59b28cc3c043f70304628b3b2771a60c01a
https://github.com/mhdawson
mhdawson https://github.com/mhdawson
https://github.com/nodejs/node/pull/28428/files/bccf6b35b4fa0403174e2264e8be9ac16fc76355
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
review wanted https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22review%20wanted%22
Please reload this pagehttps://github.com/nodejs/node/pull/28428
https://github.com/gabrielschulhof
https://github.com/addaleax
https://github.com/mhdawson
https://github.com/NickNaso
https://github.com/Trott
https://github.com/anthony-tuininga
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.