| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:72725782-219c-9436-2c2f-cfa5549214f3 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 999C:165D8F:D62402:12B8208:6A4FE3BB |
| html-safe-nonce | 96d13ffa0368eb10ac6f9397ae221029b6ad52cc0ca14c5e27a153caa11e39f0 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OTlDOjE2NUQ4RjpENjI0MDI6MTJCODIwODo2QTRGRTNCQiIsInZpc2l0b3JfaWQiOiIzNDc5MTczNDMxMzk1NjA3NDgzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 3fb60dbc083a8ba1b20a7de79c35859d1c59621e7c3da43081fcac1e23919f59 |
| hovercard-subject-tag | pull_request:291215856 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28407/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/254b721988f91d177c053f9f852039f56aa176337da349e9fa9c8426bf41c03f/nodejs/node/pull/28407 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/254b721988f91d177c053f9f852039f56aa176337da349e9fa9c8426bf41c03f/nodejs/node/pull/28407 |
| og:image:alt | This PR adds an experimental readline.promises, similar to the ones in the dns and fs modules. The completer() argument to the Interface class, and the question() are the primary differences from t... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | cjihrig |
| hostname | github.com |
| expected-hostname | github.com |
| None | 19b98c3d9767bb8a56238a89ff8401d1cbdf3bc5c353799aacf49fe6c76b4b7c |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 142593e66413bbae27fd485859993597d5a3b104 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/28407#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28407 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28407 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/28407 |
| Reload | https://github.com/nodejs/node/pull/28407 |
| Reload | https://github.com/nodejs/node/pull/28407 |
| Please reload this page | https://github.com/nodejs/node/pull/28407 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/28407 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
975
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| cjihrig | https://github.com/cjihrig |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| cjihrig:readline | https://github.com/cjihrig/node/tree/readline |
| Conversation | https://github.com/nodejs/node/pull/28407 |
| Commits8 (8) | https://github.com/nodejs/node/pull/28407/commits |
| Checks | https://github.com/nodejs/node/pull/28407/checks |
| Files changed | https://github.com/nodejs/node/pull/28407/files |
| readline: add readline.promises | https://github.com/nodejs/node/pull/28407#top |
| cjihrig | https://github.com/cjihrig |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| cjihrig:readline | https://github.com/cjihrig/node/tree/readline |
|
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Jun 24, 2019 | https://github.com/nodejs/node/pull/28407#issue-459994781 |
| Please reload this page | https://github.com/nodejs/node/pull/28407 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/28407 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Jun 24, 2019 | https://github.com/nodejs/node/pull/28407#event-2434921495 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| force-pushed | https://github.com/nodejs/node/compare/aa4099e8721980c82a03f9b4afa6ddbb63f01c3b..709ee455a5da5c98cd905f4641f84b40d0d12b97 |
| aa4099e | https://github.com/nodejs/node/commit/aa4099e8721980c82a03f9b4afa6ddbb63f01c3b |
| 709ee45 | https://github.com/nodejs/node/commit/709ee455a5da5c98cd905f4641f84b40d0d12b97 |
|
Compare
| https://github.com/nodejs/node/compare/aa4099e8721980c82a03f9b4afa6ddbb63f01c3b..709ee455a5da5c98cd905f4641f84b40d0d12b97 |
| June 24, 2019 17:36 | https://github.com/nodejs/node/pull/28407#event-2435039816 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
readline
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Areadline |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
|
wip
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Jun 24, 2019 | https://github.com/nodejs/node/pull/28407#event-2435578428 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| force-pushed | https://github.com/nodejs/node/compare/709ee455a5da5c98cd905f4641f84b40d0d12b97..8334552b59aa9ce8c272e114c8d21c923d10ca92 |
| 709ee45 | https://github.com/nodejs/node/commit/709ee455a5da5c98cd905f4641f84b40d0d12b97 |
| 8334552 | https://github.com/nodejs/node/commit/8334552b59aa9ce8c272e114c8d21c923d10ca92 |
|
Compare
| https://github.com/nodejs/node/compare/709ee455a5da5c98cd905f4641f84b40d0d12b97..8334552b59aa9ce8c272e114c8d21c923d10ca92 |
| June 25, 2019 17:08 | https://github.com/nodejs/node/pull/28407#event-2438302108 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
wip
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip |
| Jun 25, 2019 | https://github.com/nodejs/node/pull/28407#event-2438303734 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Jun 25, 2019 | https://github.com/nodejs/node/pull/28407#event-2438304110 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Jun 25, 2019 | https://github.com/nodejs/node/pull/28407#issuecomment-505536433 |
| Please reload this page | https://github.com/nodejs/node/pull/28407 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Jun 26, 2019
| https://github.com/nodejs/node/pull/28407#pullrequestreview-254577415 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28407/files |
| doc/api/readline.md | https://github.com/nodejs/node/pull/28407/files#diff-c7dc978445adbf0629bdf9808c3992f5a37e805f95b2f6b06ef563703701a3f1 |
| Please reload this page | https://github.com/nodejs/node/pull/28407 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Jun 26, 2019
| https://github.com/nodejs/node/pull/28407#pullrequestreview-254594217 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28407/files |
| doc/api/readline.md | https://github.com/nodejs/node/pull/28407/files#diff-c7dc978445adbf0629bdf9808c3992f5a37e805f95b2f6b06ef563703701a3f1 |
| Please reload this page | https://github.com/nodejs/node/pull/28407 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Jun 26, 2019
| https://github.com/nodejs/node/pull/28407#pullrequestreview-254630399 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28407/files |
| doc/api/readline.md | https://github.com/nodejs/node/pull/28407/files#diff-c7dc978445adbf0629bdf9808c3992f5a37e805f95b2f6b06ef563703701a3f1 |
| Please reload this page | https://github.com/nodejs/node/pull/28407 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Jun 26, 2019
| https://github.com/nodejs/node/pull/28407#pullrequestreview-254633365 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28407/files |
| doc/api/readline.md | https://github.com/nodejs/node/pull/28407/files#diff-c7dc978445adbf0629bdf9808c3992f5a37e805f95b2f6b06ef563703701a3f1 |
| Please reload this page | https://github.com/nodejs/node/pull/28407 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Jun 26, 2019
| https://github.com/nodejs/node/pull/28407#pullrequestreview-254636384 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28407/files |
| doc/api/readline.md | https://github.com/nodejs/node/pull/28407/files#diff-c7dc978445adbf0629bdf9808c3992f5a37e805f95b2f6b06ef563703701a3f1 |
| Please reload this page | https://github.com/nodejs/node/pull/28407 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| force-pushed | https://github.com/nodejs/node/compare/8334552b59aa9ce8c272e114c8d21c923d10ca92..426c9b0ba8dbf153c37dd8b323cd736d626f0621 |
| 8334552 | https://github.com/nodejs/node/commit/8334552b59aa9ce8c272e114c8d21c923d10ca92 |
| 426c9b0 | https://github.com/nodejs/node/commit/426c9b0ba8dbf153c37dd8b323cd736d626f0621 |
|
Compare
| https://github.com/nodejs/node/compare/8334552b59aa9ce8c272e114c8d21c923d10ca92..426c9b0ba8dbf153c37dd8b323cd736d626f0621 |
| June 27, 2019 18:34 | https://github.com/nodejs/node/pull/28407#event-2445203644 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Jun 27, 2019 | https://github.com/nodejs/node/pull/28407#issuecomment-506461648 |
| @vsemozhetbyt | https://github.com/vsemozhetbyt |
| Please reload this page | https://github.com/nodejs/node/pull/28407 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28407 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28407 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28407 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28407 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 28, 2019 | https://github.com/nodejs/node/pull/28407#issuecomment-506619950 |
| https://ci.nodejs.org/job/node-test-pull-request/24137/ | https://ci.nodejs.org/job/node-test-pull-request/24137/ |
| Please reload this page | https://github.com/nodejs/node/pull/28407 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 28, 2019 | https://github.com/nodejs/node/pull/28407#issuecomment-506734431 |
| https://ci.nodejs.org/job/node-test-pull-request/24144/ | https://ci.nodejs.org/job/node-test-pull-request/24144/ |
| Please reload this page | https://github.com/nodejs/node/pull/28407 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 28, 2019 | https://github.com/nodejs/node/pull/28407#issuecomment-506752416 |
| https://ci.nodejs.org/job/node-test-pull-request/24148/ | https://ci.nodejs.org/job/node-test-pull-request/24148/ |
| Please reload this page | https://github.com/nodejs/node/pull/28407 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 28, 2019 | https://github.com/nodejs/node/pull/28407#issuecomment-506795983 |
| https://ci.nodejs.org/job/node-test-pull-request/24151/ | https://ci.nodejs.org/job/node-test-pull-request/24151/ |
| Please reload this page | https://github.com/nodejs/node/pull/28407 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Jun 28, 2019 | https://github.com/nodejs/node/pull/28407#issuecomment-506847800 |
| Please reload this page | https://github.com/nodejs/node/pull/28407 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| force-pushed | https://github.com/nodejs/node/compare/426c9b0ba8dbf153c37dd8b323cd736d626f0621..8b0e3687c8b875e64d6138381b9710a831a01442 |
| 426c9b0 | https://github.com/nodejs/node/commit/426c9b0ba8dbf153c37dd8b323cd736d626f0621 |
| 8b0e368 | https://github.com/nodejs/node/commit/8b0e3687c8b875e64d6138381b9710a831a01442 |
|
Compare
| https://github.com/nodejs/node/compare/426c9b0ba8dbf153c37dd8b323cd736d626f0621..8b0e3687c8b875e64d6138381b9710a831a01442 |
| June 29, 2019 15:10 | https://github.com/nodejs/node/pull/28407#event-2448975420 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 29, 2019 | https://github.com/nodejs/node/pull/28407#issuecomment-506963978 |
| https://ci.nodejs.org/job/node-test-pull-request/24168/ | https://ci.nodejs.org/job/node-test-pull-request/24168/ |
| Please reload this page | https://github.com/nodejs/node/pull/28407 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 29, 2019 | https://github.com/nodejs/node/pull/28407#issuecomment-506974421 |
| https://ci.nodejs.org/job/node-test-pull-request/24169/ | https://ci.nodejs.org/job/node-test-pull-request/24169/ |
| Please reload this page | https://github.com/nodejs/node/pull/28407 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 30, 2019 | https://github.com/nodejs/node/pull/28407#issuecomment-507048565 |
| https://ci.nodejs.org/job/node-test-pull-request/24176/ | https://ci.nodejs.org/job/node-test-pull-request/24176/ |
| Please reload this page | https://github.com/nodejs/node/pull/28407 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Jun 30, 2019
| https://github.com/nodejs/node/pull/28407#pullrequestreview-256094895 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28407/files |
| lib/internal/readline/utils.js | https://github.com/nodejs/node/pull/28407/files#diff-ff43f9e16142d30286b57ad845339b594f45e9ac843d9854455c72eb7a18d2c0 |
| Please reload this page | https://github.com/nodejs/node/pull/28407 |
| lib/readline.js | https://github.com/nodejs/node/pull/28407/files#diff-36f855786dc2ab46536bcb72a1f08f98c9b730ffa5dcd9dcff2ff952d7ee5c50 |
| Please reload this page | https://github.com/nodejs/node/pull/28407 |
| lib/readline.js | https://github.com/nodejs/node/pull/28407/files#diff-36f855786dc2ab46536bcb72a1f08f98c9b730ffa5dcd9dcff2ff952d7ee5c50 |
| addaleax | https://github.com/addaleax |
| Jun 30, 2019 | https://github.com/nodejs/node/pull/28407#discussion_r298854395 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/28407 |
| cjihrig | https://github.com/cjihrig |
| Jul 10, 2019 | https://github.com/nodejs/node/pull/28407#discussion_r302111169 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/28407 |
| addaleax | https://github.com/addaleax |
| Jul 10, 2019 | https://github.com/nodejs/node/pull/28407#discussion_r302279700 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/28407 |
| https://github.com/geek |
| geek | https://github.com/geek |
|
Jul 2, 2019
| https://github.com/nodejs/node/pull/28407#pullrequestreview-257000389 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28407/files |
| cjihrig | https://github.com/cjihrig |
| July 10, 2019 09:35 | https://github.com/nodejs/node/pull/28407#commits-pushed-166483a |
|
| https://github.com/cjihrig |
| lib: rename lib/internal/readline.js | https://github.com/nodejs/node/pull/28407/commits/166483a58d997b5c3262877cefd79ea5fa06b073 |
| 166483a | https://github.com/nodejs/node/pull/28407/commits/166483a58d997b5c3262877cefd79ea5fa06b073 |
|
| https://github.com/cjihrig |
| readline: move Interface to separate file | https://github.com/nodejs/node/pull/28407/commits/f763ff071b273c5c68b34f0c93b988b2ab63f4f1 |
| f763ff0 | https://github.com/nodejs/node/pull/28407/commits/f763ff071b273c5c68b34f0c93b988b2ab63f4f1 |
|
| https://github.com/cjihrig |
| readline: use named constant for surrogate checks | https://github.com/nodejs/node/pull/28407/commits/9ff7ccb798a096b139313023afb400495ae6ed23 |
| 9ff7ccb | https://github.com/nodejs/node/pull/28407/commits/9ff7ccb798a096b139313023afb400495ae6ed23 |
|
| https://github.com/cjihrig |
| readline: replace last uses var | https://github.com/nodejs/node/pull/28407/commits/9639082014de2badcec6cabd0a49c51cfa000c7c |
| 9639082 | https://github.com/nodejs/node/pull/28407/commits/9639082014de2badcec6cabd0a49c51cfa000c7c |
|
| https://github.com/cjihrig |
| readline: refactor _tabComplete() | https://github.com/nodejs/node/pull/28407/commits/74da7617164e7449bc0c0163785b1953e8bee28c |
| 74da761 | https://github.com/nodejs/node/pull/28407/commits/74da7617164e7449bc0c0163785b1953e8bee28c |
|
| https://github.com/cjihrig |
| readline: centralize Interface argument parsing | https://github.com/nodejs/node/pull/28407/commits/93d3cf8c489fa4fd494cccc52cfbf632b64e4a1e |
| 93d3cf8 | https://github.com/nodejs/node/pull/28407/commits/93d3cf8c489fa4fd494cccc52cfbf632b64e4a1e |
|
| https://github.com/cjihrig |
| readline: add readline.promises | https://github.com/nodejs/node/pull/28407/commits/11c8737e1b380cc71350d8ab3ef35c08e254b4c6 |
| 11c8737 | https://github.com/nodejs/node/pull/28407/commits/11c8737e1b380cc71350d8ab3ef35c08e254b4c6 |
|
| https://github.com/cjihrig |
| fixup! readline: add readline.promises | https://github.com/nodejs/node/pull/28407/commits/edcdf05009347f34d6ce962eecb8e52766ff5e63 |
| edcdf05 | https://github.com/nodejs/node/pull/28407/commits/edcdf05009347f34d6ce962eecb8e52766ff5e63 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| force-pushed | https://github.com/nodejs/node/compare/8b0e3687c8b875e64d6138381b9710a831a01442..edcdf05009347f34d6ce962eecb8e52766ff5e63 |
| 8b0e368 | https://github.com/nodejs/node/commit/8b0e3687c8b875e64d6138381b9710a831a01442 |
| edcdf05 | https://github.com/nodejs/node/commit/edcdf05009347f34d6ce962eecb8e52766ff5e63 |
|
Compare
| https://github.com/nodejs/node/compare/8b0e3687c8b875e64d6138381b9710a831a01442..edcdf05009347f34d6ce962eecb8e52766ff5e63 |
| July 10, 2019 14:18 | https://github.com/nodejs/node/pull/28407#event-2472738304 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 10, 2019 | https://github.com/nodejs/node/pull/28407#issuecomment-510098185 |
| Please reload this page | https://github.com/nodejs/node/pull/28407 |
| https://ci.nodejs.org/job/node-test-pull-request/24360/ | https://ci.nodejs.org/job/node-test-pull-request/24360/ |
| Please reload this page | https://github.com/nodejs/node/pull/28407 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Jul 11, 2019 | https://github.com/nodejs/node/pull/28407#event-2475886469 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Jul 11, 2019
| https://github.com/nodejs/node/pull/28407#ref-pullrequest-466896369 |
|
readline: use named constant for surrogate checks
#28638
| https://github.com/nodejs/node/pull/28638 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Jul 11, 2019 | https://github.com/nodejs/node/pull/28407#issuecomment-510637579 |
| @cjihrig | https://github.com/cjihrig |
| Please reload this page | https://github.com/nodejs/node/pull/28407 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Jul 11, 2019 | https://github.com/nodejs/node/pull/28407#issuecomment-510640678 |
| Please reload this page | https://github.com/nodejs/node/pull/28407 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Jul 12, 2019
| https://github.com/nodejs/node/pull/28407#ref-pullrequest-466997820 |
|
readline: expose stream API in clearScreenDown()
#28641
| https://github.com/nodejs/node/pull/28641 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28407 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/28407/files/edcdf05009347f34d6ce962eecb8e52766ff5e63 |
|
| https://github.com/vsemozhetbyt |
|
vsemozhetbyt
| https://github.com/vsemozhetbyt |
|
| https://github.com/nodejs/node/pull/28407/files/8334552b59aa9ce8c272e114c8d21c923d10ca92 |
|
| https://github.com/geek |
|
geek
| https://github.com/geek |
|
| https://github.com/nodejs/node/pull/28407/files/8b0e3687c8b875e64d6138381b9710a831a01442 |
|
readline
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Areadline |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
| Please reload this page | https://github.com/nodejs/node/pull/28407 |
|
| https://github.com/cjihrig |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/addaleax |
|
| https://github.com/geek |
|
| https://github.com/vsemozhetbyt |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |