René's URL Explorer Experiment


Title: readline: add readline.promises by cjihrig · Pull Request #28407 · nodejs/node · GitHub

Open Graph Title: readline: add readline.promises by cjihrig · Pull Request #28407 · nodejs/node

X Title: readline: add readline.promises by cjihrig · Pull Request #28407 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This PR adds an experimental readline.promises, similar to the ones in the dns and fs modules. The completer() argument to the Interface class, and the question() are the primary differences from t...

X Description: This PR adds an experimental readline.promises, similar to the ones in the dns and fs modules. The completer() argument to the Interface class, and the question() are the primary differences from t...

Opengraph URL: https://github.com/nodejs/node/pull/28407

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:72725782-219c-9436-2c2f-cfa5549214f3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id999C:165D8F:D62402:12B8208:6A4FE3BB
html-safe-nonce96d13ffa0368eb10ac6f9397ae221029b6ad52cc0ca14c5e27a153caa11e39f0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OTlDOjE2NUQ4RjpENjI0MDI6MTJCODIwODo2QTRGRTNCQiIsInZpc2l0b3JfaWQiOiIzNDc5MTczNDMxMzk1NjA3NDgzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac3fb60dbc083a8ba1b20a7de79c35859d1c59621e7c3da43081fcac1e23919f59
hovercard-subject-tagpull_request:291215856
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28407/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/254b721988f91d177c053f9f852039f56aa176337da349e9fa9c8426bf41c03f/nodejs/node/pull/28407
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/254b721988f91d177c053f9f852039f56aa176337da349e9fa9c8426bf41c03f/nodejs/node/pull/28407
og:image:altThis PR adds an experimental readline.promises, similar to the ones in the dns and fs modules. The completer() argument to the Interface class, and the question() are the primary differences from t...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecjihrig
hostnamegithub.com
expected-hostnamegithub.com
None19b98c3d9767bb8a56238a89ff8401d1cbdf3bc5c353799aacf49fe6c76b4b7c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release142593e66413bbae27fd485859993597d5a3b104
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/28407#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28407
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28407
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/28407
Reloadhttps://github.com/nodejs/node/pull/28407
Reloadhttps://github.com/nodejs/node/pull/28407
Please reload this pagehttps://github.com/nodejs/node/pull/28407
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/28407
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 975 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:readlinehttps://github.com/cjihrig/node/tree/readline
Conversationhttps://github.com/nodejs/node/pull/28407
Commits8 (8)https://github.com/nodejs/node/pull/28407/commits
Checkshttps://github.com/nodejs/node/pull/28407/checks
Files changedhttps://github.com/nodejs/node/pull/28407/files
readline: add readline.promiseshttps://github.com/nodejs/node/pull/28407#top
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:readlinehttps://github.com/cjihrig/node/tree/readline
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jun 24, 2019https://github.com/nodejs/node/pull/28407#issue-459994781
Please reload this pagehttps://github.com/nodejs/node/pull/28407
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/28407
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Jun 24, 2019https://github.com/nodejs/node/pull/28407#event-2434921495
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/aa4099e8721980c82a03f9b4afa6ddbb63f01c3b..709ee455a5da5c98cd905f4641f84b40d0d12b97
aa4099ehttps://github.com/nodejs/node/commit/aa4099e8721980c82a03f9b4afa6ddbb63f01c3b
709ee45https://github.com/nodejs/node/commit/709ee455a5da5c98cd905f4641f84b40d0d12b97
Compare https://github.com/nodejs/node/compare/aa4099e8721980c82a03f9b4afa6ddbb63f01c3b..709ee455a5da5c98cd905f4641f84b40d0d12b97
June 24, 2019 17:36https://github.com/nodejs/node/pull/28407#event-2435039816
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
readline https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Areadline
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Jun 24, 2019https://github.com/nodejs/node/pull/28407#event-2435578428
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/709ee455a5da5c98cd905f4641f84b40d0d12b97..8334552b59aa9ce8c272e114c8d21c923d10ca92
709ee45https://github.com/nodejs/node/commit/709ee455a5da5c98cd905f4641f84b40d0d12b97
8334552https://github.com/nodejs/node/commit/8334552b59aa9ce8c272e114c8d21c923d10ca92
Compare https://github.com/nodejs/node/compare/709ee455a5da5c98cd905f4641f84b40d0d12b97..8334552b59aa9ce8c272e114c8d21c923d10ca92
June 25, 2019 17:08https://github.com/nodejs/node/pull/28407#event-2438302108
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Jun 25, 2019https://github.com/nodejs/node/pull/28407#event-2438303734
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jun 25, 2019https://github.com/nodejs/node/pull/28407#event-2438304110
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jun 25, 2019https://github.com/nodejs/node/pull/28407#issuecomment-505536433
Please reload this pagehttps://github.com/nodejs/node/pull/28407
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Jun 26, 2019 https://github.com/nodejs/node/pull/28407#pullrequestreview-254577415
View reviewed changes https://github.com/nodejs/node/pull/28407/files
doc/api/readline.mdhttps://github.com/nodejs/node/pull/28407/files#diff-c7dc978445adbf0629bdf9808c3992f5a37e805f95b2f6b06ef563703701a3f1
Please reload this pagehttps://github.com/nodejs/node/pull/28407
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Jun 26, 2019 https://github.com/nodejs/node/pull/28407#pullrequestreview-254594217
View reviewed changes https://github.com/nodejs/node/pull/28407/files
doc/api/readline.mdhttps://github.com/nodejs/node/pull/28407/files#diff-c7dc978445adbf0629bdf9808c3992f5a37e805f95b2f6b06ef563703701a3f1
Please reload this pagehttps://github.com/nodejs/node/pull/28407
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Jun 26, 2019 https://github.com/nodejs/node/pull/28407#pullrequestreview-254630399
View reviewed changes https://github.com/nodejs/node/pull/28407/files
doc/api/readline.mdhttps://github.com/nodejs/node/pull/28407/files#diff-c7dc978445adbf0629bdf9808c3992f5a37e805f95b2f6b06ef563703701a3f1
Please reload this pagehttps://github.com/nodejs/node/pull/28407
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Jun 26, 2019 https://github.com/nodejs/node/pull/28407#pullrequestreview-254633365
View reviewed changes https://github.com/nodejs/node/pull/28407/files
doc/api/readline.mdhttps://github.com/nodejs/node/pull/28407/files#diff-c7dc978445adbf0629bdf9808c3992f5a37e805f95b2f6b06ef563703701a3f1
Please reload this pagehttps://github.com/nodejs/node/pull/28407
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Jun 26, 2019 https://github.com/nodejs/node/pull/28407#pullrequestreview-254636384
View reviewed changes https://github.com/nodejs/node/pull/28407/files
doc/api/readline.mdhttps://github.com/nodejs/node/pull/28407/files#diff-c7dc978445adbf0629bdf9808c3992f5a37e805f95b2f6b06ef563703701a3f1
Please reload this pagehttps://github.com/nodejs/node/pull/28407
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/8334552b59aa9ce8c272e114c8d21c923d10ca92..426c9b0ba8dbf153c37dd8b323cd736d626f0621
8334552https://github.com/nodejs/node/commit/8334552b59aa9ce8c272e114c8d21c923d10ca92
426c9b0https://github.com/nodejs/node/commit/426c9b0ba8dbf153c37dd8b323cd736d626f0621
Compare https://github.com/nodejs/node/compare/8334552b59aa9ce8c272e114c8d21c923d10ca92..426c9b0ba8dbf153c37dd8b323cd736d626f0621
June 27, 2019 18:34https://github.com/nodejs/node/pull/28407#event-2445203644
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jun 27, 2019https://github.com/nodejs/node/pull/28407#issuecomment-506461648
@vsemozhetbythttps://github.com/vsemozhetbyt
Please reload this pagehttps://github.com/nodejs/node/pull/28407
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28407
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28407
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28407
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28407
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 28, 2019https://github.com/nodejs/node/pull/28407#issuecomment-506619950
https://ci.nodejs.org/job/node-test-pull-request/24137/https://ci.nodejs.org/job/node-test-pull-request/24137/
Please reload this pagehttps://github.com/nodejs/node/pull/28407
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 28, 2019https://github.com/nodejs/node/pull/28407#issuecomment-506734431
https://ci.nodejs.org/job/node-test-pull-request/24144/https://ci.nodejs.org/job/node-test-pull-request/24144/
Please reload this pagehttps://github.com/nodejs/node/pull/28407
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 28, 2019https://github.com/nodejs/node/pull/28407#issuecomment-506752416
https://ci.nodejs.org/job/node-test-pull-request/24148/https://ci.nodejs.org/job/node-test-pull-request/24148/
Please reload this pagehttps://github.com/nodejs/node/pull/28407
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 28, 2019https://github.com/nodejs/node/pull/28407#issuecomment-506795983
https://ci.nodejs.org/job/node-test-pull-request/24151/https://ci.nodejs.org/job/node-test-pull-request/24151/
Please reload this pagehttps://github.com/nodejs/node/pull/28407
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jun 28, 2019https://github.com/nodejs/node/pull/28407#issuecomment-506847800
Please reload this pagehttps://github.com/nodejs/node/pull/28407
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/426c9b0ba8dbf153c37dd8b323cd736d626f0621..8b0e3687c8b875e64d6138381b9710a831a01442
426c9b0https://github.com/nodejs/node/commit/426c9b0ba8dbf153c37dd8b323cd736d626f0621
8b0e368https://github.com/nodejs/node/commit/8b0e3687c8b875e64d6138381b9710a831a01442
Compare https://github.com/nodejs/node/compare/426c9b0ba8dbf153c37dd8b323cd736d626f0621..8b0e3687c8b875e64d6138381b9710a831a01442
June 29, 2019 15:10https://github.com/nodejs/node/pull/28407#event-2448975420
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 29, 2019https://github.com/nodejs/node/pull/28407#issuecomment-506963978
https://ci.nodejs.org/job/node-test-pull-request/24168/https://ci.nodejs.org/job/node-test-pull-request/24168/
Please reload this pagehttps://github.com/nodejs/node/pull/28407
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 29, 2019https://github.com/nodejs/node/pull/28407#issuecomment-506974421
https://ci.nodejs.org/job/node-test-pull-request/24169/https://ci.nodejs.org/job/node-test-pull-request/24169/
Please reload this pagehttps://github.com/nodejs/node/pull/28407
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 30, 2019https://github.com/nodejs/node/pull/28407#issuecomment-507048565
https://ci.nodejs.org/job/node-test-pull-request/24176/https://ci.nodejs.org/job/node-test-pull-request/24176/
Please reload this pagehttps://github.com/nodejs/node/pull/28407
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 30, 2019 https://github.com/nodejs/node/pull/28407#pullrequestreview-256094895
View reviewed changes https://github.com/nodejs/node/pull/28407/files
lib/internal/readline/utils.jshttps://github.com/nodejs/node/pull/28407/files#diff-ff43f9e16142d30286b57ad845339b594f45e9ac843d9854455c72eb7a18d2c0
Please reload this pagehttps://github.com/nodejs/node/pull/28407
lib/readline.jshttps://github.com/nodejs/node/pull/28407/files#diff-36f855786dc2ab46536bcb72a1f08f98c9b730ffa5dcd9dcff2ff952d7ee5c50
Please reload this pagehttps://github.com/nodejs/node/pull/28407
lib/readline.jshttps://github.com/nodejs/node/pull/28407/files#diff-36f855786dc2ab46536bcb72a1f08f98c9b730ffa5dcd9dcff2ff952d7ee5c50
addaleaxhttps://github.com/addaleax
Jun 30, 2019https://github.com/nodejs/node/pull/28407#discussion_r298854395
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28407
cjihrighttps://github.com/cjihrig
Jul 10, 2019https://github.com/nodejs/node/pull/28407#discussion_r302111169
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/28407
addaleaxhttps://github.com/addaleax
Jul 10, 2019https://github.com/nodejs/node/pull/28407#discussion_r302279700
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28407
https://github.com/geek
geekhttps://github.com/geek
Jul 2, 2019 https://github.com/nodejs/node/pull/28407#pullrequestreview-257000389
View reviewed changes https://github.com/nodejs/node/pull/28407/files
cjihrighttps://github.com/cjihrig
July 10, 2019 09:35https://github.com/nodejs/node/pull/28407#commits-pushed-166483a
https://github.com/cjihrig
lib: rename lib/internal/readline.jshttps://github.com/nodejs/node/pull/28407/commits/166483a58d997b5c3262877cefd79ea5fa06b073
166483ahttps://github.com/nodejs/node/pull/28407/commits/166483a58d997b5c3262877cefd79ea5fa06b073
https://github.com/cjihrig
readline: move Interface to separate filehttps://github.com/nodejs/node/pull/28407/commits/f763ff071b273c5c68b34f0c93b988b2ab63f4f1
f763ff0https://github.com/nodejs/node/pull/28407/commits/f763ff071b273c5c68b34f0c93b988b2ab63f4f1
https://github.com/cjihrig
readline: use named constant for surrogate checkshttps://github.com/nodejs/node/pull/28407/commits/9ff7ccb798a096b139313023afb400495ae6ed23
9ff7ccbhttps://github.com/nodejs/node/pull/28407/commits/9ff7ccb798a096b139313023afb400495ae6ed23
https://github.com/cjihrig
readline: replace last uses varhttps://github.com/nodejs/node/pull/28407/commits/9639082014de2badcec6cabd0a49c51cfa000c7c
9639082https://github.com/nodejs/node/pull/28407/commits/9639082014de2badcec6cabd0a49c51cfa000c7c
https://github.com/cjihrig
readline: refactor _tabComplete()https://github.com/nodejs/node/pull/28407/commits/74da7617164e7449bc0c0163785b1953e8bee28c
74da761https://github.com/nodejs/node/pull/28407/commits/74da7617164e7449bc0c0163785b1953e8bee28c
https://github.com/cjihrig
readline: centralize Interface argument parsinghttps://github.com/nodejs/node/pull/28407/commits/93d3cf8c489fa4fd494cccc52cfbf632b64e4a1e
93d3cf8https://github.com/nodejs/node/pull/28407/commits/93d3cf8c489fa4fd494cccc52cfbf632b64e4a1e
https://github.com/cjihrig
readline: add readline.promiseshttps://github.com/nodejs/node/pull/28407/commits/11c8737e1b380cc71350d8ab3ef35c08e254b4c6
11c8737https://github.com/nodejs/node/pull/28407/commits/11c8737e1b380cc71350d8ab3ef35c08e254b4c6
https://github.com/cjihrig
fixup! readline: add readline.promiseshttps://github.com/nodejs/node/pull/28407/commits/edcdf05009347f34d6ce962eecb8e52766ff5e63
edcdf05https://github.com/nodejs/node/pull/28407/commits/edcdf05009347f34d6ce962eecb8e52766ff5e63
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/8b0e3687c8b875e64d6138381b9710a831a01442..edcdf05009347f34d6ce962eecb8e52766ff5e63
8b0e368https://github.com/nodejs/node/commit/8b0e3687c8b875e64d6138381b9710a831a01442
edcdf05https://github.com/nodejs/node/commit/edcdf05009347f34d6ce962eecb8e52766ff5e63
Compare https://github.com/nodejs/node/compare/8b0e3687c8b875e64d6138381b9710a831a01442..edcdf05009347f34d6ce962eecb8e52766ff5e63
July 10, 2019 14:18https://github.com/nodejs/node/pull/28407#event-2472738304
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 10, 2019https://github.com/nodejs/node/pull/28407#issuecomment-510098185
Please reload this pagehttps://github.com/nodejs/node/pull/28407
https://ci.nodejs.org/job/node-test-pull-request/24360/https://ci.nodejs.org/job/node-test-pull-request/24360/
Please reload this pagehttps://github.com/nodejs/node/pull/28407
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jul 11, 2019https://github.com/nodejs/node/pull/28407#event-2475886469
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jul 11, 2019 https://github.com/nodejs/node/pull/28407#ref-pullrequest-466896369
readline: use named constant for surrogate checks #28638 https://github.com/nodejs/node/pull/28638
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 11, 2019https://github.com/nodejs/node/pull/28407#issuecomment-510637579
@cjihrighttps://github.com/cjihrig
Please reload this pagehttps://github.com/nodejs/node/pull/28407
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jul 11, 2019https://github.com/nodejs/node/pull/28407#issuecomment-510640678
Please reload this pagehttps://github.com/nodejs/node/pull/28407
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jul 12, 2019 https://github.com/nodejs/node/pull/28407#ref-pullrequest-466997820
readline: expose stream API in clearScreenDown() #28641 https://github.com/nodejs/node/pull/28641
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28407
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/28407/files/edcdf05009347f34d6ce962eecb8e52766ff5e63
https://github.com/vsemozhetbyt
vsemozhetbyt https://github.com/vsemozhetbyt
https://github.com/nodejs/node/pull/28407/files/8334552b59aa9ce8c272e114c8d21c923d10ca92
https://github.com/geek
geek https://github.com/geek
https://github.com/nodejs/node/pull/28407/files/8b0e3687c8b875e64d6138381b9710a831a01442
readline https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Areadline
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
Please reload this pagehttps://github.com/nodejs/node/pull/28407
https://github.com/cjihrig
https://github.com/nodejs-github-bot
https://github.com/addaleax
https://github.com/geek
https://github.com/vsemozhetbyt
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.