René's URL Explorer Experiment


Title: [v8.x] n-api: make func argument of napi_create_threadsafe_function optional by gabrielschulhof · Pull Request #28400 · nodejs/node · GitHub

Open Graph Title: [v8.x] n-api: make func argument of napi_create_threadsafe_function optional by gabrielschulhof · Pull Request #28400 · nodejs/node

X Title: [v8.x] n-api: make func argument of napi_create_threadsafe_function optional by gabrielschulhof · Pull Request #28400 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: PR-URL: #27791 Refs: #27592 Reviewed-By: Gabriel Schulhof gabriel.schulhof@intel.com Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included docu...

X Description: PR-URL: #27791 Refs: #27592 Reviewed-By: Gabriel Schulhof gabriel.schulhof@intel.com Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included docu...

Mail addresses
gabriel.schulhof@intel.com

Opengraph URL: https://github.com/nodejs/node/pull/28400

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:665b460b-1b2a-dfc6-3943-2f602700487c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAF9E:19A6A8:F405D9:1562BED:6A4E983D
html-safe-nonce9f2c65af17406eb96d6fd16f136a5038c375578e1eb77a891dcf2cbf7f41f35e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjlFOjE5QTZBODpGNDA1RDk6MTU2MkJFRDo2QTRFOTgzRCIsInZpc2l0b3JfaWQiOiI1Njk5ODk4MTY4ODUxNzMyNTQxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacf7ceba15686864a80841d3784d57e3ec82435b69628ecafee48a04f7eff20174
hovercard-subject-tagpull_request:290935222
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28400/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b1f08eca92badd549f9c6dc49b31f6346b2cf43f4686302538f9ad3b3a24e708/nodejs/node/pull/28400
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b1f08eca92badd549f9c6dc49b31f6346b2cf43f4686302538f9ad3b3a24e708/nodejs/node/pull/28400
og:image:altPR-URL: #27791 Refs: #27592 Reviewed-By: Gabriel Schulhof gabriel.schulhof@intel.com Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included docu...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegabrielschulhof
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/28400#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28400
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28400
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/28400
Reloadhttps://github.com/nodejs/node/pull/28400
Reloadhttps://github.com/nodejs/node/pull/28400
Please reload this pagehttps://github.com/nodejs/node/pull/28400
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/28400
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 965 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
gabrielschulhofhttps://github.com/gabrielschulhof
nodejs:v8.x-staginghttps://github.com/nodejs/node/tree/v8.x-staging
gabrielschulhof:backport-27791-to-v8.xhttps://github.com/gabrielschulhof/node/tree/backport-27791-to-v8.x
Conversationhttps://github.com/nodejs/node/pull/28400
Commits1 (1)https://github.com/nodejs/node/pull/28400/commits
Checkshttps://github.com/nodejs/node/pull/28400/checks
Files changedhttps://github.com/nodejs/node/pull/28400/files
[v8.x] n-api: make func argument of napi_create_threadsafe_function optionalhttps://github.com/nodejs/node/pull/28400#top
gabrielschulhofhttps://github.com/gabrielschulhof
nodejs:v8.x-staginghttps://github.com/nodejs/node/tree/v8.x-staging
gabrielschulhof:backport-27791-to-v8.xhttps://github.com/gabrielschulhof/node/tree/backport-27791-to-v8.x
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Jun 24, 2019https://github.com/nodejs/node/pull/28400#issue-459643077
#27791https://github.com/nodejs/node/pull/27791
#27592https://github.com/nodejs/node/issues/27592
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/28400
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av8.x
Jun 24, 2019https://github.com/nodejs/node/pull/28400#event-2432766981
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Jun 24, 2019https://github.com/nodejs/node/pull/28400#event-2432767108
https://github.com/legendecas
legendecashttps://github.com/legendecas
Jun 24, 2019 https://github.com/nodejs/node/pull/28400#pullrequestreview-253163621
View reviewed changes https://github.com/nodejs/node/pull/28400/files
legendecashttps://github.com/legendecas
https://github.com/nodejs/node/pull/28400#pullrequestreview-253163621
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28400
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jun 24, 2019 https://github.com/nodejs/node/pull/28400#pullrequestreview-253680360
View reviewed changes https://github.com/nodejs/node/pull/28400/files
doc/api/n-api.mdhttps://github.com/nodejs/node/pull/28400/files#diff-26709ee1f9f0cb60d2d67f45106b31de8ed5eb28ad66c91903fd935a6d607d4d
Please reload this pagehttps://github.com/nodejs/node/pull/28400
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
force-pushedhttps://github.com/nodejs/node/compare/5d69cd48df49209ff50ec0fbf5bcef629fe7f0ad..5b1f49715fb1fc27af50b41b02dd91db1c647b53
5d69cd4https://github.com/nodejs/node/commit/5d69cd48df49209ff50ec0fbf5bcef629fe7f0ad
5b1f497https://github.com/nodejs/node/commit/5b1f49715fb1fc27af50b41b02dd91db1c647b53
Compare https://github.com/nodejs/node/compare/5d69cd48df49209ff50ec0fbf5bcef629fe7f0ad..5b1f49715fb1fc27af50b41b02dd91db1c647b53
June 25, 2019 19:26https://github.com/nodejs/node/pull/28400#event-2438677081
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jun 26, 2019 https://github.com/nodejs/node/pull/28400#pullrequestreview-254694148
View reviewed changes https://github.com/nodejs/node/pull/28400/files
doc/api/n-api.mdhttps://github.com/nodejs/node/pull/28400/files#diff-26709ee1f9f0cb60d2d67f45106b31de8ed5eb28ad66c91903fd935a6d607d4d
Please reload this pagehttps://github.com/nodejs/node/pull/28400
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
force-pushedhttps://github.com/nodejs/node/compare/5b1f49715fb1fc27af50b41b02dd91db1c647b53..64849c314005e3439c4c1b7403cd2d137d896d47
5b1f497https://github.com/nodejs/node/commit/5b1f49715fb1fc27af50b41b02dd91db1c647b53
64849c3https://github.com/nodejs/node/commit/64849c314005e3439c4c1b7403cd2d137d896d47
Compare https://github.com/nodejs/node/compare/5b1f49715fb1fc27af50b41b02dd91db1c647b53..64849c314005e3439c4c1b7403cd2d137d896d47
July 1, 2019 18:05https://github.com/nodejs/node/pull/28400#event-2452024222
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jul 1, 2019 https://github.com/nodejs/node/pull/28400#pullrequestreview-256588617
View reviewed changes https://github.com/nodejs/node/pull/28400/files
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jul 4, 2019https://github.com/nodejs/node/pull/28400#event-2461164906
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 4, 2019https://github.com/nodejs/node/pull/28400#issuecomment-508551553
https://ci.nodejs.org/job/node-test-pull-request/24268/https://ci.nodejs.org/job/node-test-pull-request/24268/
Please reload this pagehttps://github.com/nodejs/node/pull/28400
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 6, 2019https://github.com/nodejs/node/pull/28400#issuecomment-508900785
https://ci.nodejs.org/job/node-test-pull-request/24312/https://ci.nodejs.org/job/node-test-pull-request/24312/
Please reload this pagehttps://github.com/nodejs/node/pull/28400
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Jul 8, 2019 https://github.com/nodejs/node/pull/28400#ref-issue-451609284
What should go into N-API 5? nodejs/abi-stable-node#374 https://github.com/nodejs/abi-stable-node/issues/374
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 18, 2019https://github.com/nodejs/node/pull/28400#issuecomment-513015661
https://ci.nodejs.org/job/node-test-pull-request/24550/https://ci.nodejs.org/job/node-test-pull-request/24550/
Please reload this pagehttps://github.com/nodejs/node/pull/28400
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jul 23, 2019 https://github.com/nodejs/node/pull/28400#pullrequestreview-265697988
View reviewed changes https://github.com/nodejs/node/pull/28400/files
mhdawsonhttps://github.com/mhdawson
https://github.com/nodejs/node/pull/28400#pullrequestreview-265697988
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28400
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 30, 2019https://github.com/nodejs/node/pull/28400#issuecomment-516254366
Please reload this pagehttps://github.com/nodejs/node/pull/28400
https://github.com/Trott
Trotthttps://github.com/Trott
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jul 30, 2019https://github.com/nodejs/node/pull/28400#event-2518458461
https://github.com/legendecas
n-api: make func argument of napi_create_threadsafe_function optionalhttps://github.com/nodejs/node/pull/28400/commits/d0a05d061d69cd8a3f63cdf91826932765e3c719
d0a05d0https://github.com/nodejs/node/pull/28400/commits/d0a05d061d69cd8a3f63cdf91826932765e3c719
nodejs#27791https://github.com/nodejs/node/pull/27791
nodejs#27592https://github.com/nodejs/node/issues/27592
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
force-pushedhttps://github.com/nodejs/node/compare/64849c314005e3439c4c1b7403cd2d137d896d47..d0a05d061d69cd8a3f63cdf91826932765e3c719
64849c3https://github.com/nodejs/node/commit/64849c314005e3439c4c1b7403cd2d137d896d47
d0a05d0https://github.com/nodejs/node/commit/d0a05d061d69cd8a3f63cdf91826932765e3c719
Compare https://github.com/nodejs/node/compare/64849c314005e3439c4c1b7403cd2d137d896d47..d0a05d061d69cd8a3f63cdf91826932765e3c719
September 2, 2019 06:58https://github.com/nodejs/node/pull/28400#event-2600103255
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Sep 2, 2019https://github.com/nodejs/node/pull/28400#issuecomment-527026894
Please reload this pagehttps://github.com/nodejs/node/pull/28400
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 19, 2019https://github.com/nodejs/node/pull/28400#issuecomment-533082116
https://ci.nodejs.org/job/node-test-pull-request/25576/https://ci.nodejs.org/job/node-test-pull-request/25576/
Please reload this pagehttps://github.com/nodejs/node/pull/28400
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
Sep 19, 2019https://github.com/nodejs/node/pull/28400#event-2647582358
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Oct 13, 2019https://github.com/nodejs/node/pull/28400#issuecomment-541393956
Please reload this pagehttps://github.com/nodejs/node/pull/28400
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Oct 13, 2019https://github.com/nodejs/node/pull/28400#event-2708506383
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
October 13, 2019 07:24https://github.com/nodejs/node/pull/28400#event-2708507239
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28400
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/28400/files/64849c314005e3439c4c1b7403cd2d137d896d47
https://github.com/legendecas
legendecas https://github.com/legendecas
https://github.com/nodejs/node/pull/28400/files/5b1f49715fb1fc27af50b41b02dd91db1c647b53
https://github.com/mhdawson
mhdawson https://github.com/mhdawson
https://github.com/nodejs/node/pull/28400/files/64849c314005e3439c4c1b7403cd2d137d896d47
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
Please reload this pagehttps://github.com/nodejs/node/pull/28400
https://github.com/gabrielschulhof
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/richardlau
https://github.com/legendecas
https://github.com/mhdawson
https://github.com/BethGriggs
https://github.com/BridgeAR
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.