René's URL Explorer Experiment


Title: worker: handle calling terminate when kHandler is null by elyalvarado · Pull Request #28370 · nodejs/node · GitHub

Open Graph Title: worker: handle calling terminate when kHandler is null by elyalvarado · Pull Request #28370 · nodejs/node

X Title: worker: handle calling terminate when kHandler is null by elyalvarado · Pull Request #28370 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This PR makes a change to the Worker.terminate() method when called if the kHandler is null. Before this pull request it was returning undefined, but the API is expecting a promise. With the change...

X Description: This PR makes a change to the Worker.terminate() method when called if the kHandler is null. Before this pull request it was returning undefined, but the API is expecting a promise. With the change...

Opengraph URL: https://github.com/nodejs/node/pull/28370

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ad30ff38-371a-0db7-9c47-ca8df45f5ac5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDD32:B5AA6:202B112:2BE82F2:6A4F31EB
html-safe-nonceceb47993a6620af164e0d0924f730d0344530eb758545265017d9ce5d1cec339
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERDMyOkI1QUE2OjIwMkIxMTI6MkJFODJGMjo2QTRGMzFFQiIsInZpc2l0b3JfaWQiOiIzNjI2NTc4MDQ5MDI0MDc4MzE1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac54477e486dfbd9a4260b18ff65bbdeb7160ca59a961f826713a0467a885302ff
hovercard-subject-tagpull_request:290765671
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28370/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/694c863402014f54b6e9777798f4b6f2ff72d011b54d25e53747edd7c5fdcc45/nodejs/node/pull/28370
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/694c863402014f54b6e9777798f4b6f2ff72d011b54d25e53747edd7c5fdcc45/nodejs/node/pull/28370
og:image:altThis PR makes a change to the Worker.terminate() method when called if the kHandler is null. Before this pull request it was returning undefined, but the API is expecting a promise. With the change...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameelyalvarado
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b8f23afb982271f1b22258a94aede67a6b77760
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/28370#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28370
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28370
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/28370
Reloadhttps://github.com/nodejs/node/pull/28370
Reloadhttps://github.com/nodejs/node/pull/28370
Please reload this pagehttps://github.com/nodejs/node/pull/28370
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/28370
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 971 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
elyalvaradohttps://github.com/elyalvarado
nodejs:masterhttps://github.com/nodejs/node/tree/master
elyalvarado:terminate-with-null-handlershttps://github.com/elyalvarado/node/tree/terminate-with-null-handlers
Conversationhttps://github.com/nodejs/node/pull/28370
Commits5 (5)https://github.com/nodejs/node/pull/28370/commits
Checkshttps://github.com/nodejs/node/pull/28370/checks
Files changedhttps://github.com/nodejs/node/pull/28370/files
worker: handle calling terminate when kHandler is nullhttps://github.com/nodejs/node/pull/28370#top
elyalvaradohttps://github.com/elyalvarado
nodejs:masterhttps://github.com/nodejs/node/tree/master
elyalvarado:terminate-with-null-handlershttps://github.com/elyalvarado/node/tree/terminate-with-null-handlers
https://github.com/elyalvarado
elyalvaradohttps://github.com/elyalvarado
Jun 21, 2019https://github.com/nodejs/node/pull/28370#issue-459394200
Please reload this pagehttps://github.com/nodejs/node/pull/28370
always return promiseshttps://www.w3.org/2001/tag/doc/promises-guide#always-return-promises
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/28370
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
worker https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aworker
Jun 21, 2019https://github.com/nodejs/node/pull/28370#event-2431575420
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Jun 22, 2019 https://github.com/nodejs/node/pull/28370#pullrequestreview-253077732
View reviewed changes https://github.com/nodejs/node/pull/28370/files
lib/internal/worker.jshttps://github.com/nodejs/node/pull/28370/files#diff-7ee37130d43feac3a3f96a16e0b9628597ff2d8aee8e3c86765a616ff684e564
Please reload this pagehttps://github.com/nodejs/node/pull/28370
https://github.com/elyalvarado
elyalvaradohttps://github.com/elyalvarado
force-pushedhttps://github.com/nodejs/node/compare/77806ac4b4eb765bf3573689fb982fc832fba060..c59a793579dc7bb052600ba6bd3f596b73e23ad3
77806achttps://github.com/nodejs/node/commit/77806ac4b4eb765bf3573689fb982fc832fba060
c59a793https://github.com/nodejs/node/commit/c59a793579dc7bb052600ba6bd3f596b73e23ad3
Compare https://github.com/nodejs/node/compare/77806ac4b4eb765bf3573689fb982fc832fba060..c59a793579dc7bb052600ba6bd3f596b73e23ad3
June 22, 2019 12:33https://github.com/nodejs/node/pull/28370#event-2431949763
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 22, 2019 https://github.com/nodejs/node/pull/28370#pullrequestreview-253098369
View reviewed changes https://github.com/nodejs/node/pull/28370/files
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/28370#pullrequestreview-253098369
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28370
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Jun 22, 2019 https://github.com/nodejs/node/pull/28370#pullrequestreview-253098677
View reviewed changes https://github.com/nodejs/node/pull/28370/files
TimothyGuhttps://github.com/TimothyGu
https://github.com/nodejs/node/pull/28370#pullrequestreview-253098677
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/28370
lib/internal/worker.jshttps://github.com/nodejs/node/pull/28370/files#diff-7ee37130d43feac3a3f96a16e0b9628597ff2d8aee8e3c86765a616ff684e564
Please reload this pagehttps://github.com/nodejs/node/pull/28370
https://github.com/jasnell
jasnellhttps://github.com/jasnell
code-and-learn https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn
Jun 23, 2019https://github.com/nodejs/node/pull/28370#event-2432585756
https://github.com/elyalvarado
elyalvaradohttps://github.com/elyalvarado
force-pushedhttps://github.com/nodejs/node/compare/c59a793579dc7bb052600ba6bd3f596b73e23ad3..4222cd91f530145380f35dfb75a0798d8737477f
c59a793https://github.com/nodejs/node/commit/c59a793579dc7bb052600ba6bd3f596b73e23ad3
4222cd9https://github.com/nodejs/node/commit/4222cd91f530145380f35dfb75a0798d8737477f
Compare https://github.com/nodejs/node/compare/c59a793579dc7bb052600ba6bd3f596b73e23ad3..4222cd91f530145380f35dfb75a0798d8737477f
June 23, 2019 22:34https://github.com/nodejs/node/pull/28370#event-2432677247
https://github.com/elyalvarado
elyalvaradohttps://github.com/elyalvarado
Jun 23, 2019https://github.com/nodejs/node/pull/28370#issuecomment-504793750
Please reload this pagehttps://github.com/nodejs/node/pull/28370
https://github.com/elyalvarado
elyalvaradohttps://github.com/elyalvarado
Jun 23, 2019https://github.com/nodejs/node/pull/28370#event-2432679667
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Jun 23, 2019 https://github.com/nodejs/node/pull/28370#pullrequestreview-253153086
View reviewed changes https://github.com/nodejs/node/pull/28370/files
https://github.com/khriztianmoreno
khriztianmorenohttps://github.com/khriztianmoreno
Jul 4, 2019 https://github.com/nodejs/node/pull/28370#pullrequestreview-258046735
View reviewed changes https://github.com/nodejs/node/pull/28370/files
khriztianmorenohttps://github.com/khriztianmoreno
https://github.com/nodejs/node/pull/28370#pullrequestreview-258046735
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28370
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jul 4, 2019https://github.com/nodejs/node/pull/28370#event-2461075852
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 4, 2019https://github.com/nodejs/node/pull/28370#issuecomment-508539207
https://ci.nodejs.org/job/node-test-pull-request/24264/https://ci.nodejs.org/job/node-test-pull-request/24264/
Please reload this pagehttps://github.com/nodejs/node/pull/28370
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28370
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jul 4, 2019 https://github.com/nodejs/node/pull/28370#pullrequestreview-258145986
View reviewed changes https://github.com/nodejs/node/pull/28370/files
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 5, 2019 https://github.com/nodejs/node/pull/28370#pullrequestreview-258196197
View reviewed changes https://github.com/nodejs/node/pull/28370/files
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 5, 2019https://github.com/nodejs/node/pull/28370#issuecomment-508604316
https://ci.nodejs.org/job/node-test-pull-request/24278/https://ci.nodejs.org/job/node-test-pull-request/24278/
Please reload this pagehttps://github.com/nodejs/node/pull/28370
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jul 15, 2019 https://github.com/nodejs/node/pull/28370#pullrequestreview-261851312
View reviewed changes https://github.com/nodejs/node/pull/28370/files
test/parallel/test-worker-terminate-null-handler.jshttps://github.com/nodejs/node/pull/28370/files#diff-57b85076ef81ed0822c5a37fcb13941a99084eea2f9bb9729d9e7922e02d768f
Please reload this pagehttps://github.com/nodejs/node/pull/28370
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 15, 2019https://github.com/nodejs/node/pull/28370#issuecomment-511426352
https://ci.nodejs.org/job/node-test-pull-request/24468/https://ci.nodejs.org/job/node-test-pull-request/24468/
Please reload this pagehttps://github.com/nodejs/node/pull/28370
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jul 17, 2019 https://github.com/nodejs/node/pull/28370#pullrequestreview-263076460
View reviewed changes https://github.com/nodejs/node/pull/28370/files
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 30, 2019https://github.com/nodejs/node/pull/28370#issuecomment-516253400
https://ci.nodejs.org/job/node-test-pull-request/24765/https://ci.nodejs.org/job/node-test-pull-request/24765/
Please reload this pagehttps://github.com/nodejs/node/pull/28370
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 30, 2019https://github.com/nodejs/node/pull/28370#issuecomment-516264860
https://ci.nodejs.org/job/node-test-pull-request/24771/https://ci.nodejs.org/job/node-test-pull-request/24771/
Please reload this pagehttps://github.com/nodejs/node/pull/28370
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 30, 2019https://github.com/nodejs/node/pull/28370#issuecomment-516273517
Please reload this pagehttps://github.com/nodejs/node/pull/28370
elyalvaradohttps://github.com/elyalvarado
July 30, 2019 16:36https://github.com/nodejs/node/pull/28370#commits-pushed-b8408ac
https://github.com/elyalvarado
https://github.com/Trott
worker: handle calling terminate when kHandler is nullhttps://github.com/nodejs/node/pull/28370/commits/b8408ac2685c8c69940664e9bfe40d6bdcec4a4b
b8408achttps://github.com/nodejs/node/pull/28370/commits/b8408ac2685c8c69940664e9bfe40d6bdcec4a4b
https://github.com/elyalvarado
https://github.com/Trott
worker: make calling terminate always return a promisehttps://github.com/nodejs/node/pull/28370/commits/fd8a6041b105550e46502221bd623b4259f9abaa
fd8a604https://github.com/nodejs/node/pull/28370/commits/fd8a6041b105550e46502221bd623b4259f9abaa
https://github.com/elyalvarado
https://github.com/Trott
worker: always deprecation warning on terminate if callback suppliedhttps://github.com/nodejs/node/pull/28370/commits/0cb0c9c2446642ef1d1cae16e4c03bdce07bccf6
0cb0c9chttps://github.com/nodejs/node/pull/28370/commits/0cb0c9c2446642ef1d1cae16e4c03bdce07bccf6
https://github.com/elyalvarado
https://github.com/Trott
Rename variable for clarityhttps://github.com/nodejs/node/pull/28370/commits/f07fd01df386028a421b00f116c6f508fb1112d1
f07fd01https://github.com/nodejs/node/pull/28370/commits/f07fd01df386028a421b00f116c6f508fb1112d1
https://github.com/elyalvarado
https://github.com/Trott
Rename variable to reduce line lengthhttps://github.com/nodejs/node/pull/28370/commits/3916e593d6b972db37b33c0c610adabede287f65
3916e59https://github.com/nodejs/node/pull/28370/commits/3916e593d6b972db37b33c0c610adabede287f65
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/fd7f67ed36534e597a147e86c87d1482c7e8502b..3916e593d6b972db37b33c0c610adabede287f65
fd7f67ehttps://github.com/nodejs/node/commit/fd7f67ed36534e597a147e86c87d1482c7e8502b
3916e59https://github.com/nodejs/node/commit/3916e593d6b972db37b33c0c610adabede287f65
Compare https://github.com/nodejs/node/compare/fd7f67ed36534e597a147e86c87d1482c7e8502b..3916e593d6b972db37b33c0c610adabede287f65
July 30, 2019 23:38https://github.com/nodejs/node/pull/28370#event-2521560008
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 30, 2019https://github.com/nodejs/node/pull/28370#issuecomment-516635988
Please reload this pagehttps://github.com/nodejs/node/pull/28370
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 30, 2019https://github.com/nodejs/node/pull/28370#issuecomment-516636148
https://ci.nodejs.org/job/node-test-pull-request/24789/https://ci.nodejs.org/job/node-test-pull-request/24789/
Please reload this pagehttps://github.com/nodejs/node/pull/28370
https://github.com/elyalvarado
elyalvaradohttps://github.com/elyalvarado
Jul 31, 2019https://github.com/nodejs/node/pull/28370#issuecomment-516664550
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/28370
Trotthttps://github.com/Trott
Jul 31, 2019 https://github.com/nodejs/node/pull/28370#ref-commit-9083a67
https://github.com/elyalvarado
https://github.com/Trott
worker: handle calling terminate when kHandler is nullhttps://github.com/Trott/io.js/commit/9083a676dd3e01e01cc551993f0b0d7711acbbf1
9083a67https://github.com/Trott/io.js/commit/9083a676dd3e01e01cc551993f0b0d7711acbbf1
nodejs#28370https://github.com/nodejs/node/pull/28370
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 31, 2019https://github.com/nodejs/node/pull/28370#issuecomment-516671303
https://www.nodetodo.org/next-steps/https://www.nodetodo.org/next-steps/
Please reload this pagehttps://github.com/nodejs/node/pull/28370
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 31, 2019https://github.com/nodejs/node/pull/28370#event-2521795774
targoshttps://github.com/targos
Aug 2, 2019 https://github.com/nodejs/node/pull/28370#ref-commit-43acce1
https://github.com/elyalvarado
https://github.com/targos
worker: handle calling terminate when kHandler is nullhttps://github.com/nodejs/node/commit/43acce192509f7a9404ae54e7e15cfb5b7be6491
43acce1https://github.com/nodejs/node/commit/43acce192509f7a9404ae54e7e15cfb5b7be6491
#28370https://github.com/nodejs/node/pull/28370
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Aug 6, 2019 https://github.com/nodejs/node/pull/28370#ref-pullrequest-477378713
v12.8.0 release proposal #29017 https://github.com/nodejs/node/pull/29017
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28370
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/28370/files/fd7f67ed36534e597a147e86c87d1482c7e8502b
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/28370/files/3c4bf936ac0bb03b8208eda5beddaf8391390f6d
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/28370/files/c59a793579dc7bb052600ba6bd3f596b73e23ad3
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/28370/files/3c4bf936ac0bb03b8208eda5beddaf8391390f6d
https://github.com/khriztianmoreno
khriztianmoreno https://github.com/khriztianmoreno
https://github.com/nodejs/node/pull/28370/files/060052190c4ac7c23d9c2b292128b12670e2c31c
https://github.com/TimothyGu
TimothyGu https://github.com/TimothyGu
https://github.com/nodejs/node/pull/28370/files/4222cd91f530145380f35dfb75a0798d8737477f
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
code-and-learn https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn
worker https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aworker
Please reload this pagehttps://github.com/nodejs/node/pull/28370
https://github.com/elyalvarado
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/jasnell
https://github.com/khriztianmoreno
https://github.com/TimothyGu
https://github.com/BridgeAR
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.