| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:7c737ff1-fcf2-ed6e-a24c-8f03430779a5 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8B1A:3AF9A7:3D8E6EE:5523841:6A4F5149 |
| html-safe-nonce | f0b7a29a4aea3423e7933bc61593342ca4fb8c625c1373bd935ffd84d8e0375b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QjFBOjNBRjlBNzozRDhFNkVFOjU1MjM4NDE6NkE0RjUxNDkiLCJ2aXNpdG9yX2lkIjoiNTI3OTA5MDA3MjE5MjI0MTk5MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | b138a07d970f17217b09e886cd4f64bdf4b44936997decd55c72ea918d77f56d |
| hovercard-subject-tag | pull_request:290757934 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28351/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/5341e80167497143c1feec5cafc7c555fca944edec92c8a8011127c3cb7280fd/nodejs/node/pull/28351 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5341e80167497143c1feec5cafc7c555fca944edec92c8a8011127c3cb7280fd/nodejs/node/pull/28351 |
| og:image:alt | This description was fixed. Test are working fine, but the description was not correct
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Angelfire |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4b249b445842943ed31549e027f57a8ade9881ed |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/28351#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28351 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28351 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/28351 |
| Reload | https://github.com/nodejs/node/pull/28351 |
| Reload | https://github.com/nodejs/node/pull/28351 |
| Please reload this page | https://github.com/nodejs/node/pull/28351 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/28351 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
970
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Angelfire | https://github.com/Angelfire |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Angelfire:test-fix-description | https://github.com/Angelfire/node/tree/test-fix-description |
| Conversation | https://github.com/nodejs/node/pull/28351 |
| Commits2 (2) | https://github.com/nodejs/node/pull/28351/commits |
| Checks | https://github.com/nodejs/node/pull/28351/checks |
| Files changed | https://github.com/nodejs/node/pull/28351/files |
| Test fix description | https://github.com/nodejs/node/pull/28351#top |
| Angelfire | https://github.com/Angelfire |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Angelfire:test-fix-description | https://github.com/Angelfire/node/tree/test-fix-description |
|
| https://github.com/Angelfire |
| Angelfire | https://github.com/Angelfire |
| Jun 21, 2019 | https://github.com/nodejs/node/pull/28351#issue-459384714 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/28351 |
| Angelfire | https://github.com/Angelfire |
| June 21, 2019 16:43 | https://github.com/nodejs/node/pull/28351#commits-pushed-0b2acb3 |
|
| https://github.com/Angelfire |
| test: updating description | https://github.com/nodejs/node/pull/28351/commits/0b2acb3970e1b34355569e3c46c9b14e4e7a9780 |
| 0b2acb3 | https://github.com/nodejs/node/pull/28351/commits/0b2acb3970e1b34355569e3c46c9b14e4e7a9780 |
|
| https://github.com/Angelfire |
| test: updating description | https://github.com/nodejs/node/pull/28351/commits/ebb4ccd496afd5c8a92d537eb5d9710d1b9e5c95 |
| ebb4ccd | https://github.com/nodejs/node/pull/28351/commits/ebb4ccd496afd5c8a92d537eb5d9710d1b9e5c95 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Jun 21, 2019 | https://github.com/nodejs/node/pull/28351#event-2431515969 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Jun 21, 2019
| https://github.com/nodejs/node/pull/28351#pullrequestreview-253047770 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28351/files/ebb4ccd496afd5c8a92d537eb5d9710d1b9e5c95 |
| https://github.com/ZYSzys |
| ZYSzys | https://github.com/ZYSzys |
|
Jun 22, 2019
| https://github.com/nodejs/node/pull/28351#pullrequestreview-253092749 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28351/files/ebb4ccd496afd5c8a92d537eb5d9710d1b9e5c95 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Jun 22, 2019
| https://github.com/nodejs/node/pull/28351#pullrequestreview-253099006 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28351/files/ebb4ccd496afd5c8a92d537eb5d9710d1b9e5c95 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Jun 22, 2019
| https://github.com/nodejs/node/pull/28351#pullrequestreview-253102076 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28351/files/ebb4ccd496afd5c8a92d537eb5d9710d1b9e5c95 |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
|
Jun 23, 2019
| https://github.com/nodejs/node/pull/28351#pullrequestreview-253139253 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28351/files/ebb4ccd496afd5c8a92d537eb5d9710d1b9e5c95 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
code-and-learn
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn |
| Jun 23, 2019 | https://github.com/nodejs/node/pull/28351#event-2432580593 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Jun 23, 2019
| https://github.com/nodejs/node/pull/28351#pullrequestreview-253144547 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28351/files/ebb4ccd496afd5c8a92d537eb5d9710d1b9e5c95 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Jul 1, 2019 | https://github.com/nodejs/node/pull/28351#event-2452651664 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28351 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
|
Jul 2, 2019
| https://github.com/nodejs/node/pull/28351#pullrequestreview-256621349 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28351/files/ebb4ccd496afd5c8a92d537eb5d9710d1b9e5c95 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28351 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28351 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 6, 2019 | https://github.com/nodejs/node/pull/28351#issuecomment-508888733 |
| https://ci.nodejs.org/job/node-test-pull-request/24300/ | https://ci.nodejs.org/job/node-test-pull-request/24300/ |
| Please reload this page | https://github.com/nodejs/node/pull/28351 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 30, 2019 | https://github.com/nodejs/node/pull/28351#issuecomment-516253272 |
| https://ci.nodejs.org/job/node-test-pull-request/24763/ | https://ci.nodejs.org/job/node-test-pull-request/24763/ |
| Please reload this page | https://github.com/nodejs/node/pull/28351 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 30, 2019 | https://github.com/nodejs/node/pull/28351#issuecomment-516272579 |
| https://ci.nodejs.org/job/node-test-pull-request/24774/ | https://ci.nodejs.org/job/node-test-pull-request/24774/ |
| Please reload this page | https://github.com/nodejs/node/pull/28351 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jul 30, 2019 | https://github.com/nodejs/node/pull/28351#issuecomment-516418372 |
| https://www.nodetodo.org/next-steps/ | https://www.nodetodo.org/next-steps/ |
| Please reload this page | https://github.com/nodejs/node/pull/28351 |
| Trott | https://github.com/Trott |
|
Jul 30, 2019
| https://github.com/nodejs/node/pull/28351#ref-commit-3d56e89 |
|
| https://github.com/Angelfire |
|
| https://github.com/Trott |
| test: udpate test comment description | https://github.com/Trott/io.js/commit/3d56e89c8a569a1995926ee84dc54b965b751dad |
| 3d56e89 | https://github.com/Trott/io.js/commit/3d56e89c8a569a1995926ee84dc54b965b751dad |
| nodejs#28351 | https://github.com/nodejs/node/pull/28351 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jul 30, 2019 | https://github.com/nodejs/node/pull/28351#event-2519806652 |
| targos | https://github.com/targos |
|
Aug 2, 2019
| https://github.com/nodejs/node/pull/28351#ref-commit-9b47f77 |
|
| https://github.com/Angelfire |
|
| https://github.com/targos |
| test: udpate test comment description | https://github.com/nodejs/node/commit/9b47f77571ba0c418b83c2574f241ffd05a4c651 |
| 9b47f77 | https://github.com/nodejs/node/commit/9b47f77571ba0c418b83c2574f241ffd05a4c651 |
| #28351 | https://github.com/nodejs/node/pull/28351 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Aug 6, 2019
| https://github.com/nodejs/node/pull/28351#ref-pullrequest-477378713 |
|
v12.8.0 release proposal
#29017
| https://github.com/nodejs/node/pull/29017 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28351 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/28351/files/ebb4ccd496afd5c8a92d537eb5d9710d1b9e5c95 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/28351/files/ebb4ccd496afd5c8a92d537eb5d9710d1b9e5c95 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/28351/files/ebb4ccd496afd5c8a92d537eb5d9710d1b9e5c95 |
|
| https://github.com/gengjiawen |
|
gengjiawen
| https://github.com/gengjiawen |
|
| https://github.com/nodejs/node/pull/28351/files/ebb4ccd496afd5c8a92d537eb5d9710d1b9e5c95 |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/28351/files/ebb4ccd496afd5c8a92d537eb5d9710d1b9e5c95 |
|
| https://github.com/trivikr |
|
trivikr
| https://github.com/trivikr |
|
| https://github.com/nodejs/node/pull/28351/files/ebb4ccd496afd5c8a92d537eb5d9710d1b9e5c95 |
|
| https://github.com/ZYSzys |
|
ZYSzys
| https://github.com/ZYSzys |
|
| https://github.com/nodejs/node/pull/28351/files/ebb4ccd496afd5c8a92d537eb5d9710d1b9e5c95 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
code-and-learn
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/28351 |
|
| https://github.com/Angelfire |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/Trott |
|
| https://github.com/jasnell |
|
| https://github.com/addaleax |
|
| https://github.com/gengjiawen |
|
| https://github.com/BridgeAR |
|
| https://github.com/trivikr |
|
| https://github.com/ZYSzys |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |