| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:1903bdbd-1edb-d47e-79b8-8b104d84b2e7 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 96A4:73E1D:50CC66:6C17DC:6A5047D5 |
| html-safe-nonce | 2075d077417deea6e14fea352bcc286b1b72c955ede79e7f71ff2d2bd036cbc4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NkE0OjczRTFEOjUwQ0M2Njo2QzE3REM6NkE1MDQ3RDUiLCJ2aXNpdG9yX2lkIjoiNzA5MDc2NzY3MzQ3NTIyMTQ2MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 6315a2b266d09793353f2a9f21b36e47021d93b0df55f90a9a02086f0d8e5401 |
| hovercard-subject-tag | pull_request:290367119 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28330/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/4b49ca0d3b703fb9e2814d0e4313c4aef59b0e02ec67f93bd78570e2458d73a9/nodejs/node/pull/28330 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/4b49ca0d3b703fb9e2814d0e4313c4aef59b0e02ec67f93bd78570e2458d73a9/nodejs/node/pull/28330 |
| og:image:alt | Experimental APIs should not have an N-API version
specified. Remove cases were one had been added
incorrectly.
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
documentation i... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mhdawson |
| hostname | github.com |
| expected-hostname | github.com |
| None | d6dc8294eb500fa36bbc57472d61fe87c522f9c3c1d64f70f4926f66a66a7efb |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5741a45fe07e5f377d0d4c524a92e3056acc51bb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/28330#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28330 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28330 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/28330 |
| Reload | https://github.com/nodejs/node/pull/28330 |
| Reload | https://github.com/nodejs/node/pull/28330 |
| Please reload this page | https://github.com/nodejs/node/pull/28330 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/28330 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
978
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| mhdawson | https://github.com/mhdawson |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| mhdawson:fixexperimentalInfo | https://github.com/mhdawson/io.js/tree/fixexperimentalInfo |
| Conversation | https://github.com/nodejs/node/pull/28330 |
| Commits1 (1) | https://github.com/nodejs/node/pull/28330/commits |
| Checks | https://github.com/nodejs/node/pull/28330/checks |
| Files changed | https://github.com/nodejs/node/pull/28330/files |
| doc: remove N-API version for Experimental APIs | https://github.com/nodejs/node/pull/28330#top |
| mhdawson | https://github.com/mhdawson |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| mhdawson:fixexperimentalInfo | https://github.com/mhdawson/io.js/tree/fixexperimentalInfo |
|
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Jun 20, 2019 | https://github.com/nodejs/node/pull/28330#issue-458864986 |
| Please reload this page | https://github.com/nodejs/node/pull/28330 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/28330 |
|
| https://github.com/mhdawson |
| doc: remove N-API version for Experimental APIs | https://github.com/nodejs/node/pull/28330/commits/d5dbf2cc801c30437b0c045c4b274b14ed2c3441 |
| d5dbf2c | https://github.com/nodejs/node/pull/28330/commits/d5dbf2cc801c30437b0c045c4b274b14ed2c3441 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
node-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api |
| Jun 20, 2019 | https://github.com/nodejs/node/pull/28330#event-2428547428 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Jun 20, 2019
| https://github.com/nodejs/node/pull/28330#pullrequestreview-252523123 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28330/files/d5dbf2cc801c30437b0c045c4b274b14ed2c3441 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Jun 20, 2019
| https://github.com/nodejs/node/pull/28330#pullrequestreview-252528928 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28330/files/d5dbf2cc801c30437b0c045c4b274b14ed2c3441 |
|
[v8.x] n-api: implement date object
#28301
| https://github.com/nodejs/node/pull/28301 |
|
[v10.x] n-api: implement date object
#28298
| https://github.com/nodejs/node/pull/28298 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Jun 21, 2019
| https://github.com/nodejs/node/pull/28330#pullrequestreview-252923273 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28330/files/d5dbf2cc801c30437b0c045c4b274b14ed2c3441 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Jun 21, 2019
| https://github.com/nodejs/node/pull/28330#pullrequestreview-253005642 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28330/files/d5dbf2cc801c30437b0c045c4b274b14ed2c3441 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Jun 21, 2019
| https://github.com/nodejs/node/pull/28330#pullrequestreview-253024900 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28330/files/d5dbf2cc801c30437b0c045c4b274b14ed2c3441 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Jun 21, 2019 | https://github.com/nodejs/node/pull/28330#event-2431454650 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Jun 22, 2019
| https://github.com/nodejs/node/pull/28330#pullrequestreview-253079081 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28330/files/d5dbf2cc801c30437b0c045c4b274b14ed2c3441 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Jun 22, 2019
| https://github.com/nodejs/node/pull/28330#pullrequestreview-253102443 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28330/files/d5dbf2cc801c30437b0c045c4b274b14ed2c3441 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jun 23, 2019 | https://github.com/nodejs/node/pull/28330#issuecomment-504781167 |
| https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3706/ | https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3706/ |
| Please reload this page | https://github.com/nodejs/node/pull/28330 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Jun 25, 2019 | https://github.com/nodejs/node/pull/28330#issuecomment-505517026 |
| 1b3eac4 | https://github.com/nodejs/node/commit/1b3eac4c7d54170f17df32a01dc345031408183c |
| Please reload this page | https://github.com/nodejs/node/pull/28330 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Jun 25, 2019 | https://github.com/nodejs/node/pull/28330#event-2438162187 |
| addaleax | https://github.com/addaleax |
|
Jun 25, 2019
| https://github.com/nodejs/node/pull/28330#ref-commit-1b3eac4 |
|
| https://github.com/mhdawson |
|
| https://github.com/addaleax |
| doc: remove N-API version for Experimental APIs | https://github.com/nodejs/node/commit/1b3eac4c7d54170f17df32a01dc345031408183c |
| 1b3eac4 | https://github.com/nodejs/node/commit/1b3eac4c7d54170f17df32a01dc345031408183c |
| #28330 | https://github.com/nodejs/node/pull/28330 |
| targos | https://github.com/targos |
|
Jul 2, 2019
| https://github.com/nodejs/node/pull/28330#ref-commit-e55d0ef |
|
| https://github.com/mhdawson |
|
| https://github.com/targos |
| doc: remove N-API version for Experimental APIs | https://github.com/nodejs/node/commit/e55d0efe364f12286dbb45b3a71e94572c4765f4 |
| e55d0ef | https://github.com/nodejs/node/commit/e55d0efe364f12286dbb45b3a71e94572c4765f4 |
| #28330 | https://github.com/nodejs/node/pull/28330 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Jul 2, 2019
| https://github.com/nodejs/node/pull/28330#ref-pullrequest-463146264 |
|
Release v12.6.0 proposal
#28508
| https://github.com/nodejs/node/pull/28508 |
|
2019-07-03 Version 12.6.0 (Current) @targos
beevelop/docker-nodejs#288
| https://github.com/beevelop/docker-nodejs/issues/288 |
|
2019-07-03 Version 12.6.0 (Current) @targos
beevelop/docker-nodejs#289
| https://github.com/beevelop/docker-nodejs/issues/289 |
|
2019-07-03 Version 12.6.0 (Current) @targos
beevelop/docker-nodejs#290
| https://github.com/beevelop/docker-nodejs/issues/290 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| September 30, 2019 13:16 | https://github.com/nodejs/node/pull/28330#event-2673218791 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28330 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/28330/files/d5dbf2cc801c30437b0c045c4b274b14ed2c3441 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/28330/files/d5dbf2cc801c30437b0c045c4b274b14ed2c3441 |
|
| https://github.com/gabrielschulhof |
|
gabrielschulhof
| https://github.com/gabrielschulhof |
|
| https://github.com/nodejs/node/pull/28330/files/d5dbf2cc801c30437b0c045c4b274b14ed2c3441 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/28330/files/d5dbf2cc801c30437b0c045c4b274b14ed2c3441 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/28330/files/d5dbf2cc801c30437b0c045c4b274b14ed2c3441 |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/28330/files/d5dbf2cc801c30437b0c045c4b274b14ed2c3441 |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/28330/files/d5dbf2cc801c30437b0c045c4b274b14ed2c3441 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
node-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api |
| Please reload this page | https://github.com/nodejs/node/pull/28330 |
|
| https://github.com/mhdawson |
|
| https://github.com/Trott |
|
| https://github.com/addaleax |
|
| https://github.com/jasnell |
|
| https://github.com/gabrielschulhof |
|
| https://github.com/lpinca |
|
| https://github.com/cjihrig |
|
| https://github.com/richardlau |
|
| https://github.com/BridgeAR |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |