René's URL Explorer Experiment


Title: child_process: attach child in promisification by cjihrig · Pull Request #28325 · nodejs/node · GitHub

Open Graph Title: child_process: attach child in promisification by cjihrig · Pull Request #28325 · nodejs/node

X Title: child_process: attach child in promisification by cjihrig · Pull Request #28325 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This commit updates the custom exec() and execFile() promisification to attach the ChildProcess instance to the returned Promise. Fixes: #28244 Checklist make -j4 test (UNIX), or vcbuild test (Wi...

X Description: This commit updates the custom exec() and execFile() promisification to attach the ChildProcess instance to the returned Promise. Fixes: #28244 Checklist make -j4 test (UNIX), or vcbuild test (Wi...

Opengraph URL: https://github.com/nodejs/node/pull/28325

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:4c42782a-0f33-78f9-fb96-d267bcabb5fd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA9FC:F5E51:A86DA29:ABD6388:6A50B173
html-safe-nonce771b9228bc0ab0e37cd384e2986e40fb7a9acee0b4a8579be01b82e18b85021c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOUZDOkY1RTUxOkE4NkRBMjk6QUJENjM4ODo2QTUwQjE3MyIsInZpc2l0b3JfaWQiOiI0OTg1NDUyNjE2MTcyNzg1OSIsInJlZ2lvbl9lZGdlIjoic2VhIiwicmVnaW9uX3JlbmRlciI6InNlYSJ9
visitor-hmac65cff818876f54d308c5603c0040d614d5695c2724c18b233808bead4800375e
hovercard-subject-tagpull_request:290286357
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28325/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/94128bd61eb65620a99f562bdceb61c2a1c7b3aaaadf544c2e5ccd6cdb9dd25d/nodejs/node/pull/28325
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/94128bd61eb65620a99f562bdceb61c2a1c7b3aaaadf544c2e5ccd6cdb9dd25d/nodejs/node/pull/28325
og:image:altThis commit updates the custom exec() and execFile() promisification to attach the ChildProcess instance to the returned Promise. Fixes: #28244 Checklist make -j4 test (UNIX), or vcbuild test (Wi...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecjihrig
hostnamegithub.com
expected-hostnamegithub.com
Noned6dc8294eb500fa36bbc57472d61fe87c522f9c3c1d64f70f4926f66a66a7efb
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7ac0ad2f2c7e4b9056617355fd9e33e22b0c8df9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/28325#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28325
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28325
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/28325
Reloadhttps://github.com/nodejs/node/pull/28325
Reloadhttps://github.com/nodejs/node/pull/28325
Please reload this pagehttps://github.com/nodejs/node/pull/28325
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/28325
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.1k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 979 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:cp-promhttps://github.com/cjihrig/node/tree/cp-prom
Conversationhttps://github.com/nodejs/node/pull/28325
Commits1 (1)https://github.com/nodejs/node/pull/28325/commits
Checkshttps://github.com/nodejs/node/pull/28325/checks
Files changedhttps://github.com/nodejs/node/pull/28325/files
child_process: attach child in promisificationhttps://github.com/nodejs/node/pull/28325#top
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:cp-promhttps://github.com/cjihrig/node/tree/cp-prom
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jun 20, 2019https://github.com/nodejs/node/pull/28325#issue-458751495
#28244https://github.com/nodejs/node/issues/28244
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/28325
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
child_process https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Achild_process
Jun 20, 2019https://github.com/nodejs/node/pull/28325#event-2427935072
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jun 20, 2019 https://github.com/nodejs/node/pull/28325#pullrequestreview-252481265
View reviewed changes https://github.com/nodejs/node/pull/28325/files
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 21, 2019https://github.com/nodejs/node/pull/28325#issuecomment-504485804
https://ci.nodejs.org/job/node-test-pull-request/24042/https://ci.nodejs.org/job/node-test-pull-request/24042/
Please reload this pagehttps://github.com/nodejs/node/pull/28325
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 21, 2019https://github.com/nodejs/node/pull/28325#issuecomment-504501901
https://ci.nodejs.org/job/node-test-pull-request/24043/https://ci.nodejs.org/job/node-test-pull-request/24043/
Please reload this pagehttps://github.com/nodejs/node/pull/28325
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 21, 2019https://github.com/nodejs/node/pull/28325#issuecomment-504530108
Please reload this pagehttps://github.com/nodejs/node/pull/28325
https://ci.nodejs.org/job/node-test-pull-request/24044/https://ci.nodejs.org/job/node-test-pull-request/24044/
Please reload this pagehttps://github.com/nodejs/node/pull/28325
https://github.com/Trott
Trotthttps://github.com/Trott
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jun 21, 2019https://github.com/nodejs/node/pull/28325#event-2431534740
https://github.com/geek
geekhttps://github.com/geek
Jun 22, 2019 https://github.com/nodejs/node/pull/28325#pullrequestreview-253101717
View reviewed changes https://github.com/nodejs/node/pull/28325/files
https://github.com/cjihrig
child_process: attach child in promisificationhttps://github.com/nodejs/node/pull/28325/commits/3aeb810ca6e2230ae53f7196abd013ec56b94aa8
3aeb810https://github.com/nodejs/node/pull/28325/commits/3aeb810ca6e2230ae53f7196abd013ec56b94aa8
nodejs#28325https://github.com/nodejs/node/pull/28325
nodejs#28244https://github.com/nodejs/node/issues/28244
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/c289d29e70219cf922e2003e95faab3c17351605..3aeb810ca6e2230ae53f7196abd013ec56b94aa8
c289d29https://github.com/nodejs/node/commit/c289d29e70219cf922e2003e95faab3c17351605
3aeb810https://github.com/nodejs/node/commit/3aeb810ca6e2230ae53f7196abd013ec56b94aa8
Compare https://github.com/nodejs/node/compare/c289d29e70219cf922e2003e95faab3c17351605..3aeb810ca6e2230ae53f7196abd013ec56b94aa8
June 22, 2019 17:18https://github.com/nodejs/node/pull/28325#event-2432062974
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
3aeb810https://github.com/nodejs/node/commit/3aeb810ca6e2230ae53f7196abd013ec56b94aa8
Jun 22, 2019https://github.com/nodejs/node/pull/28325#event-2432063557
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
June 22, 2019 17:20https://github.com/nodejs/node/pull/28325#event-2432063711
targoshttps://github.com/targos
Jul 2, 2019 https://github.com/nodejs/node/pull/28325#ref-commit-dd5e07f
https://github.com/cjihrig
https://github.com/targos
child_process: attach child in promisificationhttps://github.com/nodejs/node/commit/dd5e07f9b4447f21919aea4688df757225935a21
dd5e07fhttps://github.com/nodejs/node/commit/dd5e07f9b4447f21919aea4688df757225935a21
#28325https://github.com/nodejs/node/pull/28325
#28244https://github.com/nodejs/node/issues/28244
targoshttps://github.com/targos
Jul 2, 2019 https://github.com/nodejs/node/pull/28325#ref-commit-d711542
https://github.com/targos
2019-07-03, Version 12.6.0 (Current)https://github.com/nodejs/node/commit/d711542f65df9a087d21f868305011ff8118c586
d711542https://github.com/nodejs/node/commit/d711542f65df9a087d21f868305011ff8118c586
#27992https://github.com/nodejs/node/pull/27992
#28325https://github.com/nodejs/node/pull/28325
#28449https://github.com/nodejs/node/pull/28449
#28018https://github.com/nodejs/node/pull/28018
#28490https://github.com/nodejs/node/pull/28490
#28007https://github.com/nodejs/node/pull/28007
#28153https://github.com/nodejs/node/pull/28153
#28508https://github.com/nodejs/node/pull/28508
https://github.com/targos
targoshttps://github.com/targos
Jul 2, 2019 https://github.com/nodejs/node/pull/28325#ref-pullrequest-463146264
Release v12.6.0 proposal #28508 https://github.com/nodejs/node/pull/28508
targoshttps://github.com/targos
Jul 2, 2019 https://github.com/nodejs/node/pull/28325#ref-commit-e6a8ac1
https://github.com/targos
2019-07-03, Version 12.6.0 (Current)https://github.com/nodejs/node/commit/e6a8ac12407b92557984cd1bbce7af97fa656f40
e6a8ac1https://github.com/nodejs/node/commit/e6a8ac12407b92557984cd1bbce7af97fa656f40
#27992https://github.com/nodejs/node/pull/27992
#28325https://github.com/nodejs/node/pull/28325
#28449https://github.com/nodejs/node/pull/28449
#28018https://github.com/nodejs/node/pull/28018
#28490https://github.com/nodejs/node/pull/28490
#28007https://github.com/nodejs/node/pull/28007
#28153https://github.com/nodejs/node/pull/28153
https://github.com/gengjiawenhttps://github.com/gengjiawen
#28322https://github.com/nodejs/node/pull/28322
#28508https://github.com/nodejs/node/pull/28508
targoshttps://github.com/targos
Jul 2, 2019 https://github.com/nodejs/node/pull/28325#ref-commit-e71a0f4
https://github.com/targos
2019-07-03, Version 12.6.0 (Current)https://github.com/nodejs/node/commit/e71a0f4d5faa4ad77887fbb3fff0ddb7bca6942e
e71a0f4https://github.com/nodejs/node/commit/e71a0f4d5faa4ad77887fbb3fff0ddb7bca6942e
#27992https://github.com/nodejs/node/pull/27992
#28325https://github.com/nodejs/node/pull/28325
#28449https://github.com/nodejs/node/pull/28449
#28511https://github.com/nodejs/node/pull/28511
#28018https://github.com/nodejs/node/pull/28018
#28490https://github.com/nodejs/node/pull/28490
#28007https://github.com/nodejs/node/pull/28007
#28153https://github.com/nodejs/node/pull/28153
https://github.com/gengjiawenhttps://github.com/gengjiawen
#28322https://github.com/nodejs/node/pull/28322
#28508https://github.com/nodejs/node/pull/28508
targoshttps://github.com/targos
Jul 3, 2019 https://github.com/nodejs/node/pull/28325#ref-commit-fcf8fe9
https://github.com/targos
2019-07-03, Version 12.6.0 (Current)https://github.com/nodejs/node/commit/fcf8fe9f1a556758eb9faf86bf74de2ddda805c8
fcf8fe9https://github.com/nodejs/node/commit/fcf8fe9f1a556758eb9faf86bf74de2ddda805c8
#27992https://github.com/nodejs/node/pull/27992
#28325https://github.com/nodejs/node/pull/28325
#28449https://github.com/nodejs/node/pull/28449
#28511https://github.com/nodejs/node/pull/28511
#28018https://github.com/nodejs/node/pull/28018
#28490https://github.com/nodejs/node/pull/28490
#28007https://github.com/nodejs/node/pull/28007
#28153https://github.com/nodejs/node/pull/28153
https://github.com/gengjiawenhttps://github.com/gengjiawen
#28322https://github.com/nodejs/node/pull/28322
#28508https://github.com/nodejs/node/pull/28508
2019-07-03 Version 12.6.0 (Current) @targos beevelop/docker-nodejs#288 https://github.com/beevelop/docker-nodejs/issues/288
2019-07-03 Version 12.6.0 (Current) @targos beevelop/docker-nodejs#289 https://github.com/beevelop/docker-nodejs/issues/289
2019-07-03 Version 12.6.0 (Current) @targos beevelop/docker-nodejs#290 https://github.com/beevelop/docker-nodejs/issues/290
https://github.com/Hakerh400
Hakerh400https://github.com/Hakerh400
Jul 4, 2019 https://github.com/nodejs/node/pull/28325#ref-pullrequest-464048113
util: attach return value to promisified functions #28529 https://github.com/nodejs/node/pull/28529
https://github.com/binarybaron
binarybaronhttps://github.com/binarybaron
Jan 17, 2022 https://github.com/nodejs/node/pull/28325#ref-pullrequest-1105930075
Use the promise version of execFile sindresorhus/ps-list#50 https://github.com/sindresorhus/ps-list/pull/50
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28325
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/28325/files/c289d29e70219cf922e2003e95faab3c17351605
https://github.com/geek
geek https://github.com/geek
https://github.com/nodejs/node/pull/28325/files/c289d29e70219cf922e2003e95faab3c17351605
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
child_process https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Achild_process
Get the child from promisified childProcess.execFile https://github.com/nodejs/node/issues/28244
Please reload this pagehttps://github.com/nodejs/node/pull/28325
https://github.com/cjihrig
https://github.com/nodejs-github-bot
https://github.com/geek
https://github.com/lpinca
https://github.com/Trott
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.