René's URL Explorer Experiment


Title: domain: use strong reference to domain while active by addaleax · Pull Request #28313 · nodejs/node · GitHub

Open Graph Title: domain: use strong reference to domain while active by addaleax · Pull Request #28313 · nodejs/node

X Title: domain: use strong reference to domain while active by addaleax · Pull Request #28313 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: When an uncaught exception is thrown inside a domain, the domain is removed from the stack as of 43a5170. This means that it might not be kept alive as an object anymore, and may be garbage collect...

X Description: When an uncaught exception is thrown inside a domain, the domain is removed from the stack as of 43a5170. This means that it might not be kept alive as an object anymore, and may be garbage collect...

Opengraph URL: https://github.com/nodejs/node/pull/28313

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:be9082e0-45d4-fa9c-98c4-d888d853f7bf
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA8C6:90996:1705484:212BFD3:6A4F7249
html-safe-nonce3e1c66261b51a9f5daa1e3c910f07fc32c460cfa1d3f022c2611ab40d5929975
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOEM2OjkwOTk2OjE3MDU0ODQ6MjEyQkZEMzo2QTRGNzI0OSIsInZpc2l0b3JfaWQiOiI4MTUxOTkwMTIzMDczODYwMTY5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacc4deb5a72d1d264fd9b51843279abc42a809e9b37af4056c38fa10aa9c23f24a
hovercard-subject-tagpull_request:289941881
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28313/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/64574597f67b7dd85bd825e2f7b0c5822c038a8a9751ddda1f15953adc3bcec0/nodejs/node/pull/28313
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/64574597f67b7dd85bd825e2f7b0c5822c038a8a9751ddda1f15953adc3bcec0/nodejs/node/pull/28313
og:image:altWhen an uncaught exception is thrown inside a domain, the domain is removed from the stack as of 43a5170. This means that it might not be kept alive as an object anymore, and may be garbage collect...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/28313#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28313
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28313
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/28313
Reloadhttps://github.com/nodejs/node/pull/28313
Reloadhttps://github.com/nodejs/node/pull/28313
Please reload this pagehttps://github.com/nodejs/node/pull/28313
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/28313
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 973 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:domain-strong-referencehttps://github.com/addaleax/node/tree/domain-strong-reference
Conversationhttps://github.com/nodejs/node/pull/28313
Commits1 (1)https://github.com/nodejs/node/pull/28313/commits
Checkshttps://github.com/nodejs/node/pull/28313/checks
Files changedhttps://github.com/nodejs/node/pull/28313/files
domain: use strong reference to domain while activehttps://github.com/nodejs/node/pull/28313#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:domain-strong-referencehttps://github.com/addaleax/node/tree/domain-strong-reference
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 20, 2019https://github.com/nodejs/node/pull/28313#issue-458305302
43a5170https://github.com/nodejs/node/commit/43a51708589ac789ce08beaeb49d6d778dfbdc49
#28275https://github.com/nodejs/node/issues/28275
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/28313
https://github.com/addaleax
domain: use strong reference to domain while activehttps://github.com/nodejs/node/pull/28313/commits/302fc52c40ef8bb2c321e5c954faa9e292551e93
302fc52https://github.com/nodejs/node/pull/28313/commits/302fc52c40ef8bb2c321e5c954faa9e292551e93
43a5170https://github.com/addaleax/node/commit/43a51708589ac789ce08beaeb49d6d778dfbdc49
nodejs#28275https://github.com/nodejs/node/issues/28275
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
domain https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adomain
util https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Autil
Jun 20, 2019https://github.com/nodejs/node/pull/28313#event-2426010314
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jun 20, 2019 https://github.com/nodejs/node/pull/28313#pullrequestreview-252145497
View reviewed changes https://github.com/nodejs/node/pull/28313/files/302fc52c40ef8bb2c321e5c954faa9e292551e93
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28313
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28313
https://github.com/vdeturckheim
vdeturckheimhttps://github.com/vdeturckheim
Jun 21, 2019 https://github.com/nodejs/node/pull/28313#pullrequestreview-252988040
View reviewed changes https://github.com/nodejs/node/pull/28313/files/302fc52c40ef8bb2c321e5c954faa9e292551e93
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 22, 2019 https://github.com/nodejs/node/pull/28313#pullrequestreview-253079120
View reviewed changes https://github.com/nodejs/node/pull/28313/files/302fc52c40ef8bb2c321e5c954faa9e292551e93
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jul 1, 2019https://github.com/nodejs/node/pull/28313#event-2452606108
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28313
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 3, 2019https://github.com/nodejs/node/pull/28313#issuecomment-508235865
https://ci.nodejs.org/job/node-test-pull-request/24250/https://ci.nodejs.org/job/node-test-pull-request/24250/
Please reload this pagehttps://github.com/nodejs/node/pull/28313
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 6, 2019https://github.com/nodejs/node/pull/28313#issuecomment-508895010
https://ci.nodejs.org/job/node-test-pull-request/24303/https://ci.nodejs.org/job/node-test-pull-request/24303/
Please reload this pagehttps://github.com/nodejs/node/pull/28313
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 14, 2019https://github.com/nodejs/node/pull/28313#issuecomment-511233768
https://ci.nodejs.org/job/node-test-pull-request/24430/https://ci.nodejs.org/job/node-test-pull-request/24430/
Please reload this pagehttps://github.com/nodejs/node/pull/28313
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 14, 2019https://github.com/nodejs/node/pull/28313#issuecomment-511236921
https://ci.nodejs.org/job/node-test-pull-request/24433/https://ci.nodejs.org/job/node-test-pull-request/24433/
Please reload this pagehttps://github.com/nodejs/node/pull/28313
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 14, 2019https://github.com/nodejs/node/pull/28313#issuecomment-511239488
https://ci.nodejs.org/job/node-test-pull-request/24436/https://ci.nodejs.org/job/node-test-pull-request/24436/
Please reload this pagehttps://github.com/nodejs/node/pull/28313
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 24, 2019https://github.com/nodejs/node/pull/28313#issuecomment-514823076
Please reload this pagehttps://github.com/nodejs/node/pull/28313
https://ci.nodejs.org/job/node-test-pull-request/24672/https://ci.nodejs.org/job/node-test-pull-request/24672/
Please reload this pagehttps://github.com/nodejs/node/pull/28313
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 25, 2019https://github.com/nodejs/node/pull/28313#issuecomment-514883059
43e5478https://github.com/nodejs/node/commit/43e5478e2f51343b66f4d243bb4800d8e422f764
Please reload this pagehttps://github.com/nodejs/node/pull/28313
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 25, 2019https://github.com/nodejs/node/pull/28313#event-2508220552
Trotthttps://github.com/Trott
Jul 25, 2019 https://github.com/nodejs/node/pull/28313#ref-commit-43e5478
https://github.com/addaleax
https://github.com/Trott
domain: use strong reference to domain while activehttps://github.com/Trott/io.js/commit/43e5478e2f51343b66f4d243bb4800d8e422f764
43e5478https://github.com/Trott/io.js/commit/43e5478e2f51343b66f4d243bb4800d8e422f764
43a5170https://github.com/Trott/io.js/commit/43a51708589ac789ce08beaeb49d6d778dfbdc49
nodejs#28275https://github.com/nodejs/node/issues/28275
nodejs#28313https://github.com/nodejs/node/pull/28313
gntemhttps://github.com/gntem
Jul 27, 2019 https://github.com/nodejs/node/pull/28313#ref-commit-d1bbdda
https://github.com/addaleax
https://github.com/gntem
domain: use strong reference to domain while activehttps://github.com/gntem/node/commit/d1bbddabd8e8de7af636eeda6ee0beb921b95f35
d1bbddahttps://github.com/gntem/node/commit/d1bbddabd8e8de7af636eeda6ee0beb921b95f35
43a5170https://github.com/gntem/node/commit/43a51708589ac789ce08beaeb49d6d778dfbdc49
nodejs#28275https://github.com/nodejs/node/issues/28275
nodejs#28313https://github.com/nodejs/node/pull/28313
targoshttps://github.com/targos
Aug 2, 2019 https://github.com/nodejs/node/pull/28313#ref-commit-727ffe4
https://github.com/addaleax
https://github.com/targos
domain: use strong reference to domain while activehttps://github.com/nodejs/node/commit/727ffe472068be1093a3f2d9f7f1238852166ac0
727ffe4https://github.com/nodejs/node/commit/727ffe472068be1093a3f2d9f7f1238852166ac0
43a5170https://github.com/nodejs/node/commit/43a51708589ac789ce08beaeb49d6d778dfbdc49
#28275https://github.com/nodejs/node/issues/28275
#28313https://github.com/nodejs/node/pull/28313
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Aug 6, 2019 https://github.com/nodejs/node/pull/28313#ref-pullrequest-477378713
v12.8.0 release proposal #29017 https://github.com/nodejs/node/pull/29017
vikashk1https://github.com/vikashk1
Aug 13, 2019 https://github.com/nodejs/node/pull/28313#ref-commit-9af17ad
https://github.com/vikashk1
Please ignore this msg (https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc
#1https://github.com/vikashk1/node/pull/1
)https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc
9af17adhttps://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Aug 23, 2019 https://github.com/nodejs/node/pull/28313#ref-pullrequest-398516795
process: improve nextTick performance #25461 https://github.com/nodejs/node/pull/25461
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28313
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/28313/files/302fc52c40ef8bb2c321e5c954faa9e292551e93
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/28313/files/302fc52c40ef8bb2c321e5c954faa9e292551e93
https://github.com/vdeturckheim
vdeturckheim https://github.com/vdeturckheim
https://github.com/nodejs/node/pull/28313/files/302fc52c40ef8bb2c321e5c954faa9e292551e93
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
domain https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adomain
util https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Autil
parallel/test-domain-error-types can crash if GC timings get unlucky https://github.com/nodejs/node/issues/28275
Please reload this pagehttps://github.com/nodejs/node/pull/28313
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/bnoordhuis
https://github.com/vdeturckheim
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.