René's URL Explorer Experiment


Title: [v10.x] n-api: implement date object by gabrielschulhof · Pull Request #28298 · nodejs/node · GitHub

Open Graph Title: [v10.x] n-api: implement date object by gabrielschulhof · Pull Request #28298 · nodejs/node

X Title: [v10.x] n-api: implement date object by gabrielschulhof · Pull Request #28298 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Implements napi_create_date() as well as napi_is_date() to allow working with JavaScript Date objects. PR-URL: #25917 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and...

X Description: Implements napi_create_date() as well as napi_is_date() to allow working with JavaScript Date objects. PR-URL: #25917 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and...

Opengraph URL: https://github.com/nodejs/node/pull/28298

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d21e13e2-a944-9e24-ad3a-40e800066f16
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAC8E:2373EB:3C7322E:554EC8A:6A4FA2B5
html-safe-nonce4998b0038eee3db88cac6a8ae14641ca356fbae5331ac22eb6d4b6fe4fe276b9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQzhFOjIzNzNFQjozQzczMjJFOjU1NEVDOEE6NkE0RkEyQjUiLCJ2aXNpdG9yX2lkIjoiMzgyMjcyNjUwODE5Mjk2NTMwMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4fc62964e5a92529ad9bdd014ae956753a472c5550a82d75ac6f544700532184
hovercard-subject-tagpull_request:289864314
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28298/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/50b34a67845f5568678bcc7fd00c216275a96455c6b07036d068e7bae224ad32/nodejs/node/pull/28298
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/50b34a67845f5568678bcc7fd00c216275a96455c6b07036d068e7bae224ad32/nodejs/node/pull/28298
og:image:altImplements napi_create_date() as well as napi_is_date() to allow working with JavaScript Date objects. PR-URL: #25917 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegabrielschulhof
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/28298#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28298
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28298
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/28298
Reloadhttps://github.com/nodejs/node/pull/28298
Reloadhttps://github.com/nodejs/node/pull/28298
Please reload this pagehttps://github.com/nodejs/node/pull/28298
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/28298
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 972 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
gabrielschulhofhttps://github.com/gabrielschulhof
nodejs:v10.x-staginghttps://github.com/nodejs/node/tree/v10.x-staging
gabrielschulhof:backport-25917-to-v10.xhttps://github.com/gabrielschulhof/node/tree/backport-25917-to-v10.x
Conversationhttps://github.com/nodejs/node/pull/28298
Commits1 (1)https://github.com/nodejs/node/pull/28298/commits
Checkshttps://github.com/nodejs/node/pull/28298/checks
Files changedhttps://github.com/nodejs/node/pull/28298/files
[v10.x] n-api: implement date objecthttps://github.com/nodejs/node/pull/28298#top
gabrielschulhofhttps://github.com/gabrielschulhof
nodejs:v10.x-staginghttps://github.com/nodejs/node/tree/v10.x-staging
gabrielschulhof:backport-25917-to-v10.xhttps://github.com/gabrielschulhof/node/tree/backport-25917-to-v10.x
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Jun 19, 2019https://github.com/nodejs/node/pull/28298#issue-458208609
#25917https://github.com/nodejs/node/pull/25917
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/28298
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av10.x
Jun 19, 2019https://github.com/nodejs/node/pull/28298#event-2425397765
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
Jun 19, 2019https://github.com/nodejs/node/pull/28298#event-2425456431
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jun 20, 2019 https://github.com/nodejs/node/pull/28298#pullrequestreview-252529912
View reviewed changes https://github.com/nodejs/node/pull/28298/files
doc/api/n-api.mdhttps://github.com/nodejs/node/pull/28298/files#diff-26709ee1f9f0cb60d2d67f45106b31de8ed5eb28ad66c91903fd935a6d607d4d
richardlauhttps://github.com/richardlau
Jun 20, 2019https://github.com/nodejs/node/pull/28298#discussion_r295989599
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#28330https://github.com/nodejs/node/pull/28330
Please reload this pagehttps://github.com/nodejs/node/pull/28298
gabrielschulhofhttps://github.com/gabrielschulhof
Jun 21, 2019https://github.com/nodejs/node/pull/28298#discussion_r296065154
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@richardlauhttps://github.com/richardlau
Please reload this pagehttps://github.com/nodejs/node/pull/28298
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
force-pushedhttps://github.com/nodejs/node/compare/f0293524f7b2d9c32db2ed7effd4ebc815387864..440570a87a63450127b5e079e8ddc44cf4421f8a
f029352https://github.com/nodejs/node/commit/f0293524f7b2d9c32db2ed7effd4ebc815387864
440570ahttps://github.com/nodejs/node/commit/440570a87a63450127b5e079e8ddc44cf4421f8a
Compare https://github.com/nodejs/node/compare/f0293524f7b2d9c32db2ed7effd4ebc815387864..440570a87a63450127b5e079e8ddc44cf4421f8a
June 25, 2019 19:28https://github.com/nodejs/node/pull/28298#event-2438682358
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Jul 8, 2019 https://github.com/nodejs/node/pull/28298#ref-issue-451609284
What should go into N-API 5? nodejs/abi-stable-node#374 https://github.com/nodejs/abi-stable-node/issues/374
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 16, 2019https://github.com/nodejs/node/pull/28298#issuecomment-511854772
https://ci.nodejs.org/job/node-test-pull-request/24500/https://ci.nodejs.org/job/node-test-pull-request/24500/
Please reload this pagehttps://github.com/nodejs/node/pull/28298
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
force-pushedhttps://github.com/nodejs/node/compare/c940dc09c69ee23f9782e49d12658a4c5180c956..35be08a16fae3e4135dc04b24c5d03a8db869a34
c940dc0https://github.com/nodejs/node/commit/c940dc09c69ee23f9782e49d12658a4c5180c956
35be08ahttps://github.com/nodejs/node/commit/35be08a16fae3e4135dc04b24c5d03a8db869a34
Compare https://github.com/nodejs/node/compare/c940dc09c69ee23f9782e49d12658a4c5180c956..35be08a16fae3e4135dc04b24c5d03a8db869a34
July 17, 2019 09:49https://github.com/nodejs/node/pull/28298#event-2488844777
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jul 17, 2019https://github.com/nodejs/node/pull/28298#issuecomment-512285860
@BethGriggshttps://github.com/BethGriggs
Please reload this pagehttps://github.com/nodejs/node/pull/28298
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
backported-to-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v10.x
backported-to-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v10.x
Jul 17, 2019https://github.com/nodejs/node/pull/28298#event-2489690056
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jul 17, 2019https://github.com/nodejs/node/pull/28298#issuecomment-512287200
@BethGriggshttps://github.com/BethGriggs
Please reload this pagehttps://github.com/nodejs/node/pull/28298
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Jul 17, 2019https://github.com/nodejs/node/pull/28298#issuecomment-512288840
@mhdawsonhttps://github.com/mhdawson
Please reload this pagehttps://github.com/nodejs/node/pull/28298
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 17, 2019https://github.com/nodejs/node/pull/28298#issuecomment-512289254
https://ci.nodejs.org/job/node-test-pull-request/24512/https://ci.nodejs.org/job/node-test-pull-request/24512/
Please reload this pagehttps://github.com/nodejs/node/pull/28298
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Jul 17, 2019 https://github.com/nodejs/node/pull/28298#ref-pullrequest-456468991
adds experimental napi_date nodejs/node-addon-api#497 https://github.com/nodejs/node-addon-api/pull/497
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 23, 2019https://github.com/nodejs/node/pull/28298#issuecomment-514262156
https://ci.nodejs.org/job/node-test-pull-request/24630/https://ci.nodejs.org/job/node-test-pull-request/24630/
Please reload this pagehttps://github.com/nodejs/node/pull/28298
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jul 23, 2019https://github.com/nodejs/node/pull/28298#issuecomment-514393402
@BethGriggshttps://github.com/BethGriggs
Please reload this pagehttps://github.com/nodejs/node/pull/28298
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 25, 2019https://github.com/nodejs/node/pull/28298#issuecomment-515237557
https://ci.nodejs.org/job/node-test-pull-request/24702/https://ci.nodejs.org/job/node-test-pull-request/24702/
Please reload this pagehttps://github.com/nodejs/node/pull/28298
https://github.com/jarrodconnolly
n-api: implement date objecthttps://github.com/nodejs/node/pull/28298/commits/ce01f2f3fb032fc7564706180d587b54dbf56454
ce01f2fhttps://github.com/nodejs/node/pull/28298/commits/ce01f2f3fb032fc7564706180d587b54dbf56454
nodejs#25917https://github.com/nodejs/node/pull/25917
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
force-pushedhttps://github.com/nodejs/node/compare/440570a87a63450127b5e079e8ddc44cf4421f8a..ce01f2f3fb032fc7564706180d587b54dbf56454
440570ahttps://github.com/nodejs/node/commit/440570a87a63450127b5e079e8ddc44cf4421f8a
ce01f2fhttps://github.com/nodejs/node/commit/ce01f2f3fb032fc7564706180d587b54dbf56454
Compare https://github.com/nodejs/node/compare/440570a87a63450127b5e079e8ddc44cf4421f8a..ce01f2f3fb032fc7564706180d587b54dbf56454
September 2, 2019 06:32https://github.com/nodejs/node/pull/28298#event-2600054039
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Sep 2, 2019https://github.com/nodejs/node/pull/28298#issuecomment-527023183
Please reload this pagehttps://github.com/nodejs/node/pull/28298
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Sep 3, 2019 https://github.com/nodejs/node/pull/28298#pullrequestreview-283099388
View reviewed changes https://github.com/nodejs/node/pull/28298/files/ce01f2f3fb032fc7564706180d587b54dbf56454
BethGriggshttps://github.com/BethGriggs
Sep 3, 2019 https://github.com/nodejs/node/pull/28298#ref-commit-4f41e4f
https://github.com/jarrodconnolly
https://github.com/BethGriggs
n-api: implement date objecthttps://github.com/nodejs/node/commit/4f41e4f471180e9b86c92e51814b9aa7c5fe00dc
4f41e4fhttps://github.com/nodejs/node/commit/4f41e4f471180e9b86c92e51814b9aa7c5fe00dc
#28298https://github.com/nodejs/node/pull/28298
#25917https://github.com/nodejs/node/pull/25917
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Sep 3, 2019https://github.com/nodejs/node/pull/28298#issuecomment-527535883
Please reload this pagehttps://github.com/nodejs/node/pull/28298
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Sep 3, 2019https://github.com/nodejs/node/pull/28298#event-2604214937
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
March 13, 2020 06:47https://github.com/nodejs/node/pull/28298#event-3125582945
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28298
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/28298/files/440570a87a63450127b5e079e8ddc44cf4421f8a
https://github.com/BethGriggs
BethGriggs https://github.com/BethGriggs
https://github.com/nodejs/node/pull/28298/files/ce01f2f3fb032fc7564706180d587b54dbf56454
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
Please reload this pagehttps://github.com/nodejs/node/pull/28298
https://github.com/gabrielschulhof
https://github.com/nodejs-github-bot
https://github.com/mhdawson
https://github.com/BethGriggs
https://github.com/richardlau
https://github.com/jarrodconnolly
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.