| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:d21e13e2-a944-9e24-ad3a-40e800066f16 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AC8E:2373EB:3C7322E:554EC8A:6A4FA2B5 |
| html-safe-nonce | 4998b0038eee3db88cac6a8ae14641ca356fbae5331ac22eb6d4b6fe4fe276b9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQzhFOjIzNzNFQjozQzczMjJFOjU1NEVDOEE6NkE0RkEyQjUiLCJ2aXNpdG9yX2lkIjoiMzgyMjcyNjUwODE5Mjk2NTMwMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 4fc62964e5a92529ad9bdd014ae956753a472c5550a82d75ac6f544700532184 |
| hovercard-subject-tag | pull_request:289864314 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28298/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/50b34a67845f5568678bcc7fd00c216275a96455c6b07036d068e7bae224ad32/nodejs/node/pull/28298 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/50b34a67845f5568678bcc7fd00c216275a96455c6b07036d068e7bae224ad32/nodejs/node/pull/28298 |
| og:image:alt | Implements napi_create_date() as well as napi_is_date() to
allow working with JavaScript Date objects.
PR-URL: #25917
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gabrielschulhof |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4b249b445842943ed31549e027f57a8ade9881ed |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/28298#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28298 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28298 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/28298 |
| Reload | https://github.com/nodejs/node/pull/28298 |
| Reload | https://github.com/nodejs/node/pull/28298 |
| Please reload this page | https://github.com/nodejs/node/pull/28298 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/28298 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
972
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| gabrielschulhof | https://github.com/gabrielschulhof |
| nodejs:v10.x-staging | https://github.com/nodejs/node/tree/v10.x-staging |
| gabrielschulhof:backport-25917-to-v10.x | https://github.com/gabrielschulhof/node/tree/backport-25917-to-v10.x |
| Conversation | https://github.com/nodejs/node/pull/28298 |
| Commits1 (1) | https://github.com/nodejs/node/pull/28298/commits |
| Checks | https://github.com/nodejs/node/pull/28298/checks |
| Files changed | https://github.com/nodejs/node/pull/28298/files |
| [v10.x] n-api: implement date object | https://github.com/nodejs/node/pull/28298#top |
| gabrielschulhof | https://github.com/gabrielschulhof |
| nodejs:v10.x-staging | https://github.com/nodejs/node/tree/v10.x-staging |
| gabrielschulhof:backport-25917-to-v10.x | https://github.com/gabrielschulhof/node/tree/backport-25917-to-v10.x |
|
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Jun 19, 2019 | https://github.com/nodejs/node/pull/28298#issue-458208609 |
| #25917 | https://github.com/nodejs/node/pull/25917 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/28298 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av10.x |
| Jun 19, 2019 | https://github.com/nodejs/node/pull/28298#event-2425397765 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
node-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api |
| Jun 19, 2019 | https://github.com/nodejs/node/pull/28298#event-2425456431 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Jun 20, 2019
| https://github.com/nodejs/node/pull/28298#pullrequestreview-252529912 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28298/files |
| doc/api/n-api.md | https://github.com/nodejs/node/pull/28298/files#diff-26709ee1f9f0cb60d2d67f45106b31de8ed5eb28ad66c91903fd935a6d607d4d |
| richardlau | https://github.com/richardlau |
| Jun 20, 2019 | https://github.com/nodejs/node/pull/28298#discussion_r295989599 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #28330 | https://github.com/nodejs/node/pull/28330 |
| Please reload this page | https://github.com/nodejs/node/pull/28298 |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Jun 21, 2019 | https://github.com/nodejs/node/pull/28298#discussion_r296065154 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @richardlau | https://github.com/richardlau |
| Please reload this page | https://github.com/nodejs/node/pull/28298 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| force-pushed | https://github.com/nodejs/node/compare/f0293524f7b2d9c32db2ed7effd4ebc815387864..440570a87a63450127b5e079e8ddc44cf4421f8a |
| f029352 | https://github.com/nodejs/node/commit/f0293524f7b2d9c32db2ed7effd4ebc815387864 |
| 440570a | https://github.com/nodejs/node/commit/440570a87a63450127b5e079e8ddc44cf4421f8a |
|
Compare
| https://github.com/nodejs/node/compare/f0293524f7b2d9c32db2ed7effd4ebc815387864..440570a87a63450127b5e079e8ddc44cf4421f8a |
| June 25, 2019 19:28 | https://github.com/nodejs/node/pull/28298#event-2438682358 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Jul 8, 2019
| https://github.com/nodejs/node/pull/28298#ref-issue-451609284 |
|
What should go into N-API 5?
nodejs/abi-stable-node#374
| https://github.com/nodejs/abi-stable-node/issues/374 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 16, 2019 | https://github.com/nodejs/node/pull/28298#issuecomment-511854772 |
| https://ci.nodejs.org/job/node-test-pull-request/24500/ | https://ci.nodejs.org/job/node-test-pull-request/24500/ |
| Please reload this page | https://github.com/nodejs/node/pull/28298 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
| force-pushed | https://github.com/nodejs/node/compare/c940dc09c69ee23f9782e49d12658a4c5180c956..35be08a16fae3e4135dc04b24c5d03a8db869a34 |
| c940dc0 | https://github.com/nodejs/node/commit/c940dc09c69ee23f9782e49d12658a4c5180c956 |
| 35be08a | https://github.com/nodejs/node/commit/35be08a16fae3e4135dc04b24c5d03a8db869a34 |
|
Compare
| https://github.com/nodejs/node/compare/c940dc09c69ee23f9782e49d12658a4c5180c956..35be08a16fae3e4135dc04b24c5d03a8db869a34 |
| July 17, 2019 09:49 | https://github.com/nodejs/node/pull/28298#event-2488844777 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Jul 17, 2019 | https://github.com/nodejs/node/pull/28298#issuecomment-512285860 |
| @BethGriggs | https://github.com/BethGriggs |
| Please reload this page | https://github.com/nodejs/node/pull/28298 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
backported-to-v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v10.x |
|
backported-to-v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v10.x |
| Jul 17, 2019 | https://github.com/nodejs/node/pull/28298#event-2489690056 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Jul 17, 2019 | https://github.com/nodejs/node/pull/28298#issuecomment-512287200 |
| @BethGriggs | https://github.com/BethGriggs |
| Please reload this page | https://github.com/nodejs/node/pull/28298 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
| Jul 17, 2019 | https://github.com/nodejs/node/pull/28298#issuecomment-512288840 |
| @mhdawson | https://github.com/mhdawson |
| Please reload this page | https://github.com/nodejs/node/pull/28298 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 17, 2019 | https://github.com/nodejs/node/pull/28298#issuecomment-512289254 |
| https://ci.nodejs.org/job/node-test-pull-request/24512/ | https://ci.nodejs.org/job/node-test-pull-request/24512/ |
| Please reload this page | https://github.com/nodejs/node/pull/28298 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Jul 17, 2019
| https://github.com/nodejs/node/pull/28298#ref-pullrequest-456468991 |
|
adds experimental napi_date
nodejs/node-addon-api#497
| https://github.com/nodejs/node-addon-api/pull/497 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 23, 2019 | https://github.com/nodejs/node/pull/28298#issuecomment-514262156 |
| https://ci.nodejs.org/job/node-test-pull-request/24630/ | https://ci.nodejs.org/job/node-test-pull-request/24630/ |
| Please reload this page | https://github.com/nodejs/node/pull/28298 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Jul 23, 2019 | https://github.com/nodejs/node/pull/28298#issuecomment-514393402 |
| @BethGriggs | https://github.com/BethGriggs |
| Please reload this page | https://github.com/nodejs/node/pull/28298 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 25, 2019 | https://github.com/nodejs/node/pull/28298#issuecomment-515237557 |
| https://ci.nodejs.org/job/node-test-pull-request/24702/ | https://ci.nodejs.org/job/node-test-pull-request/24702/ |
| Please reload this page | https://github.com/nodejs/node/pull/28298 |
|
| https://github.com/jarrodconnolly |
| n-api: implement date object | https://github.com/nodejs/node/pull/28298/commits/ce01f2f3fb032fc7564706180d587b54dbf56454 |
| ce01f2f | https://github.com/nodejs/node/pull/28298/commits/ce01f2f3fb032fc7564706180d587b54dbf56454 |
| nodejs#25917 | https://github.com/nodejs/node/pull/25917 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| force-pushed | https://github.com/nodejs/node/compare/440570a87a63450127b5e079e8ddc44cf4421f8a..ce01f2f3fb032fc7564706180d587b54dbf56454 |
| 440570a | https://github.com/nodejs/node/commit/440570a87a63450127b5e079e8ddc44cf4421f8a |
| ce01f2f | https://github.com/nodejs/node/commit/ce01f2f3fb032fc7564706180d587b54dbf56454 |
|
Compare
| https://github.com/nodejs/node/compare/440570a87a63450127b5e079e8ddc44cf4421f8a..ce01f2f3fb032fc7564706180d587b54dbf56454 |
| September 2, 2019 06:32 | https://github.com/nodejs/node/pull/28298#event-2600054039 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Sep 2, 2019 | https://github.com/nodejs/node/pull/28298#issuecomment-527023183 |
| Please reload this page | https://github.com/nodejs/node/pull/28298 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Sep 3, 2019
| https://github.com/nodejs/node/pull/28298#pullrequestreview-283099388 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28298/files/ce01f2f3fb032fc7564706180d587b54dbf56454 |
| BethGriggs | https://github.com/BethGriggs |
|
Sep 3, 2019
| https://github.com/nodejs/node/pull/28298#ref-commit-4f41e4f |
|
| https://github.com/jarrodconnolly |
|
| https://github.com/BethGriggs |
| n-api: implement date object | https://github.com/nodejs/node/commit/4f41e4f471180e9b86c92e51814b9aa7c5fe00dc |
| 4f41e4f | https://github.com/nodejs/node/commit/4f41e4f471180e9b86c92e51814b9aa7c5fe00dc |
| #28298 | https://github.com/nodejs/node/pull/28298 |
| #25917 | https://github.com/nodejs/node/pull/25917 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
| Sep 3, 2019 | https://github.com/nodejs/node/pull/28298#issuecomment-527535883 |
| Please reload this page | https://github.com/nodejs/node/pull/28298 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
| Sep 3, 2019 | https://github.com/nodejs/node/pull/28298#event-2604214937 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| March 13, 2020 06:47 | https://github.com/nodejs/node/pull/28298#event-3125582945 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28298 |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/28298/files/440570a87a63450127b5e079e8ddc44cf4421f8a |
|
| https://github.com/BethGriggs |
|
BethGriggs
| https://github.com/BethGriggs |
|
| https://github.com/nodejs/node/pull/28298/files/ce01f2f3fb032fc7564706180d587b54dbf56454 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
node-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api |
| Please reload this page | https://github.com/nodejs/node/pull/28298 |
|
| https://github.com/gabrielschulhof |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/mhdawson |
|
| https://github.com/BethGriggs |
|
| https://github.com/richardlau |
|
| https://github.com/jarrodconnolly |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |