René's URL Explorer Experiment


Title: https: do not automatically use invalid servername by sam-github · Pull Request #28209 · nodejs/node · GitHub

Open Graph Title: https: do not automatically use invalid servername by sam-github · Pull Request #28209 · nodejs/node

X Title: https: do not automatically use invalid servername by sam-github · Pull Request #28209 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Stop automatically setting servername in https.request() if the target host is specified with an IP address. Doing so is invalid, and triggers a deprecation warning. It is still possible to send an...

X Description: Stop automatically setting servername in https.request() if the target host is specified with an IP address. Doing so is invalid, and triggers a deprecation warning. It is still possible to send an...

Opengraph URL: https://github.com/nodejs/node/pull/28209

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:1fc9bf01-5117-3905-2028-96b59416cc17
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAFCC:19115:1F32C0:285187:69926947
html-safe-nonce3c66f37765c342d42e4153ad83cbe9927db10bae136703b920774b97acaedca2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRkNDOjE5MTE1OjFGMzJDMDoyODUxODc6Njk5MjY5NDciLCJ2aXNpdG9yX2lkIjoiNTAzMzE4MDY2MzA4NTQyNzAxNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac3155c765887fbb254d2200645577449457a17aa5912e82b3e456bc2fac6cdc92
hovercard-subject-tagpull_request:288018647
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28209/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f7839349e597d9a3916723e17a5a91ea1365cfcdb3499650d770877b2fc7c934/nodejs/node/pull/28209
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f7839349e597d9a3916723e17a5a91ea1365cfcdb3499650d770877b2fc7c934/nodejs/node/pull/28209
og:image:altStop automatically setting servername in https.request() if the target host is specified with an IP address. Doing so is invalid, and triggers a deprecation warning. It is still possible to send an...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesam-github
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/28209#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28209
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28209
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/28209
Reloadhttps://github.com/nodejs/node/pull/28209
Reloadhttps://github.com/nodejs/node/pull/28209
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/28209
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.8k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 716 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
sam-githubhttps://github.com/sam-github
nodejs:masterhttps://github.com/nodejs/node/tree/master
sam-github:fix-invalid-auto-https-servernamehttps://github.com/sam-github/node/tree/fix-invalid-auto-https-servername
Conversationhttps://github.com/nodejs/node/pull/28209
Commits1 (1)https://github.com/nodejs/node/pull/28209/commits
Checkshttps://github.com/nodejs/node/pull/28209/checks
Files changedhttps://github.com/nodejs/node/pull/28209/files
https: do not automatically use invalid servernamehttps://github.com/nodejs/node/pull/28209#top
sam-githubhttps://github.com/sam-github
nodejs:masterhttps://github.com/nodejs/node/tree/master
sam-github:fix-invalid-auto-https-servernamehttps://github.com/sam-github/node/tree/fix-invalid-auto-https-servername
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Jun 13, 2019https://github.com/nodejs/node/pull/28209#issue-455855281
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/28209
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 13, 2019https://github.com/nodejs/node/pull/28209#issuecomment-501793690
Please reload this pagehttps://github.com/nodejs/node/pull/28209
https://ci.nodejs.org/job/node-test-pull-request/23869/https://ci.nodejs.org/job/node-test-pull-request/23869/
https://ci.nodejs.org/job/node-test-pull-request/23885/https://ci.nodejs.org/job/node-test-pull-request/23885/
Please reload this pagehttps://github.com/nodejs/node/pull/28209
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
Jun 13, 2019https://github.com/nodejs/node/pull/28209#event-2411316425
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jun 13, 2019 https://github.com/nodejs/node/pull/28209#pullrequestreview-249624617
View reviewed changes https://github.com/nodejs/node/pull/28209/files
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 13, 2019 https://github.com/nodejs/node/pull/28209#pullrequestreview-249625102
View reviewed changes https://github.com/nodejs/node/pull/28209/files
doc/api/https.mdhttps://github.com/nodejs/node/pull/28209/files#diff-42dab9abff58c0bc6231f61d8810bf26cf595294fcd90d79af525db3167860c6
Please reload this pagehttps://github.com/nodejs/node/pull/28209
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jun 13, 2019 https://github.com/nodejs/node/pull/28209#pullrequestreview-249625382
View reviewed changes https://github.com/nodejs/node/pull/28209/files
doc/api/https.mdhttps://github.com/nodejs/node/pull/28209/files#diff-42dab9abff58c0bc6231f61d8810bf26cf595294fcd90d79af525db3167860c6
Please reload this pagehttps://github.com/nodejs/node/pull/28209
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 14, 2019 https://github.com/nodejs/node/pull/28209#pullrequestreview-249693128
View reviewed changes https://github.com/nodejs/node/pull/28209/files
https://github.com/sam-github
https: do not automatically use invalid servernamehttps://github.com/nodejs/node/pull/28209/commits/9bbc7d9989b05539df07ecaaf5d5a8b1aef74980
9bbc7d9https://github.com/nodejs/node/pull/28209/commits/9bbc7d9989b05539df07ecaaf5d5a8b1aef74980
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
force-pushedhttps://github.com/nodejs/node/compare/b467b57895f11a62c45c53d95778c2edd50b9ab2..9bbc7d9989b05539df07ecaaf5d5a8b1aef74980
b467b57https://github.com/nodejs/node/commit/b467b57895f11a62c45c53d95778c2edd50b9ab2
9bbc7d9https://github.com/nodejs/node/commit/9bbc7d9989b05539df07ecaaf5d5a8b1aef74980
Compare https://github.com/nodejs/node/compare/b467b57895f11a62c45c53d95778c2edd50b9ab2..9bbc7d9989b05539df07ecaaf5d5a8b1aef74980
June 14, 2019 19:04https://github.com/nodejs/node/pull/28209#event-2414580862
https://github.com/awwright
awwrighthttps://github.com/awwright
Jun 15, 2019https://github.com/nodejs/node/pull/28209#issuecomment-502349682
RFC 6066https://tools.ietf.org/html/rfc6066#page-6
Please reload this pagehttps://github.com/nodejs/node/pull/28209
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
Jun 16, 2019 https://github.com/nodejs/node/pull/28209#pullrequestreview-250214801
View reviewed changes https://github.com/nodejs/node/pull/28209/files/9bbc7d9989b05539df07ecaaf5d5a8b1aef74980
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jun 16, 2019https://github.com/nodejs/node/pull/28209#event-2415702266
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Jun 16, 2019 https://github.com/nodejs/node/pull/28209#ref-issue-456654134
CI failures: 20190612-20190615 nodejs/reliability#23 https://github.com/nodejs/reliability/issues/23
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 17, 2019 https://github.com/nodejs/node/pull/28209#pullrequestreview-250287386
View reviewed changes https://github.com/nodejs/node/pull/28209/files/9bbc7d9989b05539df07ecaaf5d5a8b1aef74980
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jun 17, 2019 https://github.com/nodejs/node/pull/28209#pullrequestreview-250358706
View reviewed changes https://github.com/nodejs/node/pull/28209/files/9bbc7d9989b05539df07ecaaf5d5a8b1aef74980
BridgeARhttps://github.com/BridgeAR
Jun 17, 2019 https://github.com/nodejs/node/pull/28209#ref-commit-574985c
https://github.com/sam-github
https://github.com/BridgeAR
https: do not automatically use invalid servernamehttps://github.com/BridgeAR/node/commit/574985cec8d96ee33be957f247941ad2c9e522bf
574985chttps://github.com/BridgeAR/node/commit/574985cec8d96ee33be957f247941ad2c9e522bf
nodejs#28209https://github.com/nodejs/node/pull/28209
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jun 17, 2019https://github.com/nodejs/node/pull/28209#issuecomment-502618510
574985chttps://github.com/nodejs/node/commit/574985cec8d96ee33be957f247941ad2c9e522bf
Please reload this pagehttps://github.com/nodejs/node/pull/28209
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jun 17, 2019https://github.com/nodejs/node/pull/28209#event-2417073987
BridgeARhttps://github.com/BridgeAR
Jun 17, 2019 https://github.com/nodejs/node/pull/28209#ref-commit-53cc16c
https://github.com/sam-github
https://github.com/BridgeAR
https: do not automatically use invalid servernamehttps://github.com/nodejs/node/commit/53cc16c7ddd6a7487e17d94a28d313369faafd5f
53cc16chttps://github.com/nodejs/node/commit/53cc16c7ddd6a7487e17d94a28d313369faafd5f
#28209https://github.com/nodejs/node/pull/28209
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jun 17, 2019 https://github.com/nodejs/node/pull/28209#ref-pullrequest-457113206
v12.5.0 proposal #28268 https://github.com/nodejs/node/pull/28268
targoshttps://github.com/targos
Jun 18, 2019 https://github.com/nodejs/node/pull/28209#ref-commit-faeed80
https://github.com/sam-github
https://github.com/targos
https: do not automatically use invalid servernamehttps://github.com/nodejs/node/commit/faeed804c7e93aa1dbde41fe04974a6fdbbbc9b7
faeed80https://github.com/nodejs/node/commit/faeed804c7e93aa1dbde41fe04974a6fdbbbc9b7
#28209https://github.com/nodejs/node/pull/28209
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
November 28, 2019 22:21https://github.com/nodejs/node/pull/28209#event-2839969967
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28209
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/28209/files/11813e29dd6bb79cb39a7e2725d6d7f394573d68
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/28209/files/11813e29dd6bb79cb39a7e2725d6d7f394573d68
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/28209/files/9bbc7d9989b05539df07ecaaf5d5a8b1aef74980
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/28209/files/11813e29dd6bb79cb39a7e2725d6d7f394573d68
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/28209/files/9bbc7d9989b05539df07ecaaf5d5a8b1aef74980
https://github.com/ZYSzys
ZYSzys https://github.com/ZYSzys
https://github.com/nodejs/node/pull/28209/files/9bbc7d9989b05539df07ecaaf5d5a8b1aef74980
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
Please reload this pagehttps://github.com/nodejs/node/pull/28209
https://github.com/sam-github
https://github.com/nodejs-github-bot
https://github.com/awwright
https://github.com/BridgeAR
https://github.com/bnoordhuis
https://github.com/jasnell
https://github.com/Trott
https://github.com/addaleax
https://github.com/ZYSzys
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.