| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:fba584d9-06b5-6438-6eb0-d04028712edb |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 939E:27CF87:7F6526:A12D42:699268CF |
| html-safe-nonce | d4b2ad944881abee3e5ef1db6845286dc0195db0cd7cc22260680a14d1d78082 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MzlFOjI3Q0Y4Nzo3RjY1MjY6QTEyRDQyOjY5OTI2OENGIiwidmlzaXRvcl9pZCI6Ijg5NTU2NTk5MTUyNDgxNjcxMTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 8f6c8ed7ea381830d03c5cee59c84fe6e6c38e7b924bcfe55e5a8418bf9152ab |
| hovercard-subject-tag | pull_request:288013553 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28208/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/4d1a5e753b5e24b17ddd141114dd2303442ae076beb0de320ae1a6f91a045901/nodejs/node/pull/28208 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/4d1a5e753b5e24b17ddd141114dd2303442ae076beb0de320ae1a6f91a045901/nodejs/node/pull/28208 |
| og:image:alt | The @nodejs/tooling group has been working on porting rimraf into Node.js Core: nodejs/tooling#13. We've spoken with @isaacs and this is done with his cooperation: iansu#1 (comment). We've ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | iansu |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/28208#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28208 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28208 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/28208 |
| Reload | https://github.com/nodejs/node/pull/28208 |
| Reload | https://github.com/nodejs/node/pull/28208 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.8k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
716
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| iansu | https://github.com/iansu |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| iansu:shutil-rmtree | https://github.com/iansu/node/tree/shutil-rmtree |
| Conversation | https://github.com/nodejs/node/pull/28208 |
| Commits8 (8) | https://github.com/nodejs/node/pull/28208/commits |
| Checks | https://github.com/nodejs/node/pull/28208/checks |
| Files changed | https://github.com/nodejs/node/pull/28208/files |
| lib: port rimraf to core as shutil.rmtree | https://github.com/nodejs/node/pull/28208#top |
| iansu | https://github.com/iansu |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| iansu:shutil-rmtree | https://github.com/iansu/node/tree/shutil-rmtree |
|
| https://github.com/iansu |
| iansu | https://github.com/iansu |
| Jun 13, 2019 | https://github.com/nodejs/node/pull/28208#issue-455848798 |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
| rimraf | https://www.npmjs.com/package/rimraf |
| nodejs/tooling#13 | https://github.com/nodejs/tooling/issues/13 |
| @isaacs | https://github.com/isaacs |
| iansu#1 (comment) | https://github.com/iansu/node/pull/1#issuecomment-489389946 |
| #28171 | https://github.com/nodejs/node/pull/28171 |
| @boneskull | https://github.com/boneskull |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
| iansu | https://github.com/iansu |
| June 13, 2019 10:46 | https://github.com/nodejs/node/pull/28208#commits-pushed-fa504e0 |
|
| https://github.com/iansu |
| lib: add shutil module with rmtree method | https://github.com/nodejs/node/pull/28208/commits/fa504e00bf203dcd7ee4d198f218087d5e814476 |
| fa504e0 | https://github.com/nodejs/node/pull/28208/commits/fa504e00bf203dcd7ee4d198f218087d5e814476 |
|
| https://github.com/iansu |
| Add tests | https://github.com/nodejs/node/pull/28208/commits/b04be5042f5c94a67801dba8d12a4b91fc118e89 |
| b04be50 | https://github.com/nodejs/node/pull/28208/commits/b04be5042f5c94a67801dba8d12a4b91fc118e89 |
|
| https://github.com/iansu |
| Move helper functions to internal module | https://github.com/nodejs/node/pull/28208/commits/9c2436ec0602f7f95234f08a175cd1d8db210b3e |
| 9c2436e | https://github.com/nodejs/node/pull/28208/commits/9c2436ec0602f7f95234f08a175cd1d8db210b3e |
|
| https://github.com/iansu |
| Remove assert | https://github.com/nodejs/node/pull/28208/commits/c765d7c28e505d46999a94f830276eb4f00c8750 |
| c765d7c | https://github.com/nodejs/node/pull/28208/commits/c765d7c28e505d46999a94f830276eb4f00c8750 |
|
| https://github.com/iansu |
| Fix lint errors | https://github.com/nodejs/node/pull/28208/commits/d98fff1d5d9f1ad16db72fef9e83a81b0bb4d37f |
| d98fff1 | https://github.com/nodejs/node/pull/28208/commits/d98fff1d5d9f1ad16db72fef9e83a81b0bb4d37f |
|
| https://github.com/iansu |
| Only validate error argument if it's passed | https://github.com/nodejs/node/pull/28208/commits/4c372b65f7abf93163b4028fc0572ca339a765e9 |
| 4c372b6 | https://github.com/nodejs/node/pull/28208/commits/4c372b65f7abf93163b4028fc0572ca339a765e9 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
| Jun 13, 2019 | https://github.com/nodejs/node/pull/28208#event-2411274757 |
| https://github.com/boneskull |
| boneskull | https://github.com/boneskull |
| Jun 13, 2019 | https://github.com/nodejs/node/pull/28208#issuecomment-501789036 |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
| https://github.com/boneskull |
| boneskull | https://github.com/boneskull |
|
Jun 13, 2019
| https://github.com/nodejs/node/pull/28208#pullrequestreview-249481608 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28208/files/4c372b65f7abf93163b4028fc0572ca339a765e9 |
| boneskull | https://github.com/boneskull |
| https://github.com/nodejs/node/pull/28208#pullrequestreview-249481608 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jun 13, 2019 | https://github.com/nodejs/node/pull/28208#issuecomment-501790156 |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
| https://github.com/boneskull |
| boneskull | https://github.com/boneskull |
| Jun 13, 2019 | https://github.com/nodejs/node/pull/28208#issuecomment-501791345 |
| @iansu | https://github.com/iansu |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Jun 13, 2019
| https://github.com/nodejs/node/pull/28208#pullrequestreview-249484488 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28208/files/4c372b65f7abf93163b4028fc0572ca339a765e9 |
| Trott | https://github.com/Trott |
| https://github.com/nodejs/node/pull/28208#pullrequestreview-249484488 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
wip
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip |
|
fs
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs |
| Jun 13, 2019 | https://github.com/nodejs/node/pull/28208#event-2411304175 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jun 13, 2019 | https://github.com/nodejs/node/pull/28208#issuecomment-501792589 |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
| https://github.com/boneskull |
| boneskull | https://github.com/boneskull |
| Jun 13, 2019 | https://github.com/nodejs/node/pull/28208#issuecomment-501792926 |
| nodejs/tooling#13 | https://github.com/nodejs/tooling/issues/13 |
| nodejs/tooling#23 | https://github.com/nodejs/tooling/issues/23 |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
| https://github.com/boneskull |
| boneskull | https://github.com/boneskull |
| Jun 13, 2019 | https://github.com/nodejs/node/pull/28208#issuecomment-501793503 |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jun 13, 2019 | https://github.com/nodejs/node/pull/28208#issuecomment-501794274 |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jun 13, 2019 | https://github.com/nodejs/node/pull/28208#issuecomment-501795395 |
| https://www.npmjs.com/package/shutil | https://www.npmjs.com/package/shutil |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Jun 13, 2019
| https://github.com/nodejs/node/pull/28208#pullrequestreview-249491859 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28208/files/4c372b65f7abf93163b4028fc0572ca339a765e9 |
| Fishrock123 | https://github.com/Fishrock123 |
| https://github.com/nodejs/node/pull/28208#pullrequestreview-249491859 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
| https://github.com/bcoe |
| bcoe | https://github.com/bcoe |
|
Jun 13, 2019
| https://github.com/nodejs/node/pull/28208#ref-pullrequest-454608888 |
|
fs: implement fs.rmdir recurisve
#28171
| https://github.com/nodejs/node/pull/28171 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
| Jun 13, 2019 | https://github.com/nodejs/node/pull/28208#event-2411381624 |
| https://github.com/bcoe |
| bcoe | https://github.com/bcoe |
| Jun 13, 2019 | https://github.com/nodejs/node/pull/28208#issuecomment-501805363 |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
| @Fishrock123 | https://github.com/Fishrock123 |
| @sam-github | https://github.com/sam-github |
| @zero1five | https://github.com/zero1five |
| @refack | https://github.com/refack |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
|
Jun 13, 2019
| https://github.com/nodejs/node/pull/28208#pullrequestreview-249500843 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28208/files/4c372b65f7abf93163b4028fc0572ca339a765e9 |
| lib/internal/shutil.js | https://github.com/nodejs/node/pull/28208/files/4c372b65f7abf93163b4028fc0572ca339a765e9#diff-789544bdb4a068d840cdb3645097a5905d2f78a827eaffff6d5c880653a2f4b6 |
| sam-github | https://github.com/sam-github |
| Jun 13, 2019 | https://github.com/nodejs/node/pull/28208#discussion_r293496722 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| lib: add shutil module with rmtree method iansu/node#1 (comment) | https://github.com/iansu/node/pull/1#issuecomment-489389946 |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
| iansu | https://github.com/iansu |
| Jun 13, 2019 | https://github.com/nodejs/node/pull/28208#discussion_r293500790 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
| silverwind | https://github.com/silverwind |
| Jun 14, 2019 | https://github.com/nodejs/node/pull/28208#discussion_r294005552 |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| like this | https://github.com/nodejs/node/blob/b6148402d461ffb70446ddd4b55051e093ad1aef/LICENSE#L1472 |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
| MylesBorins | https://github.com/MylesBorins |
| Jun 17, 2019 | https://github.com/nodejs/node/pull/28208#discussion_r294484438 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #27979 | https://github.com/nodejs/node/pull/27979 |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
| https://github.com/iansu |
| iansu | https://github.com/iansu |
| Jun 13, 2019 | https://github.com/nodejs/node/pull/28208#issuecomment-501807751 |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
| Jun 13, 2019 | https://github.com/nodejs/node/pull/28208#event-2411420368 |
| https://github.com/boneskull |
| boneskull | https://github.com/boneskull |
| Jun 13, 2019 | https://github.com/nodejs/node/pull/28208#issuecomment-501812297 |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Jun 13, 2019 | https://github.com/nodejs/node/pull/28208#issuecomment-501823819 |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Jun 13, 2019 | https://github.com/nodejs/node/pull/28208#issuecomment-501824142 |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
| @iansu | https://github.com/iansu |
| https://github.com/isaacs/rimraf | https://github.com/isaacs/rimraf |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| Jun 14, 2019 | https://github.com/nodejs/node/pull/28208#issuecomment-501932372 |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
| https://github.com/iansu |
| iansu | https://github.com/iansu |
| Jun 14, 2019 | https://github.com/nodejs/node/pull/28208#issuecomment-502254593 |
| @joyeecheung | https://github.com/joyeecheung |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jun 14, 2019 | https://github.com/nodejs/node/pull/28208#issuecomment-502302058 |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
| https://github.com/iansu |
| iansu | https://github.com/iansu |
| Jun 14, 2019 | https://github.com/nodejs/node/pull/28208#issuecomment-502303867 |
| @jasnell | https://github.com/jasnell |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
| https://github.com/ljharb |
| ljharb | https://github.com/ljharb |
| Jun 14, 2019 | https://github.com/nodejs/node/pull/28208#issuecomment-502312538 |
| #21552 | https://github.com/nodejs/node/pull/21552 |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
| https://github.com/ForsakenHarmony |
| ForsakenHarmony | https://github.com/ForsakenHarmony |
| Jun 15, 2019 | https://github.com/nodejs/node/pull/28208#issuecomment-502319103 |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Jun 17, 2019
| https://github.com/nodejs/node/pull/28208#pullrequestreview-250703745 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28208/files/4c372b65f7abf93163b4028fc0572ca339a765e9 |
| MylesBorins | https://github.com/MylesBorins |
| https://github.com/nodejs/node/pull/28208#pullrequestreview-250703745 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #27979 | https://github.com/nodejs/node/pull/27979 |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
| lib/internal/shutil.js | https://github.com/nodejs/node/pull/28208/files/4c372b65f7abf93163b4028fc0572ca339a765e9#diff-789544bdb4a068d840cdb3645097a5905d2f78a827eaffff6d5c880653a2f4b6 |
| MylesBorins | https://github.com/MylesBorins |
| Jun 17, 2019 | https://github.com/nodejs/node/pull/28208#discussion_r294484438 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #27979 | https://github.com/nodejs/node/pull/27979 |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
| https://github.com/iansu |
| iansu | https://github.com/iansu |
| Jun 18, 2019 | https://github.com/nodejs/node/pull/28208#issuecomment-503203305 |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Jun 18, 2019 | https://github.com/nodejs/node/pull/28208#issuecomment-503207164 |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
| https://github.com/iansu |
| iansu | https://github.com/iansu |
| Jun 18, 2019 | https://github.com/nodejs/node/pull/28208#issuecomment-503210474 |
| @targos | https://github.com/targos |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
| https://github.com/iansu |
| iansu | https://github.com/iansu |
| Jun 18, 2019 | https://github.com/nodejs/node/pull/28208#issuecomment-503211467 |
| @MylesBorins | https://github.com/MylesBorins |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| Jun 18, 2019 | https://github.com/nodejs/node/pull/28208#issuecomment-503217354 |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
| https://github.com/bcoe |
| bcoe | https://github.com/bcoe |
| Jun 21, 2019 | https://github.com/nodejs/node/pull/28208#issuecomment-504500120 |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
| @sam-github | https://github.com/sam-github |
| @sindresorhus | https://github.com/sindresorhus |
| @isaacs | https://github.com/isaacs |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
| https://github.com/iansu |
| iansu | https://github.com/iansu |
| Jun 21, 2019 | https://github.com/nodejs/node/pull/28208#issuecomment-504502388 |
| @bcoe | https://github.com/bcoe |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
| https://github.com/sindresorhus |
| sindresorhus | https://github.com/sindresorhus |
| Jun 21, 2019 | https://github.com/nodejs/node/pull/28208#issuecomment-504518125 |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Jun 21, 2019 | https://github.com/nodejs/node/pull/28208#issuecomment-504527657 |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
| https://github.com/iansu |
| iansu | https://github.com/iansu |
| Jul 2, 2019 | https://github.com/nodejs/node/pull/28208#issuecomment-507796309 |
| @MylesBorins | https://github.com/MylesBorins |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
| https://github.com/sindresorhus |
| sindresorhus | https://github.com/sindresorhus |
| Jul 2, 2019 | https://github.com/nodejs/node/pull/28208#issuecomment-507804559 |
| I'm not alone | https://stackoverflow.com/questions/45276163/does-anyone-knows-what-rimraf-means |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
| https://github.com/bcoe |
| bcoe | https://github.com/bcoe |
| Jul 2, 2019 | https://github.com/nodejs/node/pull/28208#issuecomment-507860651 |
| @sindresorhus | https://github.com/sindresorhus |
| rmtree | https://docs.python.org/2/library/shutil.html#shutil.rmtree |
| ruby | https://apidock.com/ruby/FileUtils/rmtree |
| @isaacs | https://github.com/isaacs |
| @isaacs | https://github.com/isaacs |
| this slack | http://devtoolscommunity.herokuapp.com/ |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
| https://github.com/iansu |
| iansu | https://github.com/iansu |
| Jul 2, 2019 | https://github.com/nodejs/node/pull/28208#issuecomment-507883448 |
| @isaacs | https://github.com/isaacs |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
| https://github.com/bcoe |
| bcoe | https://github.com/bcoe |
|
Jul 14, 2019
| https://github.com/nodejs/node/pull/28208#ref-pullrequest-467883114 |
|
feat: make it possible to omit glob dependency
isaacs/rimraf#192
| https://github.com/isaacs/rimraf/pull/192 |
| https://github.com/iansu |
| iansu | https://github.com/iansu |
|
Jul 24, 2019
| https://github.com/nodejs/node/pull/28208#ref-issue-356779168 |
|
An optional parameter that lets us delete folders that aren't empty directly
#22686
| https://github.com/nodejs/node/issues/22686 |
|
| https://github.com/iansu |
| Vendor rimraf as fs.rmtree | https://github.com/nodejs/node/pull/28208/commits/39706c67c985adc909b8038f52594b73e745e8ad |
| 39706c6 | https://github.com/nodejs/node/pull/28208/commits/39706c67c985adc909b8038f52594b73e745e8ad |
| https://github.com/iansu |
| iansu | https://github.com/iansu |
| Aug 14, 2019 | https://github.com/nodejs/node/pull/28208#issuecomment-521336368 |
| @isaacs | https://github.com/isaacs |
| @isaacs | https://github.com/isaacs |
| @bcoe | https://github.com/bcoe |
| @mpaktiti | https://github.com/mpaktiti |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Aug 14, 2019
| https://github.com/nodejs/node/pull/28208#pullrequestreview-275046863 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28208/files/39706c67c985adc909b8038f52594b73e745e8ad |
| cjihrig | https://github.com/cjihrig |
| https://github.com/nodejs/node/pull/28208#pullrequestreview-275046863 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Aug 16, 2019
| https://github.com/nodejs/node/pull/28208#ref-pullrequest-481752479 |
|
fs: add recursive option to rmdir()
#29168
| https://github.com/nodejs/node/pull/29168 |
| https://github.com/iansu |
| iansu | https://github.com/iansu |
| Aug 18, 2019 | https://github.com/nodejs/node/pull/28208#issuecomment-522335615 |
| @cjihrig | https://github.com/cjihrig |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
|
| https://github.com/iansu |
| Remove last trace of shutil | https://github.com/nodejs/node/pull/28208/commits/1908b52567ca1dd514856ce2793206303cf11255 |
| 1908b52 | https://github.com/nodejs/node/pull/28208/commits/1908b52567ca1dd514856ce2793206303cf11255 |
| https://github.com/iansu |
| iansu | https://github.com/iansu |
| Aug 23, 2019 | https://github.com/nodejs/node/pull/28208#issuecomment-524482162 |
| #29168 | https://github.com/nodejs/node/pull/29168 |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
| https://github.com/iansu |
| iansu | https://github.com/iansu |
| Aug 23, 2019 | https://github.com/nodejs/node/pull/28208#event-2580995021 |
| https://github.com/iansu |
| iansu | https://github.com/iansu |
|
Jul 10, 2020
| https://github.com/nodejs/node/pull/28208#ref-issue-654074174 |
|
Rethink recursive flag (and design more generally) for fs.rmdir
#34278
| https://github.com/nodejs/node/issues/34278 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28208 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/28208/files/4c372b65f7abf93163b4028fc0572ca339a765e9 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/28208/files/4c372b65f7abf93163b4028fc0572ca339a765e9 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/28208/files/39706c67c985adc909b8038f52594b73e745e8ad |
|
| https://github.com/sam-github |
|
sam-github
| https://github.com/sam-github |
|
| https://github.com/nodejs/node/pull/28208/files/4c372b65f7abf93163b4028fc0572ca339a765e9 |
|
| https://github.com/silverwind |
|
silverwind
| https://github.com/silverwind |
|
| https://github.com/nodejs/node/pull/28208/files/4c372b65f7abf93163b4028fc0572ca339a765e9 |
|
| https://github.com/MylesBorins |
|
MylesBorins
| https://github.com/MylesBorins |
|
| https://github.com/nodejs/node/pull/28208/files/4c372b65f7abf93163b4028fc0572ca339a765e9 |
|
| https://github.com/boneskull |
|
boneskull
| https://github.com/boneskull |
|
| https://github.com/nodejs/node/pull/28208/files/4c372b65f7abf93163b4028fc0572ca339a765e9 |
|
| https://github.com/Fishrock123 |
|
Fishrock123
| https://github.com/Fishrock123 |
|
| https://github.com/nodejs/node/pull/28208/files/4c372b65f7abf93163b4028fc0572ca339a765e9 |
|
fs
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
|
wip
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip |
| Please reload this page | https://github.com/nodejs/node/pull/28208 |
|
| https://github.com/iansu |
|
| https://github.com/boneskull |
|
| https://github.com/Trott |
|
| https://github.com/bcoe |
|
| https://github.com/Fishrock123 |
|
| https://github.com/sam-github |
|
| https://github.com/silverwind |
|
| https://github.com/devsnek |
|
| https://github.com/jasnell |
|
| https://github.com/zero1five |
|
| https://github.com/gireeshpunathil |
|
| https://github.com/sindresorhus |
|
| https://github.com/joyeecheung |
|
| https://github.com/ljharb |
|
| https://github.com/ForsakenHarmony |
|
| https://github.com/targos |
|
| https://github.com/MylesBorins |
|
| https://github.com/cjihrig |
|
| https://github.com/addaleax |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |