René's URL Explorer Experiment


Title: code cleanup by gengjiawen · Pull Request #28189 · nodejs/node · GitHub

Open Graph Title: code cleanup by gengjiawen · Pull Request #28189 · nodejs/node

X Title: code cleanup by gengjiawen · Pull Request #28189 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines

X Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines

Opengraph URL: https://github.com/nodejs/node/pull/28189

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d9d13bdf-0bbc-00bb-5a87-ee07a39338ab
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id908C:1EE1:45B081A:62FADC3:6A4FE3E3
html-safe-nonceb4eb11f8d9a508197a43d23fd55c995e0774f7e93ffd6be9be1cc533b691bc9f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MDhDOjFFRTE6NDVCMDgxQTo2MkZBREMzOjZBNEZFM0UzIiwidmlzaXRvcl9pZCI6IjYyMzk2MzA5Mzc4MjAyMjY1MzEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac07e3243b7ea10308237449aecdcb08b968b1c49a8cbb02e592b1973410e6f18f
hovercard-subject-tagpull_request:287571306
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28189/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b42f4b6c8efdef0238d44b773865d15d946c8d8b64bc5fc26d13bf31b1d25e53/nodejs/node/pull/28189
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b42f4b6c8efdef0238d44b773865d15d946c8d8b64bc5fc26d13bf31b1d25e53/nodejs/node/pull/28189
og:image:altChecklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegengjiawen
hostnamegithub.com
expected-hostnamegithub.com
None19b98c3d9767bb8a56238a89ff8401d1cbdf3bc5c353799aacf49fe6c76b4b7c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release142593e66413bbae27fd485859993597d5a3b104
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/28189#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28189
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28189
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/28189
Reloadhttps://github.com/nodejs/node/pull/28189
Reloadhttps://github.com/nodejs/node/pull/28189
Please reload this pagehttps://github.com/nodejs/node/pull/28189
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/28189
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 975 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
gengjiawenhttps://github.com/gengjiawen
nodejs:masterhttps://github.com/nodejs/node/tree/master
gengjiawen:yahahahttps://github.com/gengjiawen/node/tree/yahaha
Conversationhttps://github.com/nodejs/node/pull/28189
Commits2 (2)https://github.com/nodejs/node/pull/28189/commits
Checkshttps://github.com/nodejs/node/pull/28189/checks
Files changedhttps://github.com/nodejs/node/pull/28189/files
code cleanuphttps://github.com/nodejs/node/pull/28189#top
gengjiawenhttps://github.com/gengjiawen
nodejs:masterhttps://github.com/nodejs/node/tree/master
gengjiawen:yahahahttps://github.com/gengjiawen/node/tree/yahaha
https://github.com/gengjiawen
gengjiawenhttps://github.com/gengjiawen
Jun 12, 2019https://github.com/nodejs/node/pull/28189#issue-455292426
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/28189
gengjiawenhttps://github.com/gengjiawen
June 12, 2019 23:48https://github.com/nodejs/node/pull/28189#commits-pushed-a312e99
https://github.com/gengjiawen
build: change ASM compiler url to httpshttps://github.com/nodejs/node/pull/28189/commits/a312e99a93bca8ce730fca604a1bd68bb83e1c3d
a312e99https://github.com/nodejs/node/pull/28189/commits/a312e99a93bca8ce730fca604a1bd68bb83e1c3d
https://github.com/gengjiawen
src: remove redundant returnhttps://github.com/nodejs/node/pull/28189/commits/04a889461e3d1dd7d3e6e3865bcd977c748da2fa
04a8894https://github.com/nodejs/node/pull/28189/commits/04a889461e3d1dd7d3e6e3865bcd977c748da2fa
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
tls https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls
Jun 12, 2019https://github.com/nodejs/node/pull/28189#event-2407863436
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jun 12, 2019 https://github.com/nodejs/node/pull/28189#pullrequestreview-248885547
View reviewed changes https://github.com/nodejs/node/pull/28189/files/04a889461e3d1dd7d3e6e3865bcd977c748da2fa
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jun 12, 2019 https://github.com/nodejs/node/pull/28189#pullrequestreview-248945361
View reviewed changes https://github.com/nodejs/node/pull/28189/files/04a889461e3d1dd7d3e6e3865bcd977c748da2fa
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 12, 2019 https://github.com/nodejs/node/pull/28189#pullrequestreview-248963903
View reviewed changes https://github.com/nodejs/node/pull/28189/files/04a889461e3d1dd7d3e6e3865bcd977c748da2fa
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 14, 2019 https://github.com/nodejs/node/pull/28189#pullrequestreview-249695276
View reviewed changes https://github.com/nodejs/node/pull/28189/files/04a889461e3d1dd7d3e6e3865bcd977c748da2fa
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28189
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28189
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Jun 16, 2019 https://github.com/nodejs/node/pull/28189#ref-issue-456654134
CI failures: 20190612-20190615 nodejs/reliability#23 https://github.com/nodejs/reliability/issues/23
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28189
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28189
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28189
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28189
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 24, 2019https://github.com/nodejs/node/pull/28189#issuecomment-505190443
https://ci.nodejs.org/job/node-test-pull-request/24078/https://ci.nodejs.org/job/node-test-pull-request/24078/
Please reload this pagehttps://github.com/nodejs/node/pull/28189
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
Jul 2, 2019https://github.com/nodejs/node/pull/28189#issuecomment-507569526
Please reload this pagehttps://github.com/nodejs/node/pull/28189
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
Jul 2, 2019https://github.com/nodejs/node/pull/28189#event-2453483013
targoshttps://github.com/targos
Jul 20, 2019 https://github.com/nodejs/node/pull/28189#ref-commit-e4fae24
https://github.com/gengjiawen
https://github.com/targos
build: change ASM compiler url to httpshttps://github.com/nodejs/node/commit/e4fae24b62eda4123aabef6931f1f39f63575ac3
e4fae24https://github.com/nodejs/node/commit/e4fae24b62eda4123aabef6931f1f39f63575ac3
#28189https://github.com/nodejs/node/pull/28189
targoshttps://github.com/targos
Jul 20, 2019 https://github.com/nodejs/node/pull/28189#ref-commit-e610c45
https://github.com/gengjiawen
https://github.com/targos
src: remove redundant returnhttps://github.com/nodejs/node/commit/e610c45076a7940bbe2460d0a39bf7dbfe9c9bf4
e610c45https://github.com/nodejs/node/commit/e610c45076a7940bbe2460d0a39bf7dbfe9c9bf4
#28189https://github.com/nodejs/node/pull/28189
v12.7.0 release proposal #28816 https://github.com/nodejs/node/pull/28816
v12.7.0 release proposal #28817 https://github.com/nodejs/node/pull/28817
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28189
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/28189/files/04a889461e3d1dd7d3e6e3865bcd977c748da2fa
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/28189/files/04a889461e3d1dd7d3e6e3865bcd977c748da2fa
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/28189/files/04a889461e3d1dd7d3e6e3865bcd977c748da2fa
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/28189/files/04a889461e3d1dd7d3e6e3865bcd977c748da2fa
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
tls https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls
Please reload this pagehttps://github.com/nodejs/node/pull/28189
https://github.com/gengjiawen
https://github.com/nodejs-github-bot
https://github.com/ZYSzys
https://github.com/jasnell
https://github.com/Trott
https://github.com/cjihrig
https://github.com/BridgeAR
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.