| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:71bfd73e-375e-1474-1384-045960e110df |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E862:11C566:71295:8DD9B:69926347 |
| html-safe-nonce | aba7e06ccdcd9056cf9e373778144ad1763d6ab020e96f0b0c24c9e8ddcc3577 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFODYyOjExQzU2Njo3MTI5NTo4REQ5Qjo2OTkyNjM0NyIsInZpc2l0b3JfaWQiOiI0OTgzNDc4NjY1ODgwOTUzNjcxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | c5e423033df53a3aafd4aab7d4fe26588e46619cffc0c9a210da40bb6195db5e |
| hovercard-subject-tag | pull_request:287259834 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28183/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/331c7f70f41838fdfe322be68491cdc386045999215008c48819a6be191034c9/nodejs/node/pull/28183 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/331c7f70f41838fdfe322be68491cdc386045999215008c48819a6be191034c9/nodejs/node/pull/28183 |
| og:image:alt | test: document cpu-prof module and remove unused output argument from getFrames()
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
documentation is changed or added
commit mes... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Trott |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/28183#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28183 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28183 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/28183 |
| Reload | https://github.com/nodejs/node/pull/28183 |
| Reload | https://github.com/nodejs/node/pull/28183 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/28183 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.8k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
716
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:stub-out-cpu-prof | https://github.com/Trott/io.js/tree/stub-out-cpu-prof |
| Conversation | https://github.com/nodejs/node/pull/28183 |
| Commits0 (0) | https://github.com/nodejs/node/pull/28183/commits |
| Checks | https://github.com/nodejs/node/pull/28183/checks |
| Files changed | https://github.com/nodejs/node/pull/28183/files |
| test: document cpu-prof module and remove unused output argument from getFrames() | https://github.com/nodejs/node/pull/28183#top |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:stub-out-cpu-prof | https://github.com/Trott/io.js/tree/stub-out-cpu-prof |
|
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jun 11, 2019 | https://github.com/nodejs/node/pull/28183#issue-454900625 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/28183 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28183 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Jun 11, 2019 | https://github.com/nodejs/node/pull/28183#event-2405481997 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| joyeecheung | https://github.com/joyeecheung |
| June 11, 2019 20:58 | https://github.com/nodejs/node/pull/28183#event-2405482129 |
| https://github.com/Trott |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28183 |
| https://github.com/Trott |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28183 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Jun 11, 2019
| https://github.com/nodejs/node/pull/28183#pullrequestreview-248462830 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28183/files |
| test/common/README.md | https://github.com/nodejs/node/pull/28183/files#diff-4c0f5f25d9424c0e74d3544841707f668cd6481053ccea1cc0a5eaa36814d2a6 |
| Please reload this page | https://github.com/nodejs/node/pull/28183 |
| test/common/README.md | https://github.com/nodejs/node/pull/28183/files#diff-4c0f5f25d9424c0e74d3544841707f668cd6481053ccea1cc0a5eaa36814d2a6 |
| Please reload this page | https://github.com/nodejs/node/pull/28183 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Jun 11, 2019
| https://github.com/nodejs/node/pull/28183#pullrequestreview-248464317 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28183/files |
| test/common/README.md | https://github.com/nodejs/node/pull/28183/files#diff-4c0f5f25d9424c0e74d3544841707f668cd6481053ccea1cc0a5eaa36814d2a6 |
| Please reload this page | https://github.com/nodejs/node/pull/28183 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Jun 11, 2019
| https://github.com/nodejs/node/pull/28183#pullrequestreview-248481500 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28183/files |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Jun 12, 2019 | https://github.com/nodejs/node/pull/28183#event-2406100274 |
| https://github.com/Trott |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28183 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Jun 12, 2019
| https://github.com/nodejs/node/pull/28183#pullrequestreview-248626296 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28183/files |
| test/common/cpu-prof.js | https://github.com/nodejs/node/pull/28183/files#diff-af53f1f0d9d2aad59c99017ee02302ead0aeb08823e582bfdf79b7d15ba2a11b |
| Please reload this page | https://github.com/nodejs/node/pull/28183 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Jun 12, 2019
| https://github.com/nodejs/node/pull/28183#pullrequestreview-248851630 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28183/files |
| test/fixtures/workload/fibonacci.js | https://github.com/nodejs/node/pull/28183/files#diff-420c263361812514e5af7a052ce9ec5b3265e68df5aa15a68e2e8b72f7664e39 |
| Please reload this page | https://github.com/nodejs/node/pull/28183 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jun 12, 2019 | https://github.com/nodejs/node/pull/28183#issuecomment-501336641 |
| Please reload this page | https://github.com/nodejs/node/pull/28183 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jun 12, 2019 | https://github.com/nodejs/node/pull/28183#issuecomment-501338502 |
| https://ci.nodejs.org/job/node-test-pull-request/23817/ | https://ci.nodejs.org/job/node-test-pull-request/23817/ |
| Please reload this page | https://github.com/nodejs/node/pull/28183 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Jun 14, 2019
| https://github.com/nodejs/node/pull/28183#pullrequestreview-249695905 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28183/files |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jun 14, 2019 | https://github.com/nodejs/node/pull/28183#issuecomment-501980207 |
| Please reload this page | https://github.com/nodejs/node/pull/28183 |
| Trott | https://github.com/Trott |
|
Jun 14, 2019
| https://github.com/nodejs/node/pull/28183#ref-commit-06c818a |
|
| https://github.com/Trott |
| test: document cpu-prof module | https://github.com/Trott/io.js/commit/06c818a464b58831ed7be37e5a8412fc9a9b6eae |
| 06c818a | https://github.com/Trott/io.js/commit/06c818a464b58831ed7be37e5a8412fc9a9b6eae |
| nodejs#28183 | https://github.com/nodejs/node/pull/28183 |
| Trott | https://github.com/Trott |
|
Jun 14, 2019
| https://github.com/nodejs/node/pull/28183#ref-commit-4928c2f |
|
| https://github.com/Trott |
| test: remove unused output argument for getFrames() | https://github.com/Trott/io.js/commit/4928c2f3b121b54169fd5d51872c673df9c27cae |
| 4928c2f | https://github.com/Trott/io.js/commit/4928c2f3b121b54169fd5d51872c673df9c27cae |
| nodejs#28183 | https://github.com/nodejs/node/pull/28183 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jun 14, 2019 | https://github.com/nodejs/node/pull/28183#event-2412636541 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/cda56ca9a88f26e1997a7541a4775fb04dfc39fb..d4c7487840c8b2b6852951d3e0623ed16206e2e6 |
| cda56ca | https://github.com/nodejs/node/commit/cda56ca9a88f26e1997a7541a4775fb04dfc39fb |
| d4c7487 | https://github.com/nodejs/node/commit/d4c7487840c8b2b6852951d3e0623ed16206e2e6 |
|
Compare
| https://github.com/nodejs/node/compare/cda56ca9a88f26e1997a7541a4775fb04dfc39fb..d4c7487840c8b2b6852951d3e0623ed16206e2e6 |
| June 14, 2019 06:03 | https://github.com/nodejs/node/pull/28183#event-2412636544 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| June 14, 2019 06:03 | https://github.com/nodejs/node/pull/28183#event-2412637067 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| d4c7487 | https://github.com/nodejs/node/commit/d4c7487840c8b2b6852951d3e0623ed16206e2e6 |
| Jun 14, 2019 | https://github.com/nodejs/node/pull/28183#event-2412638172 |
| BridgeAR | https://github.com/BridgeAR |
|
Jun 17, 2019
| https://github.com/nodejs/node/pull/28183#ref-commit-5d8dce4 |
|
| https://github.com/Trott |
|
| https://github.com/BridgeAR |
| test: document cpu-prof module | https://github.com/nodejs/node/commit/5d8dce41e33878113c9e92443a75159c718ff260 |
| 5d8dce4 | https://github.com/nodejs/node/commit/5d8dce41e33878113c9e92443a75159c718ff260 |
| #28183 | https://github.com/nodejs/node/pull/28183 |
| BridgeAR | https://github.com/BridgeAR |
|
Jun 17, 2019
| https://github.com/nodejs/node/pull/28183#ref-commit-066d814 |
|
| https://github.com/Trott |
|
| https://github.com/BridgeAR |
| test: remove unused output argument for getFrames() | https://github.com/nodejs/node/commit/066d814b3cd4408099a8b3a3bf327eac67f449fa |
| 066d814 | https://github.com/nodejs/node/commit/066d814b3cd4408099a8b3a3bf327eac67f449fa |
| #28183 | https://github.com/nodejs/node/pull/28183 |
| BridgeAR | https://github.com/BridgeAR |
|
Jun 17, 2019
| https://github.com/nodejs/node/pull/28183#ref-commit-414e9d2 |
|
| https://github.com/Trott |
|
| https://github.com/BridgeAR |
| test: remove FIB environment variable from cpu-prof.js | https://github.com/nodejs/node/commit/414e9d281154a9bc06caa731a98bcd9e5973ce7b |
| 414e9d2 | https://github.com/nodejs/node/commit/414e9d281154a9bc06caa731a98bcd9e5973ce7b |
| #28183 | https://github.com/nodejs/node/pull/28183 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Jun 17, 2019
| https://github.com/nodejs/node/pull/28183#ref-pullrequest-457113206 |
|
v12.5.0 proposal
#28268
| https://github.com/nodejs/node/pull/28268 |
| targos | https://github.com/targos |
|
Jun 18, 2019
| https://github.com/nodejs/node/pull/28183#ref-commit-58eccb1 |
|
| https://github.com/Trott |
|
| https://github.com/targos |
| test: document cpu-prof module | https://github.com/nodejs/node/commit/58eccb12134022deac3aeef3113e914db84600d6 |
| 58eccb1 | https://github.com/nodejs/node/commit/58eccb12134022deac3aeef3113e914db84600d6 |
| #28183 | https://github.com/nodejs/node/pull/28183 |
| targos | https://github.com/targos |
|
Jun 18, 2019
| https://github.com/nodejs/node/pull/28183#ref-commit-a3f8385 |
|
| https://github.com/Trott |
|
| https://github.com/targos |
| test: remove unused output argument for getFrames() | https://github.com/nodejs/node/commit/a3f8385d7fcae0c4cc4a382e365260861e3a5b42 |
| a3f8385 | https://github.com/nodejs/node/commit/a3f8385d7fcae0c4cc4a382e365260861e3a5b42 |
| #28183 | https://github.com/nodejs/node/pull/28183 |
| targos | https://github.com/targos |
|
Jun 18, 2019
| https://github.com/nodejs/node/pull/28183#ref-commit-bd16f9b |
|
| https://github.com/Trott |
|
| https://github.com/targos |
| test: remove FIB environment variable from cpu-prof.js | https://github.com/nodejs/node/commit/bd16f9b2daa2a42dbd4804644b513c999d586e34 |
| bd16f9b | https://github.com/nodejs/node/commit/bd16f9b2daa2a42dbd4804644b513c999d586e34 |
| #28183 | https://github.com/nodejs/node/pull/28183 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28183 |
|
| https://github.com/joyeecheung |
|
joyeecheung
| https://github.com/joyeecheung |
|
| https://github.com/nodejs/node/pull/28183/files/cda56ca9a88f26e1997a7541a4775fb04dfc39fb |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/28183/files/cda56ca9a88f26e1997a7541a4775fb04dfc39fb |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/28183/files/b6f6ba14c963c08a7c7331a02e41fc92c127e49b |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/28183 |
|
| https://github.com/Trott |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/jasnell |
|
| https://github.com/joyeecheung |
|
| https://github.com/richardlau |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |