René's URL Explorer Experiment


Title: http2: add constant to already destructured constants by dnalborczyk · Pull Request #28176 · nodejs/node · GitHub

Open Graph Title: http2: add constant to already destructured constants by dnalborczyk · Pull Request #28176 · nodejs/node

X Title: http2: add constant to already destructured constants by dnalborczyk · Pull Request #28176 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: add constant to already destructured constants and while we're at it, destructure Readable and constants as well, remove binding. Checklist make -j4 test (UNIX), or vcbuild test (Windows) pa...

X Description: add constant to already destructured constants and while we're at it, destructure Readable and constants as well, remove binding. Checklist make -j4 test (UNIX), or vcbuild test (Windows...

Opengraph URL: https://github.com/nodejs/node/pull/28176

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:04e9785a-bd4c-3337-d6ea-4ddbbbfc9cbb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9A70:33952:3137F37:44D66C8:6A4F75F8
html-safe-nonce1d8ae3691350c37fa6f47981a951e0436e3a59808b154f998a08ab7b779b0ffe
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QTcwOjMzOTUyOjMxMzdGMzc6NDRENjZDODo2QTRGNzVGOCIsInZpc2l0b3JfaWQiOiI4ODUzMTc5NDU3MjUyMzI0ODU2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac61ca64190b9acde39ca8b2e41d0c63f038600fd97e6c431646cc40b6f1e4d3d3
hovercard-subject-tagpull_request:287137478
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28176/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/11e34506f04ef4dc58933f10d7868228b2613f6c2fc49a2b024080798b4b2500/nodejs/node/pull/28176
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/11e34506f04ef4dc58933f10d7868228b2613f6c2fc49a2b024080798b4b2500/nodejs/node/pull/28176
og:image:altadd constant to already destructured constants and while we're at it, destructure Readable and constants as well, remove binding. Checklist make -j4 test (UNIX), or vcbuild test (Windows) pa...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamednalborczyk
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/28176#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28176
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28176
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/28176
Reloadhttps://github.com/nodejs/node/pull/28176
Reloadhttps://github.com/nodejs/node/pull/28176
Please reload this pagehttps://github.com/nodejs/node/pull/28176
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/28176
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 973 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
dnalborczykhttps://github.com/dnalborczyk
nodejs:masterhttps://github.com/nodejs/node/tree/master
dnalborczyk:destructhttps://github.com/dnalborczyk/node/tree/destruct
Conversationhttps://github.com/nodejs/node/pull/28176
Commits2 (2)https://github.com/nodejs/node/pull/28176/commits
Checkshttps://github.com/nodejs/node/pull/28176/checks
Files changedhttps://github.com/nodejs/node/pull/28176/files
http2: add constant to already destructured constantshttps://github.com/nodejs/node/pull/28176#top
dnalborczykhttps://github.com/dnalborczyk
nodejs:masterhttps://github.com/nodejs/node/tree/master
dnalborczyk:destructhttps://github.com/dnalborczyk/node/tree/destruct
https://github.com/dnalborczyk
dnalborczykhttps://github.com/dnalborczyk
Jun 11, 2019https://github.com/nodejs/node/pull/28176#issue-454749364
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/28176
https://github.com/dnalborczyk
http2: add constant to already destructured constantshttps://github.com/nodejs/node/pull/28176/commits/a4d8cd412291e5e146e6ea915828bbc621db6f5e
a4d8cd4https://github.com/nodejs/node/pull/28176/commits/a4d8cd412291e5e146e6ea915828bbc621db6f5e
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
Jun 11, 2019https://github.com/nodejs/node/pull/28176#event-2404515459
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jun 11, 2019 https://github.com/nodejs/node/pull/28176#pullrequestreview-248252471
View reviewed changes https://github.com/nodejs/node/pull/28176/files/a4d8cd412291e5e146e6ea915828bbc621db6f5e
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jun 11, 2019 https://github.com/nodejs/node/pull/28176#pullrequestreview-248417496
View reviewed changes https://github.com/nodejs/node/pull/28176/files/a4d8cd412291e5e146e6ea915828bbc621db6f5e
lib/internal/http2/compat.jshttps://github.com/nodejs/node/pull/28176/files/a4d8cd412291e5e146e6ea915828bbc621db6f5e#diff-e241fc9fee7eaeaf021850ee74d273cc350099b52c548d7fdb85c8440eef1c8f
Please reload this pagehttps://github.com/nodejs/node/pull/28176
lib/internal/http2/compat.jshttps://github.com/nodejs/node/pull/28176/files/a4d8cd412291e5e146e6ea915828bbc621db6f5e#diff-e241fc9fee7eaeaf021850ee74d273cc350099b52c548d7fdb85c8440eef1c8f
lpincahttps://github.com/lpinca
Jun 11, 2019https://github.com/nodejs/node/pull/28176#discussion_r292644001
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28176
dnalborczykhttps://github.com/dnalborczyk
Jun 11, 2019https://github.com/nodejs/node/pull/28176#discussion_r292681550
Please reload this pagehttps://github.com/nodejs/node/pull/28176
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28176
lib/internal/http2/compat.jshttps://github.com/nodejs/node/pull/28176/files/a4d8cd412291e5e146e6ea915828bbc621db6f5e#diff-e241fc9fee7eaeaf021850ee74d273cc350099b52c548d7fdb85c8440eef1c8f
lpincahttps://github.com/lpinca
Jun 11, 2019https://github.com/nodejs/node/pull/28176#discussion_r292644107
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28176
https://github.com/dnalborczyk
http2: destructure constants from require callhttps://github.com/nodejs/node/pull/28176/commits/d2a9fcf566adfd73570625120a0595793f1a1ac1
d2a9fcfhttps://github.com/nodejs/node/pull/28176/commits/d2a9fcf566adfd73570625120a0595793f1a1ac1
https://github.com/dnalborczyk
dnalborczykhttps://github.com/dnalborczyk
force-pushedhttps://github.com/nodejs/node/compare/9979753de3e43cb2b80eb610ae56b533d5d97ac7..d2a9fcf566adfd73570625120a0595793f1a1ac1
9979753https://github.com/nodejs/node/commit/9979753de3e43cb2b80eb610ae56b533d5d97ac7
d2a9fcfhttps://github.com/nodejs/node/commit/d2a9fcf566adfd73570625120a0595793f1a1ac1
Compare https://github.com/nodejs/node/compare/9979753de3e43cb2b80eb610ae56b533d5d97ac7..d2a9fcf566adfd73570625120a0595793f1a1ac1
June 11, 2019 22:40https://github.com/nodejs/node/pull/28176#event-2405691460
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 14, 2019 https://github.com/nodejs/node/pull/28176#pullrequestreview-249692759
View reviewed changes https://github.com/nodejs/node/pull/28176/files/d2a9fcf566adfd73570625120a0595793f1a1ac1
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jul 5, 2019https://github.com/nodejs/node/pull/28176#issuecomment-508594043
Please reload this pagehttps://github.com/nodejs/node/pull/28176
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jul 5, 2019https://github.com/nodejs/node/pull/28176#event-2461456409
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28176
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 8, 2019 https://github.com/nodejs/node/pull/28176#pullrequestreview-259192750
View reviewed changes https://github.com/nodejs/node/pull/28176/files/d2a9fcf566adfd73570625120a0595793f1a1ac1
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 8, 2019https://github.com/nodejs/node/pull/28176#issuecomment-509418838
https://ci.nodejs.org/job/node-test-pull-request/24339/https://ci.nodejs.org/job/node-test-pull-request/24339/
Please reload this pagehttps://github.com/nodejs/node/pull/28176
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 30, 2019https://github.com/nodejs/node/pull/28176#issuecomment-516251864
https://ci.nodejs.org/job/node-test-pull-request/24758/https://ci.nodejs.org/job/node-test-pull-request/24758/
Please reload this pagehttps://github.com/nodejs/node/pull/28176
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 30, 2019https://github.com/nodejs/node/pull/28176#issuecomment-516261923
https://ci.nodejs.org/job/node-test-pull-request/24769/https://ci.nodejs.org/job/node-test-pull-request/24769/
Please reload this pagehttps://github.com/nodejs/node/pull/28176
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 30, 2019https://github.com/nodejs/node/pull/28176#issuecomment-516283062
3a9cb5c...b04de23https://github.com/nodejs/node/compare/3a9cb5ccb054393df131254a29ab8b1847c16751...b04de23afa6da18d7b81b70c1a4bb53476f125c7
Please reload this pagehttps://github.com/nodejs/node/pull/28176
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 30, 2019https://github.com/nodejs/node/pull/28176#event-2518661186
Trotthttps://github.com/Trott
Jul 30, 2019 https://github.com/nodejs/node/pull/28176#ref-commit-62c8c61
https://github.com/dnalborczyk
https://github.com/Trott
http2: add constant to already destructured constantshttps://github.com/Trott/io.js/commit/62c8c61e333f161672ea6faca31e1bd1bfb9c997
62c8c61https://github.com/Trott/io.js/commit/62c8c61e333f161672ea6faca31e1bd1bfb9c997
nodejs#28176https://github.com/nodejs/node/pull/28176
Trotthttps://github.com/Trott
Jul 30, 2019 https://github.com/nodejs/node/pull/28176#ref-commit-b04de23
https://github.com/dnalborczyk
https://github.com/Trott
http2: destructure constants from require callhttps://github.com/Trott/io.js/commit/b04de23afa6da18d7b81b70c1a4bb53476f125c7
b04de23https://github.com/Trott/io.js/commit/b04de23afa6da18d7b81b70c1a4bb53476f125c7
nodejs#28176https://github.com/nodejs/node/pull/28176
targoshttps://github.com/targos
Aug 2, 2019 https://github.com/nodejs/node/pull/28176#ref-commit-d0d3149
https://github.com/dnalborczyk
https://github.com/targos
http2: add constant to already destructured constantshttps://github.com/nodejs/node/commit/d0d31498d1bc177b3167a255ebad32559745e640
d0d3149https://github.com/nodejs/node/commit/d0d31498d1bc177b3167a255ebad32559745e640
#28176https://github.com/nodejs/node/pull/28176
targoshttps://github.com/targos
Aug 2, 2019 https://github.com/nodejs/node/pull/28176#ref-commit-fa82cbc
https://github.com/dnalborczyk
https://github.com/targos
http2: destructure constants from require callhttps://github.com/nodejs/node/commit/fa82cbc6cb002e7894431a93950a92a9000d4e94
fa82cbchttps://github.com/nodejs/node/commit/fa82cbc6cb002e7894431a93950a92a9000d4e94
#28176https://github.com/nodejs/node/pull/28176
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Aug 6, 2019 https://github.com/nodejs/node/pull/28176#ref-pullrequest-477378713
v12.8.0 release proposal #29017 https://github.com/nodejs/node/pull/29017
https://github.com/dnalborczyk
dnalborczykhttps://github.com/dnalborczyk
May 21, 2020 04:27https://github.com/nodejs/node/pull/28176#event-3359195102
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28176
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/28176/files/a4d8cd412291e5e146e6ea915828bbc621db6f5e
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/28176/files/d2a9fcf566adfd73570625120a0595793f1a1ac1
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/28176/files/d2a9fcf566adfd73570625120a0595793f1a1ac1
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/28176/files/a4d8cd412291e5e146e6ea915828bbc621db6f5e
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
Please reload this pagehttps://github.com/nodejs/node/pull/28176
https://github.com/dnalborczyk
https://github.com/BridgeAR
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/jasnell
https://github.com/lpinca
https://github.com/cjihrig
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.