René's URL Explorer Experiment


Title: worker: only unref port for stdin if we ref’ed it before by addaleax · Pull Request #28153 · nodejs/node · GitHub

Open Graph Title: worker: only unref port for stdin if we ref’ed it before by addaleax · Pull Request #28153 · nodejs/node

X Title: worker: only unref port for stdin if we ref’ed it before by addaleax · Pull Request #28153 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: We set the kStartedReading flag from _read() for Worker stdio, and then ref() the port. However, the .on('end') handler is also attached when ._read() is not called, e.g. when process.stdin...

X Description: We set the kStartedReading flag from _read() for Worker stdio, and then ref() the port. However, the .on('end') handler is also attached when ._read() is not called, e.g. when proce...

Opengraph URL: https://github.com/nodejs/node/pull/28153

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:74b886ba-1758-38b7-c35d-b4b29ff3ee5e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8AB6:18EF1B:855468E:B97E081:6A5051EA
html-safe-nonce397d641387bd36367dd897cfa93ef3cd06e024d7c62d579dde86c45761e1f2eb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QUI2OjE4RUYxQjo4NTU0NjhFOkI5N0UwODE6NkE1MDUxRUEiLCJ2aXNpdG9yX2lkIjoiODk5NjUxOTc5MDI3ODM2NTY3NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac77560c635c207590c8d43b1d2b92c664b906625bd9a4f78982b028d64ad9b67d
hovercard-subject-tagpull_request:286709689
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28153/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2f960c420e0c5f3c3acf3f6225dde93a2da25d42e615dc17c01e09828e0e6a54/nodejs/node/pull/28153
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2f960c420e0c5f3c3acf3f6225dde93a2da25d42e615dc17c01e09828e0e6a54/nodejs/node/pull/28153
og:image:altWe set the kStartedReading flag from _read() for Worker stdio, and then ref() the port. However, the .on('end') handler is also attached when ._read() is not called, e.g. when process.stdin...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
Noned6dc8294eb500fa36bbc57472d61fe87c522f9c3c1d64f70f4926f66a66a7efb
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5741a45fe07e5f377d0d4c524a92e3056acc51bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/28153#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28153
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28153
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/28153
Reloadhttps://github.com/nodejs/node/pull/28153
Reloadhttps://github.com/nodejs/node/pull/28153
Please reload this pagehttps://github.com/nodejs/node/pull/28153
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/28153
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 978 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:worker-stdin-stdouthttps://github.com/addaleax/node/tree/worker-stdin-stdout
Conversationhttps://github.com/nodejs/node/pull/28153
Commits1 (1)https://github.com/nodejs/node/pull/28153/commits
Checkshttps://github.com/nodejs/node/pull/28153/checks
Files changedhttps://github.com/nodejs/node/pull/28153/files
worker: only unref port for stdin if we ref’ed it beforehttps://github.com/nodejs/node/pull/28153#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:worker-stdin-stdouthttps://github.com/addaleax/node/tree/worker-stdin-stdout
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 10, 2019https://github.com/nodejs/node/pull/28153#issue-454210941
#28144https://github.com/nodejs/node/issues/28144
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/28153
https://github.com/addaleax
worker: only unref port for stdin if we ref’ed it beforehttps://github.com/nodejs/node/pull/28153/commits/5660ae267064820f15ebb7221fab37b9881bd0f9
5660ae2https://github.com/nodejs/node/pull/28153/commits/5660ae267064820f15ebb7221fab37b9881bd0f9
nodejs#28144https://github.com/nodejs/node/issues/28144
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
worker https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aworker
Jun 10, 2019https://github.com/nodejs/node/pull/28153#event-2401210647
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28153
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28153
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28153
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jun 10, 2019 https://github.com/nodejs/node/pull/28153#pullrequestreview-247691808
View reviewed changes https://github.com/nodejs/node/pull/28153/files/5660ae267064820f15ebb7221fab37b9881bd0f9
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 10, 2019 https://github.com/nodejs/node/pull/28153#pullrequestreview-247858567
View reviewed changes https://github.com/nodejs/node/pull/28153/files/5660ae267064820f15ebb7221fab37b9881bd0f9
chjjhttps://github.com/chjj
Jun 11, 2019 https://github.com/nodejs/node/pull/28153#ref-commit-b5214a2
https://github.com/chjj
process/stdio: fix ref watching for readable stream.https://github.com/chjj/bthreads/commit/b5214a2f9fa374d7e7784904456152de7c2ceb82
b5214a2https://github.com/chjj/bthreads/commit/b5214a2f9fa374d7e7784904456152de7c2ceb82
nodejs/node#28153https://github.com/nodejs/node/pull/28153
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jun 11, 2019 https://github.com/nodejs/node/pull/28153#pullrequestreview-248486270
View reviewed changes https://github.com/nodejs/node/pull/28153/files/5660ae267064820f15ebb7221fab37b9881bd0f9
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jun 19, 2019https://github.com/nodejs/node/pull/28153#event-2425680099
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28153
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28153
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28153
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28153
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 20, 2019https://github.com/nodejs/node/pull/28153#issuecomment-504109170
https://ci.nodejs.org/job/node-test-pull-request/24015/https://ci.nodejs.org/job/node-test-pull-request/24015/
Please reload this pagehttps://github.com/nodejs/node/pull/28153
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 20, 2019https://github.com/nodejs/node/pull/28153#issuecomment-504113417
d5cf51dhttps://github.com/nodejs/node/commit/d5cf51dad589dffed2f15cc3a49d19ae13968b8f
Please reload this pagehttps://github.com/nodejs/node/pull/28153
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 20, 2019https://github.com/nodejs/node/pull/28153#event-2428106150
Trotthttps://github.com/Trott
Jun 20, 2019 https://github.com/nodejs/node/pull/28153#ref-commit-d5cf51d
https://github.com/addaleax
https://github.com/Trott
worker: only unref port for stdin if we ref’ed it beforehttps://github.com/Trott/io.js/commit/d5cf51dad589dffed2f15cc3a49d19ae13968b8f
d5cf51dhttps://github.com/Trott/io.js/commit/d5cf51dad589dffed2f15cc3a49d19ae13968b8f
nodejs#28144https://github.com/nodejs/node/issues/28144
nodejs#28153https://github.com/nodejs/node/pull/28153
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jun 20, 2019https://github.com/nodejs/node/pull/28153#issuecomment-504117366
#28327https://github.com/nodejs/node/pull/28327
https://travis-ci.com/nodejs/node/jobs/209729625#L265-L296https://travis-ci.com/nodejs/node/jobs/209729625#L265-L296
Please reload this pagehttps://github.com/nodejs/node/pull/28153
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
June 20, 2019 20:59https://github.com/nodejs/node/pull/28153#event-2428604317
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 20, 2019https://github.com/nodejs/node/pull/28153#issuecomment-504181417
@richardlauhttps://github.com/richardlau
Please reload this pagehttps://github.com/nodejs/node/pull/28153
targoshttps://github.com/targos
Jul 2, 2019 https://github.com/nodejs/node/pull/28153#ref-commit-2053dd0
https://github.com/addaleax
https://github.com/targos
worker: only unref port for stdin if we ref’ed it beforehttps://github.com/nodejs/node/commit/2053dd0c9c12242dc8d3de0e0b763f15bfb1ff0d
2053dd0https://github.com/nodejs/node/commit/2053dd0c9c12242dc8d3de0e0b763f15bfb1ff0d
#28144https://github.com/nodejs/node/issues/28144
#28153https://github.com/nodejs/node/pull/28153
targoshttps://github.com/targos
Jul 2, 2019 https://github.com/nodejs/node/pull/28153#ref-commit-d711542
https://github.com/targos
2019-07-03, Version 12.6.0 (Current)https://github.com/nodejs/node/commit/d711542f65df9a087d21f868305011ff8118c586
d711542https://github.com/nodejs/node/commit/d711542f65df9a087d21f868305011ff8118c586
#27992https://github.com/nodejs/node/pull/27992
#28325https://github.com/nodejs/node/pull/28325
#28449https://github.com/nodejs/node/pull/28449
#28018https://github.com/nodejs/node/pull/28018
#28490https://github.com/nodejs/node/pull/28490
#28007https://github.com/nodejs/node/pull/28007
#28153https://github.com/nodejs/node/pull/28153
#28508https://github.com/nodejs/node/pull/28508
https://github.com/targos
targoshttps://github.com/targos
Jul 2, 2019 https://github.com/nodejs/node/pull/28153#ref-pullrequest-463146264
Release v12.6.0 proposal #28508 https://github.com/nodejs/node/pull/28508
targoshttps://github.com/targos
Jul 2, 2019 https://github.com/nodejs/node/pull/28153#ref-commit-e6a8ac1
https://github.com/targos
2019-07-03, Version 12.6.0 (Current)https://github.com/nodejs/node/commit/e6a8ac12407b92557984cd1bbce7af97fa656f40
e6a8ac1https://github.com/nodejs/node/commit/e6a8ac12407b92557984cd1bbce7af97fa656f40
#27992https://github.com/nodejs/node/pull/27992
#28325https://github.com/nodejs/node/pull/28325
#28449https://github.com/nodejs/node/pull/28449
#28018https://github.com/nodejs/node/pull/28018
#28490https://github.com/nodejs/node/pull/28490
#28007https://github.com/nodejs/node/pull/28007
#28153https://github.com/nodejs/node/pull/28153
https://github.com/gengjiawenhttps://github.com/gengjiawen
#28322https://github.com/nodejs/node/pull/28322
#28508https://github.com/nodejs/node/pull/28508
targoshttps://github.com/targos
Jul 2, 2019 https://github.com/nodejs/node/pull/28153#ref-commit-e71a0f4
https://github.com/targos
2019-07-03, Version 12.6.0 (Current)https://github.com/nodejs/node/commit/e71a0f4d5faa4ad77887fbb3fff0ddb7bca6942e
e71a0f4https://github.com/nodejs/node/commit/e71a0f4d5faa4ad77887fbb3fff0ddb7bca6942e
#27992https://github.com/nodejs/node/pull/27992
#28325https://github.com/nodejs/node/pull/28325
#28449https://github.com/nodejs/node/pull/28449
#28511https://github.com/nodejs/node/pull/28511
#28018https://github.com/nodejs/node/pull/28018
#28490https://github.com/nodejs/node/pull/28490
#28007https://github.com/nodejs/node/pull/28007
#28153https://github.com/nodejs/node/pull/28153
https://github.com/gengjiawenhttps://github.com/gengjiawen
#28322https://github.com/nodejs/node/pull/28322
#28508https://github.com/nodejs/node/pull/28508
targoshttps://github.com/targos
Jul 3, 2019 https://github.com/nodejs/node/pull/28153#ref-commit-fcf8fe9
https://github.com/targos
2019-07-03, Version 12.6.0 (Current)https://github.com/nodejs/node/commit/fcf8fe9f1a556758eb9faf86bf74de2ddda805c8
fcf8fe9https://github.com/nodejs/node/commit/fcf8fe9f1a556758eb9faf86bf74de2ddda805c8
#27992https://github.com/nodejs/node/pull/27992
#28325https://github.com/nodejs/node/pull/28325
#28449https://github.com/nodejs/node/pull/28449
#28511https://github.com/nodejs/node/pull/28511
#28018https://github.com/nodejs/node/pull/28018
#28490https://github.com/nodejs/node/pull/28490
#28007https://github.com/nodejs/node/pull/28007
#28153https://github.com/nodejs/node/pull/28153
https://github.com/gengjiawenhttps://github.com/gengjiawen
#28322https://github.com/nodejs/node/pull/28322
#28508https://github.com/nodejs/node/pull/28508
2019-07-03 Version 12.6.0 (Current) @targos beevelop/docker-nodejs#288 https://github.com/beevelop/docker-nodejs/issues/288
2019-07-03 Version 12.6.0 (Current) @targos beevelop/docker-nodejs#289 https://github.com/beevelop/docker-nodejs/issues/289
2019-07-03 Version 12.6.0 (Current) @targos beevelop/docker-nodejs#290 https://github.com/beevelop/docker-nodejs/issues/290
https://github.com/JoshCheek
JoshCheekhttps://github.com/JoshCheek
Jul 3, 2019https://github.com/nodejs/node/pull/28153#issuecomment-508276835
Please reload this pagehttps://github.com/nodejs/node/pull/28153
https://github.com/naz
nazhttps://github.com/naz
Nov 30, 2020 https://github.com/nodejs/node/pull/28153#ref-issue-753053783
Error thrown "stdin.unref is not a function" during Parent instance initialization chjj/bthreads#8 https://github.com/chjj/bthreads/issues/8
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28153
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/28153/files/5660ae267064820f15ebb7221fab37b9881bd0f9
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/28153/files/5660ae267064820f15ebb7221fab37b9881bd0f9
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/28153/files/5660ae267064820f15ebb7221fab37b9881bd0f9
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
worker https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aworker
Worker threads get killed if they listen for data on stdin https://github.com/nodejs/node/issues/28144
Please reload this pagehttps://github.com/nodejs/node/pull/28153
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/richardlau
https://github.com/JoshCheek
https://github.com/cjihrig
https://github.com/BridgeAR
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.