René's URL Explorer Experiment


Title: tls: remove unnecessary set of DEFAULT_MAX_VERSION by danbev · Pull Request #28147 · nodejs/node · GitHub

Open Graph Title: tls: remove unnecessary set of DEFAULT_MAX_VERSION by danbev · Pull Request #28147 · nodejs/node

X Title: tls: remove unnecessary set of DEFAULT_MAX_VERSION by danbev · Pull Request #28147 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This commit removes what looks like an unnecessary setting of exports.DEFAULT_MAX_VALUE. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

X Description: This commit removes what looks like an unnecessary setting of exports.DEFAULT_MAX_VALUE. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

Opengraph URL: https://github.com/nodejs/node/pull/28147

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e5d00b65-8071-e0dd-bc2c-49d58a2a39f8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB600:80ED0:67441:81BD7:699262E7
html-safe-nonce0311aa16ad0d0dcea4ed8806bab63586a443a232125110743c73097750555797
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNjAwOjgwRUQwOjY3NDQxOjgxQkQ3OjY5OTI2MkU3IiwidmlzaXRvcl9pZCI6IjUwMTEwNjAyODg3MjU4NjkyODciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac3d806ca2bcfe831f48c905b8371b5379d7ed803bc4dde12767ac932ad8619701
hovercard-subject-tagpull_request:286642037
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28147/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a667db29c5e6ba1b0f7c06c9445352645b68c2f0872f6e2e19b5538cd1fc824e/nodejs/node/pull/28147
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a667db29c5e6ba1b0f7c06c9445352645b68c2f0872f6e2e19b5538cd1fc824e/nodejs/node/pull/28147
og:image:altThis commit removes what looks like an unnecessary setting of exports.DEFAULT_MAX_VALUE. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedanbev
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/28147#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28147
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28147
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/28147
Reloadhttps://github.com/nodejs/node/pull/28147
Reloadhttps://github.com/nodejs/node/pull/28147
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/28147
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.8k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 716 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
danbevhttps://github.com/danbev
nodejs:masterhttps://github.com/nodejs/node/tree/master
danbev:tls_default_max_versionhttps://github.com/danbev/node/tree/tls_default_max_version
Conversationhttps://github.com/nodejs/node/pull/28147
Commits1 (1)https://github.com/nodejs/node/pull/28147/commits
Checkshttps://github.com/nodejs/node/pull/28147/checks
Files changedhttps://github.com/nodejs/node/pull/28147/files
tls: remove unnecessary set of DEFAULT_MAX_VERSIONhttps://github.com/nodejs/node/pull/28147#top
danbevhttps://github.com/danbev
nodejs:masterhttps://github.com/nodejs/node/tree/master
danbev:tls_default_max_versionhttps://github.com/danbev/node/tree/tls_default_max_version
https://github.com/danbev
danbevhttps://github.com/danbev
Jun 10, 2019https://github.com/nodejs/node/pull/28147#issue-454127519
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/28147
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 10, 2019https://github.com/nodejs/node/pull/28147#issuecomment-500385854
Please reload this pagehttps://github.com/nodejs/node/pull/28147
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
tls https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls
Jun 10, 2019https://github.com/nodejs/node/pull/28147#event-2400703510
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 10, 2019https://github.com/nodejs/node/pull/28147#issuecomment-500386566
https://ci.nodejs.org/job/node-test-pull-request/23744/https://ci.nodejs.org/job/node-test-pull-request/23744/
Please reload this pagehttps://github.com/nodejs/node/pull/28147
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 10, 2019 https://github.com/nodejs/node/pull/28147#pullrequestreview-247571560
View reviewed changes https://github.com/nodejs/node/pull/28147/files
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Jun 10, 2019 https://github.com/nodejs/node/pull/28147#pullrequestreview-247630794
View reviewed changes https://github.com/nodejs/node/pull/28147/files
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jun 10, 2019 https://github.com/nodejs/node/pull/28147#pullrequestreview-247670080
View reviewed changes https://github.com/nodejs/node/pull/28147/files
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 10, 2019 https://github.com/nodejs/node/pull/28147#pullrequestreview-247673264
View reviewed changes https://github.com/nodejs/node/pull/28147/files
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Jun 10, 2019https://github.com/nodejs/node/pull/28147#issuecomment-500464812
https://github.com/nodejs/node/search?q=DEFAULT_MAX_VERSION&unscoped_q=DEFAULT_MAX_VERSIONhttps://github.com/nodejs/node/search?q=DEFAULT_MAX_VERSION&unscoped_q=DEFAULT_MAX_VERSION
Please reload this pagehttps://github.com/nodejs/node/pull/28147
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jun 10, 2019 https://github.com/nodejs/node/pull/28147#pullrequestreview-247822860
View reviewed changes https://github.com/nodejs/node/pull/28147/files
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jun 11, 2019 https://github.com/nodejs/node/pull/28147#pullrequestreview-247900466
View reviewed changes https://github.com/nodejs/node/pull/28147/files
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jun 11, 2019https://github.com/nodejs/node/pull/28147#issuecomment-500637180
https://github.com/nodejs/node/search?q=DEFAULT_MAX_VERSION&unscoped_q=DEFAULT_MAX_VERSIONhttps://github.com/nodejs/node/search?q=DEFAULT_MAX_VERSION&unscoped_q=DEFAULT_MAX_VERSION
Please reload this pagehttps://github.com/nodejs/node/pull/28147
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Jun 11, 2019 https://github.com/nodejs/node/pull/28147#pullrequestreview-247903954
View reviewed changes https://github.com/nodejs/node/pull/28147/files
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 11, 2019 https://github.com/nodejs/node/pull/28147#pullrequestreview-248420357
View reviewed changes https://github.com/nodejs/node/pull/28147/files
https://github.com/danbev
danbevhttps://github.com/danbev
Jun 17, 2019https://github.com/nodejs/node/pull/28147#issuecomment-502548949
Please reload this pagehttps://github.com/nodejs/node/pull/28147
node-test-commit-linux-containeredhttps://ci.nodejs.org/job/node-test-commit-linux-containered/13457/
Please reload this pagehttps://github.com/nodejs/node/pull/28147
https://github.com/danbev
tls: remove unnecessary set of DEFAULT_MAX_VERSIONhttps://github.com/nodejs/node/pull/28147/commits/85777f8301e273e67e0f2d87d1e48e4a1aac48cb
85777f8https://github.com/nodejs/node/pull/28147/commits/85777f8301e273e67e0f2d87d1e48e4a1aac48cb
https://github.com/danbev
danbevhttps://github.com/danbev
force-pushedhttps://github.com/nodejs/node/compare/2aec0f51238019d28e510073d8131976952e8bb0..85777f8301e273e67e0f2d87d1e48e4a1aac48cb
2aec0f5https://github.com/nodejs/node/commit/2aec0f51238019d28e510073d8131976952e8bb0
85777f8https://github.com/nodejs/node/commit/85777f8301e273e67e0f2d87d1e48e4a1aac48cb
Compare https://github.com/nodejs/node/compare/2aec0f51238019d28e510073d8131976952e8bb0..85777f8301e273e67e0f2d87d1e48e4a1aac48cb
June 17, 2019 08:45https://github.com/nodejs/node/pull/28147#event-2416864784
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 17, 2019https://github.com/nodejs/node/pull/28147#issuecomment-502592258
https://ci.nodejs.org/job/node-test-pull-request/23933/https://ci.nodejs.org/job/node-test-pull-request/23933/
Please reload this pagehttps://github.com/nodejs/node/pull/28147
https://github.com/danbev
danbevhttps://github.com/danbev
Jun 17, 2019https://github.com/nodejs/node/pull/28147#issuecomment-502664993
node-test-commit-osxhttps://ci.nodejs.org/job/node-test-commit-osx/27498/
Please reload this pagehttps://github.com/nodejs/node/pull/28147
https://github.com/danbev
danbevhttps://github.com/danbev
Jun 17, 2019https://github.com/nodejs/node/pull/28147#issuecomment-502669819
c925d1dhttps://github.com/nodejs/node/commit/c925d1dcaa13e23ae51769c8e9a20e9141a643a4
Please reload this pagehttps://github.com/nodejs/node/pull/28147
https://github.com/danbev
danbevhttps://github.com/danbev
Jun 17, 2019https://github.com/nodejs/node/pull/28147#event-2417491999
https://github.com/danbev
danbevhttps://github.com/danbev
June 17, 2019 12:52https://github.com/nodejs/node/pull/28147#event-2417492743
danbevhttps://github.com/danbev
Jun 17, 2019 https://github.com/nodejs/node/pull/28147#ref-commit-c925d1d
https://github.com/danbev
tls: remove unnecessary set of DEFAULT_MAX_VERSIONhttps://github.com/nodejs/node/commit/c925d1dcaa13e23ae51769c8e9a20e9141a643a4
c925d1dhttps://github.com/nodejs/node/commit/c925d1dcaa13e23ae51769c8e9a20e9141a643a4
#28147https://github.com/nodejs/node/pull/28147
BridgeARhttps://github.com/BridgeAR
Jun 17, 2019 https://github.com/nodejs/node/pull/28147#ref-commit-e270ff1
https://github.com/danbev
https://github.com/BridgeAR
tls: remove unnecessary set of DEFAULT_MAX_VERSIONhttps://github.com/nodejs/node/commit/e270ff1166440509fa3c4a3f3e8789a788660fa1
e270ff1https://github.com/nodejs/node/commit/e270ff1166440509fa3c4a3f3e8789a788660fa1
#28147https://github.com/nodejs/node/pull/28147
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jun 17, 2019 https://github.com/nodejs/node/pull/28147#ref-pullrequest-457113206
v12.5.0 proposal #28268 https://github.com/nodejs/node/pull/28268
targoshttps://github.com/targos
Jun 18, 2019 https://github.com/nodejs/node/pull/28147#ref-commit-7044a7a
https://github.com/danbev
https://github.com/targos
tls: remove unnecessary set of DEFAULT_MAX_VERSIONhttps://github.com/nodejs/node/commit/7044a7a3027dd60419fe010c1bfe5152b54ece36
7044a7ahttps://github.com/nodejs/node/commit/7044a7a3027dd60419fe010c1bfe5152b54ece36
#28147https://github.com/nodejs/node/pull/28147
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28147
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/28147/files/2aec0f51238019d28e510073d8131976952e8bb0
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/28147/files/2aec0f51238019d28e510073d8131976952e8bb0
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/28147/files/2aec0f51238019d28e510073d8131976952e8bb0
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/28147/files/2aec0f51238019d28e510073d8131976952e8bb0
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/28147/files/2aec0f51238019d28e510073d8131976952e8bb0
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/28147/files/2aec0f51238019d28e510073d8131976952e8bb0
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/28147/files/2aec0f51238019d28e510073d8131976952e8bb0
https://github.com/sam-github
sam-github https://github.com/sam-github
https://github.com/nodejs/node/pull/28147/files/2aec0f51238019d28e510073d8131976952e8bb0
tls https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls
Please reload this pagehttps://github.com/nodejs/node/pull/28147
https://github.com/danbev
https://github.com/nodejs-github-bot
https://github.com/trivikr
https://github.com/richardlau
https://github.com/sam-github
https://github.com/jasnell
https://github.com/Trott
https://github.com/addaleax
https://github.com/lpinca
https://github.com/cjihrig
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.