| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:4adbd57d-456d-91ef-0cab-c4b8e6ddd20f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9F40:C8AE2:7A39C36:ABBD225:6A502C0E |
| html-safe-nonce | d21096ef3a7f5678a39e1ce789bb76ba5523de288d40eb57b947e3dd41434c3e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RjQwOkM4QUUyOjdBMzlDMzY6QUJCRDIyNTo2QTUwMkMwRSIsInZpc2l0b3JfaWQiOiIxNTEwNDgyMDU2MzgzMDQ4NzE4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 676612b6a03dcbecbd19938406f5a2d0ee83c399b8852223a876c9beede27103 |
| hovercard-subject-tag | pull_request:285671341 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28092/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/2e15fa47596b39f70f5f397a053100a50ae0d46eacecdecd8690963407e7d498/nodejs/node/pull/28092 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/2e15fa47596b39f70f5f397a053100a50ae0d46eacecdecd8690963407e7d498/nodejs/node/pull/28092 |
| og:image:alt | fix #28084
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
documentation is changed or added
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | himself65 |
| hostname | github.com |
| expected-hostname | github.com |
| None | d6dc8294eb500fa36bbc57472d61fe87c522f9c3c1d64f70f4926f66a66a7efb |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d90666eaf032b7eb8975a378efe38e37f4ebb96c |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/28092#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28092 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28092 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/28092 |
| Reload | https://github.com/nodejs/node/pull/28092 |
| Reload | https://github.com/nodejs/node/pull/28092 |
| Please reload this page | https://github.com/nodejs/node/pull/28092 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/28092 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
977
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| himself65 | https://github.com/himself65 |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| himself65:28084 | https://github.com/himself65/node/tree/28084 |
| Conversation | https://github.com/nodejs/node/pull/28092 |
| Commits1 (1) | https://github.com/nodejs/node/pull/28092/commits |
| Checks | https://github.com/nodejs/node/pull/28092/checks |
| Files changed | https://github.com/nodejs/node/pull/28092/files |
| doc: add examples at assert.strictEqual | https://github.com/nodejs/node/pull/28092#top |
| himself65 | https://github.com/himself65 |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| himself65:28084 | https://github.com/himself65/node/tree/28084 |
|
| https://github.com/himself65 |
| himself65 | https://github.com/himself65 |
| Jun 6, 2019 | https://github.com/nodejs/node/pull/28092#issue-452867593 |
| #28084 | https://github.com/nodejs/node/issues/28084 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/28092 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
assert
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aassert |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
| Jun 6, 2019 | https://github.com/nodejs/node/pull/28092#event-2393377445 |
| https://github.com/himself65 |
| himself65 | https://github.com/himself65 |
| force-pushed | https://github.com/nodejs/node/compare/d023d723a18c7308e0b59ee17ee323f0b67f3254..066c675b902e88c18f3f7fbb1d19e49862a36d41 |
| d023d72 | https://github.com/nodejs/node/commit/d023d723a18c7308e0b59ee17ee323f0b67f3254 |
| 066c675 | https://github.com/nodejs/node/commit/066c675b902e88c18f3f7fbb1d19e49862a36d41 |
|
Compare
| https://github.com/nodejs/node/compare/d023d723a18c7308e0b59ee17ee323f0b67f3254..066c675b902e88c18f3f7fbb1d19e49862a36d41 |
| June 6, 2019 07:39 | https://github.com/nodejs/node/pull/28092#event-2393432930 |
| https://github.com/himself65 |
| himself65 | https://github.com/himself65 |
| Jun 6, 2019 | https://github.com/nodejs/node/pull/28092#event-2393433484 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Jun 6, 2019
| https://github.com/nodejs/node/pull/28092#pullrequestreview-246419295 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28092/files |
| doc/api/assert.md | https://github.com/nodejs/node/pull/28092/files#diff-a1dd65347b3a99f8969799e35dc0c324dfaa28865a0706671183aca7aeebea97 |
| Please reload this page | https://github.com/nodejs/node/pull/28092 |
| https://github.com/himself65 |
| himself65 | https://github.com/himself65 |
| Jun 6, 2019 | https://github.com/nodejs/node/pull/28092#event-2394436318 |
| https://github.com/himself65 |
| himself65 | https://github.com/himself65 |
| force-pushed | https://github.com/nodejs/node/compare/635e664d9808189a86efa64b41adaceb07aed463..ffc2413ac4e6ed77f4a2275e26f4f336cd50b836 |
| 635e664 | https://github.com/nodejs/node/commit/635e664d9808189a86efa64b41adaceb07aed463 |
| ffc2413 | https://github.com/nodejs/node/commit/ffc2413ac4e6ed77f4a2275e26f4f336cd50b836 |
|
Compare
| https://github.com/nodejs/node/compare/635e664d9808189a86efa64b41adaceb07aed463..ffc2413ac4e6ed77f4a2275e26f4f336cd50b836 |
| June 6, 2019 13:57 | https://github.com/nodejs/node/pull/28092#event-2394436426 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Jun 6, 2019
| https://github.com/nodejs/node/pull/28092#pullrequestreview-246834054 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28092/files |
| doc/api/assert.md | https://github.com/nodejs/node/pull/28092/files#diff-a1dd65347b3a99f8969799e35dc0c324dfaa28865a0706671183aca7aeebea97 |
| Please reload this page | https://github.com/nodejs/node/pull/28092 |
| https://github.com/himself65 |
| himself65 | https://github.com/himself65 |
| force-pushed | https://github.com/nodejs/node/compare/145d2405d4e3d6f319fde699145f0b33fc7cc145..ae4c357c67dd643f516c67724bca105abecea111 |
| 145d240 | https://github.com/nodejs/node/commit/145d2405d4e3d6f319fde699145f0b33fc7cc145 |
| ae4c357 | https://github.com/nodejs/node/commit/ae4c357c67dd643f516c67724bca105abecea111 |
|
Compare
| https://github.com/nodejs/node/compare/145d2405d4e3d6f319fde699145f0b33fc7cc145..ae4c357c67dd643f516c67724bca105abecea111 |
| June 6, 2019 23:27 | https://github.com/nodejs/node/pull/28092#event-2395891166 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Jul 5, 2019
| https://github.com/nodejs/node/pull/28092#pullrequestreview-258188399 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28092/files |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Jul 5, 2019 | https://github.com/nodejs/node/pull/28092#issuecomment-508596510 |
| https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3740/ | https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3740/ |
| Please reload this page | https://github.com/nodejs/node/pull/28092 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Jul 15, 2019
| https://github.com/nodejs/node/pull/28092#pullrequestreview-261850595 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28092/files |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Jul 15, 2019
| https://github.com/nodejs/node/pull/28092#pullrequestreview-262088750 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28092/files |
| doc/api/assert.md | https://github.com/nodejs/node/pull/28092/files#diff-a1dd65347b3a99f8969799e35dc0c324dfaa28865a0706671183aca7aeebea97 |
| Please reload this page | https://github.com/nodejs/node/pull/28092 |
| https://github.com/himself65 |
| himself65 | https://github.com/himself65 |
| force-pushed | https://github.com/nodejs/node/compare/9fdb145aa22169df196a5aedf541eda0964ad800..24c064f79534de690ae7890647b18a08cf65c0a7 |
| 9fdb145 | https://github.com/nodejs/node/commit/9fdb145aa22169df196a5aedf541eda0964ad800 |
| 24c064f | https://github.com/nodejs/node/commit/24c064f79534de690ae7890647b18a08cf65c0a7 |
|
Compare
| https://github.com/nodejs/node/compare/9fdb145aa22169df196a5aedf541eda0964ad800..24c064f79534de690ae7890647b18a08cf65c0a7 |
| July 16, 2019 02:15 | https://github.com/nodejs/node/pull/28092#event-2484701048 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Jul 16, 2019
| https://github.com/nodejs/node/pull/28092#pullrequestreview-262181486 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28092/files |
| doc/api/assert.md | https://github.com/nodejs/node/pull/28092/files#diff-a1dd65347b3a99f8969799e35dc0c324dfaa28865a0706671183aca7aeebea97 |
| Please reload this page | https://github.com/nodejs/node/pull/28092 |
|
| https://github.com/himself65 |
| doc: add examples at assert.strictEqual | https://github.com/nodejs/node/pull/28092/commits/d93cdf1270af4f33f0231186ff6386081848a5ec |
| d93cdf1 | https://github.com/nodejs/node/pull/28092/commits/d93cdf1270af4f33f0231186ff6386081848a5ec |
| https://github.com/himself65 |
| himself65 | https://github.com/himself65 |
| force-pushed | https://github.com/nodejs/node/compare/24c064f79534de690ae7890647b18a08cf65c0a7..d93cdf1270af4f33f0231186ff6386081848a5ec |
| 24c064f | https://github.com/nodejs/node/commit/24c064f79534de690ae7890647b18a08cf65c0a7 |
| d93cdf1 | https://github.com/nodejs/node/commit/d93cdf1270af4f33f0231186ff6386081848a5ec |
|
Compare
| https://github.com/nodejs/node/compare/24c064f79534de690ae7890647b18a08cf65c0a7..d93cdf1270af4f33f0231186ff6386081848a5ec |
| July 16, 2019 11:27 | https://github.com/nodejs/node/pull/28092#event-2485817455 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Jul 16, 2019
| https://github.com/nodejs/node/pull/28092#pullrequestreview-262559554 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28092/files/d93cdf1270af4f33f0231186ff6386081848a5ec |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jul 16, 2019 | https://github.com/nodejs/node/pull/28092#issuecomment-511903746 |
| https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3782/ | https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3782/ |
| Please reload this page | https://github.com/nodejs/node/pull/28092 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jul 18, 2019 | https://github.com/nodejs/node/pull/28092#issuecomment-512657896 |
| 3ad8799 | https://github.com/nodejs/node/commit/3ad87994ecfa177e19e6719bf0c6549de580623d |
| Please reload this page | https://github.com/nodejs/node/pull/28092 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jul 18, 2019 | https://github.com/nodejs/node/pull/28092#event-2491480160 |
| Trott | https://github.com/Trott |
|
Jul 18, 2019
| https://github.com/nodejs/node/pull/28092#ref-commit-3ad8799 |
|
| https://github.com/himself65 |
|
| https://github.com/Trott |
| doc: add examples at assert.strictEqual | https://github.com/Trott/io.js/commit/3ad87994ecfa177e19e6719bf0c6549de580623d |
| 3ad8799 | https://github.com/Trott/io.js/commit/3ad87994ecfa177e19e6719bf0c6549de580623d |
| nodejs#28092 | https://github.com/nodejs/node/pull/28092 |
| targos | https://github.com/targos |
|
Jul 20, 2019
| https://github.com/nodejs/node/pull/28092#ref-commit-3f78a51 |
|
| https://github.com/himself65 |
|
| https://github.com/targos |
| doc: add examples at assert.strictEqual | https://github.com/nodejs/node/commit/3f78a51b5e4afffb7e071db8c19021189ac3de21 |
| 3f78a51 | https://github.com/nodejs/node/commit/3f78a51b5e4afffb7e071db8c19021189ac3de21 |
| #28092 | https://github.com/nodejs/node/pull/28092 |
|
v12.7.0 release proposal
#28816
| https://github.com/nodejs/node/pull/28816 |
|
v12.7.0 release proposal
#28817
| https://github.com/nodejs/node/pull/28817 |
| vikashk1 | https://github.com/vikashk1 |
|
Aug 13, 2019
| https://github.com/nodejs/node/pull/28092#ref-commit-9af17ad |
|
| https://github.com/vikashk1 |
| Please ignore this msg ( | https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc |
| #1 | https://github.com/vikashk1/node/pull/1 |
| ) | https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc |
| 9af17ad | https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
Oct 29, 2019
| https://github.com/nodejs/node/pull/28092#ref-issue-452774101 |
|
doc: no example using message on assert.strictEqual
#28084
| https://github.com/nodejs/node/issues/28084 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28092 |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/28092/files/ae4c357c67dd643f516c67724bca105abecea111 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/28092/files/ae4c357c67dd643f516c67724bca105abecea111 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/28092/files/d93cdf1270af4f33f0231186ff6386081848a5ec |
|
assert
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aassert |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
doc: no example using message on assert.strictEqual
| https://github.com/nodejs/node/issues/28084 |
| Please reload this page | https://github.com/nodejs/node/pull/28092 |
|
| https://github.com/himself65 |
|
| https://github.com/BridgeAR |
|
| https://github.com/Trott |
|
| https://github.com/jasnell |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |