René's URL Explorer Experiment


Title: test: only assert on first lines of TLS trace by sam-github · Pull Request #28043 · nodejs/node · GitHub

Open Graph Title: test: only assert on first lines of TLS trace by sam-github · Pull Request #28043 · nodejs/node

X Title: test: only assert on first lines of TLS trace by sam-github · Pull Request #28043 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: The TLS trace data is best-effort, and enough can be dropped from pipe buffers that only the start of the trace is detected. Only assert on the first line of the trace, it should not get dropped, a...

X Description: The TLS trace data is best-effort, and enough can be dropped from pipe buffers that only the start of the trace is detected. Only assert on the first line of the trace, it should not get dropped, a...

Opengraph URL: https://github.com/nodejs/node/pull/28043

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:17a9b85b-410f-d9a0-032d-db65ef1d0eab
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEB32:24E098:A78818:D9F071:69928739
html-safe-nonce4b0ce5b788db7891e730862cb9b9f171971ac0081f3927d02bb807a28c087ee1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQjMyOjI0RTA5ODpBNzg4MTg6RDlGMDcxOjY5OTI4NzM5IiwidmlzaXRvcl9pZCI6IjMxMDQyMjcxNDQ1OTUyMjg3MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac817259b24bd25a1d556191a3db8bcf016d19c2fa43da337932e7ed6cb439d5d3
hovercard-subject-tagpull_request:284699025
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28043/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/def7c98b5242912ea47d1a35a5a9db820e4a901343e9b41fd28453464a41eb4e/nodejs/node/pull/28043
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/def7c98b5242912ea47d1a35a5a9db820e4a901343e9b41fd28453464a41eb4e/nodejs/node/pull/28043
og:image:altThe TLS trace data is best-effort, and enough can be dropped from pipe buffers that only the start of the trace is detected. Only assert on the first line of the trace, it should not get dropped, a...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesam-github
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/28043#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28043
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28043
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/28043
Reloadhttps://github.com/nodejs/node/pull/28043
Reloadhttps://github.com/nodejs/node/pull/28043
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/28043
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.8k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 716 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
sam-githubhttps://github.com/sam-github
nodejs:masterhttps://github.com/nodejs/node/tree/master
sam-github:fix-tls-cli-trace-testhttps://github.com/sam-github/node/tree/fix-tls-cli-trace-test
Conversationhttps://github.com/nodejs/node/pull/28043
Commits1 (1)https://github.com/nodejs/node/pull/28043/commits
Checkshttps://github.com/nodejs/node/pull/28043/checks
Files changedhttps://github.com/nodejs/node/pull/28043/files
test: only assert on first lines of TLS tracehttps://github.com/nodejs/node/pull/28043#top
sam-githubhttps://github.com/sam-github
nodejs:masterhttps://github.com/nodejs/node/tree/master
sam-github:fix-tls-cli-trace-testhttps://github.com/sam-github/node/tree/fix-tls-cli-trace-test
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Jun 3, 2019https://github.com/nodejs/node/pull/28043#issue-451650525
#27636https://github.com/nodejs/node/issues/27636
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/28043
https://github.com/sam-github
test: only assert on first lines of TLS tracehttps://github.com/nodejs/node/pull/28043/commits/b75cb26ecddee86828c5eb3e57865d460cdafe23
b75cb26https://github.com/nodejs/node/pull/28043/commits/b75cb26ecddee86828c5eb3e57865d460cdafe23
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Jun 3, 2019https://github.com/nodejs/node/pull/28043#issuecomment-498393813
#27636https://github.com/nodejs/node/issues/27636
Please reload this pagehttps://github.com/nodejs/node/pull/28043
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 3, 2019https://github.com/nodejs/node/pull/28043#issuecomment-498394056
https://ci.nodejs.org/job/node-test-pull-request/23598/https://ci.nodejs.org/job/node-test-pull-request/23598/
Please reload this pagehttps://github.com/nodejs/node/pull/28043
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jun 3, 2019 https://github.com/nodejs/node/pull/28043#pullrequestreview-245087093
View reviewed changes https://github.com/nodejs/node/pull/28043/files/b75cb26ecddee86828c5eb3e57865d460cdafe23
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jun 3, 2019 https://github.com/nodejs/node/pull/28043#pullrequestreview-245117348
View reviewed changes https://github.com/nodejs/node/pull/28043/files/b75cb26ecddee86828c5eb3e57865d460cdafe23
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jun 3, 2019 https://github.com/nodejs/node/pull/28043#pullrequestreview-245124146
View reviewed changes https://github.com/nodejs/node/pull/28043/files/b75cb26ecddee86828c5eb3e57865d460cdafe23
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jun 4, 2019 https://github.com/nodejs/node/pull/28043#pullrequestreview-245385672
View reviewed changes https://github.com/nodejs/node/pull/28043/files/b75cb26ecddee86828c5eb3e57865d460cdafe23
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 4, 2019https://github.com/nodejs/node/pull/28043#issuecomment-498796482
https://ci.nodejs.org/job/node-test-pull-request/23615/https://ci.nodejs.org/job/node-test-pull-request/23615/
Please reload this pagehttps://github.com/nodejs/node/pull/28043
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 4, 2019https://github.com/nodejs/node/pull/28043#issuecomment-498809450
https://ci.nodejs.org/job/node-test-pull-request/23618/https://ci.nodejs.org/job/node-test-pull-request/23618/
Please reload this pagehttps://github.com/nodejs/node/pull/28043
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 5, 2019https://github.com/nodejs/node/pull/28043#issuecomment-499162815
https://ci.nodejs.org/job/node-test-pull-request/23637/https://ci.nodejs.org/job/node-test-pull-request/23637/
Please reload this pagehttps://github.com/nodejs/node/pull/28043
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 6, 2019https://github.com/nodejs/node/pull/28043#issuecomment-499538726
https://ci.nodejs.org/job/node-test-pull-request/23665/https://ci.nodejs.org/job/node-test-pull-request/23665/
Please reload this pagehttps://github.com/nodejs/node/pull/28043
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 6, 2019https://github.com/nodejs/node/pull/28043#issuecomment-499569807
https://ci.nodejs.org/job/node-test-pull-request/23668/https://ci.nodejs.org/job/node-test-pull-request/23668/
Please reload this pagehttps://github.com/nodejs/node/pull/28043
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Jun 6, 2019https://github.com/nodejs/node/pull/28043#issuecomment-499587769
2976bbdhttps://github.com/nodejs/node/commit/2976bbd68f936c4f96b6028219ceb9bfc4b84f22
Please reload this pagehttps://github.com/nodejs/node/pull/28043
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Jun 6, 2019https://github.com/nodejs/node/pull/28043#event-2395124169
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
June 6, 2019 17:40https://github.com/nodejs/node/pull/28043#event-2395124394
BridgeARhttps://github.com/BridgeAR
Jun 17, 2019 https://github.com/nodejs/node/pull/28043#ref-commit-1ef2811
https://github.com/sam-github
https://github.com/BridgeAR
test: only assert on first lines of TLS tracehttps://github.com/nodejs/node/commit/1ef2811236d07db4efaf4150ca04cb00defaf080
1ef2811https://github.com/nodejs/node/commit/1ef2811236d07db4efaf4150ca04cb00defaf080
#28043https://github.com/nodejs/node/pull/28043
#27636https://github.com/nodejs/node/issues/27636
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jun 17, 2019 https://github.com/nodejs/node/pull/28043#ref-pullrequest-457113206
v12.5.0 proposal #28268 https://github.com/nodejs/node/pull/28268
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28043
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/28043/files/b75cb26ecddee86828c5eb3e57865d460cdafe23
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/28043/files/b75cb26ecddee86828c5eb3e57865d460cdafe23
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/28043/files/b75cb26ecddee86828c5eb3e57865d460cdafe23
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/28043/files/b75cb26ecddee86828c5eb3e57865d460cdafe23
investigate flaky test-tls-enable-trace-cli https://github.com/nodejs/node/issues/27636
Please reload this pagehttps://github.com/nodejs/node/pull/28043
https://github.com/sam-github
https://github.com/nodejs-github-bot
https://github.com/lpinca
https://github.com/cjihrig
https://github.com/richardlau
https://github.com/BridgeAR
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.