| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:e6b429f8-e32f-b3d7-5b29-ffd5ebd3a47f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B6F4:18B263:7F367A:A1C090:69926952 |
| html-safe-nonce | 1be8e3a0c60b587da0d913fbf3e4e6bb5267958d1695762c5e146031954c2dc7 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNkY0OjE4QjI2Mzo3RjM2N0E6QTFDMDkwOjY5OTI2OTUyIiwidmlzaXRvcl9pZCI6IjQzMjM2OTM0MzA2MTYyNTQ4MDIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | f524b3915e34d5726a57a892720a7250d604b5c6a6969f29cb2b0aa3d0f66df5 |
| hovercard-subject-tag | pull_request:284396159 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28037/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/68fcbea92f3062b3174695b96d255e2e1dd0003573d299161a229e3417a9039f/nodejs/node/pull/28037 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/68fcbea92f3062b3174695b96d255e2e1dd0003573d299161a229e3417a9039f/nodejs/node/pull/28037 |
| og:image:alt | This commit causes the Tracing class to account for util.inspect() depth.
Similar to #27983. After this commit, all of these cases in core are handled.
Checklist
make -j4 test (UNIX), or vcbuild ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | cjihrig |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/28037#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28037 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28037 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/28037 |
| Reload | https://github.com/nodejs/node/pull/28037 |
| Reload | https://github.com/nodejs/node/pull/28037 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/28037 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.8k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
716
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| cjihrig | https://github.com/cjihrig |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| cjihrig:custom-inspect | https://github.com/cjihrig/node/tree/custom-inspect |
| Conversation | https://github.com/nodejs/node/pull/28037 |
| Commits1 (1) | https://github.com/nodejs/node/pull/28037/commits |
| Checks | https://github.com/nodejs/node/pull/28037/checks |
| Files changed | https://github.com/nodejs/node/pull/28037/files |
| trace_events: respect inspect() depth | https://github.com/nodejs/node/pull/28037#top |
| cjihrig | https://github.com/cjihrig |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| cjihrig:custom-inspect | https://github.com/cjihrig/node/tree/custom-inspect |
|
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Jun 3, 2019 | https://github.com/nodejs/node/pull/28037#issue-451269925 |
| #27983 | https://github.com/nodejs/node/pull/27983 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/28037 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Jun 3, 2019
| https://github.com/nodejs/node/pull/28037#pullrequestreview-244733718 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28037/files |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 3, 2019 | https://github.com/nodejs/node/pull/28037#issuecomment-498254656 |
| https://ci.nodejs.org/job/node-test-pull-request/23590/ | https://ci.nodejs.org/job/node-test-pull-request/23590/ |
| Please reload this page | https://github.com/nodejs/node/pull/28037 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 3, 2019 | https://github.com/nodejs/node/pull/28037#issuecomment-498267106 |
| https://ci.nodejs.org/job/node-test-pull-request/23591/ | https://ci.nodejs.org/job/node-test-pull-request/23591/ |
| Please reload this page | https://github.com/nodejs/node/pull/28037 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| force-pushed | https://github.com/nodejs/node/compare/575d59419d565a04e026bead2f6ec3ad7f58975e..cc787a0fe94bf129d16784ca9dd052d3b2c694a6 |
| 575d594 | https://github.com/nodejs/node/commit/575d59419d565a04e026bead2f6ec3ad7f58975e |
| cc787a0 | https://github.com/nodejs/node/commit/cc787a0fe94bf129d16784ca9dd052d3b2c694a6 |
|
Compare
| https://github.com/nodejs/node/compare/575d59419d565a04e026bead2f6ec3ad7f58975e..cc787a0fe94bf129d16784ca9dd052d3b2c694a6 |
| June 3, 2019 14:32 | https://github.com/nodejs/node/pull/28037#event-2385113382 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 3, 2019 | https://github.com/nodejs/node/pull/28037#issuecomment-498282554 |
| https://ci.nodejs.org/job/node-test-pull-request/23593/ | https://ci.nodejs.org/job/node-test-pull-request/23593/ |
| Please reload this page | https://github.com/nodejs/node/pull/28037 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 3, 2019 | https://github.com/nodejs/node/pull/28037#issuecomment-498311664 |
| https://ci.nodejs.org/job/node-test-pull-request/23595/ | https://ci.nodejs.org/job/node-test-pull-request/23595/ |
| Please reload this page | https://github.com/nodejs/node/pull/28037 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 3, 2019 | https://github.com/nodejs/node/pull/28037#issuecomment-498337221 |
| Please reload this page | https://github.com/nodejs/node/pull/28037 |
| https://ci.nodejs.org/job/node-test-pull-request/23597/ | https://ci.nodejs.org/job/node-test-pull-request/23597/ |
| Please reload this page | https://github.com/nodejs/node/pull/28037 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Jun 3, 2019
| https://github.com/nodejs/node/pull/28037#pullrequestreview-245090539 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28037/files |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Jun 4, 2019
| https://github.com/nodejs/node/pull/28037#pullrequestreview-245385890 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28037/files |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
trace_events
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atrace_events |
|
util
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Autil |
| Jun 4, 2019 | https://github.com/nodejs/node/pull/28037#event-2387802899 |
|
| https://github.com/cjihrig |
| trace_events: respect inspect() depth | https://github.com/nodejs/node/pull/28037/commits/81a9c7201f66855cdca534dae1a3f53f822a009b |
| 81a9c72 | https://github.com/nodejs/node/pull/28037/commits/81a9c7201f66855cdca534dae1a3f53f822a009b |
| nodejs#28037 | https://github.com/nodejs/node/pull/28037 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| force-pushed | https://github.com/nodejs/node/compare/cc787a0fe94bf129d16784ca9dd052d3b2c694a6..81a9c7201f66855cdca534dae1a3f53f822a009b |
| cc787a0 | https://github.com/nodejs/node/commit/cc787a0fe94bf129d16784ca9dd052d3b2c694a6 |
| 81a9c72 | https://github.com/nodejs/node/commit/81a9c7201f66855cdca534dae1a3f53f822a009b |
|
Compare
| https://github.com/nodejs/node/compare/cc787a0fe94bf129d16784ca9dd052d3b2c694a6..81a9c7201f66855cdca534dae1a3f53f822a009b |
| June 5, 2019 19:40 | https://github.com/nodejs/node/pull/28037#event-2392316966 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| 81a9c72 | https://github.com/nodejs/node/commit/81a9c7201f66855cdca534dae1a3f53f822a009b |
| Jun 5, 2019 | https://github.com/nodejs/node/pull/28037#event-2392320353 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| June 5, 2019 19:42 | https://github.com/nodejs/node/pull/28037#event-2392321113 |
| BridgeAR | https://github.com/BridgeAR |
|
Jun 17, 2019
| https://github.com/nodejs/node/pull/28037#ref-commit-9dd840d |
|
| https://github.com/cjihrig |
|
| https://github.com/BridgeAR |
| trace_events: respect inspect() depth | https://github.com/nodejs/node/commit/9dd840dff58aff2ac2f0098174a8daee3722cbcd |
| 9dd840d | https://github.com/nodejs/node/commit/9dd840dff58aff2ac2f0098174a8daee3722cbcd |
| #28037 | https://github.com/nodejs/node/pull/28037 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Jun 17, 2019
| https://github.com/nodejs/node/pull/28037#ref-pullrequest-457113206 |
|
v12.5.0 proposal
#28268
| https://github.com/nodejs/node/pull/28268 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28037 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/28037/files/575d59419d565a04e026bead2f6ec3ad7f58975e |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/28037/files/cc787a0fe94bf129d16784ca9dd052d3b2c694a6 |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/28037/files/cc787a0fe94bf129d16784ca9dd052d3b2c694a6 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
trace_events
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atrace_events |
|
util
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Autil |
| Please reload this page | https://github.com/nodejs/node/pull/28037 |
|
| https://github.com/cjihrig |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/addaleax |
|
| https://github.com/lpinca |
|
| https://github.com/BridgeAR |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |