René's URL Explorer Experiment


Title: worker: add typechecking for postMessage transfer list by addaleax · Pull Request #28033 · nodejs/node · GitHub

Open Graph Title: worker: add typechecking for postMessage transfer list by addaleax · Pull Request #28033 · nodejs/node

X Title: worker: add typechecking for postMessage transfer list by addaleax · Pull Request #28033 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: If the transfer list argument is present, it should be an array. This commit adds typechecking to that effect. This aligns behaviour with browsers. I’m also more than happy to label this semver-maj...

X Description: If the transfer list argument is present, it should be an array. This commit adds typechecking to that effect. This aligns behaviour with browsers. I’m also more than happy to label this semver-maj...

Opengraph URL: https://github.com/nodejs/node/pull/28033

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6f85be7d-2a2c-b653-79a3-e625832644ca
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBF7C:BCEB:207A1D7:29F7A7E:699287E5
html-safe-nonce3de5a5ce106bb4c3a20937f77e751fa69acbaf664f6b8ea16e43de4c3ffb6e3c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRjdDOkJDRUI6MjA3QTFENzoyOUY3QTdFOjY5OTI4N0U1IiwidmlzaXRvcl9pZCI6IjcyNTQ2NDU4MzE0Mjg2Mzg2OTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac9d7f2ec44f9a9816708c58c080e499f5d8dc67eecac4342f7524f1e9bb43cda6
hovercard-subject-tagpull_request:284361160
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28033/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/cdb3c0bad3fe419332f48e834db10a54ad795499f847d2641d94d78a2949920c/nodejs/node/pull/28033
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/cdb3c0bad3fe419332f48e834db10a54ad795499f847d2641d94d78a2949920c/nodejs/node/pull/28033
og:image:altIf the transfer list argument is present, it should be an array. This commit adds typechecking to that effect. This aligns behaviour with browsers. I’m also more than happy to label this semver-maj...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/28033#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28033
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28033
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/28033
Reloadhttps://github.com/nodejs/node/pull/28033
Reloadhttps://github.com/nodejs/node/pull/28033
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/28033
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.8k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 716 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:worker-postmessage-transferlist-typecheckhttps://github.com/addaleax/node/tree/worker-postmessage-transferlist-typecheck
Conversationhttps://github.com/nodejs/node/pull/28033
Commits4 (4)https://github.com/nodejs/node/pull/28033/commits
Checkshttps://github.com/nodejs/node/pull/28033/checks
Files changedhttps://github.com/nodejs/node/pull/28033/files
worker: add typechecking for postMessage transfer listhttps://github.com/nodejs/node/pull/28033#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:worker-postmessage-transferlist-typecheckhttps://github.com/addaleax/node/tree/worker-postmessage-transferlist-typecheck
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 2, 2019https://github.com/nodejs/node/pull/28033#issue-451219932
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/28033
https://github.com/addaleax
worker: add typechecking for postMessage transfer listhttps://github.com/nodejs/node/pull/28033/commits/7580ecb7a1e8efff7345f27288e77b794787ea22
7580ecbhttps://github.com/nodejs/node/pull/28033/commits/7580ecb7a1e8efff7345f27288e77b794787ea22
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
worker https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aworker
Jun 2, 2019https://github.com/nodejs/node/pull/28033#event-2383323503
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 2, 2019 https://github.com/nodejs/node/pull/28033#pullrequestreview-244637247
View reviewed changes https://github.com/nodejs/node/pull/28033/files/7580ecb7a1e8efff7345f27288e77b794787ea22
Trotthttps://github.com/Trott
https://github.com/nodejs/node/pull/28033#pullrequestreview-244637247
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28033
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 2, 2019 https://github.com/nodejs/node/pull/28033#pullrequestreview-244637395
View reviewed changes https://github.com/nodejs/node/pull/28033/files/7580ecb7a1e8efff7345f27288e77b794787ea22
src/node_messaging.cchttps://github.com/nodejs/node/pull/28033/files/7580ecb7a1e8efff7345f27288e77b794787ea22#diff-512ab8348327408c9a5ba3f7c60d8f8977a672a22b96345b8cfc2562936062f5
Please reload this pagehttps://github.com/nodejs/node/pull/28033
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jun 2, 2019 https://github.com/nodejs/node/pull/28033#pullrequestreview-244640245
View reviewed changes https://github.com/nodejs/node/pull/28033/files/7580ecb7a1e8efff7345f27288e77b794787ea22
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jun 2, 2019 https://github.com/nodejs/node/pull/28033#pullrequestreview-244643270
View reviewed changes https://github.com/nodejs/node/pull/28033/files/7580ecb7a1e8efff7345f27288e77b794787ea22
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Jun 3, 2019 https://github.com/nodejs/node/pull/28033#pullrequestreview-245033673
View reviewed changes https://github.com/nodejs/node/pull/28033/files/7580ecb7a1e8efff7345f27288e77b794787ea22
src/node_messaging.cchttps://github.com/nodejs/node/pull/28033/files/7580ecb7a1e8efff7345f27288e77b794787ea22#diff-512ab8348327408c9a5ba3f7c60d8f8977a672a22b96345b8cfc2562936062f5
TimothyGuhttps://github.com/TimothyGu
Jun 3, 2019https://github.com/nodejs/node/pull/28033#discussion_r289964991
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://html.spec.whatwg.org/multipage/web-messaging.html#messageporthttps://html.spec.whatwg.org/multipage/web-messaging.html#messageport
Please reload this pagehttps://github.com/nodejs/node/pull/28033
addaleaxhttps://github.com/addaleax
Jun 9, 2019https://github.com/nodejs/node/pull/28033#discussion_r291844032
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@TimothyGuhttps://github.com/TimothyGu
Please reload this pagehttps://github.com/nodejs/node/pull/28033
TimothyGuhttps://github.com/TimothyGu
Jun 10, 2019https://github.com/nodejs/node/pull/28033#discussion_r291865394
Please reload this pagehttps://github.com/nodejs/node/pull/28033
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28033
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jun 4, 2019 https://github.com/nodejs/node/pull/28033#pullrequestreview-245392550
View reviewed changes https://github.com/nodejs/node/pull/28033/files/7580ecb7a1e8efff7345f27288e77b794787ea22
addaleaxhttps://github.com/addaleax
June 9, 2019 19:33https://github.com/nodejs/node/pull/28033#commits-pushed-5c9f1c6
https://github.com/addaleax
https://github.com/Trott
fixup! worker: add typechecking for postMessage transfer listhttps://github.com/nodejs/node/pull/28033/commits/5c9f1c69b29a026c89f1fd7ac0d9f64c4e1c185c
5c9f1c6https://github.com/nodejs/node/pull/28033/commits/5c9f1c69b29a026c89f1fd7ac0d9f64c4e1c185c
https://github.com/addaleax
fixup! worker: add typechecking for postMessage transfer listhttps://github.com/nodejs/node/pull/28033/commits/8aac5b20816d42a4935fb2f2d145963d5bf48eb9
8aac5b2https://github.com/nodejs/node/pull/28033/commits/8aac5b20816d42a4935fb2f2d145963d5bf48eb9
https://github.com/addaleax
fixup! worker: add typechecking for postMessage transfer listhttps://github.com/nodejs/node/pull/28033/commits/ace5dff006f5fc4cc0cabd64a9116b240be55b49
ace5dffhttps://github.com/nodejs/node/pull/28033/commits/ace5dff006f5fc4cc0cabd64a9116b240be55b49
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 9, 2019https://github.com/nodejs/node/pull/28033#issuecomment-500231640
https://ci.nodejs.org/job/node-test-pull-request/23730/https://ci.nodejs.org/job/node-test-pull-request/23730/
Please reload this pagehttps://github.com/nodejs/node/pull/28033
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 10, 2019https://github.com/nodejs/node/pull/28033#issuecomment-500423026
269c1d6https://github.com/nodejs/node/commit/269c1d69c957811d7f5054a524df8f151b5c5781
Please reload this pagehttps://github.com/nodejs/node/pull/28033
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 10, 2019https://github.com/nodejs/node/pull/28033#event-2401016117
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
June 10, 2019 13:48https://github.com/nodejs/node/pull/28033#event-2401016338
addaleaxhttps://github.com/addaleax
Jun 10, 2019 https://github.com/nodejs/node/pull/28033#ref-commit-269c1d6
https://github.com/addaleax
worker: add typechecking for postMessage transfer listhttps://github.com/nodejs/node/commit/269c1d69c957811d7f5054a524df8f151b5c5781
269c1d6https://github.com/nodejs/node/commit/269c1d69c957811d7f5054a524df8f151b5c5781
#28033https://github.com/nodejs/node/pull/28033
BridgeARhttps://github.com/BridgeAR
Jun 17, 2019 https://github.com/nodejs/node/pull/28033#ref-commit-79a8cd0
https://github.com/addaleax
https://github.com/BridgeAR
worker: add typechecking for postMessage transfer listhttps://github.com/nodejs/node/commit/79a8cd0dec63f9da7b829cafcaaeb4428d86ec7a
79a8cd0https://github.com/nodejs/node/commit/79a8cd0dec63f9da7b829cafcaaeb4428d86ec7a
#28033https://github.com/nodejs/node/pull/28033
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jun 17, 2019 https://github.com/nodejs/node/pull/28033#ref-pullrequest-457113206
v12.5.0 proposal #28268 https://github.com/nodejs/node/pull/28268
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 25, 2019 https://github.com/nodejs/node/pull/28033#ref-pullrequest-484968987
worker: make transfer list behave like web MessagePort #29319 https://github.com/nodejs/node/pull/29319
addaleaxhttps://github.com/addaleax
Aug 25, 2019 https://github.com/nodejs/node/pull/28033#ref-commit-440f2b2
https://github.com/addaleax
worker: make transfer list behave like web MessagePorthttps://github.com/addaleax/node/commit/440f2b25bb74dd6e22fec74d8444a61c2b62d799
440f2b2https://github.com/addaleax/node/commit/440f2b25bb74dd6e22fec74d8444a61c2b62d799
nodejs#28033 (comment)https://github.com/nodejs/node/pull/28033#discussion_r289964991
danbevhttps://github.com/danbev
Sep 6, 2019 https://github.com/nodejs/node/pull/28033#ref-commit-72650bc
https://github.com/addaleax
https://github.com/danbev
worker: make transfer list behave like web MessagePorthttps://github.com/nodejs/node/commit/72650bcf7283c7b9eb9df9154f981eabdf8c523a
72650bchttps://github.com/nodejs/node/commit/72650bcf7283c7b9eb9df9154f981eabdf8c523a
#29319https://github.com/nodejs/node/pull/29319
#28033 (comment)https://github.com/nodejs/node/pull/28033#discussion_r289964991
targoshttps://github.com/targos
Sep 20, 2019 https://github.com/nodejs/node/pull/28033#ref-commit-d2b0568
https://github.com/addaleax
https://github.com/targos
worker: make transfer list behave like web MessagePorthttps://github.com/nodejs/node/commit/d2b05688901c39342aaa419fd2cb277c1c018671
d2b0568https://github.com/nodejs/node/commit/d2b05688901c39342aaa419fd2cb277c1c018671
#29319https://github.com/nodejs/node/pull/29319
#28033 (comment)https://github.com/nodejs/node/pull/28033#discussion_r289964991
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28033
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/28033/files/7580ecb7a1e8efff7345f27288e77b794787ea22
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/28033/files/7580ecb7a1e8efff7345f27288e77b794787ea22
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/28033/files/7580ecb7a1e8efff7345f27288e77b794787ea22
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/28033/files/7580ecb7a1e8efff7345f27288e77b794787ea22
https://github.com/TimothyGu
TimothyGu https://github.com/TimothyGu
https://github.com/nodejs/node/pull/28033/files/5c9f1c69b29a026c89f1fd7ac0d9f64c4e1c185c
worker https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aworker
Please reload this pagehttps://github.com/nodejs/node/pull/28033
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/lpinca
https://github.com/TimothyGu
https://github.com/cjihrig
https://github.com/BridgeAR
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.