| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:e3aa0cad-9459-5887-c8b1-d2366cd3bc4a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 83F8:102A8A:52E2C92:73B8117:6A510495 |
| html-safe-nonce | 929b246b216ac2aeca97de58e316f345d4d3f71cdabff2225eec58b70c237c47 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4M0Y4OjEwMkE4QTo1MkUyQzkyOjczQjgxMTc6NkE1MTA0OTUiLCJ2aXNpdG9yX2lkIjoiOTEwNzI4NTk4NzUyNDkzNjg1NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | e8d6e0141e277dc5acd1eef672170b6569344ddf05428196c1ccaf068dbc7396 |
| hovercard-subject-tag | pull_request:284292258 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28007/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/f3eec0f9057df5e2a52e4d47502888bec870f228edbaa1d912f3ca34a603d2a2/nodejs/node/pull/28007 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/f3eec0f9057df5e2a52e4d47502888bec870f228edbaa1d912f3ca34a603d2a2/nodejs/node/pull/28007 |
| og:image:alt | add a new getter to duplex stream to replace the property this .writableState.finished of the object that inherited duplex.
Refs: #445
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | zero1five |
| hostname | github.com |
| expected-hostname | github.com |
| None | b076e100febaa00374cd89239f915d00dd3187f7c68b12bc2b7688181305344d |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2d129404fc45ea64edb1b98567c53e55b395536f |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/28007#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28007 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28007 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/28007 |
| Reload | https://github.com/nodejs/node/pull/28007 |
| Reload | https://github.com/nodejs/node/pull/28007 |
| Please reload this page | https://github.com/nodejs/node/pull/28007 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/28007 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36.1k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.4k
| https://github.com/nodejs/node/issues |
|
Pull requests
980
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| zero1five | https://github.com/zero1five |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| zero1five:refactor/replace-finished | https://github.com/zero1five/node/tree/refactor/replace-finished |
| Conversation | https://github.com/nodejs/node/pull/28007 |
| Commits2 (2) | https://github.com/nodejs/node/pull/28007/commits |
| Checks | https://github.com/nodejs/node/pull/28007/checks |
| Files changed | https://github.com/nodejs/node/pull/28007/files |
| http2: use getter replace use directly _witableState.finished | https://github.com/nodejs/node/pull/28007#top |
| zero1five | https://github.com/zero1five |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| zero1five:refactor/replace-finished | https://github.com/zero1five/node/tree/refactor/replace-finished |
|
| https://github.com/zero1five |
| zero1five | https://github.com/zero1five |
| Jun 1, 2019 | https://github.com/nodejs/node/pull/28007#issue-451116217 |
| #445 | https://github.com/nodejs/node/issues/445 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/28007 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
http2
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2 |
|
stream
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream |
| Jun 1, 2019 | https://github.com/nodejs/node/pull/28007#event-2382852437 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Jun 1, 2019
| https://github.com/nodejs/node/pull/28007#pullrequestreview-244598871 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28007/files |
| lib/_stream_duplex.js | https://github.com/nodejs/node/pull/28007/files#diff-d4cde0b971ff116d87a4f6f5759bea1026d4c9606578a85357509833449679cb |
| Please reload this page | https://github.com/nodejs/node/pull/28007 |
| https://github.com/himself65 |
| himself65 | https://github.com/himself65 |
|
Jun 2, 2019
| https://github.com/nodejs/node/pull/28007#pullrequestreview-244608626 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28007/files |
| lib/_stream_duplex.js | https://github.com/nodejs/node/pull/28007/files#diff-d4cde0b971ff116d87a4f6f5759bea1026d4c9606578a85357509833449679cb |
| Please reload this page | https://github.com/nodejs/node/pull/28007 |
| https://github.com/zero1five |
| zero1five | https://github.com/zero1five |
| Jun 2, 2019 | https://github.com/nodejs/node/pull/28007#issuecomment-498001303 |
| Please reload this page | https://github.com/nodejs/node/pull/28007 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| Jun 2, 2019 | https://github.com/nodejs/node/pull/28007#issuecomment-498001886 |
| node/lib/_stream_duplex.js | https://github.com/nodejs/node/blob/187b05640837443353ec4183e203f352ff0af88a/lib/_stream_duplex.js#L42-L46 |
| 187b056 | https://github.com/nodejs/node/commit/187b05640837443353ec4183e203f352ff0af88a |
| Please reload this page | https://github.com/nodejs/node/pull/28007 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| Jun 2, 2019 | https://github.com/nodejs/node/pull/28007#issuecomment-498002825 |
| @zero1five | https://github.com/zero1five |
| net: replace _writableState with writableFinished #27974 | https://github.com/nodejs/node/pull/27974 |
| Please reload this page | https://github.com/nodejs/node/pull/28007 |
| https://github.com/zero1five |
| zero1five | https://github.com/zero1five |
| Jun 2, 2019 | https://github.com/nodejs/node/pull/28007#issuecomment-498003604 |
| Please reload this page | https://github.com/nodejs/node/pull/28007 |
| @lpinca | https://github.com/lpinca |
| Please reload this page | https://github.com/nodejs/node/pull/28007 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| Jun 2, 2019 | https://github.com/nodejs/node/pull/28007#issuecomment-498003885 |
| Please reload this page | https://github.com/nodejs/node/pull/28007 |
| @zero1five | https://github.com/zero1five |
| Please reload this page | https://github.com/nodejs/node/pull/28007 |
| https://github.com/zero1five |
| zero1five | https://github.com/zero1five |
| force-pushed | https://github.com/nodejs/node/compare/868f2f1e22dbcfb9a5be859afbe58a3557602fb8..6ce51da3fe56e969b2815a374d8f04a4d2b69815 |
| 868f2f1 | https://github.com/nodejs/node/commit/868f2f1e22dbcfb9a5be859afbe58a3557602fb8 |
| 6ce51da | https://github.com/nodejs/node/commit/6ce51da3fe56e969b2815a374d8f04a4d2b69815 |
|
Compare
| https://github.com/nodejs/node/compare/868f2f1e22dbcfb9a5be859afbe58a3557602fb8..6ce51da3fe56e969b2815a374d8f04a4d2b69815 |
| June 2, 2019 09:50 | https://github.com/nodejs/node/pull/28007#event-2383107263 |
| https://github.com/zero1five |
| zero1five | https://github.com/zero1five |
| Jun 2, 2019 | https://github.com/nodejs/node/pull/28007#issuecomment-498016183 |
| #27974 | https://github.com/nodejs/node/pull/27974 |
| @lpinca | https://github.com/lpinca |
| @Trott | https://github.com/Trott |
| @himself65 | https://github.com/himself65 |
| Please reload this page | https://github.com/nodejs/node/pull/28007 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Jun 2, 2019
| https://github.com/nodejs/node/pull/28007#pullrequestreview-244619145 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28007/files |
| test/parallel/test-stream-duplex-writable-finished.js | https://github.com/nodejs/node/pull/28007/files#diff-3e84adf40a81e0785de4c477f22fbf47fa3371bc5f105fedc98a9b53050724c3 |
| Please reload this page | https://github.com/nodejs/node/pull/28007 |
| test/parallel/test-stream-writable-finished.js | https://github.com/nodejs/node/pull/28007/files#diff-23df7c4aa05a9663db7bbdcae0084d1ad997063b33fda7969bcb6247265443b3 |
| Please reload this page | https://github.com/nodejs/node/pull/28007 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| Jun 2, 2019 | https://github.com/nodejs/node/pull/28007#issuecomment-498017924 |
| Please reload this page | https://github.com/nodejs/node/pull/28007 |
| https://github.com/zero1five |
| zero1five | https://github.com/zero1five |
| force-pushed | https://github.com/nodejs/node/compare/6ce51da3fe56e969b2815a374d8f04a4d2b69815..cdb22c44a63d51cf21d5b23d8f0e0ef42842f3d2 |
| 6ce51da | https://github.com/nodejs/node/commit/6ce51da3fe56e969b2815a374d8f04a4d2b69815 |
| cdb22c4 | https://github.com/nodejs/node/commit/cdb22c44a63d51cf21d5b23d8f0e0ef42842f3d2 |
|
Compare
| https://github.com/nodejs/node/compare/6ce51da3fe56e969b2815a374d8f04a4d2b69815..cdb22c44a63d51cf21d5b23d8f0e0ef42842f3d2 |
| June 2, 2019 12:03 | https://github.com/nodejs/node/pull/28007#event-2383156470 |
| https://github.com/zero1five |
| zero1five | https://github.com/zero1five |
| Jun 2, 2019 | https://github.com/nodejs/node/pull/28007#issuecomment-498025180 |
| @lpinca | https://github.com/lpinca |
| Please reload this page | https://github.com/nodejs/node/pull/28007 |
| https://github.com/himself65 |
| himself65 | https://github.com/himself65 |
| Jun 2, 2019 | https://github.com/nodejs/node/pull/28007#issuecomment-498025497 |
| Please reload this page | https://github.com/nodejs/node/pull/28007 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Jun 4, 2019
| https://github.com/nodejs/node/pull/28007#pullrequestreview-245437653 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28007/files |
| BridgeAR | https://github.com/BridgeAR |
| https://github.com/nodejs/node/pull/28007#pullrequestreview-245437653 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/28007 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
| Jun 4, 2019 | https://github.com/nodejs/node/pull/28007#event-2388096033 |
| https://github.com/zero1five |
| zero1five | https://github.com/zero1five |
| force-pushed | https://github.com/nodejs/node/compare/d54a1112dbc4b320465526808ad6b1000f64a05e..de53445a992240320787b3b971d82cf6736ea45b |
| d54a111 | https://github.com/nodejs/node/commit/d54a1112dbc4b320465526808ad6b1000f64a05e |
| de53445 | https://github.com/nodejs/node/commit/de53445a992240320787b3b971d82cf6736ea45b |
|
Compare
| https://github.com/nodejs/node/compare/d54a1112dbc4b320465526808ad6b1000f64a05e..de53445a992240320787b3b971d82cf6736ea45b |
| June 11, 2019 15:03 | https://github.com/nodejs/node/pull/28007#event-2404485852 |
| https://github.com/zero1five |
| zero1five | https://github.com/zero1five |
| Jun 11, 2019 | https://github.com/nodejs/node/pull/28007#issuecomment-500891292 |
| @BridgeAR | https://github.com/BridgeAR |
| Please reload this page | https://github.com/nodejs/node/pull/28007 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| mcollina | https://github.com/mcollina |
| June 14, 2019 03:09 | https://github.com/nodejs/node/pull/28007#event-2412437941 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Jun 14, 2019
| https://github.com/nodejs/node/pull/28007#pullrequestreview-249692338 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28007/files |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Jun 14, 2019
| https://github.com/nodejs/node/pull/28007#pullrequestreview-249721133 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28007/files |
| mcollina | https://github.com/mcollina |
| https://github.com/nodejs/node/pull/28007#pullrequestreview-249721133 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/28007 |
| doc/api/stream.md | https://github.com/nodejs/node/pull/28007/files#diff-00d8d040a3fe90e3052af39cb55dc9bcac70539d5d17791449cbfe7e3b55fb90 |
| Please reload this page | https://github.com/nodejs/node/pull/28007 |
| https://github.com/zero1five |
| zero1five | https://github.com/zero1five |
| force-pushed | https://github.com/nodejs/node/compare/f1d35d4ae4c7807aecba4100978c1dc18e89e07a..12622a5e0b07e08cd25bc9995fcfa0b56c04f830 |
| f1d35d4 | https://github.com/nodejs/node/commit/f1d35d4ae4c7807aecba4100978c1dc18e89e07a |
| 12622a5 | https://github.com/nodejs/node/commit/12622a5e0b07e08cd25bc9995fcfa0b56c04f830 |
|
Compare
| https://github.com/nodejs/node/compare/f1d35d4ae4c7807aecba4100978c1dc18e89e07a..12622a5e0b07e08cd25bc9995fcfa0b56c04f830 |
| June 19, 2019 21:32 | https://github.com/nodejs/node/pull/28007#event-2425587015 |
| https://github.com/zero1five |
| zero1five | https://github.com/zero1five |
| Jun 19, 2019 | https://github.com/nodejs/node/pull/28007#issuecomment-503754770 |
| Please reload this page | https://github.com/nodejs/node/pull/28007 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Jun 19, 2019
| https://github.com/nodejs/node/pull/28007#pullrequestreview-251988373 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28007/files |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Jun 19, 2019 | https://github.com/nodejs/node/pull/28007#event-2425614433 |
|
| https://github.com/zero1five |
| http2: use writableFinished instead of _writableState | https://github.com/nodejs/node/pull/28007/commits/2c66f6c09bcf79c8dfe955144be4fda5bbabca8b |
| 2c66f6c | https://github.com/nodejs/node/pull/28007/commits/2c66f6c09bcf79c8dfe955144be4fda5bbabca8b |
| https://github.com/zero1five |
| zero1five | https://github.com/zero1five |
| force-pushed | https://github.com/nodejs/node/compare/284f714aee2e239c53eee5713f96ca4eca98818b..2c66f6c09bcf79c8dfe955144be4fda5bbabca8b |
| 284f714 | https://github.com/nodejs/node/commit/284f714aee2e239c53eee5713f96ca4eca98818b |
| 2c66f6c | https://github.com/nodejs/node/commit/2c66f6c09bcf79c8dfe955144be4fda5bbabca8b |
|
Compare
| https://github.com/nodejs/node/compare/284f714aee2e239c53eee5713f96ca4eca98818b..2c66f6c09bcf79c8dfe955144be4fda5bbabca8b |
| June 24, 2019 13:31 | https://github.com/nodejs/node/pull/28007#event-2434276597 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 24, 2019 | https://github.com/nodejs/node/pull/28007#issuecomment-505193761 |
| https://ci.nodejs.org/job/node-test-pull-request/24080/ | https://ci.nodejs.org/job/node-test-pull-request/24080/ |
| Please reload this page | https://github.com/nodejs/node/pull/28007 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Jun 25, 2019 | https://github.com/nodejs/node/pull/28007#issuecomment-505503641 |
| https://ci.nodejs.org/job/node-test-commit-windows-fanned/28330/ | https://ci.nodejs.org/job/node-test-commit-windows-fanned/28330/ |
| Please reload this page | https://github.com/nodejs/node/pull/28007 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jun 25, 2019 | https://github.com/nodejs/node/pull/28007#issuecomment-505635166 |
| 2bb93e1...f11a4ec | https://github.com/nodejs/node/compare/2bb93e11085ea582aea1636f544d900520d479ed...f11a4ec638b2e159d6ed8840e2e6f1cc972f41a3 |
| Please reload this page | https://github.com/nodejs/node/pull/28007 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jun 25, 2019 | https://github.com/nodejs/node/pull/28007#event-2439036143 |
| Trott | https://github.com/Trott |
|
Jun 25, 2019
| https://github.com/nodejs/node/pull/28007#ref-commit-33aef82 |
|
| https://github.com/zero1five |
|
| https://github.com/Trott |
| stream: add writableFinished | https://github.com/Trott/io.js/commit/33aef82b42ca689411673784e203e59d3f4eb142 |
| 33aef82 | https://github.com/Trott/io.js/commit/33aef82b42ca689411673784e203e59d3f4eb142 |
| nodejs#445 | https://github.com/nodejs/node/issues/445 |
| nodejs#28007 | https://github.com/nodejs/node/pull/28007 |
| Trott | https://github.com/Trott |
|
Jun 25, 2019
| https://github.com/nodejs/node/pull/28007#ref-commit-f11a4ec |
|
| https://github.com/zero1five |
|
| https://github.com/Trott |
| http2: use writableFinished instead of _writableState | https://github.com/Trott/io.js/commit/f11a4ec638b2e159d6ed8840e2e6f1cc972f41a3 |
| f11a4ec | https://github.com/Trott/io.js/commit/f11a4ec638b2e159d6ed8840e2e6f1cc972f41a3 |
| nodejs#28007 | https://github.com/nodejs/node/pull/28007 |
| nodejs#445 | https://github.com/nodejs/node/issues/445 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Jun 25, 2019
| https://github.com/nodejs/node/pull/28007#ref-pullrequest-450275241 |
|
net: replace _writableState with writableFinished
#27974
| https://github.com/nodejs/node/pull/27974 |
| cjihrig | https://github.com/cjihrig |
|
Jun 26, 2019
| https://github.com/nodejs/node/pull/28007#ref-commit-22b992b |
|
| https://github.com/cjihrig |
| doc: replace version with REPLACEME | https://github.com/cjihrig/node/commit/22b992b9803cc0c8eac57092bf6705bc3243b87b |
| 22b992b | https://github.com/cjihrig/node/commit/22b992b9803cc0c8eac57092bf6705bc3243b87b |
| nodejs#28007 | https://github.com/nodejs/node/pull/28007 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Jun 26, 2019
| https://github.com/nodejs/node/pull/28007#ref-pullrequest-460705421 |
|
doc: replace version with REPLACEME
#28431
| https://github.com/nodejs/node/pull/28431 |
| https://github.com/zero1five |
| zero1five | https://github.com/zero1five |
| June 26, 2019 02:59 | https://github.com/nodejs/node/pull/28007#event-2439478954 |
| danbev | https://github.com/danbev |
|
Jun 26, 2019
| https://github.com/nodejs/node/pull/28007#ref-commit-5b4a0cb |
|
| https://github.com/cjihrig |
|
| https://github.com/danbev |
| doc: replace version with REPLACEME | https://github.com/nodejs/node/commit/5b4a0cb1494f77565454278ab97166fba25f7e45 |
| 5b4a0cb | https://github.com/nodejs/node/commit/5b4a0cb1494f77565454278ab97166fba25f7e45 |
| #28431 | https://github.com/nodejs/node/pull/28431 |
| #28007 | https://github.com/nodejs/node/pull/28007 |
| targos | https://github.com/targos |
|
Jul 2, 2019
| https://github.com/nodejs/node/pull/28007#ref-commit-1650bcf |
|
| https://github.com/zero1five |
|
| https://github.com/targos |
| stream: add writableFinished | https://github.com/nodejs/node/commit/1650bcf4914239e1edc87e78ad92ab2f347fa1de |
| 1650bcf | https://github.com/nodejs/node/commit/1650bcf4914239e1edc87e78ad92ab2f347fa1de |
| #445 | https://github.com/nodejs/node/issues/445 |
| #28007 | https://github.com/nodejs/node/pull/28007 |
| targos | https://github.com/targos |
|
Jul 2, 2019
| https://github.com/nodejs/node/pull/28007#ref-commit-d8942f8 |
|
| https://github.com/zero1five |
|
| https://github.com/targos |
| http2: use writableFinished instead of _writableState | https://github.com/nodejs/node/commit/d8942f877d5c5c58312ac46d2e7374a96177dbad |
| d8942f8 | https://github.com/nodejs/node/commit/d8942f877d5c5c58312ac46d2e7374a96177dbad |
| #28007 | https://github.com/nodejs/node/pull/28007 |
| #445 | https://github.com/nodejs/node/issues/445 |
| targos | https://github.com/targos |
|
Jul 2, 2019
| https://github.com/nodejs/node/pull/28007#ref-commit-5367d02 |
|
| https://github.com/cjihrig |
|
| https://github.com/targos |
| doc: replace version with REPLACEME | https://github.com/nodejs/node/commit/5367d02ce1980e4da28d2b5066ccf1fe65403f78 |
| 5367d02 | https://github.com/nodejs/node/commit/5367d02ce1980e4da28d2b5066ccf1fe65403f78 |
| #28431 | https://github.com/nodejs/node/pull/28431 |
| #28007 | https://github.com/nodejs/node/pull/28007 |
| targos | https://github.com/targos |
|
Jul 2, 2019
| https://github.com/nodejs/node/pull/28007#ref-commit-d711542 |
|
| https://github.com/targos |
| 2019-07-03, Version 12.6.0 (Current) | https://github.com/nodejs/node/commit/d711542f65df9a087d21f868305011ff8118c586 |
| d711542 | https://github.com/nodejs/node/commit/d711542f65df9a087d21f868305011ff8118c586 |
| #27992 | https://github.com/nodejs/node/pull/27992 |
| #28325 | https://github.com/nodejs/node/pull/28325 |
| #28449 | https://github.com/nodejs/node/pull/28449 |
| #28018 | https://github.com/nodejs/node/pull/28018 |
| #28490 | https://github.com/nodejs/node/pull/28490 |
| #28007 | https://github.com/nodejs/node/pull/28007 |
| #28153 | https://github.com/nodejs/node/pull/28153 |
| #28508 | https://github.com/nodejs/node/pull/28508 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Jul 2, 2019
| https://github.com/nodejs/node/pull/28007#ref-pullrequest-463146264 |
|
Release v12.6.0 proposal
#28508
| https://github.com/nodejs/node/pull/28508 |
| targos | https://github.com/targos |
|
Jul 2, 2019
| https://github.com/nodejs/node/pull/28007#ref-commit-e6a8ac1 |
|
| https://github.com/targos |
| 2019-07-03, Version 12.6.0 (Current) | https://github.com/nodejs/node/commit/e6a8ac12407b92557984cd1bbce7af97fa656f40 |
| e6a8ac1 | https://github.com/nodejs/node/commit/e6a8ac12407b92557984cd1bbce7af97fa656f40 |
| #27992 | https://github.com/nodejs/node/pull/27992 |
| #28325 | https://github.com/nodejs/node/pull/28325 |
| #28449 | https://github.com/nodejs/node/pull/28449 |
| #28018 | https://github.com/nodejs/node/pull/28018 |
| #28490 | https://github.com/nodejs/node/pull/28490 |
| #28007 | https://github.com/nodejs/node/pull/28007 |
| #28153 | https://github.com/nodejs/node/pull/28153 |
| https://github.com/gengjiawen | https://github.com/gengjiawen |
| #28322 | https://github.com/nodejs/node/pull/28322 |
| #28508 | https://github.com/nodejs/node/pull/28508 |
| targos | https://github.com/targos |
|
Jul 2, 2019
| https://github.com/nodejs/node/pull/28007#ref-commit-e71a0f4 |
|
| https://github.com/targos |
| 2019-07-03, Version 12.6.0 (Current) | https://github.com/nodejs/node/commit/e71a0f4d5faa4ad77887fbb3fff0ddb7bca6942e |
| e71a0f4 | https://github.com/nodejs/node/commit/e71a0f4d5faa4ad77887fbb3fff0ddb7bca6942e |
| #27992 | https://github.com/nodejs/node/pull/27992 |
| #28325 | https://github.com/nodejs/node/pull/28325 |
| #28449 | https://github.com/nodejs/node/pull/28449 |
| #28511 | https://github.com/nodejs/node/pull/28511 |
| #28018 | https://github.com/nodejs/node/pull/28018 |
| #28490 | https://github.com/nodejs/node/pull/28490 |
| #28007 | https://github.com/nodejs/node/pull/28007 |
| #28153 | https://github.com/nodejs/node/pull/28153 |
| https://github.com/gengjiawen | https://github.com/gengjiawen |
| #28322 | https://github.com/nodejs/node/pull/28322 |
| #28508 | https://github.com/nodejs/node/pull/28508 |
| targos | https://github.com/targos |
|
Jul 3, 2019
| https://github.com/nodejs/node/pull/28007#ref-commit-fcf8fe9 |
|
| https://github.com/targos |
| 2019-07-03, Version 12.6.0 (Current) | https://github.com/nodejs/node/commit/fcf8fe9f1a556758eb9faf86bf74de2ddda805c8 |
| fcf8fe9 | https://github.com/nodejs/node/commit/fcf8fe9f1a556758eb9faf86bf74de2ddda805c8 |
| #27992 | https://github.com/nodejs/node/pull/27992 |
| #28325 | https://github.com/nodejs/node/pull/28325 |
| #28449 | https://github.com/nodejs/node/pull/28449 |
| #28511 | https://github.com/nodejs/node/pull/28511 |
| #28018 | https://github.com/nodejs/node/pull/28018 |
| #28490 | https://github.com/nodejs/node/pull/28490 |
| #28007 | https://github.com/nodejs/node/pull/28007 |
| #28153 | https://github.com/nodejs/node/pull/28153 |
| https://github.com/gengjiawen | https://github.com/gengjiawen |
| #28322 | https://github.com/nodejs/node/pull/28322 |
| #28508 | https://github.com/nodejs/node/pull/28508 |
|
2019-07-03 Version 12.6.0 (Current) @targos
beevelop/docker-nodejs#288
| https://github.com/beevelop/docker-nodejs/issues/288 |
|
2019-07-03 Version 12.6.0 (Current) @targos
beevelop/docker-nodejs#289
| https://github.com/beevelop/docker-nodejs/issues/289 |
|
2019-07-03 Version 12.6.0 (Current) @targos
beevelop/docker-nodejs#290
| https://github.com/beevelop/docker-nodejs/issues/290 |
| https://github.com/ehmicky |
| ehmicky | https://github.com/ehmicky |
|
Jul 4, 2019
| https://github.com/nodejs/node/pull/28007#ref-pullrequest-464319664 |
|
Fix test for Node >= 12.6.0
sindresorhus/execa#348
| https://github.com/sindresorhus/execa/pull/348 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Jul 8, 2019
| https://github.com/nodejs/node/pull/28007#ref-pullrequest-464977541 |
|
doc: fix nits in stream.md
#28591
| https://github.com/nodejs/node/pull/28591 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
| Sep 3, 2019 | https://github.com/nodejs/node/pull/28007#issuecomment-527511189 |
| Please reload this page | https://github.com/nodejs/node/pull/28007 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
lts-watch-v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v10.x |
| Sep 4, 2019 | https://github.com/nodejs/node/pull/28007#event-2606658577 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Sep 4, 2019 | https://github.com/nodejs/node/pull/28007#issuecomment-527861020 |
| @BethGriggs | https://github.com/BethGriggs |
| Please reload this page | https://github.com/nodejs/node/pull/28007 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
backport-requested-v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v10.x |
| Oct 17, 2019 | https://github.com/nodejs/node/pull/28007#event-2722681787 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28007 |
|
| https://github.com/mcollina |
|
mcollina
| https://github.com/mcollina |
|
| https://github.com/nodejs/node/pull/28007/files/de53445a992240320787b3b971d82cf6736ea45b |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/28007/files/cdb22c44a63d51cf21d5b23d8f0e0ef42842f3d2 |
|
| https://github.com/himself65 |
|
himself65
| https://github.com/himself65 |
|
| https://github.com/nodejs/node/pull/28007/files/d19eccd3fbb2d434bcf747674403902025c6edeb |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/28007/files/de53445a992240320787b3b971d82cf6736ea45b |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/28007/files/284f714aee2e239c53eee5713f96ca4eca98818b |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/28007/files/12622a5e0b07e08cd25bc9995fcfa0b56c04f830 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/28007/files/6ce51da3fe56e969b2815a374d8f04a4d2b69815 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
http2
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2 |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
|
stream
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream |
| Please reload this page | https://github.com/nodejs/node/pull/28007 |
|
| https://github.com/zero1five |
|
| https://github.com/lpinca |
|
| https://github.com/himself65 |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/mcollina |
|
| https://github.com/addaleax |
|
| https://github.com/Trott |
|
| https://github.com/BethGriggs |
|
| https://github.com/jasnell |
|
| https://github.com/BridgeAR |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |