| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:064ba9b3-8b38-41c2-3793-0594d458803f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E9A4:14011B:15BAC38:1D8DF2A:6A4F01FC |
| html-safe-nonce | f814b66836359e87e6f96edc3c93ff1c290e08aac9e86f3dea0274e531abe7b0 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOUE0OjE0MDExQjoxNUJBQzM4OjFEOERGMkE6NkE0RjAxRkMiLCJ2aXNpdG9yX2lkIjoiMjA5NzM3Mjg2MTg4NjgyNDk1NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | e98b6f56d88fb928f6ceac3e55b41dcece38c245d3d0425d6bb68144d61a45b9 |
| hovercard-subject-tag | pull_request:284100505 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/27995/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/93454bec317e79e6d20b65f9c5fcc4ef6254a65ea222fe6570b395c9de4db408/nodejs/node/pull/27995 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/93454bec317e79e6d20b65f9c5fcc4ef6254a65ea222fe6570b395c9de4db408/nodejs/node/pull/27995 |
| og:image:alt | Two commits to complete code coverage for lib/internal/worker.js.
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Trott |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b8f23afb982271f1b22258a94aede67a6b77760 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/27995#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27995 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27995 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/27995 |
| Reload | https://github.com/nodejs/node/pull/27995 |
| Reload | https://github.com/nodejs/node/pull/27995 |
| Please reload this page | https://github.com/nodejs/node/pull/27995 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/27995 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
965
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:unserializable-error | https://github.com/Trott/io.js/tree/unserializable-error |
| Conversation | https://github.com/nodejs/node/pull/27995 |
| Commits2 (2) | https://github.com/nodejs/node/pull/27995/commits |
| Checks | https://github.com/nodejs/node/pull/27995/checks |
| Files changed | https://github.com/nodejs/node/pull/27995/files |
| test: finish code coverage for lib/internal/worker.js | https://github.com/nodejs/node/pull/27995#top |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:unserializable-error | https://github.com/Trott/io.js/tree/unserializable-error |
|
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| May 31, 2019 | https://github.com/nodejs/node/pull/27995#issue-450864769 |
| Please reload this page | https://github.com/nodejs/node/pull/27995 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/27995 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
worker
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aworker |
| May 31, 2019 | https://github.com/nodejs/node/pull/27995#event-2381406454 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| May 31, 2019 | https://github.com/nodejs/node/pull/27995#issuecomment-497760371 |
| https://ci.nodejs.org/job/node-test-pull-request/23516/ | https://ci.nodejs.org/job/node-test-pull-request/23516/ |
| Please reload this page | https://github.com/nodejs/node/pull/27995 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
May 31, 2019
| https://github.com/nodejs/node/pull/27995#pullrequestreview-244393923 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/27995/files |
| test/parallel/test-worker-message-not-serializable.js | https://github.com/nodejs/node/pull/27995/files#diff-efc6a91803b45dad31f5c4729b29c6527bf641fab8ffdab1fba900cfe098d7a4 |
| Please reload this page | https://github.com/nodejs/node/pull/27995 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/0b5ebc7dee619e92fd0a19987d520eec56dbd048..ffd6e60542d470efd01752bc99503cb525f3e823 |
| 0b5ebc7 | https://github.com/nodejs/node/commit/0b5ebc7dee619e92fd0a19987d520eec56dbd048 |
| ffd6e60 | https://github.com/nodejs/node/commit/ffd6e60542d470efd01752bc99503cb525f3e823 |
|
Compare
| https://github.com/nodejs/node/compare/0b5ebc7dee619e92fd0a19987d520eec56dbd048..ffd6e60542d470efd01752bc99503cb525f3e823 |
| May 31, 2019 20:39 | https://github.com/nodejs/node/pull/27995#event-2382091633 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| May 31, 2019 | https://github.com/nodejs/node/pull/27995#issuecomment-497852967 |
| https://ci.nodejs.org/job/node-test-pull-request/23518/ | https://ci.nodejs.org/job/node-test-pull-request/23518/ |
| Please reload this page | https://github.com/nodejs/node/pull/27995 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| May 31, 2019 | https://github.com/nodejs/node/pull/27995#event-2382096780 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
May 31, 2019
| https://github.com/nodejs/node/pull/27995#pullrequestreview-244511670 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/27995/files |
| cjihrig | https://github.com/cjihrig |
| https://github.com/nodejs/node/pull/27995#pullrequestreview-244511670 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/27995 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Jun 1, 2019
| https://github.com/nodejs/node/pull/27995#pullrequestreview-244600184 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/27995/files |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Jun 1, 2019 | https://github.com/nodejs/node/pull/27995#event-2382911667 |
| Trott | https://github.com/Trott |
| June 2, 2019 17:50 | https://github.com/nodejs/node/pull/27995#commits-pushed-04053c4 |
|
| https://github.com/Trott |
| test: add coverage for unserializable worker thread error | https://github.com/nodejs/node/pull/27995/commits/04053c4124b095bddd28e7b968761b51896a7d83 |
| 04053c4 | https://github.com/nodejs/node/pull/27995/commits/04053c4124b095bddd28e7b968761b51896a7d83 |
| nodejs#27995 | https://github.com/nodejs/node/pull/27995 |
|
| https://github.com/Trott |
| test: handle unknown message type in worker threads | https://github.com/nodejs/node/pull/27995/commits/e8f31191902a8304f77f7ed4377f10de91aca103 |
| e8f3119 | https://github.com/nodejs/node/pull/27995/commits/e8f31191902a8304f77f7ed4377f10de91aca103 |
| nodejs#27995 | https://github.com/nodejs/node/pull/27995 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/ffd6e60542d470efd01752bc99503cb525f3e823..e8f31191902a8304f77f7ed4377f10de91aca103 |
| ffd6e60 | https://github.com/nodejs/node/commit/ffd6e60542d470efd01752bc99503cb525f3e823 |
| e8f3119 | https://github.com/nodejs/node/commit/e8f31191902a8304f77f7ed4377f10de91aca103 |
|
Compare
| https://github.com/nodejs/node/compare/ffd6e60542d470efd01752bc99503cb525f3e823..e8f31191902a8304f77f7ed4377f10de91aca103 |
| June 2, 2019 15:51 | https://github.com/nodejs/node/pull/27995#event-2383257017 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jun 2, 2019 | https://github.com/nodejs/node/pull/27995#issuecomment-498042793 |
| Please reload this page | https://github.com/nodejs/node/pull/27995 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| e8f3119 | https://github.com/nodejs/node/commit/e8f31191902a8304f77f7ed4377f10de91aca103 |
| Jun 2, 2019 | https://github.com/nodejs/node/pull/27995#event-2383257677 |
| targos | https://github.com/targos |
|
Jun 3, 2019
| https://github.com/nodejs/node/pull/27995#ref-commit-1827256 |
|
| https://github.com/Trott |
|
| https://github.com/targos |
| test: add coverage for unserializable worker thread error | https://github.com/nodejs/node/commit/182725651b97ef9adb2049a12b1b8573dcc42a8d |
| 1827256 | https://github.com/nodejs/node/commit/182725651b97ef9adb2049a12b1b8573dcc42a8d |
| #27995 | https://github.com/nodejs/node/pull/27995 |
| targos | https://github.com/targos |
|
Jun 3, 2019
| https://github.com/nodejs/node/pull/27995#ref-commit-6a5ce36 |
|
| https://github.com/Trott |
|
| https://github.com/targos |
| test: handle unknown message type in worker threads | https://github.com/nodejs/node/commit/6a5ce36fb8af710abd9143448755475510d494fb |
| 6a5ce36 | https://github.com/nodejs/node/commit/6a5ce36fb8af710abd9143448755475510d494fb |
| #27995 | https://github.com/nodejs/node/pull/27995 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Jun 3, 2019
| https://github.com/nodejs/node/pull/27995#ref-pullrequest-451450524 |
|
v12.4.0 release proposal
#28040
| https://github.com/nodejs/node/pull/28040 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| January 13, 2022 22:51 | https://github.com/nodejs/node/pull/27995#event-5890974741 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27995 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/27995/files/ffd6e60542d470efd01752bc99503cb525f3e823 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/27995/files/ffd6e60542d470efd01752bc99503cb525f3e823 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
worker
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aworker |
| Please reload this page | https://github.com/nodejs/node/pull/27995 |
|
| https://github.com/Trott |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/lpinca |
|
| https://github.com/cjihrig |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |