René's URL Explorer Experiment


Title: net: replace _writableState with writableFinished by Trott · Pull Request #27974 · nodejs/node · GitHub

Open Graph Title: net: replace _writableState with writableFinished by Trott · Pull Request #27974 · nodejs/node

X Title: net: replace _writableState with writableFinished by Trott · Pull Request #27974 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Replace use of quasi-private streams _writableState property in net.js with use of the public streams finished() method. Refs: #445 Checklist make -j4 test (UNIX), or vcbuild test (Windows) pas...

X Description: Replace use of quasi-private streams _writableState property in net.js with use of the public streams finished() method. Refs: #445 Checklist make -j4 test (UNIX), or vcbuild test (Windows) pas...

Opengraph URL: https://github.com/nodejs/node/pull/27974

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ebe3cda1-9b5c-642a-87f3-dd78f004b4e1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA154:99BDD:6957D9:91CC2D:6A5126DC
html-safe-nonce38c6ce540c0d866be241bd225ad5394089d1fcc59237d6211243327d7b8a3f9e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMTU0Ojk5QkREOjY5NTdEOTo5MUNDMkQ6NkE1MTI2REMiLCJ2aXNpdG9yX2lkIjoiOTczNTg1ODcyNzk1NTQzMjYwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacd31a0f076dbc42084ad982d5b67009e920f68552ca948f5fb042e3841a79c3c7
hovercard-subject-tagpull_request:283630199
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/27974/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1447deefd20c7bd0cd1406855002b5ed027889d0b300a3b2a5f0105ef4e17ddc/nodejs/node/pull/27974
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1447deefd20c7bd0cd1406855002b5ed027889d0b300a3b2a5f0105ef4e17ddc/nodejs/node/pull/27974
og:image:altReplace use of quasi-private streams _writableState property in net.js with use of the public streams finished() method. Refs: #445 Checklist make -j4 test (UNIX), or vcbuild test (Windows) pas...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameTrott
hostnamegithub.com
expected-hostnamegithub.com
None689b683944b0d7f015d0e776452c970832fa81b82dc15284469b556ecced715b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release942b51ed3bd5feee3d5e2719f890a5fe286edbbb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/27974#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27974
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27974
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/27974
Reloadhttps://github.com/nodejs/node/pull/27974
Reloadhttps://github.com/nodejs/node/pull/27974
Please reload this pagehttps://github.com/nodejs/node/pull/27974
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/27974
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.1k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 978 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:finishedhttps://github.com/Trott/io.js/tree/finished
Conversationhttps://github.com/nodejs/node/pull/27974
Commits0 (0)https://github.com/nodejs/node/pull/27974/commits
Checkshttps://github.com/nodejs/node/pull/27974/checks
Files changedhttps://github.com/nodejs/node/pull/27974/files
net: replace _writableState with writableFinishedhttps://github.com/nodejs/node/pull/27974#top
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:finishedhttps://github.com/Trott/io.js/tree/finished
https://github.com/Trott
Trotthttps://github.com/Trott
May 30, 2019https://github.com/nodejs/node/pull/27974#issue-450275241
Please reload this pagehttps://github.com/nodejs/node/pull/27974
#445https://github.com/nodejs/node/issues/445
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/27974
https://github.com/Trott
Trotthttps://github.com/Trott
May 30, 2019https://github.com/nodejs/node/pull/27974#issuecomment-497308502
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/27974
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27974
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 30, 2019 https://github.com/nodejs/node/pull/27974#pullrequestreview-243764017
View reviewed changes https://github.com/nodejs/node/pull/27974/files
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 30, 2019https://github.com/nodejs/node/pull/27974#issuecomment-497321748
https://ci.nodejs.org/job/node-test-pull-request/23479/https://ci.nodejs.org/job/node-test-pull-request/23479/
Please reload this pagehttps://github.com/nodejs/node/pull/27974
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
May 30, 2019 https://github.com/nodejs/node/pull/27974#pullrequestreview-243784008
View reviewed changes https://github.com/nodejs/node/pull/27974/files
https://github.com/Trott
Trotthttps://github.com/Trott
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
net https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
May 30, 2019https://github.com/nodejs/node/pull/27974#event-2378084453
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
May 30, 2019 https://github.com/nodejs/node/pull/27974#pullrequestreview-243791809
View reviewed changes https://github.com/nodejs/node/pull/27974/files
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 30, 2019https://github.com/nodejs/node/pull/27974#issuecomment-497329287
https://ci.nodejs.org/job/node-test-pull-request/23481/https://ci.nodejs.org/job/node-test-pull-request/23481/
Please reload this pagehttps://github.com/nodejs/node/pull/27974
https://github.com/lpinca
lpincahttps://github.com/lpinca
May 30, 2019https://github.com/nodejs/node/pull/27974#issuecomment-497417194
Please reload this pagehttps://github.com/nodejs/node/pull/27974
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 31, 2019 https://github.com/nodejs/node/pull/27974#pullrequestreview-244138334
View reviewed changes https://github.com/nodejs/node/pull/27974/files
https://github.com/lpinca
lpincahttps://github.com/lpinca
May 31, 2019https://github.com/nodejs/node/pull/27974#issuecomment-497582297
Please reload this pagehttps://github.com/nodejs/node/pull/27974
https://github.com/mcollina
mcollinahttps://github.com/mcollina
May 31, 2019 https://github.com/nodejs/node/pull/27974#pullrequestreview-244171507
View reviewed changes https://github.com/nodejs/node/pull/27974/files
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/27974#pullrequestreview-244171507
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/27974
https://github.com/Trott
Trotthttps://github.com/Trott
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
May 31, 2019https://github.com/nodejs/node/pull/27974#event-2381933091
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/b4d1a4b06da389e58d12d371799d36d5792d54ab..d63d4b8abaded9dafaa7e5dc5bc22edd18bc8007
b4d1a4bhttps://github.com/nodejs/node/commit/b4d1a4b06da389e58d12d371799d36d5792d54ab
d63d4b8https://github.com/nodejs/node/commit/d63d4b8abaded9dafaa7e5dc5bc22edd18bc8007
Compare https://github.com/nodejs/node/compare/b4d1a4b06da389e58d12d371799d36d5792d54ab..d63d4b8abaded9dafaa7e5dc5bc22edd18bc8007
May 31, 2019 19:26https://github.com/nodejs/node/pull/27974#event-2381939225
https://github.com/Trott
Trotthttps://github.com/Trott
May 31, 2019https://github.com/nodejs/node/pull/27974#event-2381939318
https://github.com/Trott
Trotthttps://github.com/Trott
May 31, 2019https://github.com/nodejs/node/pull/27974#issuecomment-497855828
@lpincahttps://github.com/lpinca
#445https://github.com/nodejs/node/issues/445
#445https://github.com/nodejs/node/issues/445
Please reload this pagehttps://github.com/nodejs/node/pull/27974
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jun 1, 2019https://github.com/nodejs/node/pull/27974#issuecomment-497915371
https://github.com/nodejs/node/blob/aa8b820a/lib/_stream_writable.js#L354-L362https://github.com/nodejs/node/blob/aa8b820a/lib/_stream_writable.js#L354-L362
https://github.com/nodejs/node/blob/aa8b820a/lib/_stream_writable.js#L597-L605https://github.com/nodejs/node/blob/aa8b820a/lib/_stream_writable.js#L597-L605
#445https://github.com/nodejs/node/issues/445
end-of-streamhttps://github.com/mafintosh/end-of-stream
Please reload this pagehttps://github.com/nodejs/node/pull/27974
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 1, 2019https://github.com/nodejs/node/pull/27974#issuecomment-497919829
https://github.com/nodejs/node/blob/aa8b820a/lib/_stream_writable.js#L354-L362https://github.com/nodejs/node/blob/aa8b820a/lib/_stream_writable.js#L354-L362
https://github.com/nodejs/node/blob/aa8b820a/lib/_stream_writable.js#L597-L605https://github.com/nodejs/node/blob/aa8b820a/lib/_stream_writable.js#L597-L605
#445https://github.com/nodejs/node/issues/445
end-of-streamhttps://github.com/mafintosh/end-of-stream
@lpincahttps://github.com/lpinca
Cleanup _writableState and _readableState access across codebase #445https://github.com/nodejs/node/issues/445
Please reload this pagehttps://github.com/nodejs/node/pull/27974
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 1, 2019https://github.com/nodejs/node/pull/27974#issuecomment-497919879
Please reload this pagehttps://github.com/nodejs/node/pull/27974
https://github.com/ronag
ronaghttps://github.com/ronag
Jun 1, 2019 https://github.com/nodejs/node/pull/27974#pullrequestreview-244576377
View reviewed changes https://github.com/nodejs/node/pull/27974/files
lib/net.jshttps://github.com/nodejs/node/pull/27974/files#diff-218c57e035f64b18af4db037c96f13014aeb40a1f783d4f52919e2075621da0c
ronaghttps://github.com/ronag
Jun 1, 2019https://github.com/nodejs/node/pull/27974#discussion_r289595506
Please reload this pagehttps://github.com/nodejs/node/pull/27974
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/27974
lpincahttps://github.com/lpinca
Jun 1, 2019https://github.com/nodejs/node/pull/27974#discussion_r289597722
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/27974
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jun 1, 2019https://github.com/nodejs/node/pull/27974#issuecomment-497922628
#445https://github.com/nodejs/node/issues/445
#445https://github.com/nodejs/node/issues/445
@lpincahttps://github.com/lpinca
#27974 (comment)https://github.com/nodejs/node/pull/27974#issuecomment-497915371
#445https://github.com/nodejs/node/issues/445
Please reload this pagehttps://github.com/nodejs/node/pull/27974
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jun 1, 2019https://github.com/nodejs/node/pull/27974#issuecomment-497926309
https://github.com/search?p=1&q=_readableState&type=Codehttps://github.com/search?p=1&q=_readableState&type=Code
Please reload this pagehttps://github.com/nodejs/node/pull/27974
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jun 2, 2019 https://github.com/nodejs/node/pull/27974#ref-pullrequest-451116217
http2: use getter replace use directly _witableState.finished #28007 https://github.com/nodejs/node/pull/28007
https://github.com/Trott
Trotthttps://github.com/Trott
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Jun 2, 2019https://github.com/nodejs/node/pull/27974#event-2383072527
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 2, 2019https://github.com/nodejs/node/pull/27974#issuecomment-498009742
Please reload this pagehttps://github.com/nodejs/node/pull/27974
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 25, 2019https://github.com/nodejs/node/pull/27974#event-2439045277
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/d63d4b8abaded9dafaa7e5dc5bc22edd18bc8007..f11a4ec638b2e159d6ed8840e2e6f1cc972f41a3
d63d4b8https://github.com/nodejs/node/commit/d63d4b8abaded9dafaa7e5dc5bc22edd18bc8007
f11a4echttps://github.com/nodejs/node/commit/f11a4ec638b2e159d6ed8840e2e6f1cc972f41a3
Compare https://github.com/nodejs/node/compare/d63d4b8abaded9dafaa7e5dc5bc22edd18bc8007..f11a4ec638b2e159d6ed8840e2e6f1cc972f41a3
June 25, 2019 21:51https://github.com/nodejs/node/pull/27974#event-2439045279
https://github.com/Trott
Trotthttps://github.com/Trott
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Jun 25, 2019https://github.com/nodejs/node/pull/27974#event-2439054346
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 25, 2019https://github.com/nodejs/node/pull/27974#event-2439055003
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 25, 2019 https://github.com/nodejs/node/pull/27974#pullrequestreview-254292001
View reviewed changes https://github.com/nodejs/node/pull/27974/files
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 25, 2019https://github.com/nodejs/node/pull/27974#issuecomment-505638438
https://ci.nodejs.org/job/node-test-pull-request/24106/https://ci.nodejs.org/job/node-test-pull-request/24106/
Please reload this pagehttps://github.com/nodejs/node/pull/27974
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 25, 2019https://github.com/nodejs/node/pull/27974#issuecomment-505639545
@zero1fivehttps://github.com/zero1five
#28007https://github.com/nodejs/node/pull/28007
Please reload this pagehttps://github.com/nodejs/node/pull/27974
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 26, 2019https://github.com/nodejs/node/pull/27974#issuecomment-505677694
https://ci.nodejs.org/job/node-test-pull-request/24108/https://ci.nodejs.org/job/node-test-pull-request/24108/
Please reload this pagehttps://github.com/nodejs/node/pull/27974
https://github.com/Trott
Trotthttps://github.com/Trott
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jun 26, 2019https://github.com/nodejs/node/pull/27974#event-2439403143
https://github.com/Trott
Trotthttps://github.com/Trott
addaleaxhttps://github.com/addaleax
benjamingrhttps://github.com/benjamingr
cjihrighttps://github.com/cjihrig
jasnellhttps://github.com/jasnell
lpincahttps://github.com/lpinca
mcollinahttps://github.com/mcollina
June 26, 2019 01:59https://github.com/nodejs/node/pull/27974#event-2439403545
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 26, 2019https://github.com/nodejs/node/pull/27974#issuecomment-505686922
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/27974
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 26, 2019https://github.com/nodejs/node/pull/27974#event-2439530825
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jun 26, 2019 https://github.com/nodejs/node/pull/27974#pullrequestreview-254655334
View reviewed changes https://github.com/nodejs/node/pull/27974/files
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jun 26, 2019 https://github.com/nodejs/node/pull/27974#pullrequestreview-254658276
View reviewed changes https://github.com/nodejs/node/pull/27974/files
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 26, 2019https://github.com/nodejs/node/pull/27974#event-2441263560
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/17967b73e9a857550d8c42ef1d33d9a566120637..3832713fa0c0ce7cda8a19e74cd96be1479f6f1e
17967b7https://github.com/nodejs/node/commit/17967b73e9a857550d8c42ef1d33d9a566120637
3832713https://github.com/nodejs/node/commit/3832713fa0c0ce7cda8a19e74cd96be1479f6f1e
Compare https://github.com/nodejs/node/compare/17967b73e9a857550d8c42ef1d33d9a566120637..3832713fa0c0ce7cda8a19e74cd96be1479f6f1e
June 26, 2019 15:15https://github.com/nodejs/node/pull/27974#event-2441263566
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 26, 2019https://github.com/nodejs/node/pull/27974#issuecomment-505920558
Please reload this pagehttps://github.com/nodejs/node/pull/27974
https://github.com/Trott
Trotthttps://github.com/Trott
June 26, 2019 15:15https://github.com/nodejs/node/pull/27974#event-2441264656
https://github.com/Trott
Trotthttps://github.com/Trott
3832713https://github.com/nodejs/node/commit/3832713fa0c0ce7cda8a19e74cd96be1479f6f1e
Jun 26, 2019https://github.com/nodejs/node/pull/27974#event-2441266737
targoshttps://github.com/targos
Jul 2, 2019 https://github.com/nodejs/node/pull/27974#ref-commit-8ad880f
https://github.com/Trott
https://github.com/targos
net: replace _writableState.finished with writableFinishedhttps://github.com/nodejs/node/commit/8ad880f3fc987c1a5f2045b15bcb5d8963513a97
8ad880fhttps://github.com/nodejs/node/commit/8ad880f3fc987c1a5f2045b15bcb5d8963513a97
#27974https://github.com/nodejs/node/pull/27974
#445https://github.com/nodejs/node/issues/445
https://github.com/targos
targoshttps://github.com/targos
Jul 2, 2019 https://github.com/nodejs/node/pull/27974#ref-pullrequest-463146264
Release v12.6.0 proposal #28508 https://github.com/nodejs/node/pull/28508
2019-07-03 Version 12.6.0 (Current) @targos beevelop/docker-nodejs#288 https://github.com/beevelop/docker-nodejs/issues/288
2019-07-03 Version 12.6.0 (Current) @targos beevelop/docker-nodejs#289 https://github.com/beevelop/docker-nodejs/issues/289
2019-07-03 Version 12.6.0 (Current) @targos beevelop/docker-nodejs#290 https://github.com/beevelop/docker-nodejs/issues/290
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27974
https://github.com/ronag
ronag https://github.com/ronag
https://github.com/nodejs/node/pull/27974/files/d63d4b8abaded9dafaa7e5dc5bc22edd18bc8007
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/27974/files/17967b73e9a857550d8c42ef1d33d9a566120637
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/27974/files/17967b73e9a857550d8c42ef1d33d9a566120637
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/benjamingr
benjamingr https://github.com/benjamingr
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
net https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Please reload this pagehttps://github.com/nodejs/node/pull/27974
https://github.com/Trott
https://github.com/nodejs-github-bot
https://github.com/lpinca
https://github.com/mcollina
https://github.com/jasnell
https://github.com/addaleax
https://github.com/benjamingr
https://github.com/cjihrig
https://github.com/ronag
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.