René's URL Explorer Experiment


Title: http: fix socketOnWrap edge cases by apapirovski · Pull Request #27968 · nodejs/node · GitHub

Open Graph Title: http: fix socketOnWrap edge cases by apapirovski · Pull Request #27968 · nodejs/node

X Title: http: fix socketOnWrap edge cases by apapirovski · Pull Request #27968 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Properly handle prependListener wrapping on http server socket, in addition to on and addListener. (A commit was made that was supposed to fix this last month but hadn't actually done so.) Che...

X Description: Properly handle prependListener wrapping on http server socket, in addition to on and addListener. (A commit was made that was supposed to fix this last month but hadn't actually done so.) ...

Opengraph URL: https://github.com/nodejs/node/pull/27968

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2ad1b798-d4b7-5216-15fb-ad03b5e66cb7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCD7E:244C0:1A146F1:2421E4A:6A4EBB27
html-safe-nonce34032aab2588ca657b49043f87d33087228dc44e4c0c411934ee93ef32aa80ac
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRDdFOjI0NEMwOjFBMTQ2RjE6MjQyMUU0QTo2QTRFQkIyNyIsInZpc2l0b3JfaWQiOiI4NzE1OTMwMDMyMDk3MTE0OTE5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac3f4f01c046915394e1fecdb48a08eb1fdf79af5876b74ee6147585171a6cc801
hovercard-subject-tagpull_request:283583192
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/27968/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7becef5c880c8a227ea7bf2afae34f9fd005584d7020cc8955ba66d475dc2d93/nodejs/node/pull/27968
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7becef5c880c8a227ea7bf2afae34f9fd005584d7020cc8955ba66d475dc2d93/nodejs/node/pull/27968
og:image:altProperly handle prependListener wrapping on http server socket, in addition to on and addListener. (A commit was made that was supposed to fix this last month but hadn't actually done so.) Che...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameapapirovski
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/27968#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27968
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27968
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/27968
Reloadhttps://github.com/nodejs/node/pull/27968
Reloadhttps://github.com/nodejs/node/pull/27968
Please reload this pagehttps://github.com/nodejs/node/pull/27968
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/27968
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 964 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
apapirovskihttps://github.com/apapirovski
nodejs:masterhttps://github.com/nodejs/node/tree/master
apapirovski:fix-socket-wrap-httphttps://github.com/apapirovski/node/tree/fix-socket-wrap-http
Conversationhttps://github.com/nodejs/node/pull/27968
Commits2 (2)https://github.com/nodejs/node/pull/27968/commits
Checkshttps://github.com/nodejs/node/pull/27968/checks
Files changedhttps://github.com/nodejs/node/pull/27968/files
http: fix socketOnWrap edge caseshttps://github.com/nodejs/node/pull/27968#top
apapirovskihttps://github.com/apapirovski
nodejs:masterhttps://github.com/nodejs/node/tree/master
apapirovski:fix-socket-wrap-httphttps://github.com/apapirovski/node/tree/fix-socket-wrap-http
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
May 30, 2019https://github.com/nodejs/node/pull/27968#issue-450217173
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/27968
https://github.com/apapirovski
http: fix socketOnWrap edge caseshttps://github.com/nodejs/node/pull/27968/commits/20d05f4d309b9ed65a77e64099c5e53c1a73ede0
20d05f4https://github.com/nodejs/node/pull/27968/commits/20d05f4d309b9ed65a77e64099c5e53c1a73ede0
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 30, 2019https://github.com/nodejs/node/pull/27968#issuecomment-497370806
https://ci.nodejs.org/job/node-test-pull-request/23497/https://ci.nodejs.org/job/node-test-pull-request/23497/
Please reload this pagehttps://github.com/nodejs/node/pull/27968
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
May 30, 2019 https://github.com/nodejs/node/pull/27968#pullrequestreview-243864690
View reviewed changes https://github.com/nodejs/node/pull/27968/files/20d05f4d309b9ed65a77e64099c5e53c1a73ede0
lib/_http_server.jshttps://github.com/nodejs/node/pull/27968/files/20d05f4d309b9ed65a77e64099c5e53c1a73ede0#diff-2464899ab38c61dd42654fdb9658c75989cb6883b9c9d76613872a12d3fe2780
ZYSzyshttps://github.com/ZYSzys
May 30, 2019https://github.com/nodejs/node/pull/27968#discussion_r289043711
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/27968
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
May 30, 2019https://github.com/nodejs/node/pull/27968#event-2378473209
https://github.com/apapirovski
fixup: clarify commenthttps://github.com/nodejs/node/pull/27968/commits/e1edbd6ed41225625c8cd5c8acbfc0b9289a7239
e1edbd6https://github.com/nodejs/node/pull/27968/commits/e1edbd6ed41225625c8cd5c8acbfc0b9289a7239
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 31, 2019https://github.com/nodejs/node/pull/27968#issuecomment-497629790
https://ci.nodejs.org/job/node-test-pull-request/23508/https://ci.nodejs.org/job/node-test-pull-request/23508/
Please reload this pagehttps://github.com/nodejs/node/pull/27968
https://github.com/lpinca
lpincahttps://github.com/lpinca
May 31, 2019 https://github.com/nodejs/node/pull/27968#pullrequestreview-244509848
View reviewed changes https://github.com/nodejs/node/pull/27968/files/e1edbd6ed41225625c8cd5c8acbfc0b9289a7239
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 1, 2019 https://github.com/nodejs/node/pull/27968#pullrequestreview-244603228
View reviewed changes https://github.com/nodejs/node/pull/27968/files/e1edbd6ed41225625c8cd5c8acbfc0b9289a7239
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 2, 2019https://github.com/nodejs/node/pull/27968#issuecomment-498009892
58b1fe7https://github.com/nodejs/node/commit/58b1fe7bd11db74cfac2404a1db2f7fefc7a971c
Please reload this pagehttps://github.com/nodejs/node/pull/27968
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 2, 2019https://github.com/nodejs/node/pull/27968#event-2383073763
Trotthttps://github.com/Trott
Jun 2, 2019 https://github.com/nodejs/node/pull/27968#ref-commit-58b1fe7
https://github.com/apapirovski
https://github.com/Trott
http: fix socketOnWrap edge caseshttps://github.com/Trott/io.js/commit/58b1fe7bd11db74cfac2404a1db2f7fefc7a971c
58b1fe7https://github.com/Trott/io.js/commit/58b1fe7bd11db74cfac2404a1db2f7fefc7a971c
nodejs#27968https://github.com/nodejs/node/pull/27968
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
June 2, 2019 17:20https://github.com/nodejs/node/pull/27968#event-2383293596
targoshttps://github.com/targos
Jun 3, 2019 https://github.com/nodejs/node/pull/27968#ref-commit-24eaeed
https://github.com/apapirovski
https://github.com/targos
http: fix socketOnWrap edge caseshttps://github.com/nodejs/node/commit/24eaeed393362b95410fba9500f731f32ecd5c1d
24eaeedhttps://github.com/nodejs/node/commit/24eaeed393362b95410fba9500f731f32ecd5c1d
#27968https://github.com/nodejs/node/pull/27968
https://github.com/targos
targoshttps://github.com/targos
Jun 3, 2019 https://github.com/nodejs/node/pull/27968#ref-pullrequest-451450524
v12.4.0 release proposal #28040 https://github.com/nodejs/node/pull/28040
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27968
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/27968/files/e1edbd6ed41225625c8cd5c8acbfc0b9289a7239
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/27968/files/e1edbd6ed41225625c8cd5c8acbfc0b9289a7239
https://github.com/ZYSzys
ZYSzys https://github.com/ZYSzys
https://github.com/nodejs/node/pull/27968/files/20d05f4d309b9ed65a77e64099c5e53c1a73ede0
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
Please reload this pagehttps://github.com/nodejs/node/pull/27968
https://github.com/apapirovski
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/lpinca
https://github.com/ZYSzys
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.