| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:8948e9aa-076e-70b9-6246-2e0af087c871 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E34C:778F9:1AEE4D5:22BE348:69927363 |
| html-safe-nonce | 78264c8748103dcfade04e0e8534e57e965116be1bf39cbf5b39ee2558829c6e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMzRDOjc3OEY5OjFBRUU0RDU6MjJCRTM0ODo2OTkyNzM2MyIsInZpc2l0b3JfaWQiOiI4NDM2OTA1NTYxODQ5NzU0NDY3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | adc66772f716a2b7a567f7f0f5731e41b7348d2133ff0179606b1012a004e002 |
| hovercard-subject-tag | pull_request:283088551 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/27945/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/a6bffb4beeee6982121d3a90d4e06d14685392702cad17543db6333075c2b028/nodejs/node/pull/27945 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a6bffb4beeee6982121d3a90d4e06d14685392702cad17543db6333075c2b028/nodejs/node/pull/27945 |
| og:image:alt | napi_define_class is tested by passing NULL to all parameters that are
pointers, one at a time. Moreover, two bugs were corrected. One was
utf8name and the second was the property descriptor pointe... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | octaviansoldea |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/27945#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27945 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27945 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/27945 |
| Reload | https://github.com/nodejs/node/pull/27945 |
| Reload | https://github.com/nodejs/node/pull/27945 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/27945 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.8k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
716
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| octaviansoldea | https://github.com/octaviansoldea |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| octaviansoldea:napi_define_class | https://github.com/octaviansoldea/node/tree/napi_define_class |
| Conversation | https://github.com/nodejs/node/pull/27945 |
| Commits1 (1) | https://github.com/nodejs/node/pull/27945/commits |
| Checks | https://github.com/nodejs/node/pull/27945/checks |
| Files changed | https://github.com/nodejs/node/pull/27945/files |
| src: add napi_define_class() null checks | https://github.com/nodejs/node/pull/27945#top |
| octaviansoldea | https://github.com/octaviansoldea |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| octaviansoldea:napi_define_class | https://github.com/octaviansoldea/node/tree/napi_define_class |
|
| https://github.com/octaviansoldea |
| octaviansoldea | https://github.com/octaviansoldea |
| May 29, 2019 | https://github.com/nodejs/node/pull/27945#issue-449591652 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/27945 |
| src: add napi_define_class() null checks | https://github.com/nodejs/node/pull/27945/commits/ae8c9321ebe0ce51864fb7575bb1e33aa945c94f |
| ae8c932 | https://github.com/nodejs/node/pull/27945/commits/ae8c9321ebe0ce51864fb7575bb1e33aa945c94f |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
| May 29, 2019 | https://github.com/nodejs/node/pull/27945#event-2373817436 |
| https://github.com/legendecas |
| legendecas | https://github.com/legendecas |
|
May 30, 2019
| https://github.com/nodejs/node/pull/27945#pullrequestreview-243597157 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/27945/files/ae8c9321ebe0ce51864fb7575bb1e33aa945c94f |
| test/js-native-api/test_constructor/test.js | https://github.com/nodejs/node/pull/27945/files/ae8c9321ebe0ce51864fb7575bb1e33aa945c94f#diff-13437f1ddc2c19981f155fe7e605f027c20c5618e1d58e91b95dce095a571fd5 |
| legendecas | https://github.com/legendecas |
| May 30, 2019 | https://github.com/nodejs/node/pull/27945#discussion_r288833979 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/27945 |
| gabrielschulhof | https://github.com/gabrielschulhof |
| May 30, 2019 | https://github.com/nodejs/node/pull/27945#discussion_r288859001 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @legendecas | https://github.com/legendecas |
| #27628 | https://github.com/nodejs/node/pull/27628 |
| Please reload this page | https://github.com/nodejs/node/pull/27945 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
node-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api |
| May 30, 2019 | https://github.com/nodejs/node/pull/27945#event-2377093822 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
May 30, 2019
| https://github.com/nodejs/node/pull/27945#pullrequestreview-243627144 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/27945/files/ae8c9321ebe0ce51864fb7575bb1e33aa945c94f |
| test/js-native-api/test_constructor/test_constructor.c | https://github.com/nodejs/node/pull/27945/files/ae8c9321ebe0ce51864fb7575bb1e33aa945c94f#diff-41d56102df7063c15cd7a5b3c9b1e8a64ed8fd8accdc01d0d1b56b79f48223e9 |
| gabrielschulhof | https://github.com/gabrielschulhof |
| May 30, 2019 | https://github.com/nodejs/node/pull/27945#discussion_r288859091 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/27945 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 7, 2019 | https://github.com/nodejs/node/pull/27945#issuecomment-500054990 |
| https://ci.nodejs.org/job/node-test-pull-request/23702/ | https://ci.nodejs.org/job/node-test-pull-request/23702/ |
| Please reload this page | https://github.com/nodejs/node/pull/27945 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 8, 2019 | https://github.com/nodejs/node/pull/27945#issuecomment-500088318 |
| https://ci.nodejs.org/job/node-test-pull-request/23707/ | https://ci.nodejs.org/job/node-test-pull-request/23707/ |
| Please reload this page | https://github.com/nodejs/node/pull/27945 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Jun 8, 2019 | https://github.com/nodejs/node/pull/27945#issuecomment-500093518 |
| a18e27d | https://github.com/nodejs/node/commit/a18e27df9ec29b1633146116810eeb14a3dd335f |
| Please reload this page | https://github.com/nodejs/node/pull/27945 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Jun 8, 2019 | https://github.com/nodejs/node/pull/27945#event-2398764711 |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Jun 8, 2019
| https://github.com/nodejs/node/pull/27945#ref-commit-a18e27d |
| src: add napi_define_class() null checks | https://github.com/nodejs/node/commit/a18e27df9ec29b1633146116810eeb14a3dd335f |
| a18e27d | https://github.com/nodejs/node/commit/a18e27df9ec29b1633146116810eeb14a3dd335f |
| #27945 | https://github.com/nodejs/node/pull/27945 |
| BridgeAR | https://github.com/BridgeAR |
|
Jun 17, 2019
| https://github.com/nodejs/node/pull/27945#ref-commit-c821eef |
|
| https://github.com/BridgeAR |
| src: add napi_define_class() null checks | https://github.com/nodejs/node/commit/c821eefa5f7cd883e29e82a7337b8ae450238e5d |
| c821eef | https://github.com/nodejs/node/commit/c821eefa5f7cd883e29e82a7337b8ae450238e5d |
| #27945 | https://github.com/nodejs/node/pull/27945 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Jun 17, 2019
| https://github.com/nodejs/node/pull/27945#ref-pullrequest-457113206 |
|
v12.5.0 proposal
#28268
| https://github.com/nodejs/node/pull/28268 |
| octaviansoldea | https://github.com/octaviansoldea |
|
Jul 2, 2019
| https://github.com/nodejs/node/pull/27945#ref-commit-ce56853 |
| test: propagate napi_status to JS | https://github.com/octaviansoldea/node/commit/ce56853033e179ab8fcbf700de535c5a741bb209 |
| ce56853 | https://github.com/octaviansoldea/node/commit/ce56853033e179ab8fcbf700de535c5a741bb209 |
| nodejs#27945 (comment) | https://github.com/nodejs/node/pull/27945#discussion_r288833979 |
| https://github.com/octaviansoldea |
| octaviansoldea | https://github.com/octaviansoldea |
|
Jul 2, 2019
| https://github.com/nodejs/node/pull/27945#ref-pullrequest-462982091 |
|
test: propagate napi_status to JS
#28505
| https://github.com/nodejs/node/pull/28505 |
| octaviansoldea | https://github.com/octaviansoldea |
|
Jul 4, 2019
| https://github.com/nodejs/node/pull/27945#ref-commit-4a5161c |
| test: propagate napi_status to JS | https://github.com/octaviansoldea/node/commit/4a5161c3a92d9d7aa2d16c4c8f1be947aee53211 |
| 4a5161c | https://github.com/octaviansoldea/node/commit/4a5161c3a92d9d7aa2d16c4c8f1be947aee53211 |
| nodejs#27945 (comment) | https://github.com/nodejs/node/pull/27945#discussion_r288833979 |
| octaviansoldea | https://github.com/octaviansoldea |
|
Jul 18, 2019
| https://github.com/nodejs/node/pull/27945#ref-commit-ce7e75a |
| test: propagate napi_status to JS | https://github.com/octaviansoldea/node/commit/ce7e75a16063d1c8be400e8384777362aa6ad80b |
| ce7e75a | https://github.com/octaviansoldea/node/commit/ce7e75a16063d1c8be400e8384777362aa6ad80b |
| nodejs#27945 (comment) | https://github.com/nodejs/node/pull/27945#discussion_r288833979 |
| octaviansoldea | https://github.com/octaviansoldea |
|
Jul 18, 2019
| https://github.com/nodejs/node/pull/27945#ref-commit-5c2f2a3 |
| test: propagate napi_status to JS | https://github.com/octaviansoldea/node/commit/5c2f2a37d0fcd4665d5ef15b88c23e116b897f08 |
| 5c2f2a3 | https://github.com/octaviansoldea/node/commit/5c2f2a37d0fcd4665d5ef15b88c23e116b897f08 |
| nodejs#27945 (comment) | https://github.com/nodejs/node/pull/27945#discussion_r288833979 |
| Trott | https://github.com/Trott |
|
Jul 18, 2019
| https://github.com/nodejs/node/pull/27945#ref-commit-3da44b0 |
|
| https://github.com/Trott |
| test: propagate napi_status to JS | https://github.com/Trott/io.js/commit/3da44b0b52617556a1c3816a0ae9167a1848655f |
| 3da44b0 | https://github.com/Trott/io.js/commit/3da44b0b52617556a1c3816a0ae9167a1848655f |
| nodejs#27945 (comment) | https://github.com/nodejs/node/pull/27945#discussion_r288833979 |
| nodejs#28505 | https://github.com/nodejs/node/pull/28505 |
| targos | https://github.com/targos |
|
Jul 20, 2019
| https://github.com/nodejs/node/pull/27945#ref-commit-88809a4 |
|
| https://github.com/targos |
| test: propagate napi_status to JS | https://github.com/nodejs/node/commit/88809a49f66e4e494d4e2c6565284d1e4a247bf2 |
| 88809a4 | https://github.com/nodejs/node/commit/88809a49f66e4e494d4e2c6565284d1e4a247bf2 |
| #27945 (comment) | https://github.com/nodejs/node/pull/27945#discussion_r288833979 |
| #28505 | https://github.com/nodejs/node/pull/28505 |
| vikashk1 | https://github.com/vikashk1 |
|
Aug 13, 2019
| https://github.com/nodejs/node/pull/27945#ref-commit-9af17ad |
|
| https://github.com/vikashk1 |
| Please ignore this msg ( | https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc |
| #1 | https://github.com/vikashk1/node/pull/1 |
| ) | https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc |
| 9af17ad | https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27945 |
|
| https://github.com/legendecas |
|
legendecas
| https://github.com/legendecas |
|
| https://github.com/nodejs/node/pull/27945/files/ae8c9321ebe0ce51864fb7575bb1e33aa945c94f |
|
| https://github.com/gabrielschulhof |
|
gabrielschulhof
| https://github.com/gabrielschulhof |
|
| https://github.com/nodejs/node/pull/27945/files/ae8c9321ebe0ce51864fb7575bb1e33aa945c94f |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
node-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api |
| Please reload this page | https://github.com/nodejs/node/pull/27945 |
|
| https://github.com/octaviansoldea |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/gabrielschulhof |
|
| https://github.com/legendecas |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |