| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:ea77a119-cf3e-3142-5597-00be84460d29 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E4FE:12E2F2:1B42C42:2317DA8:69927486 |
| html-safe-nonce | 724467da0649e43be220c956f64f706da3ddbf1f67ebd9dc35e5ca4d393f9844 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNEZFOjEyRTJGMjoxQjQyQzQyOjIzMTdEQTg6Njk5Mjc0ODYiLCJ2aXNpdG9yX2lkIjoiNDAxNjg0OTA5OTk5NTM3ODgyMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | cb7d8417d899a9ff61c50c3a233451af3c15ad4a707b043dbd760aca88cf2766 |
| hovercard-subject-tag | pull_request:283004289 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/27942/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/bc837e7684f385481732b6f9a89a78db6a01a03a76ec7b902a021254d97c2d78/nodejs/node/pull/27942 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/bc837e7684f385481732b6f9a89a78db6a01a03a76ec7b902a021254d97c2d78/nodejs/node/pull/27942 |
| og:image:alt | I was asked by a community member if they needed to
recompile for v12.x based on the version matrix. Add
additional context to help ensure it is clear that this
is not the case.
Checklist
make ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mhdawson |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/27942#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27942 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27942 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/27942 |
| Reload | https://github.com/nodejs/node/pull/27942 |
| Reload | https://github.com/nodejs/node/pull/27942 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/27942 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.8k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
716
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| mhdawson | https://github.com/mhdawson |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| mhdawson:clarifyMatrix | https://github.com/mhdawson/io.js/tree/clarifyMatrix |
| Conversation | https://github.com/nodejs/node/pull/27942 |
| Commits6 (6) | https://github.com/nodejs/node/pull/27942/commits |
| Checks | https://github.com/nodejs/node/pull/27942/checks |
| Files changed | https://github.com/nodejs/node/pull/27942/files |
| doc: clarify N-API version Matrix. | https://github.com/nodejs/node/pull/27942#top |
| mhdawson | https://github.com/mhdawson |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| mhdawson:clarifyMatrix | https://github.com/mhdawson/io.js/tree/clarifyMatrix |
|
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| May 28, 2019 | https://github.com/nodejs/node/pull/27942#issue-449486255 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/27942 |
|
| https://github.com/mhdawson |
| doc: clarify N-API version Matrix. | https://github.com/nodejs/node/pull/27942/commits/10f9ab18f7dd42722bf3def5904e5e39f3aeed83 |
| 10f9ab1 | https://github.com/nodejs/node/pull/27942/commits/10f9ab18f7dd42722bf3def5904e5e39f3aeed83 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
May 28, 2019
| https://github.com/nodejs/node/pull/27942#pullrequestreview-242942992 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/27942/files/10f9ab18f7dd42722bf3def5904e5e39f3aeed83 |
| doc/api/n-api.md | https://github.com/nodejs/node/pull/27942/files/10f9ab18f7dd42722bf3def5904e5e39f3aeed83#diff-26709ee1f9f0cb60d2d67f45106b31de8ed5eb28ad66c91903fd935a6d607d4d |
| Please reload this page | https://github.com/nodejs/node/pull/27942 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
May 28, 2019
| https://github.com/nodejs/node/pull/27942#pullrequestreview-242943107 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/27942/files/10f9ab18f7dd42722bf3def5904e5e39f3aeed83 |
| doc/api/n-api.md | https://github.com/nodejs/node/pull/27942/files/10f9ab18f7dd42722bf3def5904e5e39f3aeed83#diff-26709ee1f9f0cb60d2d67f45106b31de8ed5eb28ad66c91903fd935a6d607d4d |
| Please reload this page | https://github.com/nodejs/node/pull/27942 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
May 28, 2019
| https://github.com/nodejs/node/pull/27942#pullrequestreview-242943616 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/27942/files/10f9ab18f7dd42722bf3def5904e5e39f3aeed83 |
| doc/api/n-api.md | https://github.com/nodejs/node/pull/27942/files/10f9ab18f7dd42722bf3def5904e5e39f3aeed83#diff-26709ee1f9f0cb60d2d67f45106b31de8ed5eb28ad66c91903fd935a6d607d4d |
| Please reload this page | https://github.com/nodejs/node/pull/27942 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
node-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api |
| Jun 2, 2019 | https://github.com/nodejs/node/pull/27942#event-2383291302 |
| mhdawson | https://github.com/mhdawson |
| June 5, 2019 14:45 | https://github.com/nodejs/node/pull/27942#commits-pushed-668c024 |
|
| https://github.com/mhdawson |
|
| https://github.com/Trott |
| Update doc/api/n-api.md | https://github.com/nodejs/node/pull/27942/commits/668c02466b9683e9769e03d09019cf48246aa408 |
| 668c024 | https://github.com/nodejs/node/pull/27942/commits/668c02466b9683e9769e03d09019cf48246aa408 |
|
| https://github.com/mhdawson |
|
| https://github.com/Trott |
| Update doc/api/n-api.md | https://github.com/nodejs/node/pull/27942/commits/70c7833900d5638b0820f0fa322e40dc79746c43 |
| 70c7833 | https://github.com/nodejs/node/pull/27942/commits/70c7833900d5638b0820f0fa322e40dc79746c43 |
|
| https://github.com/mhdawson |
|
| https://github.com/Trott |
| Update doc/api/n-api.md | https://github.com/nodejs/node/pull/27942/commits/a6bba0fe52274faee92ba3610d250620dd0e9f8b |
| a6bba0f | https://github.com/nodejs/node/pull/27942/commits/a6bba0fe52274faee92ba3610d250620dd0e9f8b |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Jun 5, 2019 | https://github.com/nodejs/node/pull/27942#issuecomment-499207969 |
| @Trott | https://github.com/Trott |
| Please reload this page | https://github.com/nodejs/node/pull/27942 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Jun 5, 2019
| https://github.com/nodejs/node/pull/27942#pullrequestreview-246192625 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/27942/files/a6bba0fe52274faee92ba3610d250620dd0e9f8b |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Jun 5, 2019
| https://github.com/nodejs/node/pull/27942#pullrequestreview-246254221 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/27942/files/a6bba0fe52274faee92ba3610d250620dd0e9f8b |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Jun 5, 2019
| https://github.com/nodejs/node/pull/27942#pullrequestreview-246255781 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/27942/files/a6bba0fe52274faee92ba3610d250620dd0e9f8b |
| https://github.com/boneskull |
| boneskull | https://github.com/boneskull |
|
Jun 5, 2019
| https://github.com/nodejs/node/pull/27942#pullrequestreview-246300948 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/27942/files/a6bba0fe52274faee92ba3610d250620dd0e9f8b |
| boneskull | https://github.com/boneskull |
| https://github.com/nodejs/node/pull/27942#pullrequestreview-246300948 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/27942 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Jun 10, 2019
| https://github.com/nodejs/node/pull/27942#pullrequestreview-247669079 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/27942/files/a6bba0fe52274faee92ba3610d250620dd0e9f8b |
|
| https://github.com/mhdawson |
| squash: address comments | https://github.com/nodejs/node/pull/27942/commits/8f3d2e4b1fd188346525f17634b4bbb602daaf56 |
| 8f3d2e4 | https://github.com/nodejs/node/pull/27942/commits/8f3d2e4b1fd188346525f17634b4bbb602daaf56 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Jun 10, 2019 | https://github.com/nodejs/node/pull/27942#event-2402407403 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Jun 10, 2019 | https://github.com/nodejs/node/pull/27942#issuecomment-500620730 |
| Please reload this page | https://github.com/nodejs/node/pull/27942 |
| https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3669/ | https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3669/ |
| Please reload this page | https://github.com/nodejs/node/pull/27942 |
|
| https://github.com/mhdawson |
| squash: fix linter failure | https://github.com/nodejs/node/pull/27942/commits/33b7dd939441019871253f5a4ba7f07dd211bd70 |
| 33b7dd9 | https://github.com/nodejs/node/pull/27942/commits/33b7dd939441019871253f5a4ba7f07dd211bd70 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Jun 10, 2019 | https://github.com/nodejs/node/pull/27942#issuecomment-500630755 |
| https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3670/ | https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3670/ |
| Please reload this page | https://github.com/nodejs/node/pull/27942 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Jun 10, 2019 | https://github.com/nodejs/node/pull/27942#issuecomment-500632580 |
| Please reload this page | https://github.com/nodejs/node/pull/27942 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Jun 11, 2019 | https://github.com/nodejs/node/pull/27942#issuecomment-500838112 |
| Please reload this page | https://github.com/nodejs/node/pull/27942 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Jun 11, 2019 | https://github.com/nodejs/node/pull/27942#event-2404123273 |
| mhdawson | https://github.com/mhdawson |
|
Jun 11, 2019
| https://github.com/nodejs/node/pull/27942#ref-commit-fddc2d7 |
|
| https://github.com/mhdawson |
| doc: clarify N-API version Matrix | https://github.com/nodejs/node/commit/fddc2d7a7eac87be04e4b3cb26ef45e6dcc07fac |
| fddc2d7 | https://github.com/nodejs/node/commit/fddc2d7a7eac87be04e4b3cb26ef45e6dcc07fac |
| #27942 | https://github.com/nodejs/node/pull/27942 |
| BridgeAR | https://github.com/BridgeAR |
|
Jun 17, 2019
| https://github.com/nodejs/node/pull/27942#ref-commit-69af43e |
|
| https://github.com/mhdawson |
|
| https://github.com/BridgeAR |
| doc: clarify N-API version Matrix | https://github.com/nodejs/node/commit/69af43ead9e964a82a18046b54c284963974d3fa |
| 69af43e | https://github.com/nodejs/node/commit/69af43ead9e964a82a18046b54c284963974d3fa |
| #27942 | https://github.com/nodejs/node/pull/27942 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Jun 17, 2019
| https://github.com/nodejs/node/pull/27942#ref-pullrequest-457113206 |
|
v12.5.0 proposal
#28268
| https://github.com/nodejs/node/pull/28268 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| September 30, 2019 13:14 | https://github.com/nodejs/node/pull/27942#event-2673214843 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27942 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/27942/files/a6bba0fe52274faee92ba3610d250620dd0e9f8b |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/27942/files/a6bba0fe52274faee92ba3610d250620dd0e9f8b |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/27942/files/a6bba0fe52274faee92ba3610d250620dd0e9f8b |
|
| https://github.com/BethGriggs |
|
BethGriggs
| https://github.com/BethGriggs |
|
| https://github.com/nodejs/node/pull/27942/files/a6bba0fe52274faee92ba3610d250620dd0e9f8b |
|
| https://github.com/boneskull |
|
boneskull
| https://github.com/boneskull |
|
| https://github.com/nodejs/node/pull/27942/files/a6bba0fe52274faee92ba3610d250620dd0e9f8b |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
node-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api |
| Please reload this page | https://github.com/nodejs/node/pull/27942 |
|
| https://github.com/mhdawson |
|
| https://github.com/jasnell |
|
| https://github.com/Trott |
|
| https://github.com/boneskull |
|
| https://github.com/richardlau |
|
| https://github.com/BethGriggs |
|
| https://github.com/addaleax |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |