René's URL Explorer Experiment


Title: bindings: close after reading module struct by indutny · Pull Request #2792 · nodejs/node · GitHub

Open Graph Title: bindings: close after reading module struct by indutny · Pull Request #2792 · nodejs/node

X Title: bindings: close after reading module struct by indutny · Pull Request #2792 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Do not let the module struct to be deallocated by uv_dclose before reading data from it. Found it while investigating: #2791 (comment) cc @nodejs/collaborators

X Description: Do not let the module struct to be deallocated by uv_dclose before reading data from it. Found it while investigating: #2791 (comment) cc @nodejs/collaborators

Opengraph URL: https://github.com/nodejs/node/pull/2792

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:010d4ea1-ad6e-f2d0-c6e3-335b19eced6d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDEAC:418ED:47388C0:624A67C:6A4F55D3
html-safe-nonce1bcdaaf3dd506a2fe3083268e08c72c085ce653ede774ec77c516e6bbd320e97
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERUFDOjQxOEVEOjQ3Mzg4QzA6NjI0QTY3Qzo2QTRGNTVEMyIsInZpc2l0b3JfaWQiOiIxMjQwNTU0OTQ1MzU2MTkxMTg3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac492854525d40c1e40f53317f9480df7f50b1cc8a5bfe3e3b18174478100c5270
hovercard-subject-tagpull_request:44654111
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/2792/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/18f75e2c5f8595c76c3f8658616e1534f9851d2f722279541aa2d8e5549dcaa9/nodejs/node/pull/2792
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/18f75e2c5f8595c76c3f8658616e1534f9851d2f722279541aa2d8e5549dcaa9/nodejs/node/pull/2792
og:image:altDo not let the module struct to be deallocated by uv_dclose before reading data from it. Found it while investigating: #2791 (comment) cc @nodejs/collaborators
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameindutny
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/2792#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F2792
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F2792
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/2792
Reloadhttps://github.com/nodejs/node/pull/2792
Reloadhttps://github.com/nodejs/node/pull/2792
Please reload this pagehttps://github.com/nodejs/node/pull/2792
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/2792
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 970 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
indutnyhttps://github.com/indutny
nodejs:masterhttps://github.com/nodejs/node/tree/master
indutny:fix/gh-2791https://github.com/indutny/io.js/tree/fix/gh-2791
Conversationhttps://github.com/nodejs/node/pull/2792
Commits1 (1)https://github.com/nodejs/node/pull/2792/commits
Checkshttps://github.com/nodejs/node/pull/2792/checks
Files changedhttps://github.com/nodejs/node/pull/2792/files
bindings: close after reading module structhttps://github.com/nodejs/node/pull/2792#top
indutnyhttps://github.com/indutny
nodejs:masterhttps://github.com/nodejs/node/tree/master
indutny:fix/gh-2791https://github.com/indutny/io.js/tree/fix/gh-2791
https://github.com/indutny
indutnyhttps://github.com/indutny
Sep 10, 2015https://github.com/nodejs/node/pull/2792#issue-105784129
#2791 (comment)https://github.com/nodejs/node/issues/2791#issuecomment-139196668
Please reload this pagehttps://github.com/nodejs/node/pull/2792
https://github.com/indutny
bindings: close after reading module structhttps://github.com/nodejs/node/pull/2792/commits/908e025ff649ce2c3440baaeb2f551aa272b3957
908e025https://github.com/nodejs/node/pull/2792/commits/908e025ff649ce2c3440baaeb2f551aa272b3957
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Sep 10, 2015https://github.com/nodejs/node/pull/2792#issuecomment-139204435
Please reload this pagehttps://github.com/nodejs/node/pull/2792
bnoordhuishttps://github.com/bnoordhuis
Sep 10, 2015 https://github.com/nodejs/node/pull/2792#discussion-diff-39148912
View reviewed changes https://github.com/nodejs/node/pull/2792/files/908e025ff649ce2c3440baaeb2f551aa272b3957#diff-6c1386cbc6e4a11941649af31a0257d5c3e40b5f41223cdddf87ab2e984b705a
src/node.cchttps://github.com/nodejs/node/pull/2792/files#diff-6c1386cbc6e4a11941649af31a0257d5c3e40b5f41223cdddf87ab2e984b705a
bnoordhuishttps://github.com/bnoordhuis
Sep 10, 2015https://github.com/nodejs/node/pull/2792#discussion_r39148912
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/2792
indutnyhttps://github.com/indutny
Sep 10, 2015https://github.com/nodejs/node/pull/2792#discussion_r39149679
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/2792
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Sep 10, 2015https://github.com/nodejs/node/pull/2792#event-405862052
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Sep 10, 2015https://github.com/nodejs/node/pull/2792#issuecomment-139259648
Please reload this pagehttps://github.com/nodejs/node/pull/2792
https://github.com/yosuke-furukawa
yosuke-furukawahttps://github.com/yosuke-furukawa
Sep 10, 2015https://github.com/nodejs/node/pull/2792#issuecomment-139264793
Please reload this pagehttps://github.com/nodejs/node/pull/2792
indutnyhttps://github.com/indutny
Sep 10, 2015 https://github.com/nodejs/node/pull/2792#ref-commit-a6d674d
https://github.com/indutny
bindings: close after reading module structhttps://github.com/nodejs/node/commit/a6d674d751517774b227126f20ba15ab637192fd
a6d674dhttps://github.com/nodejs/node/commit/a6d674d751517774b227126f20ba15ab637192fd
#2792https://github.com/nodejs/node/pull/2792
https://github.com/indutny
indutnyhttps://github.com/indutny
Sep 10, 2015https://github.com/nodejs/node/pull/2792#issuecomment-139353499
a6d674dhttps://github.com/nodejs/node/commit/a6d674d751517774b227126f20ba15ab637192fd
Please reload this pagehttps://github.com/nodejs/node/pull/2792
https://github.com/indutny
indutnyhttps://github.com/indutny
Sep 10, 2015https://github.com/nodejs/node/pull/2792#issuecomment-139353539
@rvagghttps://github.com/rvagg
Please reload this pagehttps://github.com/nodejs/node/pull/2792
https://github.com/indutny
indutnyhttps://github.com/indutny
Sep 10, 2015https://github.com/nodejs/node/pull/2792#event-406351828
https://github.com/indutny
indutnyhttps://github.com/indutny
September 10, 2015 19:26https://github.com/nodejs/node/pull/2792#event-406351858
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
land-on-4x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-4x
Sep 10, 2015https://github.com/nodejs/node/pull/2792#event-406413180
indutnyhttps://github.com/indutny
Sep 11, 2015 https://github.com/nodejs/node/pull/2792#ref-commit-9683e5d
https://github.com/indutny
https://github.com/rvagg
bindings: close after reading module structhttps://github.com/nodejs/node/commit/9683e5df51956e737eb5a2914458d481e2dc4bd8
9683e5dhttps://github.com/nodejs/node/commit/9683e5df51956e737eb5a2914458d481e2dc4bd8
#2792https://github.com/nodejs/node/pull/2792
indutnyhttps://github.com/indutny
Sep 12, 2015 https://github.com/nodejs/node/pull/2792#ref-commit-b73ff52
https://github.com/indutny
https://github.com/rvagg
bindings: close after reading module structhttps://github.com/nodejs/node/commit/b73ff52fe684ad6c9216bf4934d7f8e9459ab7d3
b73ff52https://github.com/nodejs/node/commit/b73ff52fe684ad6c9216bf4934d7f8e9459ab7d3
#2792https://github.com/nodejs/node/pull/2792
https://github.com/rvagg
rvagghttps://github.com/rvagg
Sep 12, 2015 https://github.com/nodejs/node/pull/2792#ref-pullrequest-104996474
Release proposal: v3.3.1 #2698 https://github.com/nodejs/node/pull/2698
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Sep 13, 2015 https://github.com/nodejs/node/pull/2792#ref-issue-106216415
Release proposal: v4.1.0 #2844 https://github.com/nodejs/node/issues/2844
https://github.com/rvagg
rvagghttps://github.com/rvagg
Sep 22, 2015 https://github.com/nodejs/node/pull/2792#ref-pullrequest-107656289
Release proposal: v4.1.1 #2995 https://github.com/nodejs/node/pull/2995
https://github.com/jasnell
jasnellhttps://github.com/jasnell
lts-landed-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-landed-on-v4.x
Oct 7, 2015https://github.com/nodejs/node/pull/2792#event-429728218
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v4.x
Nov 16, 2015https://github.com/nodejs/node/pull/2792#event-465806938
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F2792
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Please reload this pagehttps://github.com/nodejs/node/pull/2792
https://github.com/indutny
https://github.com/evanlucas
https://github.com/mscdex
https://github.com/yosuke-furukawa
https://github.com/bnoordhuis
https://github.com/trevnorris
https://github.com/ChALkeR
https://github.com/jasnell
https://github.com/MylesBorins
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.