René's URL Explorer Experiment


Title: doc,test: clarify that Http2Stream is destroyed after data is read by mildsunrise · Pull Request #27891 · nodejs/node · GitHub

Open Graph Title: doc,test: clarify that Http2Stream is destroyed after data is read by mildsunrise · Pull Request #27891 · nodejs/node

X Title: doc,test: clarify that Http2Stream is destroyed after data is read by mildsunrise · Pull Request #27891 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Correct docs to clarify that behaviour, and fix a race condition in test-http2-large-write-destroy.js. Fixes: #27863 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/o...

X Description: Correct docs to clarify that behaviour, and fix a race condition in test-http2-large-write-destroy.js. Fixes: #27863 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/o...

Opengraph URL: https://github.com/nodejs/node/pull/27891

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:bb4d51a0-f4db-095c-7aa8-843c2dfe8b3c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE1B2:B5089:E4954E:13EB015:6A4E8A67
html-safe-nonce7373cf716f570fc5401306f93427146ae7bca4b1631dcf4cc2b531d1a6eb8ec7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMUIyOkI1MDg5OkU0OTU0RToxM0VCMDE1OjZBNEU4QTY3IiwidmlzaXRvcl9pZCI6IjYzMDA5ODUwNzgyMTk0NDI3OTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac16d20f989bb164da6a4f1649cb52efc837078d339962571fd0f6f15d7d101d49
hovercard-subject-tagpull_request:282291402
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/27891/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e88a670d7657583fa569f1e393ac9f077cfe139b8e086b5d29b8ec04ac7ed95f/nodejs/node/pull/27891
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e88a670d7657583fa569f1e393ac9f077cfe139b8e086b5d29b8ec04ac7ed95f/nodejs/node/pull/27891
og:image:altCorrect docs to clarify that behaviour, and fix a race condition in test-http2-large-write-destroy.js. Fixes: #27863 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/o...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemildsunrise
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/27891#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27891
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27891
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/27891
Reloadhttps://github.com/nodejs/node/pull/27891
Reloadhttps://github.com/nodejs/node/pull/27891
Please reload this pagehttps://github.com/nodejs/node/pull/27891
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/27891
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 965 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
mildsunrisehttps://github.com/mildsunrise
nodejs:masterhttps://github.com/nodejs/node/tree/master
mildsunrise:patch/http2-closehttps://github.com/mildsunrise/node/tree/patch/http2-close
Conversationhttps://github.com/nodejs/node/pull/27891
Commits2 (2)https://github.com/nodejs/node/pull/27891/commits
Checkshttps://github.com/nodejs/node/pull/27891/checks
Files changedhttps://github.com/nodejs/node/pull/27891/files
doc,test: clarify that Http2Stream is destroyed after data is readhttps://github.com/nodejs/node/pull/27891#top
mildsunrisehttps://github.com/mildsunrise
nodejs:masterhttps://github.com/nodejs/node/tree/master
mildsunrise:patch/http2-closehttps://github.com/mildsunrise/node/tree/patch/http2-close
https://github.com/mildsunrise
mildsunrisehttps://github.com/mildsunrise
May 26, 2019https://github.com/nodejs/node/pull/27891#issue-448559316
#27863https://github.com/nodejs/node/issues/27863
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/27891
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 26, 2019 https://github.com/nodejs/node/pull/27891#pullrequestreview-242037551
View reviewed changes https://github.com/nodejs/node/pull/27891/files
test/parallel/test-http2-large-write-destroy.jshttps://github.com/nodejs/node/pull/27891/files#diff-f1e2641cbedff58120c61aa8c96b18e512b125385f63e2768285dae4a761901a
Please reload this pagehttps://github.com/nodejs/node/pull/27891
https://github.com/mildsunrise
doc,test: clarify that Http2Stream is destroyed after data is readhttps://github.com/nodejs/node/pull/27891/commits/b5abaa573026d84808296b8a9c2a0e6803463d3b
b5abaa5https://github.com/nodejs/node/pull/27891/commits/b5abaa573026d84808296b8a9c2a0e6803463d3b
nodejs#27863https://github.com/nodejs/node/issues/27863
https://github.com/mildsunrise
mildsunrisehttps://github.com/mildsunrise
force-pushedhttps://github.com/nodejs/node/compare/b2a38bed75cc00382bffaaac25d9f242c00041d3..b5abaa573026d84808296b8a9c2a0e6803463d3b
b2a38behttps://github.com/nodejs/node/commit/b2a38bed75cc00382bffaaac25d9f242c00041d3
b5abaa5https://github.com/nodejs/node/commit/b5abaa573026d84808296b8a9c2a0e6803463d3b
Compare https://github.com/nodejs/node/compare/b2a38bed75cc00382bffaaac25d9f242c00041d3..b5abaa573026d84808296b8a9c2a0e6803463d3b
May 26, 2019 12:38https://github.com/nodejs/node/pull/27891#event-2367795291
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 26, 2019https://github.com/nodejs/node/pull/27891#issuecomment-495996926
https://ci.nodejs.org/job/node-test-pull-request/23340/https://ci.nodejs.org/job/node-test-pull-request/23340/
Please reload this pagehttps://github.com/nodejs/node/pull/27891
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 26, 2019 https://github.com/nodejs/node/pull/27891#pullrequestreview-242038492
View reviewed changes https://github.com/nodejs/node/pull/27891/files/b5abaa573026d84808296b8a9c2a0e6803463d3b
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
doc https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
May 26, 2019https://github.com/nodejs/node/pull/27891#event-2367800915
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
May 26, 2019 https://github.com/nodejs/node/pull/27891#pullrequestreview-242040254
View reviewed changes https://github.com/nodejs/node/pull/27891/files/b5abaa573026d84808296b8a9c2a0e6803463d3b
https://github.com/Trott
Trotthttps://github.com/Trott
May 27, 2019 https://github.com/nodejs/node/pull/27891#pullrequestreview-242066521
View reviewed changes https://github.com/nodejs/node/pull/27891/files/b5abaa573026d84808296b8a9c2a0e6803463d3b
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 27, 2019https://github.com/nodejs/node/pull/27891#issuecomment-496048238
https://ci.nodejs.org/job/node-test-pull-request/23369/https://ci.nodejs.org/job/node-test-pull-request/23369/
Please reload this pagehttps://github.com/nodejs/node/pull/27891
https://github.com/Trott
Trotthttps://github.com/Trott
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
May 27, 2019https://github.com/nodejs/node/pull/27891#event-2368109655
https://github.com/lpinca
lpincahttps://github.com/lpinca
May 27, 2019 https://github.com/nodejs/node/pull/27891#pullrequestreview-242100062
View reviewed changes https://github.com/nodejs/node/pull/27891/files/b5abaa573026d84808296b8a9c2a0e6803463d3b
test/parallel/test-http2-large-write-destroy.jshttps://github.com/nodejs/node/pull/27891/files/b5abaa573026d84808296b8a9c2a0e6803463d3b#diff-f1e2641cbedff58120c61aa8c96b18e512b125385f63e2768285dae4a761901a
Please reload this pagehttps://github.com/nodejs/node/pull/27891
https://github.com/mildsunrise
https://github.com/lpinca
Update test/parallel/test-http2-large-write-destroy.jshttps://github.com/nodejs/node/pull/27891/commits/088ed66082753d31bf9697510bd9a6795f278e79
088ed66https://github.com/nodejs/node/pull/27891/commits/088ed66082753d31bf9697510bd9a6795f278e79
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 27, 2019https://github.com/nodejs/node/pull/27891#issuecomment-496101126
https://ci.nodejs.org/job/node-test-pull-request/23402/https://ci.nodejs.org/job/node-test-pull-request/23402/
Please reload this pagehttps://github.com/nodejs/node/pull/27891
https://github.com/mildsunrise
mildsunrisehttps://github.com/mildsunrise
May 27, 2019 https://github.com/nodejs/node/pull/27891#ref-pullrequest-448354393
tls: group chunks into TLS segments #27861 https://github.com/nodejs/node/pull/27861
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 27, 2019https://github.com/nodejs/node/pull/27891#issuecomment-496221123
https://ci.nodejs.org/job/node-test-pull-request/23407/https://ci.nodejs.org/job/node-test-pull-request/23407/
Please reload this pagehttps://github.com/nodejs/node/pull/27891
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 28, 2019https://github.com/nodejs/node/pull/27891#issuecomment-496338815
https://ci.nodejs.org/job/node-test-pull-request/23427/https://ci.nodejs.org/job/node-test-pull-request/23427/
Please reload this pagehttps://github.com/nodejs/node/pull/27891
https://github.com/mildsunrise
mildsunrisehttps://github.com/mildsunrise
May 28, 2019https://github.com/nodejs/node/pull/27891#issuecomment-496380551
Please reload this pagehttps://github.com/nodejs/node/pull/27891
https://github.com/Trott
Trotthttps://github.com/Trott
May 28, 2019https://github.com/nodejs/node/pull/27891#issuecomment-496624328
Please reload this pagehttps://github.com/nodejs/node/pull/27891
https://github.com/Trott
Trotthttps://github.com/Trott
May 28, 2019https://github.com/nodejs/node/pull/27891#event-2372663505
Trotthttps://github.com/Trott
May 28, 2019 https://github.com/nodejs/node/pull/27891#ref-commit-42d8011
https://github.com/mildsunrise
https://github.com/Trott
doc,test: clarify that Http2Stream is destroyed after data is readhttps://github.com/Trott/io.js/commit/42d80113bbd4ad5d790e061ea7568a04f0e900c6
42d8011https://github.com/Trott/io.js/commit/42d80113bbd4ad5d790e061ea7568a04f0e900c6
nodejs#27863https://github.com/nodejs/node/issues/27863
nodejs#27891https://github.com/nodejs/node/pull/27891
https://github.com/mildsunrise
mildsunrisehttps://github.com/mildsunrise
May 28, 2019 18:12https://github.com/nodejs/node/pull/27891#event-2372697154
targoshttps://github.com/targos
May 31, 2019 https://github.com/nodejs/node/pull/27891#ref-commit-6cd64c8
https://github.com/mildsunrise
https://github.com/targos
doc,test: clarify that Http2Stream is destroyed after data is readhttps://github.com/nodejs/node/commit/6cd64c82799f2258aad75d33b18d809ccaabe4ad
6cd64c8https://github.com/nodejs/node/commit/6cd64c82799f2258aad75d33b18d809ccaabe4ad
#27863https://github.com/nodejs/node/issues/27863
#27891https://github.com/nodejs/node/pull/27891
https://github.com/targos
targoshttps://github.com/targos
Jun 3, 2019 https://github.com/nodejs/node/pull/27891#ref-pullrequest-451450524
v12.4.0 release proposal #28040 https://github.com/nodejs/node/pull/28040
mildsunrisehttps://github.com/mildsunrise
Jul 30, 2019 https://github.com/nodejs/node/pull/27891#ref-commit-100d8ef
https://github.com/mildsunrise
doc,test: clarify that Http2Stream is destroyed after data is readhttps://github.com/mildsunrise/node/commit/100d8ef236a4434bc9eb39290e97baa291e06e69
100d8efhttps://github.com/mildsunrise/node/commit/100d8ef236a4434bc9eb39290e97baa291e06e69
nodejs#27863https://github.com/nodejs/node/issues/27863
nodejs#27891https://github.com/nodejs/node/pull/27891
https://github.com/mildsunrise
mildsunrisehttps://github.com/mildsunrise
Jul 30, 2019 https://github.com/nodejs/node/pull/27891#ref-pullrequest-474831385
[v10.x] tls: group chunks into TLS segments #28904 https://github.com/nodejs/node/pull/28904
BethGriggshttps://github.com/BethGriggs
Oct 7, 2019 https://github.com/nodejs/node/pull/27891#ref-commit-56a834a
https://github.com/mildsunrise
https://github.com/BethGriggs
doc,test: clarify that Http2Stream is destroyed after data is readhttps://github.com/nodejs/node/commit/56a834a53f7e1651b2f5b7533da3b1df27bb8498
56a834ahttps://github.com/nodejs/node/commit/56a834a53f7e1651b2f5b7533da3b1df27bb8498
#27863https://github.com/nodejs/node/issues/27863
#28904https://github.com/nodejs/node/pull/28904
#27891https://github.com/nodejs/node/pull/27891
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Oct 7, 2019 https://github.com/nodejs/node/pull/27891#ref-pullrequest-503572635
v10.17.0 proposal #29875 https://github.com/nodejs/node/pull/29875
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27891
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/27891/files/b5abaa573026d84808296b8a9c2a0e6803463d3b
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/27891/files/b2a38bed75cc00382bffaaac25d9f242c00041d3
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/27891/files/b5abaa573026d84808296b8a9c2a0e6803463d3b
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/27891/files/b5abaa573026d84808296b8a9c2a0e6803463d3b
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/27891/files/b5abaa573026d84808296b8a9c2a0e6803463d3b
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
doc https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
http2: close not emitted when receiving RST_STREAM after DATA https://github.com/nodejs/node/issues/27863
Please reload this pagehttps://github.com/nodejs/node/pull/27891
https://github.com/mildsunrise
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/addaleax
https://github.com/lpinca
https://github.com/cjihrig
https://github.com/BridgeAR
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.