René's URL Explorer Experiment


Title: http: fix deferToConnect comments by ronag · Pull Request #27876 · nodejs/node · GitHub

Open Graph Title: http: fix deferToConnect comments by ronag · Pull Request #27876 · nodejs/node

X Title: http: fix deferToConnect comments by ronag · Pull Request #27876 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes #27875. Fix description to actual intended and current behaviour. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is ch...

X Description: Fixes #27875. Fix description to actual intended and current behaviour. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is ch...

Opengraph URL: https://github.com/nodejs/node/pull/27876

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:cb9d7c78-b101-6f39-44a7-39bed08cf06a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9140:28B9FB:80F9F8:B21011:6A507E23
html-safe-nonce366be1765e1fc53e4293249c0917e24989002332851dcfc5c57e864647517be8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MTQwOjI4QjlGQjo4MEY5Rjg6QjIxMDExOjZBNTA3RTIzIiwidmlzaXRvcl9pZCI6IjQ2NTI5NTQyMDkxNzk2OTY2NzUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac11a22ed0dc4cc3a56a623066a4e431913b276e9f35e7f27967a2c5bd0d8e489d
hovercard-subject-tagpull_request:282255838
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/27876/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2a1f0e7fa84681b46c8915b361ce6a68bb53c02045e63b47884337ec86b00beb/nodejs/node/pull/27876
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2a1f0e7fa84681b46c8915b361ce6a68bb53c02045e63b47884337ec86b00beb/nodejs/node/pull/27876
og:image:altFixes #27875. Fix description to actual intended and current behaviour. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is ch...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameronag
hostnamegithub.com
expected-hostnamegithub.com
Noned6dc8294eb500fa36bbc57472d61fe87c522f9c3c1d64f70f4926f66a66a7efb
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7ac0ad2f2c7e4b9056617355fd9e33e22b0c8df9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/27876#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27876
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27876
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/27876
Reloadhttps://github.com/nodejs/node/pull/27876
Reloadhttps://github.com/nodejs/node/pull/27876
Please reload this pagehttps://github.com/nodejs/node/pull/27876
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/27876
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 979 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:fix-defer-to-connecthttps://github.com/nxtedition/node/tree/fix-defer-to-connect
Conversationhttps://github.com/nodejs/node/pull/27876
Commits1 (1)https://github.com/nodejs/node/pull/27876/commits
Checkshttps://github.com/nodejs/node/pull/27876/checks
Files changedhttps://github.com/nodejs/node/pull/27876/files
http: fix deferToConnect commentshttps://github.com/nodejs/node/pull/27876#top
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:fix-defer-to-connecthttps://github.com/nxtedition/node/tree/fix-defer-to-connect
https://github.com/ronag
ronaghttps://github.com/ronag
May 25, 2019https://github.com/nodejs/node/pull/27876#issue-448504135
Please reload this pagehttps://github.com/nodejs/node/pull/27876
#27875https://github.com/nodejs/node/issues/27875
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/27876
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
May 25, 2019https://github.com/nodejs/node/pull/27876#event-2367524641
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/2f266db34085adac7dce1b022f182d785b9e62e8..d67691224a13999326ec6654f237546a6307c5d8
2f266dbhttps://github.com/nodejs/node/commit/2f266db34085adac7dce1b022f182d785b9e62e8
d676912https://github.com/nodejs/node/commit/d67691224a13999326ec6654f237546a6307c5d8
Compare https://github.com/nodejs/node/compare/2f266db34085adac7dce1b022f182d785b9e62e8..d67691224a13999326ec6654f237546a6307c5d8
May 25, 2019 21:27https://github.com/nodejs/node/pull/27876#event-2367525004
https://github.com/Trott
Trotthttps://github.com/Trott
May 26, 2019https://github.com/nodejs/node/pull/27876#issuecomment-495967033
Please reload this pagehttps://github.com/nodejs/node/pull/27876
https://github.com/ronag
ronaghttps://github.com/ronag
May 26, 2019https://github.com/nodejs/node/pull/27876#issuecomment-495982021
@Trotthttps://github.com/Trott
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/27876
https://github.com/mcollina
mcollinahttps://github.com/mcollina
May 26, 2019https://github.com/nodejs/node/pull/27876#issuecomment-495985885
#27875https://github.com/nodejs/node/issues/27875
Please reload this pagehttps://github.com/nodejs/node/pull/27876
https://github.com/ronag
ronaghttps://github.com/ronag
May 26, 2019https://github.com/nodejs/node/pull/27876#issuecomment-495987618
Please reload this pagehttps://github.com/nodejs/node/pull/27876
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/d67691224a13999326ec6654f237546a6307c5d8..f04e16700cb770148d44cc2addfa622e44e2d2ec
d676912https://github.com/nodejs/node/commit/d67691224a13999326ec6654f237546a6307c5d8
f04e167https://github.com/nodejs/node/commit/f04e16700cb770148d44cc2addfa622e44e2d2ec
Compare https://github.com/nodejs/node/compare/d67691224a13999326ec6654f237546a6307c5d8..f04e16700cb770148d44cc2addfa622e44e2d2ec
May 26, 2019 10:39https://github.com/nodejs/node/pull/27876#event-2367748290
https://github.com/ronag
ronaghttps://github.com/ronag
May 26, 2019https://github.com/nodejs/node/pull/27876#issuecomment-495988065
Please reload this pagehttps://github.com/nodejs/node/pull/27876
Please reload this pagehttps://github.com/nodejs/node/pull/27876
https://github.com/mcollina
mcollinahttps://github.com/mcollina
May 26, 2019 https://github.com/nodejs/node/pull/27876#pullrequestreview-242034697
View reviewed changes https://github.com/nodejs/node/pull/27876/files
lib/_http_client.jshttps://github.com/nodejs/node/pull/27876/files#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
mcollinahttps://github.com/mcollina
May 26, 2019https://github.com/nodejs/node/pull/27876#discussion_r287593071
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/27876
ronaghttps://github.com/ronag
May 26, 2019https://github.com/nodejs/node/pull/27876#discussion_r287594252
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/27876
mcollinahttps://github.com/mcollina
May 26, 2019https://github.com/nodejs/node/pull/27876#discussion_r287596193
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/27876
ronaghttps://github.com/ronag
May 26, 2019https://github.com/nodejs/node/pull/27876#discussion_r287602957
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://nodejs.org/api/http.html#http_event_sockethttps://nodejs.org/api/http.html#http_event_socket
Please reload this pagehttps://github.com/nodejs/node/pull/27876
https://github.com/ronag
http: fix deferToConnect commentshttps://github.com/nodejs/node/pull/27876/commits/2fd58d5d8fcbe530693fa462a3ed7d7a26b2aec6
2fd58d5https://github.com/nodejs/node/pull/27876/commits/2fd58d5d8fcbe530693fa462a3ed7d7a26b2aec6
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/f04e16700cb770148d44cc2addfa622e44e2d2ec..2fd58d5d8fcbe530693fa462a3ed7d7a26b2aec6
f04e167https://github.com/nodejs/node/commit/f04e16700cb770148d44cc2addfa622e44e2d2ec
2fd58d5https://github.com/nodejs/node/commit/2fd58d5d8fcbe530693fa462a3ed7d7a26b2aec6
Compare https://github.com/nodejs/node/compare/f04e16700cb770148d44cc2addfa622e44e2d2ec..2fd58d5d8fcbe530693fa462a3ed7d7a26b2aec6
May 26, 2019 15:29https://github.com/nodejs/node/pull/27876#event-2367867946
https://github.com/mcollina
mcollinahttps://github.com/mcollina
May 26, 2019 https://github.com/nodejs/node/pull/27876#pullrequestreview-242049064
View reviewed changes https://github.com/nodejs/node/pull/27876/files/2fd58d5d8fcbe530693fa462a3ed7d7a26b2aec6
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/27876#pullrequestreview-242049064
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/27876
https://github.com/Trott
Trotthttps://github.com/Trott
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
May 27, 2019https://github.com/nodejs/node/pull/27876#event-2368083129
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 27, 2019https://github.com/nodejs/node/pull/27876#issuecomment-496044367
https://ci.nodejs.org/job/node-test-pull-request/23364/https://ci.nodejs.org/job/node-test-pull-request/23364/
Please reload this pagehttps://github.com/nodejs/node/pull/27876
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 29, 2019https://github.com/nodejs/node/pull/27876#event-2375077801
https://github.com/Trott
Trotthttps://github.com/Trott
May 30, 2019 https://github.com/nodejs/node/pull/27876#pullrequestreview-243803232
View reviewed changes https://github.com/nodejs/node/pull/27876/files/2fd58d5d8fcbe530693fa462a3ed7d7a26b2aec6
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 30, 2019https://github.com/nodejs/node/pull/27876#issuecomment-497335646
https://ci.nodejs.org/job/node-test-pull-request/23485/https://ci.nodejs.org/job/node-test-pull-request/23485/
Please reload this pagehttps://github.com/nodejs/node/pull/27876
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 30, 2019https://github.com/nodejs/node/pull/27876#issuecomment-497364060
https://ci.nodejs.org/job/node-test-pull-request/23492/https://ci.nodejs.org/job/node-test-pull-request/23492/
Please reload this pagehttps://github.com/nodejs/node/pull/27876
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 2, 2019https://github.com/nodejs/node/pull/27876#issuecomment-498013332
c6f545ahttps://github.com/nodejs/node/commit/c6f545a74a0d6888d2e628019a98a882a9325855
Please reload this pagehttps://github.com/nodejs/node/pull/27876
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 2, 2019https://github.com/nodejs/node/pull/27876#event-2383091870
Trotthttps://github.com/Trott
Jun 2, 2019 https://github.com/nodejs/node/pull/27876#ref-commit-c6f545a
https://github.com/ronag
https://github.com/Trott
http: fix deferToConnect commentshttps://github.com/Trott/io.js/commit/c6f545a74a0d6888d2e628019a98a882a9325855
c6f545ahttps://github.com/Trott/io.js/commit/c6f545a74a0d6888d2e628019a98a882a9325855
nodejs#27876https://github.com/nodejs/node/pull/27876
targoshttps://github.com/targos
Jun 3, 2019 https://github.com/nodejs/node/pull/27876#ref-commit-d948656
https://github.com/ronag
https://github.com/targos
http: fix deferToConnect commentshttps://github.com/nodejs/node/commit/d948656635a8abc537ff73db8629854efadfbf02
d948656https://github.com/nodejs/node/commit/d948656635a8abc537ff73db8629854efadfbf02
#27876https://github.com/nodejs/node/pull/27876
https://github.com/targos
targoshttps://github.com/targos
Jun 3, 2019 https://github.com/nodejs/node/pull/27876#ref-pullrequest-451450524
v12.4.0 release proposal #28040 https://github.com/nodejs/node/pull/28040
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jun 23, 2019 https://github.com/nodejs/node/pull/27876#ref-issue-448503928
ClientRequest._deferToConnect doesn't wait until connected #27875 https://github.com/nodejs/node/issues/27875
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27876
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/27876/files/2fd58d5d8fcbe530693fa462a3ed7d7a26b2aec6
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/27876/files/2fd58d5d8fcbe530693fa462a3ed7d7a26b2aec6
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
ClientRequest._deferToConnect doesn't wait until connected https://github.com/nodejs/node/issues/27875
Please reload this pagehttps://github.com/nodejs/node/pull/27876
https://github.com/ronag
https://github.com/Trott
https://github.com/mcollina
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.