René's URL Explorer Experiment


Title: test: remove check for valid hostname in test-dns.js by Trott · Pull Request #2785 · nodejs/node · GitHub

Open Graph Title: test: remove check for valid hostname in test-dns.js by Trott · Pull Request #2785 · nodejs/node

X Title: test: remove check for valid hostname in test-dns.js by Trott · Pull Request #2785 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Operating systems can and do return invalid hostnames if that's what they have (for example) in /etc/hosts. Test passes if no error is thrown and the hostname string is not empty. Fixes: #2468

X Description: Operating systems can and do return invalid hostnames if that's what they have (for example) in /etc/hosts. Test passes if no error is thrown and the hostname string is not empty. Fixes: #2468

Opengraph URL: https://github.com/nodejs/node/pull/2785

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f1c391d3-2bbd-c08c-c2c9-9f8432d6aebf
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBB34:5CEA4:2AD9D9D:3B392D3:6A4F04AE
html-safe-nonce22d883bccf33e91e916afcd32f544381f73cbb548c2c05760dc0d81aac2a69e2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQjM0OjVDRUE0OjJBRDlEOUQ6M0IzOTJEMzo2QTRGMDRBRSIsInZpc2l0b3JfaWQiOiI1ODkyMjMxMDczNTY0MTMyNTI2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaccfbe23402b86d8312bd58d4aca7d585ed405f04420e1f815b3abfbaf3dd5d2fb
hovercard-subject-tagpull_request:44605546
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/2785/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8c380b4cdb0308e42dbe1ba584045fc6b02bb85d292ed9d8840f8b60b446fbe9/nodejs/node/pull/2785
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8c380b4cdb0308e42dbe1ba584045fc6b02bb85d292ed9d8840f8b60b446fbe9/nodejs/node/pull/2785
og:image:altOperating systems can and do return invalid hostnames if that's what they have (for example) in /etc/hosts. Test passes if no error is thrown and the hostname string is not empty. Fixes: #2468
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameTrott
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b8f23afb982271f1b22258a94aede67a6b77760
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/2785#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F2785
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F2785
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/2785
Reloadhttps://github.com/nodejs/node/pull/2785
Reloadhttps://github.com/nodejs/node/pull/2785
Please reload this pagehttps://github.com/nodejs/node/pull/2785
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/2785
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 965 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:test-dns-hostname-checkhttps://github.com/Trott/io.js/tree/test-dns-hostname-check
Conversationhttps://github.com/nodejs/node/pull/2785
Commits1 (1)https://github.com/nodejs/node/pull/2785/commits
Checkshttps://github.com/nodejs/node/pull/2785/checks
Files changedhttps://github.com/nodejs/node/pull/2785/files
test: remove check for valid hostname in test-dns.jshttps://github.com/nodejs/node/pull/2785#top
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:test-dns-hostname-checkhttps://github.com/Trott/io.js/tree/test-dns-hostname-check
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 9, 2015https://github.com/nodejs/node/pull/2785#issue-105692322
#2468https://github.com/nodejs/node/issues/2468
Please reload this pagehttps://github.com/nodejs/node/pull/2785
https://github.com/Trott
Trotthttps://github.com/Trott
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Sep 9, 2015https://github.com/nodejs/node/pull/2785#event-405343314
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 9, 2015https://github.com/nodejs/node/pull/2785#issuecomment-139057331
https://ci.nodejs.org/job/node-test-pull-request/269/https://ci.nodejs.org/job/node-test-pull-request/269/
Please reload this pagehttps://github.com/nodejs/node/pull/2785
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Sep 9, 2015https://github.com/nodejs/node/pull/2785#issuecomment-139062522
Please reload this pagehttps://github.com/nodejs/node/pull/2785
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 9, 2015https://github.com/nodejs/node/pull/2785#issuecomment-139064269
https://ci.nodejs.org/job/node-test-commit/534/https://ci.nodejs.org/job/node-test-commit/534/
Please reload this pagehttps://github.com/nodejs/node/pull/2785
https://github.com/mscdex
mscdexhttps://github.com/mscdex
dns https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adns
Sep 9, 2015https://github.com/nodejs/node/pull/2785#event-405389897
https://github.com/Trott
test: remove check for valid hostname in test-dns.jshttps://github.com/nodejs/node/pull/2785/commits/cd12f23e456defcd7f3ce3aebd49474d5f0002e2
cd12f23https://github.com/nodejs/node/pull/2785/commits/cd12f23e456defcd7f3ce3aebd49474d5f0002e2
nodejs#2468https://github.com/nodejs/node/issues/2468
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/c1901789a215b5ceb38276b1cc70c2c17bc71c0c..cd12f23e456defcd7f3ce3aebd49474d5f0002e2
c190178https://github.com/nodejs/node/commit/c1901789a215b5ceb38276b1cc70c2c17bc71c0c
cd12f23https://github.com/nodejs/node/commit/cd12f23e456defcd7f3ce3aebd49474d5f0002e2
Compare https://github.com/nodejs/node/compare/c1901789a215b5ceb38276b1cc70c2c17bc71c0c..cd12f23e456defcd7f3ce3aebd49474d5f0002e2
September 10, 2015 21:25https://github.com/nodejs/node/pull/2785#event-406481479
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 10, 2015 https://github.com/nodejs/node/pull/2785#ref-pullrequest-105902404
Split up internet DNS tests to avoid timeout problem #2802 https://github.com/nodejs/node/pull/2802
Trotthttps://github.com/Trott
Sep 10, 2015 https://github.com/nodejs/node/pull/2785#ref-commit-a1949e8
https://github.com/Trott
test: remove valid hostname check in test-dns.jshttps://github.com/nodejs/node/commit/a1949e8ad9483609fd450f8cc21cc2dca703259e
a1949e8https://github.com/nodejs/node/commit/a1949e8ad9483609fd450f8cc21cc2dca703259e
#2468https://github.com/nodejs/node/issues/2468
#2785https://github.com/nodejs/node/pull/2785
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 10, 2015https://github.com/nodejs/node/pull/2785#issuecomment-139397010
a1949e8https://github.com/nodejs/node/commit/a1949e8ad9483609fd450f8cc21cc2dca703259e
Please reload this pagehttps://github.com/nodejs/node/pull/2785
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 10, 2015https://github.com/nodejs/node/pull/2785#event-406526437
Trotthttps://github.com/Trott
Sep 11, 2015 https://github.com/nodejs/node/pull/2785#ref-commit-6e2fe1c
https://github.com/Trott
https://github.com/rvagg
test: remove valid hostname check in test-dns.jshttps://github.com/nodejs/node/commit/6e2fe1c21a06a592b2420846f11400fc726a5b1c
6e2fe1chttps://github.com/nodejs/node/commit/6e2fe1c21a06a592b2420846f11400fc726a5b1c
#2468https://github.com/nodejs/node/issues/2468
#2785https://github.com/nodejs/node/pull/2785
Trotthttps://github.com/Trott
Sep 12, 2015 https://github.com/nodejs/node/pull/2785#ref-commit-1dad19b
https://github.com/Trott
https://github.com/rvagg
test: remove valid hostname check in test-dns.jshttps://github.com/nodejs/node/commit/1dad19ba81983c6e22b6c453f78806962b3c31b4
1dad19bhttps://github.com/nodejs/node/commit/1dad19ba81983c6e22b6c453f78806962b3c31b4
#2468https://github.com/nodejs/node/issues/2468
#2785https://github.com/nodejs/node/pull/2785
https://github.com/rvagg
rvagghttps://github.com/rvagg
Sep 12, 2015 https://github.com/nodejs/node/pull/2785#ref-pullrequest-104996474
Release proposal: v3.3.1 #2698 https://github.com/nodejs/node/pull/2698
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 12, 2015 https://github.com/nodejs/node/pull/2785#ref-issue-102225385
Investigate flaky test test-dns #2468 https://github.com/nodejs/node/issues/2468
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Sep 13, 2015 https://github.com/nodejs/node/pull/2785#ref-issue-106216415
Release proposal: v4.1.0 #2844 https://github.com/nodejs/node/issues/2844
https://github.com/rvagg
rvagghttps://github.com/rvagg
Sep 22, 2015 https://github.com/nodejs/node/pull/2785#ref-pullrequest-107656289
Release proposal: v4.1.1 #2995 https://github.com/nodejs/node/pull/2995
https://github.com/Trott
Trotthttps://github.com/Trott
January 9, 2022 22:03https://github.com/nodejs/node/pull/2785#event-5862810452
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F2785
dns https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adns
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/2785
https://github.com/Trott
https://github.com/bnoordhuis
https://github.com/mscdex
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.