René's URL Explorer Experiment


Title: src: move DiagnosticFilename inlines into a -inl.h by sam-github · Pull Request #27839 · nodejs/node · GitHub

Open Graph Title: src: move DiagnosticFilename inlines into a -inl.h by sam-github · Pull Request #27839 · nodejs/node

X Title: src: move DiagnosticFilename inlines into a -inl.h by sam-github · Pull Request #27839 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: DiagnosticFilename's constructor default values use inlines from env-inl.h, causing the many users of node_internals.h to include env-inl.h, even if they never use DiagnosticFilename. Checklis...

X Description: DiagnosticFilename's constructor default values use inlines from env-inl.h, causing the many users of node_internals.h to include env-inl.h, even if they never use DiagnosticFilename. Chec...

Opengraph URL: https://github.com/nodejs/node/pull/27839

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a56f813d-bd0f-1e44-4326-6a141cc2db7c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB40E:50FD4:BD73EA:10A36E5:6A4E87BB
html-safe-nonce073314136ddae1a3073825cd3aa6bb87aff547b902b2679561a7ffd509a6e85a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNDBFOjUwRkQ0OkJENzNFQToxMEEzNkU1OjZBNEU4N0JCIiwidmlzaXRvcl9pZCI6IjE2NzEyMTY1MzQ1MTEzMjMwNjciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac4bd1d75bdfc61e3ae4a81c099c18d23d1b198592ee86e7e95357ff9268be2e3c
hovercard-subject-tagpull_request:281679711
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/27839/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/20df6265b252f1797b0b8d5a46062dbb4e28417cf2cf83e61c0c8402df1e97dd/nodejs/node/pull/27839
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/20df6265b252f1797b0b8d5a46062dbb4e28417cf2cf83e61c0c8402df1e97dd/nodejs/node/pull/27839
og:image:altDiagnosticFilename's constructor default values use inlines from env-inl.h, causing the many users of node_internals.h to include env-inl.h, even if they never use DiagnosticFilename. Checklis...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesam-github
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/27839#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27839
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27839
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/27839
Reloadhttps://github.com/nodejs/node/pull/27839
Reloadhttps://github.com/nodejs/node/pull/27839
Please reload this pagehttps://github.com/nodejs/node/pull/27839
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/27839
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 965 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
sam-githubhttps://github.com/sam-github
nodejs:masterhttps://github.com/nodejs/node/tree/master
sam-github:diagnosticfilename-inlhttps://github.com/sam-github/node/tree/diagnosticfilename-inl
Conversationhttps://github.com/nodejs/node/pull/27839
Commits1 (1)https://github.com/nodejs/node/pull/27839/commits
Checkshttps://github.com/nodejs/node/pull/27839/checks
Files changedhttps://github.com/nodejs/node/pull/27839/files
src: move DiagnosticFilename inlines into a -inl.hhttps://github.com/nodejs/node/pull/27839#top
sam-githubhttps://github.com/sam-github
nodejs:masterhttps://github.com/nodejs/node/tree/master
sam-github:diagnosticfilename-inlhttps://github.com/sam-github/node/tree/diagnosticfilename-inl
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
May 23, 2019https://github.com/nodejs/node/pull/27839#issue-447744899
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/27839
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 23, 2019https://github.com/nodejs/node/pull/27839#issuecomment-495278449
https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3606https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3606
Please reload this pagehttps://github.com/nodejs/node/pull/27839
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
May 23, 2019https://github.com/nodejs/node/pull/27839#event-2362962134
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 23, 2019https://github.com/nodejs/node/pull/27839#issuecomment-495278998
https://ci.nodejs.org/job/node-test-pull-request/23295/https://ci.nodejs.org/job/node-test-pull-request/23295/
Please reload this pagehttps://github.com/nodejs/node/pull/27839
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
May 23, 2019 https://github.com/nodejs/node/pull/27839#pullrequestreview-241366251
View reviewed changes https://github.com/nodejs/node/pull/27839/files
src/diagnosticfilename-inl.hhttps://github.com/nodejs/node/pull/27839/files#diff-68c3bb93a72e6cbeefa645bc1a745d0b7555c3e99669fe4986cf01c6502dbc81
Please reload this pagehttps://github.com/nodejs/node/pull/27839
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
May 23, 2019 https://github.com/nodejs/node/pull/27839#pullrequestreview-241376462
View reviewed changes https://github.com/nodejs/node/pull/27839/files
mhdawsonhttps://github.com/mhdawson
https://github.com/nodejs/node/pull/27839#pullrequestreview-241376462
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/27839
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 23, 2019https://github.com/nodejs/node/pull/27839#issuecomment-495338198
https://ci.nodejs.org/job/node-test-pull-request/23301/https://ci.nodejs.org/job/node-test-pull-request/23301/
Please reload this pagehttps://github.com/nodejs/node/pull/27839
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 24, 2019 https://github.com/nodejs/node/pull/27839#pullrequestreview-241834275
View reviewed changes https://github.com/nodejs/node/pull/27839/files
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 24, 2019https://github.com/nodejs/node/pull/27839#issuecomment-495753402
https://ci.nodejs.org/job/node-test-pull-request/23312/https://ci.nodejs.org/job/node-test-pull-request/23312/
Please reload this pagehttps://github.com/nodejs/node/pull/27839
https://github.com/sam-github
src: move DiagnosticFilename inlines into a -inl.hhttps://github.com/nodejs/node/pull/27839/commits/62634380a4ef77ecb002ceeaa4eee13fe18898ab
6263438https://github.com/nodejs/node/pull/27839/commits/62634380a4ef77ecb002ceeaa4eee13fe18898ab
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
force-pushedhttps://github.com/nodejs/node/compare/54d46e7c20e6b1340e0098ff86ee7839caa5f1d3..62634380a4ef77ecb002ceeaa4eee13fe18898ab
54d46e7https://github.com/nodejs/node/commit/54d46e7c20e6b1340e0098ff86ee7839caa5f1d3
6263438https://github.com/nodejs/node/commit/62634380a4ef77ecb002ceeaa4eee13fe18898ab
Compare https://github.com/nodejs/node/compare/54d46e7c20e6b1340e0098ff86ee7839caa5f1d3..62634380a4ef77ecb002ceeaa4eee13fe18898ab
May 24, 2019 19:31https://github.com/nodejs/node/pull/27839#event-2366510502
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 24, 2019https://github.com/nodejs/node/pull/27839#issuecomment-495764325
https://ci.nodejs.org/job/node-test-pull-request/23314/https://ci.nodejs.org/job/node-test-pull-request/23314/
Please reload this pagehttps://github.com/nodejs/node/pull/27839
https://github.com/Trott
Trotthttps://github.com/Trott
May 25, 2019 https://github.com/nodejs/node/pull/27839#pullrequestreview-242010211
View reviewed changes https://github.com/nodejs/node/pull/27839/files/62634380a4ef77ecb002ceeaa4eee13fe18898ab
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 26, 2019https://github.com/nodejs/node/pull/27839#issuecomment-496008062
02f9a0fhttps://github.com/nodejs/node/commit/02f9a0fe27a70062631a39971099e13f54d2b588
Please reload this pagehttps://github.com/nodejs/node/pull/27839
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 26, 2019https://github.com/nodejs/node/pull/27839#event-2367860844
addaleaxhttps://github.com/addaleax
May 26, 2019 https://github.com/nodejs/node/pull/27839#ref-commit-02f9a0f
https://github.com/sam-github
https://github.com/addaleax
src: move DiagnosticFilename inlines into a -inl.hhttps://github.com/nodejs/node/commit/02f9a0fe27a70062631a39971099e13f54d2b588
02f9a0fhttps://github.com/nodejs/node/commit/02f9a0fe27a70062631a39971099e13f54d2b588
#27839https://github.com/nodejs/node/pull/27839
targoshttps://github.com/targos
May 28, 2019 https://github.com/nodejs/node/pull/27839#ref-commit-44846ae
https://github.com/sam-github
https://github.com/targos
src: move DiagnosticFilename inlines into a -inl.hhttps://github.com/nodejs/node/commit/44846aebd24560afc4cbadca3c2e0db285d07ab0
44846aehttps://github.com/nodejs/node/commit/44846aebd24560afc4cbadca3c2e0db285d07ab0
#27839https://github.com/nodejs/node/pull/27839
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
May 29, 2019 07:56https://github.com/nodejs/node/pull/27839#event-2374181540
https://github.com/targos
targoshttps://github.com/targos
Jun 3, 2019 https://github.com/nodejs/node/pull/27839#ref-pullrequest-451450524
v12.4.0 release proposal #28040 https://github.com/nodejs/node/pull/28040
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27839
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/27839/files/a0585ee795c57aacf73f3b503174ad8adc2aa5df
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/27839/files/54d46e7c20e6b1340e0098ff86ee7839caa5f1d3
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/27839/files/62634380a4ef77ecb002ceeaa4eee13fe18898ab
https://github.com/mhdawson
mhdawson https://github.com/mhdawson
https://github.com/nodejs/node/pull/27839/files/a0585ee795c57aacf73f3b503174ad8adc2aa5df
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Please reload this pagehttps://github.com/nodejs/node/pull/27839
https://github.com/sam-github
https://github.com/nodejs-github-bot
https://github.com/addaleax
https://github.com/jasnell
https://github.com/Trott
https://github.com/cjihrig
https://github.com/mhdawson
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.