René's URL Explorer Experiment


Title: test: fix flaky test-https-agent-additional-options by Trott · Pull Request #27830 · nodejs/node · GitHub

Open Graph Title: test: fix flaky test-https-agent-additional-options by Trott · Pull Request #27830 · nodejs/node

X Title: test: fix flaky test-https-agent-additional-options by Trott · Pull Request #27830 · nodejs/node

Description: test: fix test-https-agent-additional-options test-https-agent-additional-options can occasionally fail if a socket closes before the checks near the end of the test. Modify the test to check the freeSockets pool after each request. Fixes: https://github.com/nodejs/node/issues/24449 test: refactor test-https-agent-additional-options Move callback to location where it is less confusing. test: favor arrow functions for anonymous callbacks In test-https-agent-additional-options, use arrow functions for anonymous callbacks. Replace a use of `this` with the relevant constant. test: replace flag with option test-https-agent-additional-options is invoked with a command-line flag. However, there is an equivalent option that can be enabled within the code. Do that instead. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

Open Graph Description: test: fix test-https-agent-additional-options test-https-agent-additional-options can occasionally fail if a socket closes before the checks near the end of the test. Modify the test to check the ...

X Description: test: fix test-https-agent-additional-options test-https-agent-additional-options can occasionally fail if a socket closes before the checks near the end of the test. Modify the test to check the ...

Opengraph URL: https://github.com/nodejs/node/pull/27830

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits/:range(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:90db3603-18c8-e84b-4a07-067213d62af9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9D62:3AEBEF:1EFF01E:2A46696:6A65585D
html-safe-nonceb02288299a136d62647ccf02a985fe0fd197d9307aac35d5152723675679b940
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RDYyOjNBRUJFRjoxRUZGMDFFOjJBNDY2OTY6NkE2NTU4NUQiLCJ2aXNpdG9yX2lkIjoiODQwMTk0MzQxNTY3NzYwNTk4MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac21757978ee000bde96cdbe57ab3a89f4a4da1f4bafcd65a19e01b8664a11c7fa
hovercard-subject-tagpull_request:281389550
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/27830/commits/83f77d207adfe0a5edeb874b847d48fdb69b69f5
twitter:imagehttps://avatars.githubusercontent.com/u/718899?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/718899?s=400&v=4
og:image:alttest: fix test-https-agent-additional-options test-https-agent-additional-options can occasionally fail if a socket closes before the checks near the end of the test. Modify the test to check the ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None52c76df668885aaff23b50bdca1fa1ea44ac9c1553e888ebc70ff1e4daa4625b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release309153364422b3c499922d1a2a6404910a58ed8e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/27830/commits/83f77d207adfe0a5edeb874b847d48fdb69b69f5#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27830%2Fcommits%2F83f77d207adfe0a5edeb874b847d48fdb69b69f5
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27830%2Fcommits%2F83f77d207adfe0a5edeb874b847d48fdb69b69f5
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/27830/commits/83f77d207adfe0a5edeb874b847d48fdb69b69f5
Reloadhttps://github.com/nodejs/node/pull/27830/commits/83f77d207adfe0a5edeb874b847d48fdb69b69f5
Reloadhttps://github.com/nodejs/node/pull/27830/commits/83f77d207adfe0a5edeb874b847d48fdb69b69f5
Please reload this pagehttps://github.com/nodejs/node/pull/27830/commits/83f77d207adfe0a5edeb874b847d48fdb69b69f5
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/27830/commits/83f77d207adfe0a5edeb874b847d48fdb69b69f5
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.1k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 1.1k https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:add-opthttps://github.com/Trott/io.js/tree/add-opt
Conversation 11 https://github.com/nodejs/node/pull/27830
Commits 4 https://github.com/nodejs/node/pull/27830/commits
Checks 0 https://github.com/nodejs/node/pull/27830/checks
Files changed https://github.com/nodejs/node/pull/27830/files
Please reload this pagehttps://github.com/nodejs/node/pull/27830/commits/83f77d207adfe0a5edeb874b847d48fdb69b69f5
test: fix flaky test-https-agent-additional-options https://github.com/nodejs/node/pull/27830/commits/83f77d207adfe0a5edeb874b847d48fdb69b69f5#top
Show all changes 4 commits https://github.com/nodejs/node/pull/27830/files
81e8971 test: replace flag with option Trott May 21, 2019 https://github.com/nodejs/node/pull/27830/commits/81e897124a34413f90b562be4c950e682c13f5a6
9181f38 test: favor arrow functions for anonymous callbacks Trott May 21, 2019 https://github.com/nodejs/node/pull/27830/commits/9181f38c0ed358d012c396bd0d2d56a5e60b5a3d
212ecda test: refactor test-https-agent-additional-options Trott May 21, 2019 https://github.com/nodejs/node/pull/27830/commits/212ecdade44712824ae5bd52c535fcf6f839e704
83f77d2 test: fix test-https-agent-additional-options Trott May 21, 2019 https://github.com/nodejs/node/pull/27830/commits/83f77d207adfe0a5edeb874b847d48fdb69b69f5
Clear filters https://github.com/nodejs/node/pull/27830/commits/83f77d207adfe0a5edeb874b847d48fdb69b69f5
Please reload this pagehttps://github.com/nodejs/node/pull/27830/commits/83f77d207adfe0a5edeb874b847d48fdb69b69f5
Please reload this pagehttps://github.com/nodejs/node/pull/27830/commits/83f77d207adfe0a5edeb874b847d48fdb69b69f5
Prev https://github.com/nodejs/node/pull/27830/commits/212ecdade44712824ae5bd52c535fcf6f839e704
#24449https://github.com/nodejs/node/issues/24449
Please reload this pagehttps://github.com/nodejs/node/pull/27830/commits/83f77d207adfe0a5edeb874b847d48fdb69b69f5
https://github.com/Trott
Trotthttps://github.com/nodejs/node/commits?author=Trott
test/parallel/test-https-agent-additional-options.jshttps://github.com/nodejs/node/pull/27830/commits/83f77d207adfe0a5edeb874b847d48fdb69b69f5#diff-c4f65e07cf74fc4de758a58acf160872f08f481981fb9f48fb23309c074a13c9
View file https://github.com/Trott/io.js/blob/83f77d207adfe0a5edeb874b847d48fdb69b69f5/test/parallel/test-https-agent-additional-options.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/27830/commits/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/27830/commits/83f77d207adfe0a5edeb874b847d48fdb69b69f5#diff-c4f65e07cf74fc4de758a58acf160872f08f481981fb9f48fb23309c074a13c9
https://github.com/nodejs/node/pull/27830/commits/83f77d207adfe0a5edeb874b847d48fdb69b69f5#diff-c4f65e07cf74fc4de758a58acf160872f08f481981fb9f48fb23309c074a13c9
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.