René's URL Explorer Experiment


Title: test: fix flaky test-https-agent-additional-options by Trott · Pull Request #27830 · nodejs/node · GitHub

Open Graph Title: test: fix flaky test-https-agent-additional-options by Trott · Pull Request #27830 · nodejs/node

X Title: test: fix flaky test-https-agent-additional-options by Trott · Pull Request #27830 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: test: fix test-https-agent-additional-options test-https-agent-additional-options can occasionally fail if a socket closes before the checks near the end of the test. Modify the test to check the ...

X Description: test: fix test-https-agent-additional-options test-https-agent-additional-options can occasionally fail if a socket closes before the checks near the end of the test. Modify the test to check the ...

Opengraph URL: https://github.com/nodejs/node/pull/27830

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a95684e3-cabb-4ba2-74e7-6dec32f58562
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDDC0:3C5CB:1DB7942:28F40EF:6A4EBBEB
html-safe-noncedf294dba5de8da4df6ba8e5d435d247198e6f4527759bffb32e7fe1ff04010a0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEREMwOjNDNUNCOjFEQjc5NDI6MjhGNDBFRjo2QTRFQkJFQiIsInZpc2l0b3JfaWQiOiIzNjMyNTAyNjcyOTQxMDM4NTcxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac4635eae1f28428794f529bfcb8e81e79f6c5f1ab06c4b3e635ba08a0ecce8b3a
hovercard-subject-tagpull_request:281389550
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/27830/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4e061af4430ff0057936fdb39bcc96c9a4b58998175f784a0d90ecf0d8b8c7a5/nodejs/node/pull/27830
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4e061af4430ff0057936fdb39bcc96c9a4b58998175f784a0d90ecf0d8b8c7a5/nodejs/node/pull/27830
og:image:alttest: fix test-https-agent-additional-options test-https-agent-additional-options can occasionally fail if a socket closes before the checks near the end of the test. Modify the test to check the ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameTrott
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/27830#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27830
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27830
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/27830
Reloadhttps://github.com/nodejs/node/pull/27830
Reloadhttps://github.com/nodejs/node/pull/27830
Please reload this pagehttps://github.com/nodejs/node/pull/27830
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/27830
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 964 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:add-opthttps://github.com/Trott/io.js/tree/add-opt
Conversationhttps://github.com/nodejs/node/pull/27830
Commits4 (4)https://github.com/nodejs/node/pull/27830/commits
Checkshttps://github.com/nodejs/node/pull/27830/checks
Files changedhttps://github.com/nodejs/node/pull/27830/files
test: fix flaky test-https-agent-additional-optionshttps://github.com/nodejs/node/pull/27830#top
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:add-opthttps://github.com/Trott/io.js/tree/add-opt
https://github.com/Trott
Trotthttps://github.com/Trott
May 22, 2019https://github.com/nodejs/node/pull/27830#issue-447379813
Please reload this pagehttps://github.com/nodejs/node/pull/27830
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/27830
Trotthttps://github.com/Trott
May 21, 2019 18:49https://github.com/nodejs/node/pull/27830#commits-pushed-81e8971
https://github.com/Trott
test: replace flag with optionhttps://github.com/nodejs/node/pull/27830/commits/81e897124a34413f90b562be4c950e682c13f5a6
81e8971https://github.com/nodejs/node/pull/27830/commits/81e897124a34413f90b562be4c950e682c13f5a6
https://github.com/Trott
test: favor arrow functions for anonymous callbackshttps://github.com/nodejs/node/pull/27830/commits/9181f38c0ed358d012c396bd0d2d56a5e60b5a3d
9181f38https://github.com/nodejs/node/pull/27830/commits/9181f38c0ed358d012c396bd0d2d56a5e60b5a3d
https://github.com/Trott
test: refactor test-https-agent-additional-optionshttps://github.com/nodejs/node/pull/27830/commits/212ecdade44712824ae5bd52c535fcf6f839e704
212ecdahttps://github.com/nodejs/node/pull/27830/commits/212ecdade44712824ae5bd52c535fcf6f839e704
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 22, 2019https://github.com/nodejs/node/pull/27830#issuecomment-495006652
https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3601https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3601
Please reload this pagehttps://github.com/nodejs/node/pull/27830
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
May 22, 2019https://github.com/nodejs/node/pull/27830#event-2360832134
https://github.com/Trott
Trotthttps://github.com/Trott
May 22, 2019 https://github.com/nodejs/node/pull/27830#ref-issue-381884767
flaky: parallel/test-https-agent-additional-options #24449 https://github.com/nodejs/node/issues/24449
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 22, 2019https://github.com/nodejs/node/pull/27830#issuecomment-495006937
https://ci.nodejs.org/job/node-test-pull-request/23283/https://ci.nodejs.org/job/node-test-pull-request/23283/
Please reload this pagehttps://github.com/nodejs/node/pull/27830
https://github.com/Trott
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27830
https://github.com/Trott
Trotthttps://github.com/Trott
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
May 22, 2019https://github.com/nodejs/node/pull/27830#event-2360878602
https://github.com/Trott
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27830
https://github.com/Trott
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27830
https://github.com/Trott
test: fix test-https-agent-additional-optionshttps://github.com/nodejs/node/pull/27830/commits/83f77d207adfe0a5edeb874b847d48fdb69b69f5
83f77d2https://github.com/nodejs/node/pull/27830/commits/83f77d207adfe0a5edeb874b847d48fdb69b69f5
nodejs#24449https://github.com/nodejs/node/issues/24449
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/dca643284f36217f47bb215aa80e5146593fb910..83f77d207adfe0a5edeb874b847d48fdb69b69f5
dca6432https://github.com/nodejs/node/commit/dca643284f36217f47bb215aa80e5146593fb910
83f77d2https://github.com/nodejs/node/commit/83f77d207adfe0a5edeb874b847d48fdb69b69f5
Compare https://github.com/nodejs/node/compare/dca643284f36217f47bb215aa80e5146593fb910..83f77d207adfe0a5edeb874b847d48fdb69b69f5
May 23, 2019 02:13https://github.com/nodejs/node/pull/27830#event-2361064582
https://github.com/Trott
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27830
https://github.com/Trott
Trotthttps://github.com/Trott
May 23, 2019https://github.com/nodejs/node/pull/27830#issuecomment-495045091
Please reload this pagehttps://github.com/nodejs/node/pull/27830
https://ci.nodejs.org/job/node-stress-single-test/2217/https://ci.nodejs.org/job/node-stress-single-test/2217/
https://ci.nodejs.org/job/node-stress-single-test/2214/https://ci.nodejs.org/job/node-stress-single-test/2214/
Please reload this pagehttps://github.com/nodejs/node/pull/27830
https://github.com/Trott
Trotthttps://github.com/Trott
May 23, 2019https://github.com/nodejs/node/pull/27830#issuecomment-495047003
Please reload this pagehttps://github.com/nodejs/node/pull/27830
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 23, 2019https://github.com/nodejs/node/pull/27830#issuecomment-495047086
https://ci.nodejs.org/job/node-test-pull-request/23286/https://ci.nodejs.org/job/node-test-pull-request/23286/
Please reload this pagehttps://github.com/nodejs/node/pull/27830
https://github.com/Trott
Trotthttps://github.com/Trott
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
May 23, 2019https://github.com/nodejs/node/pull/27830#event-2361108946
https://github.com/Trott
Trotthttps://github.com/Trott
May 23, 2019https://github.com/nodejs/node/pull/27830#event-2363115213
https://github.com/Trott
Trotthttps://github.com/Trott
review wanted https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22review%20wanted%22
May 24, 2019https://github.com/nodejs/node/pull/27830#event-2364439759
https://github.com/Trott
Trotthttps://github.com/Trott
May 24, 2019https://github.com/nodejs/node/pull/27830#issuecomment-495718013
Please reload this pagehttps://github.com/nodejs/node/pull/27830
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
May 24, 2019 https://github.com/nodejs/node/pull/27830#pullrequestreview-241863379
View reviewed changes https://github.com/nodejs/node/pull/27830/files/83f77d207adfe0a5edeb874b847d48fdb69b69f5
https://github.com/lpinca
lpincahttps://github.com/lpinca
May 24, 2019 https://github.com/nodejs/node/pull/27830#pullrequestreview-241866731
View reviewed changes https://github.com/nodejs/node/pull/27830/files/83f77d207adfe0a5edeb874b847d48fdb69b69f5
https://github.com/Trott
Trotthttps://github.com/Trott
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
review wanted https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22review%20wanted%22
May 24, 2019https://github.com/nodejs/node/pull/27830#event-2366392542
Trotthttps://github.com/Trott
May 25, 2019 https://github.com/nodejs/node/pull/27830#ref-commit-3f01710
https://github.com/Trott
test: replace flag with optionhttps://github.com/Trott/io.js/commit/3f01710d3ce89518825c7216975d544d6e78afb2
3f01710https://github.com/Trott/io.js/commit/3f01710d3ce89518825c7216975d544d6e78afb2
nodejs#27830https://github.com/nodejs/node/pull/27830
Trotthttps://github.com/Trott
May 25, 2019 https://github.com/nodejs/node/pull/27830#ref-commit-d03cff7
https://github.com/Trott
test: favor arrow functions for anonymous callbackshttps://github.com/Trott/io.js/commit/d03cff7620f0a62433f36abc252532ab0a79a56c
d03cff7https://github.com/Trott/io.js/commit/d03cff7620f0a62433f36abc252532ab0a79a56c
nodejs#27830https://github.com/nodejs/node/pull/27830
Trotthttps://github.com/Trott
May 25, 2019 https://github.com/nodejs/node/pull/27830#ref-commit-0fa5c9f
https://github.com/Trott
test: refactor test-https-agent-additional-optionshttps://github.com/Trott/io.js/commit/0fa5c9f256210d858862e62f63754f216a94e1e9
0fa5c9fhttps://github.com/Trott/io.js/commit/0fa5c9f256210d858862e62f63754f216a94e1e9
nodejs#27830https://github.com/nodejs/node/pull/27830
Trotthttps://github.com/Trott
May 25, 2019 https://github.com/nodejs/node/pull/27830#ref-commit-0d28300
https://github.com/Trott
test: fix test-https-agent-additional-optionshttps://github.com/Trott/io.js/commit/0d2830041a399d5d56f7e0780c982a80570bdde2
0d28300https://github.com/Trott/io.js/commit/0d2830041a399d5d56f7e0780c982a80570bdde2
nodejs#27830https://github.com/nodejs/node/pull/27830
nodejs#24449https://github.com/nodejs/node/issues/24449
https://github.com/Trott
Trotthttps://github.com/Trott
May 25, 2019https://github.com/nodejs/node/pull/27830#issuecomment-495829120
Please reload this pagehttps://github.com/nodejs/node/pull/27830
https://github.com/Trott
Trotthttps://github.com/Trott
May 25, 2019https://github.com/nodejs/node/pull/27830#event-2366976069
targoshttps://github.com/targos
May 28, 2019 https://github.com/nodejs/node/pull/27830#ref-commit-155b947
https://github.com/Trott
https://github.com/targos
test: replace flag with optionhttps://github.com/nodejs/node/commit/155b947251e1189a4e54480c6fb169b384eb31a3
155b947https://github.com/nodejs/node/commit/155b947251e1189a4e54480c6fb169b384eb31a3
#27830https://github.com/nodejs/node/pull/27830
targoshttps://github.com/targos
May 28, 2019 https://github.com/nodejs/node/pull/27830#ref-commit-17abc8c
https://github.com/Trott
https://github.com/targos
test: favor arrow functions for anonymous callbackshttps://github.com/nodejs/node/commit/17abc8c942292329db5d05b45ecea55ec05c60b0
17abc8chttps://github.com/nodejs/node/commit/17abc8c942292329db5d05b45ecea55ec05c60b0
#27830https://github.com/nodejs/node/pull/27830
targoshttps://github.com/targos
May 28, 2019 https://github.com/nodejs/node/pull/27830#ref-commit-a4c1fd5
https://github.com/Trott
https://github.com/targos
test: refactor test-https-agent-additional-optionshttps://github.com/nodejs/node/commit/a4c1fd5ffc4da36d9364c9cadd3b2b88089dd8e8
a4c1fd5https://github.com/nodejs/node/commit/a4c1fd5ffc4da36d9364c9cadd3b2b88089dd8e8
#27830https://github.com/nodejs/node/pull/27830
targoshttps://github.com/targos
May 28, 2019 https://github.com/nodejs/node/pull/27830#ref-commit-bfcbab4
https://github.com/Trott
https://github.com/targos
test: fix test-https-agent-additional-optionshttps://github.com/nodejs/node/commit/bfcbab4c0c047fb052839d58db78d2db8887cdf6
bfcbab4https://github.com/nodejs/node/commit/bfcbab4c0c047fb052839d58db78d2db8887cdf6
#27830https://github.com/nodejs/node/pull/27830
#24449https://github.com/nodejs/node/issues/24449
https://github.com/targos
targoshttps://github.com/targos
Jun 3, 2019 https://github.com/nodejs/node/pull/27830#ref-pullrequest-451450524
v12.4.0 release proposal #28040 https://github.com/nodejs/node/pull/28040
https://github.com/Trott
Trotthttps://github.com/Trott
January 13, 2022 22:51https://github.com/nodejs/node/pull/27830#event-5890974421
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F27830
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/27830/files/83f77d207adfe0a5edeb874b847d48fdb69b69f5
https://github.com/sam-github
sam-github https://github.com/sam-github
https://github.com/nodejs/node/pull/27830/files/83f77d207adfe0a5edeb874b847d48fdb69b69f5
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/27830
https://github.com/Trott
https://github.com/nodejs-github-bot
https://github.com/sam-github
https://github.com/lpinca
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.